Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: remove deprecated options

2023-10-09 Thread Kyle Swanson
Hi, On Thu, Oct 5, 2023 at 1:19 PM Kyle Swanson wrote: > Removal of deprecated libvmaf filter options. These options have been > deprecated since 3d29724c008d8f27fecf85757152789b074e8ef9 (Jan 23, > 2022). Patch attached. I'll push this tomorrow.

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: remove deprecated options

2023-10-10 Thread Kyle Swanson
Hi, On Mon, Oct 9, 2023 at 10:17 AM Kyle Swanson wrote: > On Thu, Oct 5, 2023 at 1:19 PM Kyle Swanson wrote: > > Removal of deprecated libvmaf filter options. These options have been > > deprecated since 3d29724c008d8f27fecf85757152789b074e8ef9 (Jan 23, > > 2022). Patch at

[FFmpeg-devel] [PATCH] avfilter/libvmaf: update pix_fmts

2023-10-10 Thread Kyle Swanson
Hi, This patch adds 12/16-bit support to the libvmaf filter. Unless there are questions/reviews, I'll push tomorrow. Patch attached. Thanks, Kyle 0001-avfilter-libvmaf-update-pix_fmts.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: update pix_fmts

2023-10-12 Thread Kyle Swanson
Hi, On Tue, Oct 10, 2023 at 1:02 PM Kyle Swanson wrote: > This patch adds 12/16-bit support to the libvmaf filter. Unless there > are questions/reviews, I'll push tomorrow. Patch attached. Merged. Thanks, Kyle ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] VMAF is now propagated to the AVFrame coming from the graph

2023-10-16 Thread Kyle Swanson
Hi, On Fri, Oct 13, 2023 at 11:01 PM wrote: > > From: ichlubna > > Related to my ticket here: https://trac.ffmpeg.org/ticket/10586 > VMAF score was not propagated to AVFormat like SSIM or PSNR in the result of > the filter graph. I have fixed this to make the usage consistent and possible > to

[FFmpeg-devel] [PATCH] avfilter/libvmaf: fix broken cuda build

2023-10-24 Thread Kyle Swanson
Hi, I broke the libvmaf_cuda build after 6028728bb829c04cc68c66c846c75a70bf4c0613. Fix is attached. I will merge this patch soon. Thanks, Kyle 0001-avfilter-libvmaf-fix-broken-cuda-build.patch Description: Binary data ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: fix broken cuda build

2023-10-27 Thread Kyle Swanson
On Tue, Oct 24, 2023 at 1:56 PM Kyle Swanson wrote: > I broke the libvmaf_cuda build after > 6028728bb829c04cc68c66c846c75a70bf4c0613. Fix is attached. I will > merge this patch soon. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-16 Thread Kyle Swanson
Hi, On Wed, Nov 15, 2023 at 12:39 PM Paul B Mahol wrote: > > Attached. Only had a few minutes to look at this. Seems like more than just merging two filters, I see a bunch of new filter options for example. Can you explain? Thanks, Kyle ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-21 Thread Kyle Swanson
Hi, On Sun, Nov 19, 2023 at 3:48 AM Paul B Mahol wrote: > > On Fri, Nov 17, 2023 at 7:38 AM Kyle Swanson wrote: > > > Hi, > > > > On Wed, Nov 15, 2023 at 12:39 PM Paul B Mahol wrote: > > > > > > Attached. > > > > Only had a few minutes t

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Kyle Swanson
Hi, On Mon, Nov 27, 2023 at 1:29 AM Gyan Doshi wrote: > > Will push soon. This filter can take any number of models now, each defining their own pooling methods. Looking at the docs now, I can see that it's not clear how to do this, I'll need to send a patch on that. The global `pool` option has

Re: [FFmpeg-devel] [PATCH] doc/filters: restore libvmaf option pool entry

2023-11-27 Thread Kyle Swanson
Hi, On Mon, Nov 27, 2023 at 10:15 AM Gyan Doshi wrote: > Do you mean in the lib? Because in ffmpeg git master, in the wrapper, > the option remains available and undeprecated. > > Regards, > Gyan Oops, you're right. Ignore everything I just said, sorry for the noise. Thanks, Kyle __

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-30 Thread Kyle Swanson
Hi, On Thu, Nov 30, 2023 at 6:11 AM Paul B Mahol wrote: > > I tested this a lot, and its great move forward. > > Make more useful testing and review next time, I'm sure you are quite > capable person. Paul, I agree with Anton. Refactoring the code (i.e. changing filter behavior) and combining it

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-30 Thread Kyle Swanson
Hi, On Thu, Nov 30, 2023 at 1:36 PM Paul B Mahol wrote: > > Loudnorm filter is big pile of hacks, I wanted to move forward and I > improved it. > > I received nothing in return just some politics talks. > > I will apply this soon unless technical comments arise. > > Why would I spend on this more

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-30 Thread Kyle Swanson
Hi, On Thu, Nov 30, 2023 at 2:43 PM Paul B Mahol wrote: > But how you could refactor code if one filter shares nothing with another > filter code? > > Its not possible. You all seem to not understand problem at all. I get that this patch swaps the libebur128 loudness computation with the f_ebur1

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-12-01 Thread Kyle Swanson
Hi, On Fri, Dec 1, 2023 at 2:37 AM Paul B Mahol wrote: > Keeping old code will not make patch any prettier. It's not really about pretty, it's about splitting up the patch so we can do things one at a time. I think the change to use f_ebur128.c loudness computation might have some advantages, bu

[FFmpeg-devel] [PATCH] avfilter/libvmaf: small cleanup for style, whitespace, unused

2023-12-01 Thread Kyle Swanson
Hi, Small cleanup patch for vf_libvmaf.c. Will apply soon. Thanks, Kyle 0001-avfilter-libvmaf-small-cleanup-for-style-whitespace-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: small cleanup for style, whitespace, unused

2023-12-04 Thread Kyle Swanson
On Fri, Dec 1, 2023 at 1:57 PM Kyle Swanson wrote: > Small cleanup patch for vf_libvmaf.c. Will apply soon. Pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-06 Thread Kyle Swanson
Hi, On Mon, Dec 4, 2023 at 7:59 AM Nil Fons Miret via ffmpeg-devel wrote: > > The libvmaf filter was doing substring checks in place of string > equality comparisons. This led to a bug when the user specified the > pooling method "harmonic_mean", since "mean" was checked first and the > substring

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-08 Thread Kyle Swanson
On Wed, Dec 6, 2023 at 9:54 AM Kyle Swanson wrote: > Will push this tomorrow. Pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add qrencodesrc source

2023-12-11 Thread Kyle Swanson
Hi, On Sat, Dec 9, 2023 at 10:14 AM Stefano Sabatini wrote: > > On date Thursday 2023-11-30 01:49:14 +0100, Stefano Sabatini wrote: > > --- > > configure | 4 + > > libavfilter/Makefile| 1 + > > libavfilter/allfilters.c| 1 + > > libavfilter/vsrc_qrencode.c |

Re: [FFmpeg-devel] [PATCH v2] avcodec: libdav1d AV1 decoder wrapper.

2018-10-01 Thread Kyle Swanson
Hi, On Sun, Sep 30, 2018 at 5:08 PM James Almer wrote: > From: Ronald S. Bultje > > Originally written by Ronald S. Bultje, with fixes, optimizations and > improvements by James Almer. > > Signed-off-by: James Almer > --- > Updated with some refactoring and to use a few new public facing field

[FFmpeg-devel] [PATCH] libvmaf: update docs

2018-10-22 Thread Kyle Swanson
From: Kyle Swanson For context: https://github.com/Netflix/vmaf/issues/237 Signed-off-by: Kyle Swanson --- I'll push this sometime in the next 24hrs unless someone has an issue. doc/filters.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH] libvmaf: update docs

2018-11-26 Thread Kyle Swanson
Hi, On 10/22/18, Kyle Swanson wrote: > From: Kyle Swanson > > For context: https://github.com/Netflix/vmaf/issues/237 > > Signed-off-by: Kyle Swanson > --- > > I'll push this sometime in the next 24hrs unless someone has an issue. Almost forgot about this. Push

Re: [FFmpeg-devel] Add alternative delogo algorithm for my donation

2018-12-12 Thread Kyle Swanson
Hi, On 12/11/18, uwe.fre...@gmx.de wrote: > Hello, > > I would like that the delogo filter is improved by an alternative way of > removing the logo. It's the "UGLARM" mode known from Virtual Dub's > DeLogo filter and ffdshow. > I used it many years (under Windows), but now moving to Linux miss it

Re: [FFmpeg-devel] [PATCH v1 1/4] avfilter/af_loudnorm: Add file option for the measured stats

2020-04-09 Thread Kyle Swanson
Hi, On Thu, Apr 9, 2020 at 10:57 AM Nicolas George wrote: > There is JSON-specific code in af_loudnorm.c, there should not be, I > think we should start here. > > My opinion is we should rework ffprobe's writers and move them to lavu. > That would be the first step. Is there already a helper API

Re: [FFmpeg-devel] [PATCH] avfilter/af_loudnorm: Don't mix dB and linear values when calculating linear offset with inputs <3s

2020-05-01 Thread Kyle Swanson
Hi, On Tue, Apr 28, 2020 at 12:58 AM Paul B Mahol wrote: > > On 4/26/20, Sebastian Dröge wrote: > > From: Sebastian Dröge > > > > s->target_i and global are in dB but s->target_tp and true_peak are > > linear. Instead of mixing these in the calculations, convert the former > > first to have all

[FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-29 Thread Kyle Swanson
since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent Signed-off-by: Kyle Swanson --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 7495f35faa..e0b76ac1ea 100755 --- a/configure +++ b/configure @@ -1741,7 +1741,6

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-29 Thread Kyle Swanson
Hi, On Mon, Jun 29, 2020 at 10:05 AM Kyle Swanson wrote: > > since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent > > Signed-off-by: Kyle Swanson > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-29 Thread Kyle Swanson
On Mon, Jun 29, 2020 at 12:14 PM Derek Buitenhuis wrote: > You'll need to update the pkg-config check too if you want to > to this, since it's at >= 1.3.9 right now. > > - Derek Thanks. Updated patch attached. 0001-configure-remove-libvmaf-from-EXTERNAL_LIBRARY_VERSI.patch Description: Binary d

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

2019-11-14 Thread Kyle Swanson
Hi, On Wed, Nov 13, 2019 at 10:36 PM Limin Wang wrote: > Please ignore the patch, I haven't used the old version. As vmaf library use > libvmaf.pc, it better to keep it filename same, so let waiting vmaf to fix > it. Merged your PR over on the VMAF repo. This FFmpeg patch should be ignored. Tha

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-06-16 Thread Kyle Swanson
Hi, Patch attached. This is an update to the libvmaf avfilter to use the new libvmaf v2.* API which was released about 6 months ago. High level: the filter should be simpler to use now for basic users, but also more flexible for power users. libvmaf can be configured with one or many vmaf models,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-06-28 Thread Kyle Swanson
Hi, Updated patch attached. Thank you to Christopher Degawa for testing and providing feedback. Kyle 0001-avfilter-vf_libvmaf-update-filter-for-libvmaf-v2.0.0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-11 Thread Kyle Swanson
Hi, On Fri, Jan 11, 2019 at 10:21 AM Nicolas George wrote: > > Rationale: > > * This requirement should offset a little the incentive to neglect > design, code quality and politeness during the review process when > done for money. > > * The review process itself and future maintenance burden

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-11 Thread Kyle Swanson
Hi, On Fri, Jan 11, 2019 at 11:05 AM Nicolas George wrote: > > Kyle Swanson (12019-01-11): > > Lots of people get paid to work on OSS. It's not a conspiracy, that's > > just the way it is. If someone gets paid to write a patch that does > > something useful, g

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-06 Thread Kyle Swanson
Hi, On Wed, Feb 6, 2019 at 1:20 PM Reto Kromer wrote: > > Werner Robitza wrote: > > >I propose that FFmpeg maintains its own ffmpeg formula under > >its GitHub organization > > I second the idea. +1 > > (Homebrew works now on any modern x86_64 architecture running > Linux, macOS and Windows with

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-06 Thread Kyle Swanson
Hi, On Wed, Feb 6, 2019 at 1:43 PM Helmut K. C. Tessarek wrote: > Anyhow, I don't think that adding a formula to the ffmpeg src tree is > the right approach. I don't think that's the suggestion. Separate Github repo belonging to the FFmpeg Github organization. Thanks, Kyle _

[FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Kyle Swanson
senc.c:1051:38: warning: format specifies type 'long' but the argument has type 'long long' [-Wformat] avctx->bit_rate/1000, clipped_rate/1000); ^ Signed-off-by: Kyle Swanson --- libavcodec/opusenc.c | 2 +- 1 fil

Re: [FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Kyle Swanson
Hi, On Sun, Mar 26, 2017 at 1:20 PM, Nicolas George wrote: > > Thanks for the patch. > > Le sextidi 6 germinal, an CCXXV, Kyle Swanson a écrit : > > Squelches the following compiler warnings: > > > > libavcodec/opusenc.c:1051:16: warning: format specifies type &

Re: [FFmpeg-devel] [PATCH] libavcodec/opusenc: use correct format specifiers

2017-03-26 Thread Kyle Swanson
On Sun, Mar 26, 2017 at 1:53 PM, Kyle Swanson wrote: > Hi, > > On Sun, Mar 26, 2017 at 1:20 PM, Nicolas George wrote: >> >> Thanks for the patch. >> >> Le sextidi 6 germinal, an CCXXV, Kyle Swanson a écrit : >> > Squelches the following compiler warnin

[FFmpeg-devel] [PATCH] avfilter/af_loudnorm: do not upsample during second-pass linear normalization

2017-04-02 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_loudnorm.c | 58 +++ 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c index 9d91c76..e3e815e 100644 --- a/libavfilter/af_loudnorm.c

Re: [FFmpeg-devel] [PATCH] avfilter/af_loudnorm: do not upsample during second-pass linear normalization

2017-04-04 Thread Kyle Swanson
Hi, On Sun, Apr 2, 2017 at 6:32 PM, Kyle Swanson wrote: > Signed-off-by: Kyle Swanson > --- > libavfilter/af_loudnorm.c | 58 +++--- > - > 1 file changed, 34 insertions(+), 24 deletions(-) > > diff --git a/libavfilter/af_lou

Re: [FFmpeg-devel] [PATCH] avfilter/af_loudnorm: do not upsample during second-pass linear normalization

2017-04-05 Thread Kyle Swanson
On Tue, Apr 4, 2017 at 7:14 AM, Kyle Swanson wrote: > Hi, > > > On Sun, Apr 2, 2017 at 6:32 PM, Kyle Swanson wrote: > >> Signed-off-by: Kyle Swanson >> --- >> libavfilter/af_loudnorm.c | 58 +++--- >> - >> 1

Re: [FFmpeg-devel] [PATCH] lavfi: make ff_framequeue_skip_samples() more useful.

2017-04-25 Thread Kyle Swanson
Hi, On Sun, Jan 29, 2017 at 11:54 AM, Nicolas George wrote: > > Le decadi 10 pluviôse, an CCXXV, Muhammad Faiz a écrit : > > LGTM > > Thanks, pushed. > > Regards, > > -- > Nicolas George > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-01 Thread Kyle Swanson
Hi, On Mon, May 1, 2017 at 3:18 AM, Paul B Mahol wrote: > On 4/30/17, Nicolas George wrote: >> Le primidi 11 floreal, an CCXXV, Muhammad Faiz a ecrit : >>> Are you working on these? Because currently I'm not. >> >> There is nothing to work on yet: the message you answer to is raising a >> questi

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Kyle Swanson
Hi, On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: > On Tue, 2 May 2017 16:16:35 +0200 > Nicolas George wrote: > >> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >> > This is all one big mess. >> >> It is, but I will not take responsibility when it is not mine. >> >> Libavfilter was in need

Re: [FFmpeg-devel] FFmpeg 3.3.1

2017-05-24 Thread Kyle Swanson
Hi, On Sun, May 14, 2017 at 5:15 AM, Michael Niedermayer wrote: > On Sun, May 14, 2017 at 11:05:42AM +0200, Hendrik Leppkes wrote: >> On Sun, May 14, 2017 at 3:18 AM, Michael Niedermayer >> wrote: >> > Hi all >> > >> > ill make 3.3.1 soon (likely within 24h) and releases from other >> > maintain

Re: [FFmpeg-devel] order T-shirts

2017-12-19 Thread Kyle Swanson
Hi, Yeah, got mine too! Arrived safely in the USA. Thanks Thilo! Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] order T-shirts

2017-10-24 Thread Kyle Swanson
Hi, On Sun, Sep 4, 2016 at 2:34 PM, Thomas Volkert wrote: > Hi, > > Some guys at the VDD asked for FFmpeg T-shirts. > I'd like to do a new T-shirt order. The shirts could be given to > multimedia devs who stop at one of our next booths. > > My idea is to order 25 shirts: > > 1*S > 5*M > 10*L > 7

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-11-03 Thread Kyle Swanson
Hi, >On Sun, Oct 16, 2016 at 2:32 PM, Marton Balint wrote: I haven't been checking ffmpeg-devel too much lately and just saw these patches today. I'm glad to see that an ffmpeg libebur128 port is being taken seriously now, I had some trouble getting traction on a few similar patches earlier this

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-11-08 Thread Kyle Swanson
On Mon, Nov 7, 2016 at 6:00 PM, Marton Balint wrote: > > On Fri, 4 Nov 2016, Marton Balint wrote: > >> >> On Thu, 3 Nov 2016, Hendrik Leppkes wrote: >> >>> On Mon, Oct 17, 2016 at 5:20 PM, Moritz Barsnick >>> wrote: On Mon, Oct 17, 2016 at 17:09:15 +0200, wm4 wrote: > > Does thi

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-11-10 Thread Kyle Swanson
On Tue, Nov 8, 2016 at 9:39 AM, Kyle Swanson wrote: > On Mon, Nov 7, 2016 at 6:00 PM, Marton Balint wrote: >> >> On Fri, 4 Nov 2016, Marton Balint wrote: >> >>> >>> On Thu, 3 Nov 2016, Hendrik Leppkes wrote: >>> >>>> On Mon, Oct 17,

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-11-10 Thread Kyle Swanson
On Thu, Nov 10, 2016 at 4:16 PM, Marton Balint wrote: > > On Thu, 10 Nov 2016, Kyle Swanson wrote: > >> On Tue, Nov 8, 2016 at 9:39 AM, Kyle Swanson wrote: >> >> These patches look good to me. If we're going to do this, we really >> need to keep the true pea

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-11-11 Thread Kyle Swanson
On Fri, Nov 11, 2016 at 6:12 PM, Marton Balint wrote: > > On Thu, 10 Nov 2016, Kyle Swanson wrote: > >> On Thu, Nov 10, 2016 at 4:16 PM, Marton Balint wrote: >>> >>> >>> On Thu, 10 Nov 2016, Kyle Swanson wrote: >>> >>>> On Tue, Nov 8

[FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Kyle Swanson
Hi, Here's a couple of patches which update the ebur128 filter to use the recently added ebur128 API. This updated filter allows fine-tuned control over which EBU R128 parameters are measured, and provides modest speed increases over the previous ebur128 filter. Also noteworthy: this removes the v

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Kyle Swanson
On Thu, Nov 17, 2016 at 6:55 PM, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 11:04:46AM -0600, Kyle Swanson wrote: >> Hi, >> >> Here's a couple of patches which update the ebur128 filter to use the >> recently added ebur128 API. This updated filter allows

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-17 Thread Kyle Swanson
On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson wrote: > Hi, > > Here's a couple of patches which update the ebur128 filter to use the > recently added ebur128 API. This updated filter allows fine-tuned > control over which EBU R128 parameters are measured, and provides >

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-11-28 Thread Kyle Swanson
On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson wrote: > Hi, > > Here's a couple of patches which update the ebur128 filter to use the > recently added ebur128 API. This updated filter allows fine-tuned > control over which EBU R128 parameters are measured, and provides >

[FFmpeg-devel] [PATCH] cmdutils: improve `-buildconf` for shell substitution

2016-09-27 Thread Kyle Swanson
Hi, Always thought something like this might be useful, but I finally took the time to take a look. Useful when you want to configure a new FFmpeg build using the configuration string of a previously built version. True you could accomplish the same thing with sed, but I think this tweak is still

Re: [FFmpeg-devel] [PATCH] cmdutils: improve `-buildconf` for shell substitution

2016-09-27 Thread Kyle Swanson
On Tue, Sep 27, 2016 at 4:37 PM, Clément Bœsch wrote: > > On Tue, Sep 27, 2016 at 04:25:52PM -0500, Kyle Swanson wrote: > > Hi, > > > > Always thought something like this might be useful, but I finally took the > > time to take a look. Useful when you want t

[FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-05 Thread Kyle Swanson
ur128'. Please also see the accompanying blog post[2] which has an algorithm description, as well as some usage instructions. [1] https://github.com/jiixyj/libebur128 [2] http://k.ylo.ph/2016/04/04/loudnorm.html Thanks! Kyle Signed-off-by: Kyle Swanson --- Changelog | 1 + M

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-05 Thread Kyle Swanson
> Here's another audio filter. I hinted at this a few months ago, but I found > out that > finishing the last 5% took almost as long as the first 95%. This is an EBU > R128 > dynamic loudness normalization filter. This filter uses libebur128 v1.1.0[1] > and must be > configured with `--enable-li

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-06 Thread Kyle Swanson
On Wed, Apr 6, 2016 at 12:45 AM, Clément Bœsch wrote: > On Tue, Apr 05, 2016 at 07:01:14PM -0500, Kyle Swanson wrote: >> Here's another audio filter. I hinted at this a few months ago, but I found >> out that >> finishing the last 5% took almost as long as the first 95

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-06 Thread Kyle Swanson
On Wed, Apr 6, 2016 at 10:02 AM, Clément Bœsch wrote: > On Wed, Apr 06, 2016 at 09:52:51AM -0500, Kyle Swanson wrote: >> On Wed, Apr 6, 2016 at 12:45 AM, Clément Bœsch wrote: >> > On Tue, Apr 05, 2016 at 07:01:14PM -0500, Kyle Swanson wrote: >> >> Here's anoth

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-06 Thread Kyle Swanson
On Wed, Apr 6, 2016 at 5:31 PM, Paul B Mahol wrote: > On 4/6/16, Kyle Swanson wrote: >> On Wed, Apr 6, 2016 at 10:02 AM, Clement Boesch wrote: >>> On Wed, Apr 06, 2016 at 09:52:51AM -0500, Kyle Swanson wrote: >>>> On Wed, Apr 6, 2016 at 12:45 AM, Clement Boesch

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-06 Thread Kyle Swanson
On Tue, Apr 5, 2016 at 7:01 PM, Kyle Swanson wrote: > Here's another audio filter. I hinted at this a few months ago, but I found > out that > finishing the last 5% took almost as long as the first 95%. This is an EBU > R128 > dynamic loudness normalization filter. This fi

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-08 Thread Kyle Swanson
On Wed, Apr 6, 2016 at 8:09 PM, Carl Eugen Hoyos wrote: > Kyle Swanson ylo.ph> writes: > >> Does anyone have any comments about this besides the fact >> that it links an external library? > > It is not ok to add an additional dependency to FFmpeg if the > feat

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-08 Thread Kyle Swanson
On Fri, Apr 8, 2016 at 4:07 PM, Kyle Swanson wrote: > On Wed, Apr 6, 2016 at 8:09 PM, Carl Eugen Hoyos wrote: >> Kyle Swanson ylo.ph> writes: >> >>> Does anyone have any comments about this besides the fact >>> that it links an external library? >

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-09 Thread Kyle Swanson
On Tue, Apr 5, 2016 at 7:01 PM, Kyle Swanson wrote: > > Here's another audio filter. I hinted at this a few months ago, but I found > out that > finishing the last 5% took almost as long as the first 95%. This is an EBU > R128 > dynamic loudness normalization filter. This

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-09 Thread Kyle Swanson
Hi, Updated patch attached. Thanks! 0001-avfilter-add-loudnorm.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-10 Thread Kyle Swanson
On Tue, May 10, 2016 at 4:35 AM, Rostislav Pehlivanov wrote: > Then just copy the logic from libebur128 into the filter, the library > itself is smaller than some filters we have and it's under the MIT license. I think this is probably a good way to go. I'd need to rewrite the resampling bit to u

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-10 Thread Kyle Swanson
On Tue, May 10, 2016 at 4:33 AM, Paul B Mahol wrote: > On 5/10/16, Kyle Swanson wrote: >> Hi, >> >> Updated patch attached. Thanks! >> > > > [...] > >> >> +@section loudnorm >> + >> +EBU R128 loudness normalization. Includes both d

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-11 Thread Kyle Swanson
Hi, Updated patch attached. 0001-avfilter-add-loudnorm.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-14 Thread Kyle Swanson
Hi, If nobody else has any changes, can this please be pushed? Thanks On Wed, May 11, 2016 at 1:35 PM, Kyle Swanson wrote: > Hi, > > Updated patch attached. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-14 Thread Kyle Swanson
On Sat, May 14, 2016 at 5:49 PM, Paul B Mahol wrote: > On 5/14/16, Kyle Swanson wrote: >> Hi, >> >> If nobody else has any changes, can this please be pushed? > > What about removal of libebur128 dependency? > I figured loudnorm can be pushed now, and porting lib

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-05-19 Thread Kyle Swanson
> > Pushed. Waiting for libebur128 removal as dependency. Thanks. Working on porting libebur128 to FFmpeg now. Hopefully I can find some time to finish that patch soon. > > Can anything be done to make this filter faster? Probably, I'll do some profiling. The true peak limiter requires upsamplin

[FFmpeg-devel] [PATCH] avfilter/af_loudnorm: add dual_mono option

2016-06-07 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- doc/filters.texi | 7 +++ libavfilter/af_loudnorm.c | 7 +++ 2 files changed, 14 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index d9330e3..439baf9 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -2765,6 +2765,13

Re: [FFmpeg-devel] [PATCH] avfilter/af_loudnorm: add dual_mono option

2016-06-09 Thread Kyle Swanson
On Tue, Jun 7, 2016 at 11:55 AM, Kyle Swanson wrote: > Signed-off-by: Kyle Swanson > --- > doc/filters.texi | 7 +++ > libavfilter/af_loudnorm.c | 7 +++ > 2 files changed, 14 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index

[FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-12 Thread Kyle Swanson
Hi all, Here's three patches. These are still WIP and not ready to be pushed. 0001-avfilter-add-libebur128-port.patch This first patch ports libebur128 to ffmpeg. I haven't re-indented these yet, so please diff `ebur128.c' and `ebur128.h' with the original libebur128 files[1][2] to see what has c

Re: [FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-12 Thread Kyle Swanson
On Sun, Jun 12, 2016 at 8:07 PM, Rostislav Pehlivanov wrote: > On 13 June 2016 at 01:57, Michael Niedermayer > wrote: > >> On Sun, Jun 12, 2016 at 04:14:56PM -0500, Kyle Swanson wrote: >> > Hi all, >> > >> > Here's three patches. These are still

Re: [FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-12 Thread Kyle Swanson
On Sun, Jun 12, 2016 at 4:32 PM, Rostislav Pehlivanov wrote: > On 12 June 2016 at 22:14, Kyle Swanson wrote: > >> Hi all, >> >> Here's three patches. These are still WIP and not ready to be pushed. >> >> 0001-avfilter-add-libebur128-port.patch >>

[FFmpeg-devel] [PATCH] tools: update normalize script example to use loudnorm

2016-06-12 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- tools/normalize.py | 33 -- tools/normalize.rb | 60 ++ 2 files changed, 60 insertions(+), 33 deletions(-) delete mode 100755 tools/normalize.py create mode 100644 tools/normalize.rb

Re: [FFmpeg-devel] [PATCH] tools: update normalize script example to use loudnorm

2016-06-15 Thread Kyle Swanson
On Mon, Jun 13, 2016 at 3:23 AM, Clément Bœsch wrote: > On Sun, Jun 12, 2016 at 10:44:15PM -0500, Kyle Swanson wrote: >> Signed-off-by: Kyle Swanson >> --- >> tools/normalize.py | 33 -- >&g

Re: [FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-17 Thread Kyle Swanson
On Sun, Jun 12, 2016 at 4:14 PM, Kyle Swanson wrote: > > 0001-avfilter-add-libebur128-port.patch > This first patch ports libebur128 to ffmpeg. I haven't re-indented > these yet, so please diff `ebur128.c' and `ebur128.h' with the > original libebur128 files[1][2]

Re: [FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-19 Thread Kyle Swanson
On Sat, Jun 18, 2016 at 3:49 AM, Hendrik Leppkes wrote: > On Sat, Jun 18, 2016 at 10:38 AM, Hendrik Leppkes wrote: >> On Sat, Jun 18, 2016 at 8:43 AM, Kyle Swanson wrote: >>> On Sun, Jun 12, 2016 at 4:14 PM, Kyle Swanson wrote: >>>> >>>> 0001-avfilter

Re: [FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-19 Thread Kyle Swanson
gt;> >> > On Sat, Jun 18, 2016 at 10:38 AM, Hendrik Leppkes >> >> > wrote: >> >> >> On Sat, Jun 18, 2016 at 8:43 AM, Kyle Swanson wrote: >> >> >>> On Sun, Jun 12, 2016 at 4:14 PM, Kyle Swanson wrote: >> >> >>>&

Re: [FFmpeg-devel] FFmpeg 3.1 name

2016-06-24 Thread Kyle Swanson
On Thu, Jun 23, 2016 at 4:00 PM, Michael Niedermayer wrote: > Hi all > > what shall FFmpeg 3.1 be called ? > > I still have these ideas from past suggestions: > Von Neumann, Einstein, lorentz, poincaré, desitter, de broglie, Gauss, > Galois, Viterbi, Darwin > > Are there other suggestions? > Is s

Re: [FFmpeg-devel] [PATCH][WIP] avfilter: add libebur128 port

2016-06-27 Thread Kyle Swanson
On Sun, Jun 19, 2016 at 2:17 AM, Kyle Swanson wrote: > Hi, > > af_loudnorm currently links libebur128. The port makes sense because > libebur128 is tiny, MIT-licensed, has a good API, and would be useful > in several filters. Perceptual loudness has become an important topic > i

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2016-12-28 Thread Kyle Swanson
On Mon, Nov 28, 2016 at 10:59 PM, Marton Balint wrote: > > On Mon, 28 Nov 2016, Kyle Swanson wrote: > > On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson wrote: >> >>> Hi, >>> >>> Here's a couple of patches which update the ebur128 filter to us

Re: [FFmpeg-devel] [PATCH] lavfi/af_ebur128: update filter to use new ebur128 API

2017-01-01 Thread Kyle Swanson
On Wed, Dec 28, 2016 at 9:51 AM, Kyle Swanson wrote: > On Mon, Nov 28, 2016 at 10:59 PM, Marton Balint wrote: > >> >> On Mon, 28 Nov 2016, Kyle Swanson wrote: >> >> On Thu, Nov 17, 2016 at 11:04 AM, Kyle Swanson wrote: >>> >>>> Hi, >>&g

[FFmpeg-devel] [PATCH] avcodec/g722enc: force mono channel layout

2017-06-23 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavcodec/g722enc.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index 01a3db26fd..473646f45c 100644 --- a/libavcodec/g722enc.c +++ b/libavcodec/g722enc.c @@ -61,11

Re: [FFmpeg-devel] [PATCH] avcodec/g722enc: force mono channel layout

2017-06-23 Thread Kyle Swanson
On Fri, Jun 23, 2017 at 5:46 PM, Paul B Mahol wrote: > On 6/23/17, Kyle Swanson wrote: >> Signed-off-by: Kyle Swanson >> --- >> libavcodec/g722enc.c | 27 +++ >> 1 file changed, 11 insertions(+), 16 deletions(-) >> > > Shoul

Re: [FFmpeg-devel] [PATCH] avcodec/g722enc: force mono channel layout

2017-06-26 Thread Kyle Swanson
On Fri, Jun 23, 2017 at 5:46 PM, Paul B Mahol wrote: > On 6/23/17, Kyle Swanson wrote: > > Signed-off-by: Kyle Swanson > > --- > > libavcodec/g722enc.c | 27 +++ > > 1 file changed, 11 insertions(+), 16 deletions(-) > > > > Shoul

Re: [FFmpeg-devel] filters.texi: explain audio upsampling in loudnorm

2017-08-17 Thread Kyle Swanson
On Thu, Aug 17, 2017 at 1:27 PM, Lou Logan wrote: > On Wed, 16 Aug 2017 13:33:24 +0200 > Werner Robitza wrote: > >> From 35b49e497cac452c76ead8da4d618ab93216ad15 Mon Sep 17 00:00:00 2001 >> From: Werner Robitza >> Date: Wed, 16 Aug 2017 13:27:19 +0200 >> Subject: [PATCH] filters.texi: explain au

Re: [FFmpeg-devel] [PATCH] vf_libvmaf: Fix memory leak

2018-03-31 Thread Kyle Swanson
Hi, On Sun, Mar 25, 2018 at 9:44 AM, enctac wrote: > Fixes ticket #6967 > --- > libavfilter/vf_libvmaf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index dfe474c40c..42c6b66b69 100644 > --- a/libavfilter/vf_libvmaf.c > +++ b/

Re: [FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-04-09 Thread Kyle Swanson
Hi, On Sun, Apr 8, 2018 at 6:27 PM, wrote: > From: Misty De Meo > > --- > libavformat/segafilm.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c > index 4c0cca0140..e72c26b144 100644 > --- a/libavformat/segafilm.c >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/segafilmenc: Do not mix variable declaration and code.

2018-04-09 Thread Kyle Swanson
On Mon, Apr 9, 2018 at 3:50 PM, Carl Eugen Hoyos wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Tue Apr > 10 00:50:01 2018 +0200| [4d1d7263d8ff32e67710b41f24fe485818c87211] | > committer: Carl Eugen Hoyos > > lavf/segafilmenc: Do not mix variable declaration and code. > > Fixes two warnin

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

2018-01-08 Thread Kyle Swanson
Hi, Can you provide some context for this? Please add docs as well. Can't really test this because it segfaults for me: ./ffmpeg -f lavfi -i anoisesrc -af dumpwave -f null - On Sun, Jan 7, 2018 at 4:36 PM, wrote: > > From: Dmytro Humeniuk > > Signed-off-by: Dmytro Humeniuk > --- > Changelog

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-09 Thread Kyle Swanson
Hi, On Tue, Jan 9, 2018 at 3:49 PM, wrote: > From: Dmytro Humeniuk > > Signed-off-by: Dmytro Humeniuk > --- > Changelog | 1 + > doc/filters.texi | 23 > libavfilter/Makefile | 1 + > libavfilter/af_dumpwave.c | 285 +

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-10 Thread Kyle Swanson
Hi, For this to be a part of libavfilter the output needs to be more generic than the just the Soundcloud format. If we want this to be generally useful it should probably just output an array of floats between 0.0 and 1.0. The consumer of this data (JS library, or whatever) can use this in whatev

Re: [FFmpeg-devel] [PATCH v2] avfilter: add dumpwave filter.

2018-01-11 Thread Kyle Swanson
Hi, Make sure you go back and read our comments. There were several things you didn't address in your most recent patch. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

  1   2   >