On Fri, Apr 8, 2016 at 4:07 PM, Kyle Swanson <k...@ylo.ph> wrote: > On Wed, Apr 6, 2016 at 8:09 PM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote: >> Kyle Swanson <k <at> ylo.ph> writes: >> >>> Does anyone have any comments about this besides the fact >>> that it links an external library? >> >> It is not ok to add an additional dependency to FFmpeg if the >> features of the new dependency are already available within >> FFmpeg. >> (Note that I cannot judge if this is the case for your patch.) >> > > Any issues with breaking out the measurement logic from the ebur128 > filter into utility functions? I can take a crack at it if no one > thinks it's a horrible idea...
Or adapt the libebur128 code, which has a couple of nice features and an MIT license. Obviously the oversampling would have to be rewritten to use swresample. > >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
