Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

2017-01-27 Thread Andreas Cadhalpun
On 26.01.2017 13:59, Ronald S. Bultje wrote: > On Wed, Jan 25, 2017 at 8:56 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> On 26.01.2017 02:26, Ronald S. Bultje wrote: >>> The question is not whether changing A or B towards the other makes the >

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-27 Thread Andreas Cadhalpun
On 27.01.2017 02:56, Marton Balint wrote: > I see 3 problems (wm4 explicitly named them, but I also had them in mind) > - Little benefit, yet > - Makes the code less clean, more cluttered > - Increases binary size > > The ideas I proposed (use macros, use common / factorized checks for common > va

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 28.01.2017 03:48, Ronald S. Bultje wrote: > I agree a macro here doesn't help. My concern wasn't with the check itself, > I agree a file with 100 channels should error out. My concern is that these > files will universally be the result of fuzzing, so I don't want to spam > stderr with messages

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 28.01.2017 12:44, Marton Balint wrote: > If we reduce the number of extra lines (not at any cost), I think that helps. > There is also a solution which keeps the traditional C syntax, and is easy to > undestand even at first glance. > > if (st->codecpar->channels > FF_SANE_NB_CHANNELS) > r

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 29.01.2017 00:26, Paul B Mahol wrote: > On 1/29/17, Andreas Cadhalpun wrote: >> On 28.01.2017 12:44, Marton Balint wrote: >>> If we reduce the number of extra lines (not at any cost), I think that >>> helps. >>> There is also a solution which keeps the trad

Re: [FFmpeg-devel] [PATCH 1/9] 4xm: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 26.01.2017 03:21, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:11:02AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/4xm.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) > > LGTM > &

Re: [FFmpeg-devel] [PATCH 6/9] pvfdec: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 26.01.2017 09:37, Paul B Mahol wrote: > On 1/26/17, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/pvfdec.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> > &g

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 27.01.2017 03:27, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/boadec.c | 14 +- >> 1 file changed, 13 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH 2/9] electronicarts: prevent overflow during block alignment calculation

2017-01-28 Thread Andreas Cadhalpun
On 27.01.2017 01:44, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:11:31AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/electronicarts.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > LGT

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 04:46, Ronald S. Bultje wrote: > Hm ... So I guess I wasn't clear about this, but the reason I didn't reply > to other patches with log messages was not because I'm OK with, but simply > to keep the discussion contained in a single thread and not spam the list. > I'd prefer if the log

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 04:02, Marton Balint wrote: > > On Sun, 29 Jan 2017, Andreas Cadhalpun wrote: > >> On 28.01.2017 12:44, Marton Balint wrote: >>> If we reduce the number of extra lines (not at any cost), I think that >>> helps. >>> There is also a solution

Re: [FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 02:34, Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:12:19AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/ircamdec.c | 6 ++ >> 1 file changed, 6 insertions(+) > > LGTM assuming the author/

Re: [FFmpeg-devel] [PATCH 7/9] epafdec: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 09:51, Paul B Mahol wrote: > On 1/29/17, Michael Niedermayer wrote: >> On Thu, Jan 26, 2017 at 02:13:33AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/epafdec.c | 3 ++- >>> 1 file chang

Re: [FFmpeg-devel] [PATCH 8/9] xvag: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 09:51, Paul B Mahol wrote: > On 1/29/17, Michael Niedermayer wrote: >> On Thu, Jan 26, 2017 at 02:13:48AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/xvag.c | 3 ++- >>> 1 file chang

Re: [FFmpeg-devel] [PATCH 3/9] genh: prevent overflow during block alignment calculation

2017-01-29 Thread Andreas Cadhalpun
On 29.01.2017 09:52, Paul B Mahol wrote: > On 1/29/17, Michael Niedermayer wrote: >> On Thu, Jan 26, 2017 at 02:11:54AM +0100, Andreas Cadhalpun wrote: >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavformat/genh.c | 3 ++- >>> 1 file chang

[FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-29 Thread Andreas Cadhalpun
Fixes out-of-bounds writes. Signed-off-by: Andreas Cadhalpun --- libavcodec/speedhq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c index 385f779f83..6ae1e0f8df 100644 --- a/libavcodec/speedhq.c +++ b/libavcodec/speedhq.c

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 09:23, Steinar H. Gunderson wrote: > How can you get a negative run, which would be required for this to happen? Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: ff_dc_alpha_run_vlc_le.table[32] = {-1, 0} Best regards, Andreas ___

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-30 Thread Andreas Cadhalpun
On 31.01.2017 00:59, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 12:49:56AM +0100, Andreas Cadhalpun wrote: >>> How can you get a negative run, which would be required for this to happen? >> Some values in ff_dc_alpha_run_vlc_le.table are negative, e.g.: >> ff_d

[FFmpeg-devel] [PATCH] pgssubdec: reset rle_data_len/rle_remaining_len on allocation error

2017-01-30 Thread Andreas Cadhalpun
The code relies on their validity and otherwise can try to access a NULL object->rle pointer, causing segmentation faults. Signed-off-by: Andreas Cadhalpun --- libavcodec/pgssubdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/pgssubdec.c b/libavco

Re: [FFmpeg-devel] [PATCH 4/9] ircamdec: prevent overflow during block alignment calculation

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 09:52, Paul B Mahol wrote: > On 1/30/17, Andreas Cadhalpun wrote: >> On 29.01.2017 02:34, Michael Niedermayer wrote: >>> On Thu, Jan 26, 2017 at 02:12:19AM +0100, Andreas Cadhalpun wrote: >>>> Signed-off-by: Andreas Cadhalpun >>>> --- >&

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-30 Thread Andreas Cadhalpun
On 30.01.2017 17:17, Ronald S. Bultje wrote: > On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 29.01.2017 04:46, Ronald S. Bultje wrote: >>> Hm ... So I guess I wasn't clear about this, but the reason I d

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-01-31 Thread Andreas Cadhalpun
On 31.01.2017 09:43, Steinar H. Gunderson wrote: > On Tue, Jan 31, 2017 at 01:57:31AM +0100, Andreas Cadhalpun wrote: >>> This sounds like a strangeness in constructing the table, which shouldn't be >>> papered over in the inner loop of the decoder. >> Maybe, I don

Re: [FFmpeg-devel] [PATCH] pgssubdec: reset rle_data_len/rle_remaining_len on allocation error

2017-01-31 Thread Andreas Cadhalpun
On 31.01.2017 15:13, Michael Niedermayer wrote: > On Tue, Jan 31, 2017 at 01:59:38AM +0100, Andreas Cadhalpun wrote: >> The code relies on their validity and otherwise can try to access a NULL >> object->rle pointer, causing segmentation faults. >> >> Si

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-31 Thread Andreas Cadhalpun
On 31.01.2017 13:45, Ronald S. Bultje wrote: > I don't want this patch. I also don't want to discuss it further. Please > remove the log message. Thank you. For the sake of ending this, I've removed them. Please avoid complaining about log messages for my future patches. Thank you. Best regards,

Re: [FFmpeg-devel] [PATCH] speedhq: make sure the block index is not negative

2017-02-01 Thread Andreas Cadhalpun
On 01.02.2017 17:25, Steinar H. Gunderson wrote: > On Wed, Feb 01, 2017 at 02:17:05AM +0100, Andreas Cadhalpun wrote: >>> Would you mind sharing an input where this actually triggers? None of the >>> samples I have seem to trigger this, so I suppose it's some sort of fuzz

[FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line

2017-02-15 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/tiff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index efbd9791a5..474ea90015 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1386,6 +1386,7 @@ static av_cold int tiff_end(AVCodecContext

[FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

2017-02-15 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/mpegaudiodec_template.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/mpegaudiodec_template.c b/libavcodec/mpegaudiodec_template.c index 1114428f33..53c09edced 100644 --- a/libavcodec/mpegaudiodec_template.c +++ b/libavcodec

[FFmpeg-devel] [PATCH] wmaprodec: fix leaking fdsp on init failure

2017-02-15 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/wmaprodec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index 4d530264df..1ad1e23541 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -323,9 +323,6

[FFmpeg-devel] [PATCH] bink: fix leaking last frame on error

2017-02-15 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/bink.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/bink.c b/libavcodec/bink.c index cc55870114..91004a6ae5 100644 --- a/libavcodec/bink.c +++ b/libavcodec/bink.c @@ -1299,10 +1299,6 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] wmaprodec: fix leaking fdsp on init failure

2017-02-16 Thread Andreas Cadhalpun
On 16.02.2017 03:04, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:56:38AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/wmaprodec.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > sh

Re: [FFmpeg-devel] [PATCH] mpegaudiodec_template: fix leaking fdsp for mp3on4float

2017-02-16 Thread Andreas Cadhalpun
On 16.02.2017 03:12, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:39:17AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/mpegaudiodec_template.c | 3 +++ >> 1 file changed, 3 insertions(+) > > should b

Re: [FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line

2017-02-16 Thread Andreas Cadhalpun
On 16.02.2017 03:15, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:23:28AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/tiff.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavco

[FFmpeg-devel] [PATCH] fate: add yuv420p tiff en-/decoding test

2017-02-16 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- tests/lavf-regression.sh | 1 + tests/ref/lavf/tiff | 3 +++ 2 files changed, 4 insertions(+) diff --git a/tests/lavf-regression.sh b/tests/lavf-regression.sh index eda40f25db..90ecd21baa 100755 --- a/tests/lavf-regression.sh +++ b/tests/lavf

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-09 Thread Andreas Cadhalpun
Hi Kieran, On 09.08.2014 19:26, Kieran Kunhya wrote: The reality is that in the current state of affairs static linking is the *only* way you are guaranteed to have the features you expect and avoid ABI mismatches. It's very complicated when your users complain about bugs in an underlying librar

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-10 Thread Andreas Cadhalpun
jority of participants in this debate exhibit does not help with making progress on that front either. ... but I'm also under the impression that there is still too much bad blood between both upstreams for this to happen. On 10.08.2014 16:18, Reinhard Tartler wrote: > On Fri, Aug 8, 2014 a

Re: [FFmpeg-devel] [RFC][PATCH] Allow include files to be installed into subdirectory

2014-08-11 Thread Andreas Cadhalpun
Hi Ivan, On 11.08.2014 01:23, Ivan Kalvachev wrote: The patch is inspired by something I read in the Debian discussion. Libav and FFmpeg could be installed side by side without conflicts in the libraries, thanks to using additional suffixes. Thanks for your interest in the matter. However de

Re: [FFmpeg-devel] [PATCH 4/4] lavu: stop exporting internal functions

2014-08-11 Thread Andreas Cadhalpun
On 10.08.2014 02:04, James Almer wrote: Signed-off-by: James Almer --- libavutil/libavutil.v | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v index eb16ae1..e9f04cb 100644 --- a/libavutil/libavutil.v +++ b/libavutil/libavutil.v

Re: [FFmpeg-devel] [RFC][PATCH] Allow include files to be installed into subdirectory

2014-08-12 Thread Andreas Cadhalpun
Hi, On 12.08.2014 02:21, Ivan Kalvachev wrote: On 8/11/14, Andreas Cadhalpun wrote: Assuming it would be possible to install development packages for both at the same time, which one should be used, when building a program? It would be decided by the gcc -I inclusion option. But this path

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-16 Thread Andreas Cadhalpun
Hi, On 16.08.2014 17:49, Pau Garcia i Quiles wrote: On Sat, Aug 16, 2014 at 5:30 PM, Nicolas George mailto:geo...@nsup.org>> wrote: The only option is to make sure the users do not suffer from the fork, by making sure they can easily use the version that is most suited for thei

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-17 Thread Andreas Cadhalpun
Hi Russ, On 16.08.2014 18:33, Russ Allbery wrote: All the renaming and cordial co-existence in the world won't change this. The things that would change this is for one or both projects to develop a better security track record and a history of higher-quality code releases that require less ongo

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-18 Thread Andreas Cadhalpun
Hi Thomas, On 18.08.2014 08:36, Thomas Goirand wrote: There's been a very well commented technical reason stated here: the release team don't want to deal with 2 of the same library that are doing (nearly) the same things, with potentially the same security issues that we'd have to fix twice rat

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-18 Thread Andreas Cadhalpun
Hi Moritz, On 18.08.2014 14:05, Moritz Mühlenhoff wrote: Andreas Cadhalpun schrieb: On 18.08.2014 08:36, Thomas Goirand wrote: There's been a very well commented technical reason stated here: the release team don't want to deal with 2 of the same library that are doing (nearly

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-23 Thread Andreas Cadhalpun
Hi, On 17.08.2014 00:49, Andreas Cadhalpun wrote: I have now sent the pkg-config patches to the BTS [1]. I have found a simpler way to make it possible to link packages not using pkg-config against FFmpeg in Debian: The lib*-ffmpeg-dev packages now install symbolic links from the standard

Re: [FFmpeg-devel] [PATCH] web/style: Add a comment in the generated css file for the doc in the main repo

2014-08-23 Thread Andreas Cadhalpun
Hi, On 25.07.2014 11:25, db0 company wrote: Since the style in the release is the one generated from the website, it has to be the same license. If we add a license to the css/less, then it's better to have the same on the whole website. I'll add one. Did you choose a license already? Best re

Re: [FFmpeg-devel] [PATCH] Use makeinfo to generate html doc for the new website

2014-08-23 Thread Andreas Cadhalpun
/msg01516.html This is actually two separate changes. But as makeinfo and texi2html adopt 2 (very) different init file syntaxes, it is easier to do the two transitions at once. Based on a patch by Andreas Cadhalpun . Fixes Trac ticket #3232. Signed-off-by: Timothy Gu --- Is there a reason, why this

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 01:42, Michael Niedermayer wrote: From: Andreas Cadhalpun --- LICENSE.md |1 + tests/Makefile |2 +- tests/flower.pnm | Bin 0 -> 196623 bytes tests/lena.

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 14:11, Clément Bœsch wrote: On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote: [...] I'm fine with the patch, even though Lena has a special meaning in video processing... yep, i wonder if this is the best solution after sleepng over it. the lena image is well k

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 14:39, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 02:32:00PM +0200, Clément Bœsch wrote: On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote: On 26.08.2014 14:11, Clément Bœsch wrote: On

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 14:40, Nicolas George wrote: Also: aimlin /tmp $ apt-get source libav >& /dev/null aimlin /tmp $ ls -l libav-10.4/tests/lena.pnm -rw-r--r-- 1 cigaes cigaes 196668 Aug 17 16:31 libav-10.4/tests/lena.pnm (Of course it does not prove anything beyond the fact that people do not really

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 16:15, Derek Buitenhuis wrote: On 8/26/2014 12:42 AM, Michael Niedermayer wrote: [...] tests/lena.pnm | 109 I'm sorry but this is beyond stupid. I don't think so. We can't use the defacto DSP testing image because

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 16:50, Derek Buitenhuis wrote: On 8/26/2014 3:47 PM, Andreas Cadhalpun wrote: We can't use the defacto DSP testing image because it is not *FREE* enough for Debian? It is utterly asinine to remove it because Debian doesn't want to distribute Lena with source deb. They

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
Hi, On 26.08.2014 18:26, James Almer wrote: On 26/08/14 9:39 AM, Michael Niedermayer wrote: either way, i suggest that until we have a consensus, andreas should probably pick any of the solutions for debian so theres no delay on the debian side How is this a problem for Debian? lena.pnm is al

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 19:45, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 07:28:13PM +0200, Michael Niedermayer wrote: On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote: From: Andreas Cadhalpun in absence of any better ideas or pictures i intend to apply this soon of

Re: [FFmpeg-devel] [PATCH] Add a license to the LESS file

2014-08-26 Thread Andreas Cadhalpun
On 26.08.2014 21:38, db0company wrote: --- LICENSE.txt | 21 + src/less/style.less |6 -- 2 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 LICENSE.txt Thanks. diff --git a/LICENSE.txt b/LICENSE.txt new file mode 100644 index

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Andreas Cadhalpun
On 28.08.2014 14:01, Carl Eugen Hoyos wrote: Andreas Cadhalpun googlemail.com> writes: But I'm fine with moving lena.pnm to the FATE samples, which are downloaded with 'make fate-rsync'. Attached patch removes tests/lena.pnm and adapts the tests, assuming lena.pnm would b

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Andreas Cadhalpun
On 28.08.2014 14:29, Derek Buitenhuis wrote: On 8/28/2014 12:28 PM, Andreas Cadhalpun wrote: ffmpeg -f data -i http://samples.ffmpeg.org/image-samples/lena.pnm -c copy -f data -map 0 -y lena.pnm From: <https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-August/161881.html> possibl

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Andreas Cadhalpun
On 28.08.2014 15:16, Carl Eugen Hoyos wrote: Andreas Cadhalpun googlemail.com> writes: But I'm not sure what copying it to tests/data would be good for? So people can still run the limited tests without downloading the whole fate suite. With my patch that would still be possi

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Andreas Cadhalpun
On 28.08.2014 17:53, Clément Bœsch wrote: ffplay http://lucy.pkh.me/lena.pnm File size and dimensions are the same, and we can of course keep the file name since the person looks like Lena a bit. Would that one be OK? According to http://goo.gl/0K3qyP it should be OK as long as the attribution

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Andreas Cadhalpun
please you very much: http://www.shadyurl.com/ Le primidi 11 fructidor, an CCXXII, Andreas Cadhalpun a écrit : If you want to keep the original filename, why not use a real Lena [1] image, e.g.: https://en.wikipedia.org/wiki/File:Lena_Zavaroni_927-0962.jpg https://en.wikipedia.org/wiki

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Andreas Cadhalpun
On 28.08.2014 19:49, Reimar Döffinger wrote: I completely lost track of the discussion, but this all so shouts bikeshed and overkill. If I may suggest another colour for the shed: Put some random, freely licensed image where the Lena image was, put the Lena one in the sample repository and run th

[FFmpeg-devel] [PATCH] fix two spelling errors

2014-09-06 Thread Andreas Cadhalpun
Hi, attached patch fixes two spelling errors that crept in: allows to -> allows one to syncronization -> synchronization Please apply it before 2.4 gets released. Best regards, Andreas >From 8c4c7e6f7c1f6043156838cd9041beba91025060 Mon Sep 17 00:00:00 2001 From: Andreas Cadhal

Re: [FFmpeg-devel] [PATCH] fix two spelling errors

2014-09-06 Thread Andreas Cadhalpun
On 06.09.2014 13:45, Reimar Döffinger wrote: On Sat, Sep 06, 2014 at 12:13:30PM +0200, Andreas Cadhalpun wrote: -Effectively this allows to add padding with zeros from the left. +Effectively this allows one to add padding with zeros from the left. Huh? I don't think the second is more co

Re: [FFmpeg-devel] Should add AVProbeData change to API changes + release notes

2014-09-12 Thread Andreas Cadhalpun
Hi, On 11.08.2014 22:22, Michael Niedermayer wrote: On Mon, Aug 11, 2014 at 08:05:38PM +0200, Reimar Döffinger wrote: Hello, (sorry for being too lazy to send a patch) With the major version bump AVProbeData was extended by a new field. This so far has broken 3 places within FFmpeg and one with

Re: [FFmpeg-devel] Should add AVProbeData change to API changes + release notes

2014-09-12 Thread Andreas Cadhalpun
Hi, On 12.09.2014 15:18, Michael Niedermayer wrote: On Fri, Sep 12, 2014 at 01:54:36PM +0200, Andreas Cadhalpun wrote: On 11.08.2014 22:22, Michael Niedermayer wrote: On Mon, Aug 11, 2014 at 08:05:38PM +0200, Reimar Döffinger wrote: Hello, (sorry for being too lazy to send a patch) With the

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc: document the addition of the AVProbeData.mime_type field and it' s implications

2014-09-13 Thread Andreas Cadhalpun
On 13.09.2014 15:25, Michael Niedermayer wrote: On Sat, Sep 13, 2014 at 08:24:39AM +0200, Clément Bœsch wrote: On Sat, Sep 13, 2014 at 12:53:21AM +0200, Andreas Cadhalpun wrote: ffmpeg | branch: master | Andreas Cadhalpun | Fri Sep 12 18:18:42 2014 +0200

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc: document the addition of the AVProbeData.mime_type field and it' s implications

2014-09-13 Thread Andreas Cadhalpun
On 13.09.2014 23:54, Clément Bœsch wrote: On Sat, Sep 13, 2014 at 11:38:56PM +0200, Andreas Cadhalpun wrote: On 13.09.2014 15:25, Michael Niedermayer wrote: On Sat, Sep 13, 2014 at 08:24:39AM +0200, Clément Bœsch wrote: On Sat, Sep 13, 2014 at 12:53:21AM +0200, Andreas Cadhalpun wrote

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc: document the addition of the AVProbeData.mime_type field and it' s implications

2014-09-13 Thread Andreas Cadhalpun
>From 859003a6ac55243c90a7f1cf8924b8213e53e1df Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 14 Sep 2014 00:51:19 +0200 Subject: [PATCH 1/2] doc: don't claim in the RELEASE_NOTES for 2.4 that the API didn't change Signed-off-by: Andreas Cadhalpun --- RELEASE_NOTES | 4 ++--

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc: document the addition of the AVProbeData.mime_type field and it' s implications

2014-09-13 Thread Andreas Cadhalpun
On 14.09.2014 01:29, Michael Niedermayer wrote: On Sun, Sep 14, 2014 at 01:05:45AM +0200, Andreas Cadhalpun wrote: On 14.09.2014 00:43, Michael Niedermayer wrote: note, i will release 2.4 tomorrow (2014-09-14) or rather i intend to. So anything that isnt pushed to the RELEASE_NOTES by then

Re: [FFmpeg-devel] [PATCH] Changelog/ReleaseNotes: prepare for 2.4

2014-09-14 Thread Andreas Cadhalpun
On 14.09.2014 08:33, Clément Bœsch wrote: From: Clément Bœsch --- Changelog | 2 +- RELEASE_NOTES | 19 ++- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/Changelog b/Changelog index c5185f7..480a298 100644 --- a/Changelog +++ b/Changelog @@ -5,7 +5,7 @

Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

2014-09-15 Thread Andreas Cadhalpun
On 15.09.2014 22:03, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: On 15/09/14 6:07 AM, Michael Niedermayer wrote: On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: Signed-off-by: James Almer about the patchset as a whole, not specificall

[FFmpeg-devel] [PATCH] vf_deshake: rename Transform.vector to Transform.vec to avoid compiler confusion

2014-09-17 Thread Andreas Cadhalpun
2f61308 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Thu, 18 Sep 2014 00:08:05 +0200 Subject: [PATCH] vf_deshake: rename Transform.vector to Transform.vec to avoid compiler confusion The token 'vector' is a keyword in the Vector/SIMD Multimedia Extension data types and thus sh

Re: [FFmpeg-devel] [PATCH] vf_deshake: rename Transform.vector to Transform.vec to avoid compiler confusion

2014-09-17 Thread Andreas Cadhalpun
On 18.09.2014 00:33, Carl Eugen Hoyos wrote: Andreas Cadhalpun googlemail.com> writes: FFmpeg failed to build in Debian on powerpc/ppc64el with the following error: Out of curiosity: How can I reproduce this? I believe I tested on ppc64 Linux last week... If you have a Debian jessie/

Re: [FFmpeg-devel] [PATCH] tests/fate-run.sh: Cat .err file in case of error with V>0

2014-09-23 Thread Andreas Cadhalpun
On 23.09.2014 23:47, Michael Niedermayer wrote: This may make fate failures where only the console output is available easier to analyze Suggested-by: Andreas Cadhalpun Signed-off-by: Michael Niedermayer --- tests/fate-run.sh |1 + 1 file changed, 1 insertion(+) diff --git a/tests/fate

Re: [FFmpeg-devel] [PATCH] tests/fate-run.sh: Cat .err file in case of error with V>0

2014-09-23 Thread Andreas Cadhalpun
On 24.09.2014 00:43, Michael Niedermayer wrote: On Wed, Sep 24, 2014 at 12:33:25AM +0200, Andreas Cadhalpun wrote: On 23.09.2014 23:47, Michael Niedermayer wrote: This may make fate failures where only the console output is available easier to analyze Suggested-by: Andreas Cadhalpun Signed

Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

2014-10-01 Thread Andreas Cadhalpun
On 01.10.2014 04:34, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: On 15.09.2014 22:03, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: On 15/09/14 6:07 AM, Michael Niedermayer wrote: On Sun, Sep 14, 2014

[FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental

2014-11-20 Thread Andreas Cadhalpun
Hi, currently the native aac encoder is marked as experimental, while the libvo_aacenc encoder is not. However, after reading the wiki [1] and especially the mentioned mail [2], it seems the native encoder is better. Thus I'm wondering if it would make sense to no longer mark the native aa

Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental

2014-11-30 Thread Andreas Cadhalpun
On 20.11.2014 20:14, Michael Niedermayer wrote: On Thu, Nov 20, 2014 at 05:59:35PM +0100, Andreas Cadhalpun wrote: Hi, currently the native aac encoder is marked as experimental, while the libvo_aacenc encoder is not. However, after reading the wiki [1] and especially the mentioned mail [2

[FFmpeg-devel] [PATCH] doc: correct license template for t2h.pm

2014-11-30 Thread Andreas Cadhalpun
Hi, the license template of doc/t2h.pm incorrectly mentions the Lesser General Public License even though the license is GPL 3+. Attached patch fixes this. Best regards, Andreas >From 5b287f85837be262c973ef696f3d77488f7ddec1 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 30

[FFmpeg-devel] [PATCH] doc: fix spelling errors

2014-11-30 Thread Andreas Cadhalpun
de7b87b4f4c89e150640c58 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 30 Nov 2014 23:59:22 +0100 Subject: [PATCH] doc: fix spelling errors succesfully => successfully, reproducable => reproducible, specifiying => specifying, isnt => isn't, seperated => separa

Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental

2014-12-01 Thread Andreas Cadhalpun
Hi, On 01.12.2014 04:37, Michael Niedermayer wrote: On Sun, Nov 30, 2014 at 11:43:45PM +0100, Andreas Cadhalpun wrote: Subject: [PATCH] avcodec/aacenc: no longer mark native aac encoder as experimental this would result in the native encoder being used even when libfaac is enabled and

Re: [FFmpeg-devel] [RFC] no longer marking native aac encoder as experimental

2014-12-01 Thread Andreas Cadhalpun
Hi, On 02.12.2014 00:09, Michael Niedermayer wrote: On Mon, Dec 01, 2014 at 11:09:47PM +0100, Andreas Cadhalpun wrote: On 01.12.2014 04:37, Michael Niedermayer wrote: this would result in the native encoder being used even when libfaac is enabled and linked in is that intended ? Yes, even

[FFmpeg-devel] [PATCH] configure: enable vsx together with altivec for ppc64el

2015-01-09 Thread Andreas Cadhalpun
Best regards, Andreas 1: https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&arch=ppc64el&ver=7%3A2.5.1-1&stamp=1418755783 >From 4765060cc6e81a75e3c57d101963631bef3eff13 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Fri, 9 Jan 2015 17:32:09 +0100 Subject: [PATCH] configure:

[FFmpeg-devel] [PATCH] doc/examples: fix lib math dep for decoding_encoding

2015-01-09 Thread Andreas Cadhalpun
From: Andreas Cadhalpun Date: Fri, 9 Jan 2015 17:50:27 +0100 Subject: [PATCH] doc/examples: fix lib math dep for decoding_encoding It uses at least sin(). Signed-off-by: Andreas Cadhalpun --- doc/examples/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/examples/Makefile b/doc/exam

[FFmpeg-devel] [PATCH] libavcodec/ppc/mpegvideoencdsp.c: fix stack smashing in pix_norm1_altivec() and pix_sum_altivec()

2015-01-20 Thread Andreas Cadhalpun
Yan, maybe you can have a look? Best regards, Andreas 1: https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&arch=ppc64el&ver=7%3A2.5.3-1&stamp=1421583916 >From 93d465397d95594870b2ff9bbd662ccfa306bfb7 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Tue, 20 Jan 2015

[FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-21 Thread Andreas Cadhalpun
problem. Best regards, Andreas 1: https://wiki.debian.org/ReproducibleBuilds/About >From 285003006eb2b9cd1a6e2dcd6351c7f8b3090366 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Wed, 21 Jan 2015 22:31:04 +0100 Subject: [PATCH] configure: add --build-date and --build-time options Th

[FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-21 Thread Andreas Cadhalpun
:00 2001 From: Andreas Cadhalpun Date: Wed, 21 Jan 2015 22:32:58 +0100 Subject: [PATCH] configure: use ar and ranlib in deterministic mode this makes the static libraries binary reproducible Signed-off-by: Andreas Cadhalpun --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-22 Thread Andreas Cadhalpun
Hi, On 22.01.2015 02:58, Timothy Gu wrote: I'd rather have an option disabling it. Sounds cleaner. In which way cleaner? Replacing the date/time with a reproducible one is the least invasive change. Removing it altogether would produce a different end result. Best regards, Andreas

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-22 Thread Andreas Cadhalpun
Hi, On 22.01.2015 15:31, wm4 wrote: If the build date is not correct, then what value does the build date have at all? How do you know it is 'correct' currently? One can change the system clock (or use faketime). What value has the 'correct' build date? If you build an ffmpeg version from a y

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-22 Thread Andreas Cadhalpun
Hi, On 22.01.2015 17:02, Benoit Fouet wrote: If this patch is accepted in the content, then, I'd decorrelate BUILD_DATE and BUILD_TIME a bit more than what it is in your patch (see below). Do you think one would ever want to specify one, but not the other? [...] @@ -5712,6 +5716,16 @@ cat

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-25 Thread Andreas Cadhalpun
ee/tp/Texinfo/Convert/HTML.pm/#n6118 >From 3163612fb5da694a4ebcc39605561558566d85ed Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 25 Jan 2015 21:13:18 +0100 Subject: [PATCH] stop embedding the build date Theis makes the build binary reproducible. Signed-off-by: Andreas C

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Andreas Cadhalpun
Attached patch checks if the help output contains the options. That should be sufficient. Best regards, Andreas >From ae77abb9d4be562bd7d129d2b769f65ca30ebdc3 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Mon, 26 Jan 2015 23:50:29 +0100 Subject: [PATCH] configure: use ar and ranlib in

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-27 Thread Andreas Cadhalpun
Hi, On 27.01.2015 08:05, Clément Bœsch wrote: Why not have a build option to make these reproducible build on demand? There is no drawback to having this by default? I don't know of anything using the uid/gid/timestamp fields in *.a files, so I can't see a drawback in putting zeros into thes

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-27 Thread Andreas Cadhalpun
Hi, On 27.01.2015 08:44, Hendrik Leppkes wrote: Checking help output with grep? Really? Did you ever stop to check how all the other checks work in configure? Usually it tries to run the command and see if it fails, instead of doing some arbitrary grep which may result in some other matches som

[FFmpeg-devel] [PATCH 1/2] examples/demuxing_decoding: abort decoding when width, height or pix_fmt change

2015-01-31 Thread Andreas Cadhalpun
Hi, the demuxing_decoding example crashes, if width, height or pixel format of the video stream change. Attached patch fixes this. Best regards, Andreas >From 37979054edd30f3c0ea60c2103c30a18fbbc9448 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sat, 31 Jan 2015 20:58:07 +0

[FFmpeg-devel] [PATCH 2/2] examples/demuxing_decoding: set stream_idx in open_codec_context only if no error occured

2015-01-31 Thread Andreas Cadhalpun
rom: Andreas Cadhalpun Date: Sat, 31 Jan 2015 21:11:38 +0100 Subject: [PATCH 2/2] examples/demuxing_decoding: set stream_idx in open_codec_context only if no error occured Signed-off-by: Andreas Cadhalpun --- doc/examples/demuxing_decoding.c | 7 --- 1 file changed, 4 insertions(+), 3 deleti

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-31 Thread Andreas Cadhalpun
On 25.01.2015 21:25, Andreas Cadhalpun wrote: Hi, On 25.01.2015 18:53, Michael Niedermayer wrote: On Sun, Jan 25, 2015 at 05:29:08PM +0100, Hendrik Leppkes wrote: On Sun, Jan 25, 2015 at 5:15 PM, Reimar Döffinger wrote: I vote for just removing the build date. [...] Remove it for all I

Re: [FFmpeg-devel] [PATCH 1/2] examples/demuxing_decoding: abort decoding when width, height or pix_fmt change

2015-01-31 Thread Andreas Cadhalpun
ch is sufficient or can you suggest a better wording? Best regards, Andreas >From 090e0fb14f3e4741c46fdd97cdcf3c0c7c922f39 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sat, 31 Jan 2015 20:36:07 +0100 Subject: [PATCH] examples/demuxing_decoding: abort decoding when width, height or pix_fm

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-31 Thread Andreas Cadhalpun
Hi, On 31.01.2015 22:36, Michael Niedermayer wrote: On Sun, Jan 25, 2015 at 09:25:07PM +0100, Andreas Cadhalpun wrote: diff --git a/doc/Doxyfile b/doc/Doxyfile index 8697e6c..5d18b10 100644 --- a/doc/Doxyfile +++ b/doc/Doxyfile @@ -839,7 +839,7 @@ HTML_COLORSTYLE_GAMMA = 80 # page will

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Andreas Cadhalpun
Hi, On 01.02.2015 16:44, Michael Niedermayer wrote: On Sat, Jan 31, 2015 at 11:18:26PM +0100, Andreas Cadhalpun wrote: One can include the git revision in the PROJECT_NUMBER, e.g. with attached patch. this works for generating the doxy for the headers only (make doc/doxy/html) doxygen doc

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-02-01 Thread Andreas Cadhalpun
Hi, On 01.02.2015 18:30, Timothy Gu wrote: On Sun Feb 01 2015 at 9:01:04 AM Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: On 01.02.2015 16:44, Michael Niedermayer wrote: doxygen doc/Doxyfile would lack the revission Yes, one has to use the doxy-wrapper to get the re

<    1   2   3   4   5   6   7   8   9   10   >