Re: [FFmpeg-devel] [PATCH v2] libavdevice: Improve example in deprecation message for opengl and sdl

2024-06-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-04-29 23:53 +0200, Alexander Strasser via ffmpeg-devel wrote: > When piping ffmpeg into ffplay both programs write a status line in > the terminal. That causes flickering and invisibility of one or the > other status line. > > As compromise set ffplay log level to warning

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-06-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote: > Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit > : > > > +static double ff_scalarproduct_double_c(const double *v1, > > > Don't use an ff_ prefix for a static function. > > I can see over 300 such identifiers in

Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

2024-06-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-06-02 13:30 +0300, Rémi Denis-Courmont wrote: > Le sunnuntaina 2. kesäkuuta 2024, 13.04.05 EEST Alexander Strasser via ffmpeg- > devel a écrit : > > On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote: > > > Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST

Re: [FFmpeg-devel] [RFC] fftools/ffmpeg and libavdevice/sdl issue

2023-12-15 Thread Alexander Strasser via ffmpeg-devel
On 2023-12-14 01:47 +0100, Stefano Sabatini wrote: > On date Wednesday 2023-12-13 10:08:45 +0100, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-12 18:27:39) > [...] > > Honestly I don't see how this could be done in ffmpeg CLI without > > disgusting hacks, but before that the question is: >

[FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl

2024-04-14 Thread Alexander Strasser via ffmpeg-devel
When piping ffmpeg into ffplay both programs write a status line in the terminal. That causes flickering and invisibility of one or the other status line. As compromise set ffplay log level to warning, so it doesn't show the status line. The user is usually testing ffmpeg command lines and want's

Re: [FFmpeg-devel] [PATCH] fate: allow https for git URLs

2024-04-24 Thread Alexander Strasser via ffmpeg-devel
On 2024-04-24 22:01 +0200, Timo Rothenpieler wrote: > --- > tests/fate.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/fate.sh b/tests/fate.sh > index c5ee18de80..4081e865ae 100755 > --- a/tests/fate.sh > +++ b/tests/fate.sh > @@ -30,14 +30,14 @@ lock(){ > ch

Re: [FFmpeg-devel] [PATCH] fate: allow https for git URLs

2024-04-24 Thread Alexander Strasser via ffmpeg-devel
On 2024-04-24 22:26 +0200, Timo Rothenpieler wrote: > On 24.04.2024 22:12, Alexander Strasser via ffmpeg-devel wrote: > > On 2024-04-24 22:01 +0200, Timo Rothenpieler wrote: > > > --- > > > tests/fate.sh | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 d

[FFmpeg-devel] [PATCH v2] libavdevice: Improve example in deprecation message for opengl and sdl

2024-04-29 Thread Alexander Strasser via ffmpeg-devel
When piping ffmpeg into ffplay both programs write a status line in the terminal. That causes flickering and invisibility of one or the other status line. As compromise set ffplay log level to warning, so it doesn't show the status line. The user is usually testing ffmpeg command lines and want's

Re: [FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl

2024-04-29 Thread Alexander Strasser via ffmpeg-devel
On 2024-04-14 21:24 +0200, Nicolas George wrote: > Nicolas George (12024-04-14): > > Either we find options to make ffplay display frames as fast as > > possible, or we must document to the user that no adequate replacement > > exists. > > Please add “-vf setpts=0”. It still has a little more laten

Re: [FFmpeg-devel] [PATCH v2] configure: support msvc build inside WSL

2024-05-01 Thread Alexander Strasser via ffmpeg-devel
On 2024-04-27 22:14 +0200, Timo Rothenpieler wrote: > --- > configure | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 8101b4fce6..89af5f75e7 100755 > --- a/configure > +++ b/configure > @@ -5036,7 +5036,12 @@ probe_cc(){ > else

Re: [FFmpeg-devel] [PATCH] lavc/bsf: add a showinfo filter

2024-02-12 Thread Alexander Strasser via ffmpeg-devel
On 2024-01-29 19:42 +0100, Anton Khirnov wrote: [...] > --- a/doc/bitstream_filters.texi > +++ b/doc/bitstream_filters.texi > @@ -887,6 +887,10 @@ For example, to set PTS equal to DTS (not recommended if > B-frames are involved): > ffmpeg -i INPUT -c:a copy -bsf:a setts=pts=DTS out.mkv > @end ex

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-03-10 Thread Alexander Strasser via ffmpeg-devel
On 2024-02-28 19:36 +0100, Jean-Baptiste Kempf wrote: > > On Wed, 28 Feb 2024, at 18:55, James Almer wrote: > > On 2/28/2024 10:31 AM, J. Dekker wrote: > >> > >> Michael Niedermayer writes: > >> > >>> [[PGP Signed Part:Undecided]] > >>> On Wed, Feb 28, 2024 at 01:56:10PM +0100, J. Dekker wrote: >

Re: [FFmpeg-devel] [PATCH v2] libavdevice: Improve example in deprecation message for opengl and sdl

2024-07-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-06-02 11:27 +0200, Alexander Strasser via ffmpeg-devel wrote: > On 2024-04-29 23:53 +0200, Alexander Strasser via ffmpeg-devel wrote: > > When piping ffmpeg into ffplay both programs write a status line in > > the terminal. That causes flickering and invisibility of one o

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: av_image_check_size2() ensure width and height fit in 32bit

2024-07-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-07-10 15:51 +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-10 15:44:47) > > Do you still object to a 32bit check on width and height ? > > If not i intend to apply a patch adding such limits > > If you object i will take this to the TC > > In my first reply in this threa

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

2024-10-13 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-12 23:36 +0200, martin schitter wrote: > On 12.10.24 23:18, epira...@gmail.com wrote: > > Maybe just squash them into one commit. > > Yes -- this looks like the most desirable solution. > > And thanks to Alex for the suggested improvement! Thank you Martin and Marvin for the quick respo

[FFmpeg-devel] [PATCH 1/2] lavc/dnxuc_parser: Adhere to av_fourcc_make_string API

2024-10-12 Thread Alexander Strasser via ffmpeg-devel
The documentation of av_fourcc_make_string states the passed in buffer must be of at least the size of AV_FOURCC_MAX_STRING_SIZE Also move the buffer into inner scope where it is used. Fixes: CID 1632380 --- libavcodec/dnxuc_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

2024-10-12 Thread Alexander Strasser via ffmpeg-devel
The string representation of the FourCC is only used once for logging. --- Could also merge this with the first patch in this series and make it a single patch. Or drop this one. I don't have a strong opinion on these details. libavcodec/dnxuc_parser.c | 5 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 19:22 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 18:27:24) > > On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > > > On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > > > > --- >

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38) > > > It is documented in the header. > > > > I figured as much but couldn't find a hint in in avfilter.h > > > > You changed it in a previou

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 10:37 +0200, epira...@gmail.com wrote: > > > On 15 Oct 2024, at 10:30, Anton Khirnov wrote: > > > Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 07:34:26) > >> On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > >>> Quoting Alexander Stra

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 15:09 +0200, Anton Khirnov wrote: > Quoting James Almer (2024-10-15 14:54:08) > > On 10/15/2024 6:57 AM, Anton Khirnov wrote: > > > avfilter_process_command() may or may not return ENOSYS whether that > > > flag is set or not, so I don't see what exactly would it be useful for. > > >

Re: [FFmpeg-devel] [PATCH 1/2] configure: suggest installing nasm/yasm before using --disable-x86asm

2024-10-09 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-03 04:04 +0200, Lynne via ffmpeg-devel wrote: > On 01/10/2024 15:24, vipyne wrote: > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index c8fb49a7a4..d178ef59dc 100755 > > --- a/configure > > +++ b/configure

[FFmpeg-devel] [RFC PATCH 3/2] FIXUP

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
--- Sorry I forgot this fixup to the previous patch, that I had in my work tree but not committed... tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 72251ec571..bed8f7127c 100755 --- a/tests/fate-run.sh +++ b/test

[FFmpeg-devel] [RFC PATCH 1/2] Reapply "tests/fate: disable compression for zlib-based codecs"

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
The problems that caused the revert will be fixed with the follow-up change right after this commit. This reverts commit e206e72b83a0e512e21694a43af4df2b53f6d045. --- tests/fate/cover-art.mak | 6 ++-- tests/fate/image.mak | 4 +-- tests/fate/lavf-image.mak

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 21:02 +0200, Michael Niedermayer wrote: > On Fri, Oct 18, 2024 at 02:02:48PM +0200, Alexander Strasser via ffmpeg-devel > wrote: > > This is as subject notes an RFC. I wanted to send it out quickly. > > Didn't actually test on zlib systems yet (old and new

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 13:16 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-18 12:55:49) > > FTR and FWIW it was useful for me for identifying filters that can do > > more with commands than timeline enable/disable. > > And then what do you do with

Re: [FFmpeg-devel] [RFC PATCH 2/2] fate: Make it possible to have alternative reference files

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 16:36 +0200, Lynne via ffmpeg-devel wrote: > On 18/10/2024 14:41, Hendrik Leppkes wrote: > > On Fri, Oct 18, 2024 at 2:09 PM Alexander Strasser via ffmpeg-devel > > wrote: > > > This caused differences > > > with 2 fate tests depending on the zlib v

[FFmpeg-devel] [RFC PATCH 2/2] fate: Make it possible to have alternative reference files

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
Sometimes deps (external from FFmpeg) can cause different results either because of bugs or because of drop in replacements. This feature of alternate reference files should only be used where absolutely necessary because other solutions are not feasible in practice. Maintaining two reference file

[FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
This is as subject notes an RFC. I wanted to send it out quickly. Didn't actually test on zlib systems yet (old and new). So it is not that heavily tested yet and maybe has rough edges I didn't notice. I hope this would help to unbreak zlib-ng systems and not disturb systems with older zlib versi

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 15:55 +0100, Derek Buitenhuis wrote: > On 10/18/2024 1:02 PM, Alexander Strasser via ffmpeg-devel wrote: > > Alexander Strasser (2): > > Reapply "tests/fate: disable compression for zlib-based codecs" > > fate: Make it possible to have alternativ

Re: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: fix use after free on close

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-17 20:23 +0200, Marvin Scholz wrote: > The way the linked list of images was freed caused a > use after free, by accessing pic->next after pic was > already freed. > > Regression from 48a1a12968345bf673db1e1cbb5c64bd3529c50c > > Fix CID1633236 > --- > libavcodec/hw_base_encode.c | 6 +++

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 21:24 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 21:05:54) > > Still that functionality is useful > > How is it useful? It gives you no actionable information. Seems this was just applied already. FTR and FWIW it was us

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > > --- > > fftools/opt_common.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > > index 021ed75272

[FFmpeg-devel] [PATCH v2 1/3] Reapply "tests/fate: disable compression for zlib-based codecs"

2024-12-01 Thread Alexander Strasser via ffmpeg-devel
This reverts commit e206e72b83a0e512e21694a43af4df2b53f6d045. --- tests/fate/cover-art.mak | 6 ++-- tests/fate/image.mak | 4 +-- tests/fate/lavf-image.mak | 5 +-- tests/fate/lavf-video.mak | 4 +-- tests/fate/mov.mak

[FFmpeg-devel] [PATCH v2 2/3] fate: Make it possible to have alternative reference files

2024-12-01 Thread Alexander Strasser via ffmpeg-devel
Sometimes deps (external from FFmpeg) can cause different results either because of bugs or because of drop in replacements. This feature of alternate reference files should only be used where absolutely necessary because other solutions are not feasible in practice. Maintaining two reference file

[FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-01 Thread Alexander Strasser via ffmpeg-devel
This is a fixed up version of the series I sent before. This worked for me on Ubuntu 20.04 but probably will break with older zlib versions as Hendrik pointed out in the previous thread. Either we must update zlib on affected FATE clients or add more .alt files to them as well. We could also go t

[FFmpeg-devel] [PATCH v2 3/3] fate: Add .alt files so all tests pass on Ubuntu 20.04

2024-12-01 Thread Alexander Strasser via ffmpeg-devel
In commit bce5855afb25d318e090c2e6c16117f065458356 we avoided the problem by using compression level 0. That fixed the problem, but introduced a problem with older versioins of original zlib. This caused differences 2 or more fate tests depending on the zlib version used. See e.g. zlib commit 8ba39

Re: [FFmpeg-devel] [PATCH] fate: Add a target for listing failed tests

2024-12-01 Thread Alexander Strasser via ffmpeg-devel
Hi Martin! On 2024-11-07 11:36 +0200, Martin Storsjö wrote: > If running tests with "make -j fate", the execution will stop > after the first failing test. To get an overview of the whole > test suite, one rather would run "make -k -j fate", which then > again buries the results about what tests a

[FFmpeg-devel] [PATCH] avcodec/cbs_h266: Fix typo

2024-12-01 Thread Alexander Strasser via ffmpeg-devel
Introduced in commit 98698ed3c24bfd0b1e6e6db943b5f25f6046cee7 Fixes: CID1635788 CID1635789 Signed-off-by: Alexander Strasser --- Just picked this up because of Coverity. Not sure how to verify/test this change, but it seems plausible. Alexander libavcodec/cbs_h266_syntax_template.c | 2 +-

Re: [FFmpeg-devel] [PATCH] fate: Add a target for listing failed tests

2024-12-05 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-04 16:07 +0200, Martin Storsjö wrote: > On Sun, 1 Dec 2024, Alexander Strasser via ffmpeg-devel wrote: [...] > > > > Would it be better to use the same description as int fate.texi ? > > Sure, I can add that extra parenthesis. Thanks. [...] > > > +fate

Re: [FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-07 Thread Alexander Strasser via ffmpeg-devel
Hi Leo! On 2024-12-01 09:20 -0500, Leo Izen wrote: > The PNGv3 Specification Draft [1] has changed the capitalization > of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates > FFmpeg to work with the new chunk names while retaining decode-side > compatibility with files created usin

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

2024-12-07 Thread Alexander Strasser via ffmpeg-devel
On 2024-11-28 15:29 +0100, Anton Khirnov wrote: > > the current Technical Committee (TC) was elected on 2023-12-05 and its > mandate lasts for one year, so we should hold a new election soon. If > there are no unforeseen circumstances, I would like to start the vote on > Monday 2024-12-09. > > As a

Re: [FFmpeg-devel] [PATCH] web: Add link to conferences page

2024-12-09 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-08 12:36 +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > src/template_head2 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/template_head2 b/src/template_head2 > index 0394ace..51da347 100644 > --- a/src/template_head2 > +++ b/src/template_he

Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2025-01-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-28 12:56 +0100, Alexander Strasser via ffmpeg-devel wrote: > On 2024-12-27 08:13 -0500, Leo Izen wrote: [...] > > > > I did a bit of testing and I believe the issue is >=, specifically, it's > > being interpreted as a redirect-out to a file named "=&q

Re: [FFmpeg-devel] [PATCH] avfilter/vf_grayworld: Use the correct pointer for av_log()

2025-01-06 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-06 05:22 +0100, Michael Niedermayer wrote: > Fixes: crash > > Found-by: Elias Myllymäki > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_grayworld.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_grayworld.c b/libavfilter/vf_gray

Re: [FFmpeg-devel] [RFC PATCH] avformat/rtpdec: fix another int overflow in start_time_realtime

2025-01-06 Thread Alexander Strasser via ffmpeg-devel
Hi Jonathan! On 2025-01-05 04:26 -0500, Jonathan Baudanza wrote: > > > On Tue, Nov 26, 2024, at 1:35 AM, j...@jonb.org wrote: > > > > This patch replaces av_rescale, which operates on int64_t, with > > ff_parse_ntp_time, which operates on uint65_t. This will give the correct > > values for times

Re: [FFmpeg-devel] [PATCH] avformat/ipfsgateway: fix capitalizaton mistake

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-07 14:18 -0500, Leo Izen wrote: > Fix the incorrect capitalization of the project name in a comment. > The project is named FFmpeg, not FFMpeg. > > Signed-off-by: Leo Izen > Reported-by: NyanMaths > --- > libavformat/ipfsgateway.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [FFmpeg-devel] [PATCH] avformat/mov: merge stts and ctts arrays into one

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-07 10:55 -0300, James Almer wrote: > Should reduce memory usage as well as remove code duplication. > > Signed-off-by: James Almer > --- > libavformat/isom.h | 15 +- > libavformat/mov.c| 579 --- > tests/ref/fate/quickdraw | 2 +- >

Re: [FFmpeg-devel] [PATCH 2/4] doc/faq: Anwser some questions about he GA, which keep popping up

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
Hi Ronald, hi Michael, hi all! On 2025-01-07 22:32 +0100, Michael Niedermayer wrote: > Hi Ronald > > On Tue, Jan 07, 2025 at 01:30:36PM -0500, Ronald S. Bultje wrote: > > On Tue, Jan 7, 2025 at 7:02 AM Michael Niedermayer > > wrote: > > > > > Hi Ronald > > > > > > On Mon, Jan 06, 2025 at 09:38:2

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-07 00:23 +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/faq.texi | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/faq.texi b/doc/faq.texi > index 54c3fbb41fe..70002a8156d 100644 > --- a/doc/faq.texi > +++ b/doc/faq.texi > @@ -702,

Re: [FFmpeg-devel] [PATCH] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-08 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-07 20:13 -0500, Leo Izen wrote: > It should be more clear what this flag is indicating with a more > verbose comment documenting it. > > Signed-off-by: Leo Izen > --- > libavutil/frame.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavutil/frame.h b

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg.texi: replace use of uncommon unicode characters

2024-12-26 Thread Alexander Strasser via ffmpeg-devel
Hi James! On 2024-12-25 20:54 -0300, James Almer wrote: > Addresses ticket #11372 > > Signed-off-by: James Almer > --- > doc/ffmpeg.texi | 64 - > 1 file changed, 32 insertions(+), 32 deletions(-) > LGTM (mabye one of documentation maintainers als

Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2024-12-28 Thread Alexander Strasser via ffmpeg-devel
Hi Leo and Joe! On 2024-12-27 08:13 -0500, Leo Izen wrote: > On 12/26/24 6:12 PM, J Shiff wrote: > > On Wed, Dec 25, 2024 at 5:03 PM Alexander Strasser via ffmpeg-devel > > wrote: > > > > > > On 2024-12-21 19:29 -0500, J Shiff wrote: > > > > On Sa

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: reduce sequential dependency in R-V V sad

2024-12-31 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-30 20:25 +0200, Rémi Denis-Courmont wrote: > Le tiistaina 24. joulukuuta 2024, 15.30.00 EET Nuo Mi a écrit : > > On Mon, Dec 23, 2024 at 11:18 PM flow gg wrote: > > > Hi, It looks like you submitted your review comments not long after the > > > patch was merged. > > > > > > Previously,

Re: [FFmpeg-devel] [PATCH] avformat/vqf: Propagate errors from add_metadata()

2024-12-31 Thread Alexander Strasser via ffmpeg-devel
Hi Michael! On 2024-12-31 04:36 +0100, Michael Niedermayer wrote: > Suggested-by: Marton Balint > Signed-off-by: Michael Niedermayer > --- > libavformat/vqf.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/libavformat/vqf.c b/libavformat/vqf.c > index

Re: [FFmpeg-devel] SCaLE booth

2024-12-15 Thread Alexander Strasser via ffmpeg-devel
Hi Rémi! On 2024-11-19 19:10 +0200, Rémi Denis-Courmont wrote: > > I plan to solicit an FFmpeg booth at SCaLE 22x to be held early next March. > Booths for open-source communities are free and include 5 full conference > passes. The exhibition area is open, and needs to be manned, on Friday > afte

Re: [FFmpeg-devel] [PATCH 2/5] lavc/container_fifo: move to lavu and make public

2024-12-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-11 15:05 +0100, Anton Khirnov wrote: > This can be useful in other places, e.g. it can replace objpool in > fftools. > > The API is modified in the following nontrivial ways: > * opaque pointers can be passed through to all user callbacks > * read and write were previously separate callb

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-17 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-16 22:02 -0500, Leo Izen wrote: > On 12/16/24 5:50 PM, Michael Niedermayer wrote: [...] > > > (e): Find a input that encodes to max 2 variants and store 2 checksums > > Doesn't fix the problem, which is that need to be aware of all the known > variants and create hacks to work with them

Re: [FFmpeg-devel] [PATCH] checkasm: Print benchmarks of C-only functions

2024-12-14 Thread Alexander Strasser via ffmpeg-devel
Hi Martin! On 2024-12-11 10:47 +0200, Martin Storsjö wrote: > On Wed, 23 Oct 2024, Martin Storsjö wrote: > > > This corresponds to commit 9278a14cf406f8edb5052c42b83750112bf5b515 > > in dav1d. > > > > Omitting the C-only functions doesn't speed up benchmarking > > anyway (as those has to be benchm

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-14 11:09 +0100, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) > > This is a fixed up version of the series I sent before. > > > > This worked for me on Ubuntu 20.04 but probably will break > > with older zlib version

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

2024-12-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-19 06:46 -1000, compn wrote: > On Thu, 19 Dec 2024 13:16:23 -0300, James Almer wrote: > > > On 12/19/2024 1:12 PM, compn wrote: > > > On Thu, 19 Dec 2024 10:04:53 -0300, James Almer wrote: > > >> I have no idea who added the rule for "upcoming vote", but i just > > >> removed it. > > >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: remove systematic PAL8 hack

2024-12-20 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-20 19:38 +0100, Michael Niedermayer wrote: > On Fri, Dec 20, 2024 at 02:56:54PM +0100, Niklas Haas wrote: > > On Fri, 20 Dec 2024 08:37:40 -0500 "Ronald S. Bultje" > > wrote: [...] > > > Assuming you agree with that - which is hard to argue with - don't you > > > agree that for now,

Re: [FFmpeg-devel] [PATCH v2] fate: Add a target for listing failed tests

2024-12-05 Thread Alexander Strasser via ffmpeg-devel
Hi Martin, still looks good to me. On 2024-12-04 16:08 +0200, Martin Storsjö wrote: [...] > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -313,6 +313,12 @@ $(FATE): $(FATE_UTILS:%=tests/%$(HOSTEXESUF)) | > $(FATE_OUTDIRS) > fate-list: > @printf '%s\n' $(sort $(FATE)) > > +fate-list-fai

Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2024-12-21 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-16 16:19 -0500, Joe Schiffler wrote: > Since $pkg_version includes spaces, builds can fail in some MSYS environments. Could you show what the pkg_version with spaces was in your case? Alexander > Build passing with quotes: > https://github.com/JoeSchiff/pyav-ffmpeg/actions/runs/12

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: Check FLV1 resolution limits

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-08 05:13 +0100, Michael Niedermayer wrote: > Found-by: Elias Myllymäki > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo_enc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index c5f20c2d855..09

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: int overflow in start_time_realtime

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 12:10 +0200, Martin Storsjö wrote: > On Wed, 8 Jan 2025, j...@jonb.org wrote: > > > From: Jonathan Baudanza > > > > This was previously adjusted by me in 6b3f9c2e92b. > > Unfortunately, I traded one integer overflow bug for > > another. > > > > Currently, NTP timestamps that exceed I

Re: [FFmpeg-devel] [PATCH] avformat/mov: merge stts and ctts arrays into one

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 10:40 -0300, James Almer wrote: > On 1/10/2025 10:05 AM, James Almer wrote: > > On 1/7/2025 6:50 PM, Alexander Strasser via ffmpeg-devel wrote: > > > On 2025-01-07 10:55 -0300, James Almer wrote: > > > > Should reduce memory usage as w

Re: [FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
Hi Andreas! On 2025-01-11 20:40 +0100, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Patch attached > > Will apply this patch and my other patches tomorrow unless there are > objections. LGTM from my side (not maintaining any of the affected areas) I just reviewed them and partially tested

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild/bin2c: misc fix

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-08 19:42 +0800, Jun Zhao wrote: > From: Jun Zhao > > close the input file if open output fail > > Signed-off-by: Jun Zhao > --- > ffbuild/bin2c.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ffbuild/bin2c.c b/ffbuild/bin2c.c > index dfeedd7669..168b0c658

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Fix handling of 32bit unsigned sambols

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 05:06 +0100, Michael Niedermayer wrote: > This may be needed for floats > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ffv1enc.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Remove audio_drift_threshold

2025-01-19 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-12 22:19 +0100, Andreas Rheinhardt wrote: > Patch attached > From 1abad60fe2eba199845db35c92e27dbc4d35b93f Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt > Date: Sun, 12 Jan 2025 20:40:31 +0100 > Subject: [PATCH] fftools/ffmpeg_opt: Remove audio_drift_threshold > > Forgotten in 5a

Re: [FFmpeg-devel] [PATCH] avfilter: minor spell fix

2025-01-19 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-13 19:42 +0100, Leandro Santiago wrote: > Signed-off-by: Leandro Santiago > --- > libavfilter/dnn/dnn_backend_openvino.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/dnn/dnn_backend_openvino.c > b/libavfilter/dnn/dnn_backend_openvino.c > ind

[FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-22 Thread Alexander Strasser via ffmpeg-devel
Since av_match_list was added in commit 0d92b0d5f445d4f2 , this function changed its semantics shortly after, especially with commit 3c0b98dced394da3 . Signed-off-by: Alexander Strasser --- libavutil/avstring.h | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-22 23:19 +0100, epira...@gmail.com wrote: > > On 22 Jan 2025, at 22:59, Alexander Strasser via ffmpeg-devel wrote: > > > Since av_match_list was added in commit 0d92b0d5f445d4f2 , this > > function changed its semantics shortly after, especially with > &

Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
Hi Abdulrahman! I fixed up and tested your patch locally and your change looks fine :) Will include when it when I push my next batch of changes soon'ish. Depending on how it goes it will take a couple of days from now. For your information I will outline the broken parts inline below: On 2025-

[FFmpeg-devel] [PATCH v2] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
Since av_match_list was added in commit 0d92b0d5f445d4f2 , this function changed its semantics shortly after, especially with commit 3c0b98dced394da3 . Signed-off-by: Alexander Strasser --- Diff to v1: * use @p as suggested by ePirat * clarify that the hint about demuxer names is about FFmpe

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-22 21:18 +0100, Nicolas George wrote: > James Almer (12025-01-22): > > Ok, will implement a new struct. > > Thanks. > > I think this code would work: > > typedef struct AVSideDataParamChange > … > intmax_t end_padding; > } AVSideDataSomethingType; > > static const AVSideDataParam

[FFmpeg-devel] Backporting makefile targets fate-list-failing and fate-clear-reports

2025-01-04 Thread Alexander Strasser via ffmpeg-devel
Hi all! I'm thinking about backporting commit 1e76bd2f394a01c1 [1] to all releases listed on our download page. It is a new feature for the build system, but not used to build ffmpeg or otherwise related to the generated binaries. It's of utility when doing backports because it makes it easy to

Re: [FFmpeg-devel] [PATCH v2] avformat/vqf: Propagate errors from add_metadata()

2025-01-01 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-01 06:15 +0100, Michael Niedermayer wrote: > Suggested-by: Marton Balint > Signed-off-by: Michael Niedermayer > --- > libavformat/vqf.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/libavformat/vqf.c b/libavformat/vqf.c > index 79deb33

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_addroi: Add missing NULL termination to addroi_var_names[]()

2025-01-05 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-05 05:44 +0100, Michael Niedermayer wrote: > Fixes: out of array read > > Found-by: Elias Myllymäki > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_addroi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_addroi.c b/libavfilter/vf_addroi.c > index d

Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2024-12-25 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-21 19:29 -0500, J Shiff wrote: > On Sat, Dec 21, 2024 at 5:44 PM Alexander Strasser via ffmpeg-devel > wrote: > > > > On 2024-12-16 16:19 -0500, Joe Schiffler wrote: > > > Since $pkg_version includes spaces, builds can fail in some MSYS > > > envir

Re: [FFmpeg-devel] [PATCH 2/5] lavc/container_fifo: move to lavu and make public

2024-12-25 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-15 22:20 +0100, Alexander Strasser via ffmpeg-devel wrote: > On 2024-12-11 15:05 +0100, Anton Khirnov wrote: > > This can be useful in other places, e.g. it can replace objpool in > > fftools. > > > > The API is modified in the following nontrivial ways: &

[FFmpeg-devel] Pausing the heated discussions

2024-12-31 Thread Alexander Strasser via ffmpeg-devel
Hi all! I'm unhappy with what ensued here on the FFmpeg development mailing list; especially in the recent months. With the current culminations, and the stress and influx of mails it caused for all subscribers espescially in this for many of us rather busy time of the family year, I would like t