Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtmp: Implements RTMP reconnect feature

> Nowadays when you are streaming to a live platform if the RTMP(s) > server needs to restarted for any reason (ex: deploy new version) > the RTMP connection is interrupted (probably after some draining time). > Facebook will publish a proposal to avoid that by sending a > GoAway message in the RTM

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

> From a12637c97c3140a1676f20b19c91647313379b39 Mon Sep 17 00:00:00 2001 > From: pkviet > Date: Sun, 9 Sep 2018 16:47:32 +0200 > Subject: [PATCH 3/3] avcodec/aacdec: Translate pce to avutil channel_layout > > This commit enables the native aac decoder to translate pce to > ffmpeg channel layouts w

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

On Wed, Oct 24, 2018 at 1:03 PM pkv.stream wrote: > > Patch updated ; passes all FATE tests. > > Comments from Alex Converse review incorporated (much thanks to him). > Hey, I'm a bit concerned with the outputs this generates for low channel count streams. al17_44.mp4 has t

[FFmpeg-devel] [PATCH] aacsbr: Turnoff in the event of over read.

Aliased compressed AAC bytes are almost certainly not meaningful SBR data. In the wild this causes harsh artifacts switching HE-AAC streams that don't have SBR headers aligned with segment boundaries. Turning off SBR falls back to a default set of upsampling parameters that can function as a sort

Re: [FFmpeg-devel] Patch for CUDA Scale Filter

On Mon, Apr 17, 2017 at 2:51 PM, Timo Rothenpieler wrote: >>> I'm generally in favor of adding CUDA based filtering, there's a lot of >>> nice stuff that could be done that way. >>> >>> But there is one big issue with this approach: >>> >>> Having to run a .bat file prior to building isn't really

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvdec: Set need_context_update when setting the initial extradata

On Wed, Aug 30, 2017 at 5:09 PM, Michael Niedermayer wrote: > On Tue, Aug 29, 2017 at 11:40:06AM -0700, Alex Converse wrote: >> Fixes ticket 6398. >> >> Debugged with the help of James Almer and Hendrik Leppkes. >> --- >> libavformat/flvdec.c | 1 + >> 1

[FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

Report the actual level of the encoded output if a level is targeted or the level is passively tracked with a target of 0. --- libavcodec/libvpxenc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 51f423a..

[FFmpeg-devel] [PATCH 1/2] libvpxenc: Support targeting a VP9 level

Levels are specified at https://www.webmproject.org/vp9/levels/ --- libavcodec/libvpxenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 68f25a4..51f423a 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -107

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: Support targeting a VP9 level

On Fri, Nov 18, 2016 at 3:44 PM, James Zern wrote: > > On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse > wrote: > > Levels are specified at https://www.webmproject.org/vp9/levels/ > > --- > > libavcodec/libvpxenc.c | 10 ++ > > 1 file changed, 10 i

[FFmpeg-devel] [PATCH] libvpxenc: Report encoded VP9 level

Report the actual level of the encoded output if a level is targeted or the level is passively tracked with a target of 0. --- libavcodec/libvpxenc.c | 32 1 file changed, 32 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 51f423a.

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

On Tue, Nov 22, 2016 at 3:10 PM, James Zern wrote: > On Tue, Nov 22, 2016 at 12:08 PM, James Zern wrote: >> On Tue, Nov 22, 2016 at 12:04 PM, James Zern wrote: >>> On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse >>> wrote: >>>> Report the actual le

Re: [FFmpeg-devel] [PATCH] libvpxenc: Report encoded VP9 level

On Mon, Nov 28, 2016 at 11:57 AM, James Zern wrote: > On Mon, Nov 28, 2016 at 10:34 AM, Alex Converse > wrote: >> Report the actual level of the encoded output if a level is >> targeted or the level is passively tracked with a target of 0. >> --- >>

Re: [FFmpeg-devel] [PATCH] aacdec: Allow SBR after DRC.

On Tue, Dec 6, 2016 at 5:08 PM, Alex Converse wrote: > Fixes https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4 > > Reported-by: rcombs on IRC > --- > libavcodec/aacdec_template.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

[FFmpeg-devel] [PATCH] aacdec: Allow SBR after DRC.

Fixes https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4 Reported-by: rcombs on IRC --- libavcodec/aacdec_template.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 8cfa34b..64d46e3 100644

Re: [FFmpeg-devel] [PATCH] aacdec: Allow SBR after DRC.

On Thu, Dec 8, 2016 at 2:14 AM, Rostislav Pehlivanov wrote: > On 7 December 2016 at 01:08, Alex Converse wrote: > >> Fixes https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4 >> >> Reported-by: rcombs on IRC >> --- >> libavcodec/aacdec_templat

[FFmpeg-devel] [PATCH] aacdec: Rename elem_type_prev to che_prev_type.

It describes the type of the previous che element (SCE, CPE, CCE, or LFE) and does not reflect non-che elements. --- libavcodec/aacdec_template.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 64d46e3..8

Re: [FFmpeg-devel] [PATCH] aacdec: Rename elem_type_prev to che_prev_type.

On Thu, Dec 8, 2016 at 12:56 PM, Rostislav Pehlivanov wrote: > On 8 December 2016 at 19:55, Alex Converse wrote: > >> It describes the type of the previous che element (SCE, CPE, CCE, or >> LFE) and does not reflect non-che elements. >> --- >> libavcodec/aacdec

Re: [FFmpeg-devel] [PATCH] aacdec: Allow SBR after DRC.

On Thu, Dec 8, 2016 at 12:36 PM, Rostislav Pehlivanov wrote: > > On 8 December 2016 at 19:42, Alex Converse wrote: >> >> On Thu, Dec 8, 2016 at 2:14 AM, Rostislav Pehlivanov >> wrote: >> > On 7 December 2016 at 01:08, Alex Converse >> >

[FFmpeg-devel] [PATCH] libvpxenc: Don't spam level errors for VP8 encodes

Fixes "Failed to set VP9E_GET_LEVEL codec control: Codec does not implement requested capability" log messages on VP8 encodes. --- libavcodec/libvpxenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 1325199..de0d0b6 100

Re: [FFmpeg-devel] [PATCH] libvpxenc: Don't spam level errors for VP8 encodes

On Mon, Dec 12, 2016 at 2:41 PM, James Zern wrote: > On Mon, Dec 12, 2016 at 12:12 PM, Alex Converse > wrote: >> Fixes "Failed to set VP9E_GET_LEVEL codec control: Codec does not >> implement requested capability" log messages on VP8 encodes. >> --- >> l

[FFmpeg-devel] [PATCH 2/2] Normalize VP8 and VP9 tags when writing IVF.

VP9-in-ISOM uses vp08 and vp09 tags, while ivf uses VP80 and VP90. --- libavformat/ivfenc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 5dbcd97..1735606 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfen

[FFmpeg-devel] [PATCH 1/2] Parse VP9 when coming out of MP4.

Fixes Netflix VP9 DASH samples. --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a7595c5..6e80b93 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2161,6 +2161,7 @@ static int mov_finalize_stsd_codec(MOVContext *c, AVI

[FFmpeg-devel] [PATCH] ivfenc: Add VPX codec tags.

This fixes remuxing VPX from MP4 without manually overwriting the tag. --- libavformat/ivfenc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 5dbcd97..f3ae4dc 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -97,6 +97,12

[FFmpeg-devel] [PATCH 3/4] aacsbr: Associate SBR data with AAC elements on init

Quiets some log spam on pure upsampling mode. --- libavcodec/aacdec_template.c | 2 +- libavcodec/aacsbr.h | 2 +- libavcodec/aacsbr_template.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 2a06f82

[FFmpeg-devel] [PATCH 1/4] aac_latm: Allow unaligned AudioSpecificConfig

Fixes ticket 4730 --- libavcodec/aacdec.c | 26 -- libavcodec/aacdec_template.c | 82 libavcodec/mpeg4audio.c | 76 ++-- libavcodec/mpeg4audio.h | 12 ++- 4 files changed, 120 insert

[FFmpeg-devel] [PATCH 4/4] aac_latm: Align inband PCE to the start of the payload

A strict reading of the spec seems to imply that it should be aligned to the start of the element instance tag, but that would break all of the samples with PCEs. It seems like a well formed LATM stream should have its PCE in the ASC rather than inband. Fixes ticket 4544 --- libavcodec/aacdec_te

[FFmpeg-devel] [PATCH 2/4] aac_latm: Copy whole AudioSpecificConfig when it is sized.

This preserves sync extensions. --- libavcodec/aacdec.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 709ac7cdf8..08d92fe145 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -289,17 +28

[FFmpeg-devel] [PATCH v2 1/4] aac_latm: Allow unaligned AudioSpecificConfig

Fixes ticket 4730 --- libavcodec/aacdec.c | 26 -- libavcodec/aacdec_template.c | 82 libavcodec/mpeg4audio.c | 76 ++-- libavcodec/mpeg4audio.h | 12 ++- 4 files changed, 120 insert

[FFmpeg-devel] [PATCH v2 3/4] aacsbr: Associate SBR data with AAC elements on init

Quiets some log spam on pure upsampling mode. Fixes ticket 5163. --- libavcodec/aacdec_template.c | 2 +- libavcodec/aacsbr.h | 2 +- libavcodec/aacsbr_template.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_temp

Re: [FFmpeg-devel] [PATCH 3/4] aacsbr: Associate SBR data with AAC elements on init

On Thu, Feb 9, 2017 at 4:11 PM, Carl Eugen Hoyos wrote: > > 2017-02-09 18:40 GMT+01:00 Alex Converse : > > Quiets some log spam on pure upsampling mode. > > Please mention ticket #5163. > Done > For the whole patchset, I suggest you push as soon as everybody > agre

[FFmpeg-devel] [PATCH] aacdec: When ignoring a PCE restore the previous config

This is related to, but doesn't solve ticker 6152. --- libavcodec/aacdec_template.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 4e0a9529e1..4367e74cf7 100644 --- a/libavcodec/aacdec_template.c +++ b/libavcodec/aacdec_templat

Re: [FFmpeg-devel] [PATCH] aacdec: When ignoring a PCE restore the previous config

On Thu, Feb 16, 2017 at 3:21 PM, Carl Eugen Hoyos wrote: > 2017-02-16 22:13 GMT+01:00 Alex Converse : >> This is related to, but doesn't solve ticker 6152. >> --- >> libavcodec/aacdec_template.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] libavcodec: fix field_order labelling

On Sat, Aug 12, 2017 at 9:47 AM, Dave Rice wrote: > > Hello all, > This issue originated in this thread > https://github.com/amiaopensource/vrecord/issues/170. On Field Order, in the > QuickTime specification at > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFChap

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/aacdec_template: Fix running cleanup in decode_ics_info()

On Sun, Aug 20, 2017 at 5:15 PM, Michael Niedermayer wrote: > > Fixes: out of array read > Fixes: 2873/clusterfuzz-testcase-minimized-5924145713905664 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

[FFmpeg-devel] [PATCH 2/2] fate: add test vector aac-al04sf_48

--- tests/fate/aac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 5ef8ddc2b9..e8cbcef54d 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@ -2,6 +2,10 @@ FATE_AAC += fate-aac-al04_44 fate-aac-al04_44: CMD = pcm -i $(TARGET_SAMPLE

[FFmpeg-devel] [PATCH 1/2] avcodec/aac: Add floating point 960/120 MDCT window

From: Paul B Mahol Co-Authored-By: Alex Converse --- libavcodec/aac.h | 3 + libavcodec/aacdec_template.c | 124 +++--- libavcodec/aactab.c | 120 libavcodec/aactab.h | 6

Re: [FFmpeg-devel] [PATCH 2/2] fate: add test vector aac-al04sf_48

On Tue, Aug 22, 2017 at 3:23 PM, Michael Niedermayer wrote: > On Mon, Aug 21, 2017 at 04:22:15PM -0700, Alex Converse wrote: >> --- >> tests/fate/aac.mak | 4 >> 1 file changed, 4 insertions(+) > > where can i find the files to test & upload to fate samples

[FFmpeg-devel] [PATCH 2/2] avformat: Handle AV_CODEC_CAP_CHANNEL_CONF when first frame fails to decode

Fixes probing the stream from ticket 6398. Noticed by James Almer. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 23865c88c4..68ba8aa85b 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2997

[FFmpeg-devel] [PATCH 1/2] avformat/flvdec: Set need_context_update when setting the initial extradata

Fixes ticket 6398. Debugged with the help of James Almer and Hendrik Leppkes. --- libavformat/flvdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 94c9e28334..2e70352c53 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -754,

[FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

From: Alex Converse --- libavformat/flvenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index e8af48cb64..827d798a61 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -480,7 +480,7 @@ static int

Re: [FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

On Tue, Feb 20, 2018 at 3:37 PM, Dale Curtis wrote: > From 97380752ef12337d9b9a01801a9a84df3b4b9c0a Mon Sep 17 00:00:00 2001 > From: Dale Curtis > Date: Thu, 15 Feb 2018 16:22:55 -0800 > Subject: [PATCH] [aacdec] Parse and drop gain control data, so that SSR > packets decode. > > This will resul

Re: [FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

On Tue, Feb 20, 2018 at 4:56 PM, Dale Curtis wrote: > On Tue, Feb 20, 2018 at 4:18 PM, Alex Converse > wrote: > >> >> I would make this uint8_t >> > > Done. > > >> I would drop this stack struck and replace the leaf get_bits() with >> skip bits

Re: [FFmpeg-devel] [PATCH]ExtraData computation for aac in -acodec copy

On Tue, Sep 8, 2015 at 11:06 AM, Sailaja Mahendrakar wrote: > > Carl, > > >The code you pasted is in the flv demuxer. > > >Please do not top-post here, Carl Eugen > >Carl, > > What will be the resolution for no audio in RTMP output due to not having > extradata in the copyts mode i.e stream copy?

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

On Thu, May 3, 2018 at 10:58 AM, Jan Ekström wrote: > > On Thu, May 3, 2018 at 7:50 PM, Alex Converse wrote: > > From: Alex Converse > > > > --- > > libavformat/flvenc.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

t;>> >>>> On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: >>>>> On Thu, May 3, 2018 at 7:50 PM, Alex Converse >>>>> wrote: >> [...] >> >>> Will apply. >> >> I think Alex Converse has a git write account, so he can

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

On Thu, May 10, 2018 at 4:08 PM, Jan Ekström wrote: > On Fri, May 11, 2018 at 1:39 AM, Alex Converse > wrote: >> On Thu, May 3, 2018 at 10:58 AM, Jan Ekström wrote: >>> >>> Hi, >>> >>> While the timestamp field is 8+24=32 bits, the DTS value is i

[FFmpeg-devel] [PATCH 1/2] flvenc: Factorize timestamp writing

From: Alex Converse The code is trivial but the semantics in the spec are ambiguous. This should help keep parts of the muxer interpreting them consistently. --- libavformat/flvenc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/flvenc.c b

[FFmpeg-devel] [PATCH 2/2] flvenc: Fix sequence header update timestamps

From: Alex Converse --- libavformat/flvenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 9b7cdfe7db..7aa2dbf9a6 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -485,7 +485,7 @@ static int

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid truncating timestamp before avio_write_marker()

On Sun, May 13, 2018 at 3:41 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/flvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c > index e8af48cb64..168ff9ffb8 100644 > --- a/libavfo

Re: [FFmpeg-devel] [PATCH 2/2] flvenc: Fix sequence header update timestamps

On Sun, May 13, 2018 at 3:24 AM, Michael Niedermayer wrote: > On Thu, May 10, 2018 at 06:40:08PM -0700, Alex Converse wrote: >> From: Alex Converse >> >> --- >> libavformat/flvenc.c | 9 - >> 1 file changed, 4 insertions(+), 5 deletions(-) >>

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: don't force HE-AACv2 profile if no PS info is present

On Fri, Jul 22, 2022 at 8:37 AM James Almer wrote: > On 7/22/2022 12:14 PM, Andreas Rheinhardt wrote: > > James Almer: > >> On 7/22/2022 11:56 AM, Andreas Rheinhardt wrote: > >>> James Almer: > On 7/22/2022 11:23 AM, Andreas Rheinhardt wrote: > > James Almer: > >> On 7/18/2022 10:57 A