On Tue, Feb 20, 2018 at 4:56 PM, Dale Curtis <dalecur...@chromium.org> wrote: > On Tue, Feb 20, 2018 at 4:18 PM, Alex Converse <alex.conve...@gmail.com> > wrote: > >> >> I would make this uint8_t >> > > Done. > > >> I would drop this stack struck and replace the leaf get_bits() with >> skip bits. It makes the code that much harder to exploit and there is >> no point in storing data we don't plan on decoding >> > > Done. > > >> This block seems funny. decode_gain_control() always returns zero. >> Maybe make this warn once per stream when present like some of the >> other AAC warn >> cases. >> > > Done. I've added an AACContext::warn_gain_control member to do this. > > This patch set also changes the attribution from Robert Swain to Maxim > Gavrilov based on svn blame of the SoC repository after discussion at > https://trac.ffmpeg.org/ticket/1693#comment:34 >
LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
