On Thu, Feb 9, 2017 at 4:11 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-02-09 18:40 GMT+01:00 Alex Converse <alex.conve...@gmail.com>: > > Quiets some log spam on pure upsampling mode. > > Please mention ticket #5163. >
Done > For the whole patchset, I suggest you push as soon as everybody > agrees on the function prefixes. > Prefix changed. Patches 2 and 4 don't have any comments. Do they need further review by anyone? > Could you review my patch for ticket #1614? > https://ffmpeg.org/pipermail/ffmpeg-devel/2014-October/164080.html > It seems to fix the second sample attached on trac, aac_broken.mp4. > It appears that your patch is decoding two channels "on top of each other" creating the artifacts noted in the original review. There isn't an easy change to make to that patch to fix this. The best way to handle it is in positional channel orders to try to decode everything we see then sniff out the channel order after the fact, using the indexed channel configuration as more of a suggestion. That may open the door to some truly crazy stuff, so it's probably best to do some fuzzing and large scale testing on that sort of change before landing it. > Did you see ticket #5722? > It looks like it's probably a demuxer issue. I haven't looked at mov.c in a long time. [...] Regards, Alex _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
