[FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-03-26 Thread Aaron Levinson
ds to this issue, but I didn't check. I appreciate any comments. Thanks, Aaron Levinson --- next part From 66796ca78e9b307ba0a8a7c33bd89d006c44ddf8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Sun, 26 Mar 2017 01:57:19 -0700

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-03-26 Thread Aaron Levinson
On 3/26/2017 4:41 AM, Matthias Hunstock wrote: Am 26.03.2017 um 11:50 schrieb Aaron Levinson: When using the following command to play back either file: ffmpeg -i -f decklink -pix_fmt uyvy422 "DeckLink SDI 4K", I noticed that with the mpegts file with the AAC audio stream,

[FFmpeg-devel] [PATCH] Made appropriate changes to be able to successfully build C++ files using a Visual C++ build on Windows

2017-04-12 Thread Aaron Levinson
From 722cbb5f6544323430d883212ac2e38c4eb94e5f Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 12 Apr 2017 16:33:39 -0700 Subject: [PATCH] Made appropriate changes to be able to successfully build C++ files using a Visual C++ build on Windows. Purpose: Made appropriate changes to be

[FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency. Made minor changes to get the decklink avdevice code to build using Visual C++.

2017-04-12 Thread Aaron Levinson
From bcc0ec4a0bb64e74b9c9369087708f55569bf50e Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 12 Apr 2017 16:41:53 -0700 Subject: [PATCH] avdevice/decklink: Removed pthread dependency. Made minor changes to get the decklink avdevice code to build using Visual C++. Purpose: avdevice

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-04-12 Thread Aaron Levinson
On 3/26/2017 10:34 AM, Aaron Levinson wrote: > On 3/26/2017 4:41 AM, Matthias Hunstock wrote: >> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: >>> When using the following command to play back either file: >>> ffmpeg -i -f decklink -pix_fmt uyvy422 "DeckLink S

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency. Made minor changes to get the decklink avdevice code to build using Visual C++.

2017-04-12 Thread Aaron Levinson
On 4/12/2017 6:51 PM, Marton Balint wrote: On Wed, 12 Apr 2017, Aaron Levinson wrote: From bcc0ec4a0bb64e74b9c9369087708f55569bf50e Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 12 Apr 2017 16:41:53 -0700 Subject: [PATCH] avdevice/decklink: Removed pthread dependency. Made minor

[FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-12 Thread Aaron Levinson
From d175e7fc94a2efc4f0bad021c118e4f907832c9c Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 12 Apr 2017 20:12:11 -0700 Subject: [PATCH] avdevice/decklink: Removed pthread dependency Purpose: avdevice/decklink: Removed pthread dependency by replacing semaphore used in code

[FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-04-12 Thread Aaron Levinson
From aa549cf1c463f4a37bda44b934e17811986f11d9 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 12 Apr 2017 20:21:41 -0700 Subject: [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++ Purpose: Made minor changes to get the decklink avdevice code to

[FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Aaron Levinson
7;t the same as a true debug build. Thanks, Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Made appropriate changes to be able to successfully build C++ files using a Visual C++ build on Windows

2017-04-13 Thread Aaron Levinson
On 4/13/2017 12:21 AM, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 2:16 AM, Aaron Levinson wrote: >> diff --git a/configure b/configure >> index d13d60b..b0f7b1a 100755 >> --- a/configure >> +++ b/configure >> @@ -3635,10 +3635,13 @@ case "$toolchain&quo

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-13 Thread Aaron Levinson
On 4/13/2017 1:21 AM, Hendrik Leppkes wrote: On Thu, Apr 13, 2017 at 5:32 AM, Aaron Levinson wrote: diff --git a/configure b/configure index b0f7b1a..adb0060 100755 --- a/configure +++ b/configure @@ -2992,9 +2992,9 @@ avfoundation_indev_deps="pthreads" avfoundation_indev

Re: [FFmpeg-devel] [PATCH] Made appropriate changes to be able to successfully build C++ files using a Visual C++ build on Windows

2017-04-13 Thread Aaron Levinson
On 4/13/2017 1:27 AM, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 10:23 AM, Aaron Levinson wrote: >> diff --git a/configure b/configure >> index b2fc781..6112b9b 100755 >> --- a/configure >> +++ b/configure >> @@ -3637,8 +3637,10 @@ case "$toolchain&

Re: [FFmpeg-devel] [PATCH] Made appropriate changes to be able to successfully build C++ files using a Visual C++ build on Windows

2017-04-13 Thread Aaron Levinson
On 4/13/2017 2:10 AM, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 11:04 AM, Aaron Levinson wrote: >> static av_unused int pthread_cond_signal(pthread_cond_t *cond) >> { >> -win32_cond_t *win32_cond = cond->Ptr; >> +win32_cond_t *win32_cond = (win32_

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-04-13 Thread Aaron Levinson
On 4/13/2017 12:36 AM, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 5:34 AM, Aaron Levinson wrote: >> diff --git a/configure b/configure >> index adb0060..5b76a33 100755 >> --- a/configure >> +++ b/configure >> @@ -3646,6 +3646,8 @@ case "$toolchain&qu

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-13 Thread Aaron Levinson
On 4/13/2017 2:12 AM, Hendrik Leppkes wrote: On Thu, Apr 13, 2017 at 10:36 AM, Aaron Levinson wrote: Give it some time for the other changes to be reviewed by the people that actually know decklink itself, you can include that in any new versions of the patch then, no need to send one for that

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-04-13 Thread Aaron Levinson
On 4/13/2017 3:55 AM, Hendrik Leppkes wrote: On Thu, Apr 13, 2017 at 12:39 PM, Aaron Levinson wrote: On 4/13/2017 12:36 AM, Hendrik Leppkes wrote: diff --git a/configure b/configure index a383bf2..9a06437 100755 --- a/configure +++ b/configure @@ -4843,8 +4843,6 @@ case $target_os in

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Aaron Levinson
Oliver wrote: On 13 April 2017 at 17:20, Aaron Levinson wrote: I wanted to build a debug build of ffmpeg using Visual C++ today, one without any optimizations. This implies the use of the -Od compiler option. Unfortunately, I quickly discovered that the build fails soon after it starts

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-04-13 Thread Aaron Levinson
On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 10:09 PM, Aaron Levinson wrote: >> On 4/13/2017 3:55 AM, Hendrik Leppkes wrote: >>> >>> On Thu, Apr 13, 2017 at 12:39 PM, Aaron Levinson >>> wrote: >>>> >>>> On

[FFmpeg-devel] [PATCH] Enhanced configure to improve compiler options associated with debugging with Visual C++ (MSVC)

2017-04-13 Thread Aaron Levinson
From 558b957eb85a669899750b2e150eba7cdee8dcd9 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 16:46:59 -0700 Subject: [PATCH] Enhanced configure to improve compiler options associated with debugging with Visual C++ (MSVC) Purpose: Enhanced configure to improve compiler

[FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-13 Thread Aaron Levinson
From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 17:30:47 -0700 Subject: [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing Purpose: Enhanced require_pkg_config() in configure to

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-13 Thread Aaron Levinson
On 4/13/2017 3:40 PM, Marton Balint wrote: > > On Thu, 13 Apr 2017, Aaron Levinson wrote: > >> On 4/13/2017 2:12 AM, Hendrik Leppkes wrote: >>> On Thu, Apr 13, 2017 at 10:36 AM, Aaron Levinson >> wrote: >>> Give it some time for the other changes to be r

[FFmpeg-devel] [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding

2017-04-13 Thread Aaron Levinson
From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 23:12:30 -0700 Subject: [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding Purpose: Fixed problems with QuickSync (QSV) interlaced video encoding that were

Re: [FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-14 Thread Aaron Levinson
On 4/14/2017 1:09 AM, Hendrik Leppkes wrote: On Fri, Apr 14, 2017 at 2:56 AM, Aaron Levinson wrote: From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 17:30:47 -0700 Subject: [PATCH] Enhanced require_pkg_config() in configure to

[FFmpeg-devel] [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install

2017-04-14 Thread Aaron Levinson
From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:14:21 -0700 Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install Purpose: Enhanced configure and Makefile to copy .pdb

[FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-04-14 Thread Aaron Levinson
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:38:37 -0700 Subject: [PATCH] Added require fallback for libmfx in the case that pkg-config cannot find libmfx Purpose: Added require fallback for libmfx in the case that pkg

Re: [FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-14 Thread Aaron Levinson
On 4/14/2017 6:04 PM, James Almer wrote: On 4/13/2017 9:56 PM, Aaron Levinson wrote: From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 17:30:47 -0700 Subject: [PATCH] Enhanced require_pkg_config() in configure to fallback to

Re: [FFmpeg-devel] [PATCH] Enhanced configure to improve compiler options associated with debugging with Visual C++ (MSVC)

2017-04-14 Thread Aaron Levinson
On 4/13/2017 5:03 PM, Aaron Levinson wrote: > From 558b957eb85a669899750b2e150eba7cdee8dcd9 Mon Sep 17 00:00:00 2001 > From: Aaron Levinson > Date: Thu, 13 Apr 2017 16:46:59 -0700 > Subject: [PATCH] Enhanced configure to improve compiler options associated > with debugging with V

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-04-15 Thread Aaron Levinson
On 4/15/2017 4:25 AM, Ricardo Constantino wrote: > On 15 April 2017 at 02:51, Aaron Levinson wrote: > >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson >> Date: Fri, 14 Apr 2017 18:38:37 -0700 >> Subject: [PATCH] Add

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-04-15 Thread Aaron Levinson
On 4/15/2017 4:19 AM, Marton Balint wrote: On Thu, 13 Apr 2017, Aaron Levinson wrote: On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: [...] From 00fdc9d15414a92a155eb7d1394bac3736dc9405 Mon Sep 17 00

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-16 Thread Aaron Levinson
On 4/16/2017 8:57 AM, Matt Oliver wrote: On 14 April 2017 at 08:05, Hendrik Leppkes wrote: On Fri, Apr 14, 2017 at 12:00 AM, Ronald S. Bultje wrote: Hi Aaron, On Thu, Apr 13, 2017 at 4:47 PM, Aaron Levinson wrote: #if ARCH_AARCH64 if (ARCH_AARCH64) return

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-16 Thread Aaron Levinson
On 4/15/2017 9:32 PM, James Almer wrote: On 4/15/2017 7:41 AM, Marton Balint wrote: On Thu, 13 Apr 2017, Aaron Levinson wrote: On 4/13/2017 3:40 PM, Marton Balint wrote: On Thu, 13 Apr 2017, Aaron Levinson wrote: On 4/13/2017 2:12 AM, Hendrik Leppkes wrote: On Thu, Apr 13, 2017 at 10:36

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-16 Thread Aaron Levinson
On 4/16/2017 10:08 AM, Ronald S. Bultje wrote: Hi, On Sun, Apr 16, 2017 at 12:59 PM, Aaron Levinson wrote: I like using this approach, but I think such files should only be added to the build if --disable-optimizations is passed into configure. Or you could detect in configure if the

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-16 Thread Aaron Levinson
On 4/16/2017 12:15 PM, wm4 wrote: On Sun, 16 Apr 2017 15:23:15 -0300 James Almer wrote: On 4/16/2017 2:17 PM, Aaron Levinson wrote: On 4/15/2017 9:32 PM, James Almer wrote: On 4/15/2017 7:41 AM, Marton Balint wrote: On Thu, 13 Apr 2017, Aaron Levinson wrote: On 4/13/2017 3:40 PM, Marton

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-16 Thread Aaron Levinson
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote: Thanks, applied. Regards, Marton This seems to have broken the coverity builds: https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds/222597943#L1103 It was suggested on IRC by James Almer that "it seems to complain about ubitux's 'strict' pthrea

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-04-16 Thread Aaron Levinson
On 4/15/2017 6:13 AM, Aaron Levinson wrote: > On 4/15/2017 4:19 AM, Marton Balint wrote: >> >> On Thu, 13 Apr 2017, Aaron Levinson wrote: >> >>> On 4/13/2017

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-16 Thread Aaron Levinson
On 4/16/2017 3:31 PM, Hendrik Leppkes wrote: On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson wrote: On 4/16/2017 1:33 PM, Timo Rothenpieler wrote: Thanks, applied. Regards, Marton This seems to have broken the coverity builds: https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

2017-04-16 Thread Aaron Levinson
On 4/16/2017 4:25 PM, Aaron Levinson wrote: On 4/16/2017 3:31 PM, Hendrik Leppkes wrote: On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson wrote: On 4/16/2017 1:33 PM, Timo Rothenpieler wrote: Thanks, applied. Regards, Marton This seems to have broken the coverity builds: https://travis

[FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-16 Thread Aaron Levinson
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Sun, 16 Apr 2017 17:13:31 -0700 Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1 Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-16 Thread Aaron Levinson
I'll try that again with [PATCH] in the subject line. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-16 Thread Aaron Levinson
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Sun, 16 Apr 2017 17:13:31 -0700 Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1 Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-17 Thread Aaron Levinson
On 4/17/2017 8:28 AM, wm4 wrote: On Mon, 17 Apr 2017 12:06:59 -0300 James Almer wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-04-19 Thread Aaron Levinson
On 4/14/2017 6:51 PM, Aaron Levinson wrote: From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:38:37 -0700 Subject: [PATCH] Added require fallback for libmfx in the case that pkg-config cannot find libmfx Purpose: Added

[FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-04-20 Thread Aaron Levinson
From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 20 Apr 2017 23:20:20 -0700 Subject: [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined Purpose: Fixed memory leaks associated with AVStream objects if

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-20 Thread Aaron Levinson
On 4/19/2017 2:27 PM, Marton Balint wrote: On Mon, 17 Apr 2017, James Almer wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date

[FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Aaron Levinson
From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 21 Apr 2017 15:55:11 -0700 Subject: [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true Purpose: Added

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Aaron Levinson
On 4/21/2017 4:17 PM, Lou Logan wrote: > On Fri, 21 Apr 2017 16:05:16 -0700 > Aaron Levinson wrote: > >> From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson >> Date: Fri, 21 Apr 2017 15:55:11 -0700 >> Subject: [PATCH] A

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-21 Thread Aaron Levinson
Note that in case it wasn't clear, I confirmed that this patch works by running make on Linux and examining both the generated text file and the generated HTML file in a Web browser. Aaron On 4/21/2017 4:48 PM, Aaron Levinson wrote: On 4/21/2017 4:17 PM, Lou Logan wrote: On Fri, 21 Apr

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Aaron Levinson
ssors at all if the fields are public? As far as I can tell, the benefit to using these accessors is that, if certain properties become internal in the future, or variable names change, or the structures become opaque, etc, the code will continue to work. Aaron Lev

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-22 Thread Aaron Levinson
On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] diff --git a/doc/fate.texi b/doc/fate.texi index 7a96c25..f3b8c0c8 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate @float NOTE

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-22 Thread Aaron Levinson
On 4/22/2017 12:09 PM, Hendrik Leppkes wrote: On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote: On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] diff --git a/doc/fate.texi b/doc/fate.texi index 7a96c25..f3b8c0c8 100644

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/options: factorize avcodec_copy_context cleanup code

2017-04-22 Thread Aaron Levinson
t with the values in src, and besides the copies made of dest->codec and dest->priv_data earlier in the function, anything else that is overwritten could in theory leak. But, I guess that would have been a preexisting issue with this function and not really relevant for this patch. And th

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: copy the coded_side_data in avcodec_copy_context()

2017-04-23 Thread Aaron Levinson
lements in dest, even though they are owned by src. After doing the memcpy() call, I think you can fix this by setting dest->coded_side_data to NULL and dest->nb_coded_side_data to 0. Everything else looks good. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [RFC] Reviewing merges

2017-04-23 Thread Aaron Levinson
fmpeg was to contribute it to libav first. But, if this patch has to pass yet another round of code reviews, code reviews that weren't forthcoming in the first place on ffmpeg-devel when I originally submitted the patch, then that could be problematic. Aaro

Re: [FFmpeg-devel] [rfc] coc violation tribunal

2017-04-24 Thread Aaron Levinson
resolution and move forward. Its one thing to fire off an e-mail--its another to say things to someone's "face", so to speak. I'd also suggest, when passions are up, to step aside and then maybe come back to it later. Aaron Levinson

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

2017-04-25 Thread Aaron Levinson
define alloc_and_copy_or_fail(obj, size, pad) \ if (src->obj && size > 0) { \ I'm not sure if this patch is intended to be a replacement for your last "2/2" patch, but this version is missing the the coded_side_data population code that was in the first version

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CID 1405135

2017-04-25 Thread Aaron Levinson
ame based on the way it is formed, this in theory could be a problem, although it is unlikely in practice since LINE_BUFFER_SIZE is 1024. While ideally there would be a sanity check somewhere in the code to make sure those URLs aren't too long, an alternative is to copy up to max LINE

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

2017-04-30 Thread Aaron Levinson
On 4/26/2017 12:47 PM, James Almer wrote: On 4/26/2017 2:46 AM, Aaron Levinson wrote: On 4/24/2017 3:47 PM, James Almer wrote: Free coded_frame, coded_side_data and unref hw_device_ctx to prevent potential leaks. Signed-off-by: James Almer --- libavcodec/options.c | 15 +++ 1

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-04-30 Thread Aaron Levinson
to populate milliseconds anyway as follows: if (!strftime(buf, size, "%Y-%m-%dT%H:%M:%S.000Z", ptm)) Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]compat/strtod: Add missing const qualifiers

2017-05-02 Thread Aaron Levinson
On 5/1/2017 1:51 AM, Carl Eugen Hoyos wrote: Hi! Even without the casts, the patch reduces the number of warnings shown when compiling compat/strtod from seven to three. Please comment, Carl Eugen LGTM Aaron Levinson ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-02 Thread Aaron Levinson
mmit your patch, but hopefully someone else will do so. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]configure: Fix libopus detection

2017-05-02 Thread Aaron Levinson
currently taken in configure doesn't distinguish between encoding and decoding, but the patch as originally proposed just trades decoding API requirements for encoding API requirements. Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-02 Thread Aaron Levinson
f(hls->key_uri)). In addition, based on the EXT-X-KEY example at https://developer.apple.com/library/content/technotes/tn2288/_index.html , it would appear that an EXT-X-KEY declaration may span multiple lines. Your solution will not work properly in this case. Aaron Levinson +

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread Aaron Levinson
I don't seem to have the original e-mail in my inbox anymore, so I'll respond to wm4's response. Overall, the new code is a lot cleaner and easier to understand than the existing code. See below for more. Aaron Levinson On 5/2/2017 5:04 PM, wm4 wrote: On Fri, 28 Apr 2017

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-05-03 Thread Aaron Levinson
On 4/22/2017 12:22 PM, Aaron Levinson wrote: On 4/22/2017 12:09 PM, Hendrik Leppkes wrote: On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote: On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] This is documented in doc

[FFmpeg-devel] [PATCH] doc: Enhanced fate.texi to reference Windows line endings section from git-howto.texi

2017-05-03 Thread Aaron Levinson
From 345a98d31c6c758f0f82edab1b502cd8aeb3354b Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Wed, 3 May 2017 12:38:39 -0700 Subject: [PATCH] doc: Enhanced fate.texi to reference Windows line endings section from git-howto.texi Purpose: Enhanced fate.texi to indicate that FATE will fail if

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-05-03 Thread Aaron Levinson
On 4/21/2017 2:03 PM, James Almer wrote: On 4/21/2017 12:09 PM, Michael Niedermayer wrote: On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 20 Apr 2017 23:20:20 -0700 Subject

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-03 Thread Aaron Levinson
James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Thanks, Aaron Levinson On 5/2/2017 2:55 PM, James Almer wrote: Some changes and fixes suggested on IRC. Some patches are v3 as they have been sent before

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-04 Thread Aaron Levinson
NAN); In order to preserve the original logic, why not do the following: +num = den ? num * intnum / den : (((num * intnum) != 0) ? INFINITY : NAN); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-04 Thread Aaron Levinson
never use 32 characters, its not a big deal to have a little waste here. The buffer size should match the format specification. An alternative would be to use "%02hd" or "%02hhd", but doing so would require casts or using different types for hh, mm, etc. Aaron Levins

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-04 Thread Aaron Levinson
On 5/4/2017 9:15 PM, Steven Liu wrote: 2017-05-03 9:49 GMT+08:00 Aaron Levinson : On 4/27/2017 7:21 PM, Steven Liu wrote: 2017-04-26 7:30 GMT+08:00 Steven Liu : fix ticket id: #6353 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 24 1 file changed, 24

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-04 Thread Aaron Levinson
On 5/2/2017 2:29 PM, wm4 wrote: On Tue, 2 May 2017 14:17:33 -0700 Aaron Levinson wrote: On 5/1/2017 11:06 PM, MFojtak wrote: Currently this muxer does not work at all. I don't know if 000Z would make it compatible with more player as I don't know any. However, adding Z makes it

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-04 Thread Aaron Levinson
On 4/12/2017 6:08 PM, Aaron Levinson wrote: > On 3/26/2017 10:34 AM, Aaron Levinson wrote: >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: >>>> When using the following command to play back either file: >>

Re: [FFmpeg-devel] [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install

2017-05-05 Thread Aaron Levinson
On 4/14/2017 6:27 PM, Aaron Levinson wrote: From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:14:21 -0700 Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install Purpose

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 4/19/2017 10:43 AM, Aaron Levinson wrote: > On 4/14/2017 6:51 PM, Aaron Levinson wrote: >> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 >> From: Aaron Levinson >> Date: Fri, 14 Apr 2017 18:38:37 -0700 >> Subject: [PATCH] Added require fall

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Aaron Levinson
On 4/16/2017 4:11 PM, Aaron Levinson wrote: > On 4/15/2017 6:13 AM, Aaron Levinson wrote: >> On 4/15/2017 4:19 AM, Marton Balint wrote: >>> >>> On Thu, 13 Apr 2017, Aaron Levinson wrote: >>> >>>> On 4/13/2017 1:23 PM, Hendrik Leppkes wrote: >&

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function ‘av_timecode_make_string’: libavutil

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:42 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote: On 4/19/2017 10:43 AM, Aaron Levinson wrote: On 4/14/2017 6:51 PM, Aaron Levinson wrote: From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote: 2017-05-05 9:42 GMT+02:00 Aaron Levinson : On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote: 2017-05-05 3:29 GMT+02:00 Aaron Levinson : On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:55 AM, wm4 wrote: On Thu, 4 May 2017 23:46:30 -0700 Aaron Levinson wrote: On 4/12/2017 6:08 PM, Aaron Levinson wrote: On 3/26/2017 10:34 AM, Aaron Levinson wrote: On 3/26/2017 4:41 AM, Matthias Hunstock wrote: Am 26.03.2017 um 11:50 schrieb Aaron Levinson

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 12:57 AM, Clément Bœsch wrote: On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: [...] Back to your issue: you should fix the .pc in the upstream project, this is the correct fix. The "upstream project" in this case is the Intel Media SDK. This is not an o

Re: [FFmpeg-devel] [PATCH v2 0/9] Removing HEVCContext depencencies

2017-05-05 Thread Aaron Levinson
The entire patch set LGTM. Aaron Levinson On 5/3/2017 6:41 PM, James Almer wrote: On 5/3/2017 9:39 PM, Aaron Levinson wrote: James, Can you document which patches depend on other patches in this patch set to make it easier to review this patch set in chunks? Patch 2 depends on 1. Patches 3

Re: [FFmpeg-devel] [PATCH] Made minor changes to get the decklink avdevice code to build using Visual C++

2017-05-05 Thread Aaron Levinson
On 5/5/2017 4:57 PM, Marton Balint wrote: > > > On Fri, 5 May 2017, Aaron Levinson wrote: > >> On 4/16/2017 4:11 PM, Aaron Levinson wrote: >>> On 4/15/2017 6:13 AM, Aaron Levinson wrote: >>>> On 4/15/2017 4:19 AM, Marton Balint wrote: >>>&g

Re: [FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-05-05 Thread Aaron Levinson
On 5/5/2017 4:50 AM, Michael Niedermayer wrote: > On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote: >> On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote: >>> On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote: >>> [...] >>>>>

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-05 Thread Aaron Levinson
On 5/5/2017 2:26 AM, wm4 wrote: On Fri, 5 May 2017 01:11:17 -0700 Aaron Levinson wrote: As I said on IRC, I'm skeptic against this, but I'm also not sure whether I understand the situation. First, your change seems a bit fragile, and almost relies on coincidences. This could easil

Re: [FFmpeg-devel] [PATCH] build: remove --enable-raise-major configure option

2017-05-06 Thread Aaron Levinson
for the decoder). The third component always starts at 100 to distinguish FFmpeg from Libav." Note that my review only covers the content of the patch, and I don't know whether or not it makes sense to discontinue this practice. Aaron Levinson __

Re: [FFmpeg-devel] [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding

2017-05-07 Thread Aaron Levinson
Please disregard this patch--I'm submitting two new patches that have already been reviewed and applied to libav. Aaron Levinson On 4/13/2017 11:36 PM, Aaron Levinson wrote: From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 20

[FFmpeg-devel] [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters

2017-05-07 Thread Aaron Levinson
From 2882d77d76805e74fe139f6763f91c39746bebaf Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 5 May 2017 18:49:57 -0700 Subject: [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the parameters Purpose: Fill out the default/unset parameters with ones actually in use. Note

[FFmpeg-devel] [PATCH 2/2] qsvenc: Make sure the interlaced encoding works

2017-05-07 Thread Aaron Levinson
From 30eb78bac7bd92b0c085ba6873341e8319072acc Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 5 May 2017 21:31:30 -0700 Subject: [PATCH 2/2] qsvenc: Make sure the interlaced encoding works Purpose: qsvenc: make sure that interlaced encoding works. Also, reduce the vertical alignment

Re: [FFmpeg-devel] [PATCH] videotoolbox: add hwcontext support

2017-05-07 Thread Aaron Levinson
Are you also planning to change ffmpeg_videotoolbox.c? See below for more comments. Aaron Levinson On 5/2/2017 8:26 PM, wm4 wrote: This adds tons of code for no other benefit than making VideoToolbox support conform with the new hwaccel API (using hw_device_ctx and hw_frames_ctx). Since

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
ts #EXTINF:8.64, out1.ts #EXTINF:9.16, out2.ts Reported-by: Aaron Levinson Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 221089c..c1

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
handle .m3u8 files that use '\' for multi-line TAG spans, and in addition, there is no mention of '\' anywhere in the actual grammar documented in the specification. So, it seems that that this patch isn't needed. Aaron Levinson On 5/9/2017 1:01 PM, Aaron Levi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix memleak

2017-05-09 Thread Aaron Levinson
ls to av_free(old_filename). } ret = ff_write_chained(oc, stream_index, pkt, s, 0); Aaron Levinson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: move old_filename free operation earlier

2017-05-10 Thread Aaron Levinson
On 5/10/2017 3:33 AM, Steven Liu wrote: Suggested-by: Aaron Levinson Signed-off-by: Steven Liu --- libavformat/hlsenc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 221089c..7ed121a 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH] configure: jni no longer requires -ldl

2017-05-12 Thread Aaron Levinson
&& { check_header ladspa.h || die "ERROR: ladspa.h header not found"; } enabled libiec61883 && require libiec61883 libiec61883/iec61883.h iec61883_cmp_connect -lraw1394 -lavc1394 -lrom1394 -liec61883 enabled libass&& require_pkg_config libass ass/ass

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-12 Thread Aaron Levinson
On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I created the first version of the patch on March 26th, this was the first patch that I submitted to ffmpeg, and some aspects

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

2017-05-12 Thread Aaron Levinson
Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from, init_output_stream()

2017-05-12 Thread Aaron Levinson
Please disregard--I messed up the subject. I'll send a new one. Aaron Levinson On 5/12/2017 1:22 PM, Aaron Levinson wrote: Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after ca

[FFmpeg-devel] [PATCH 1/2] ffmpeg: Separated check_init_output_file() from init_output_stream()

2017-05-12 Thread Aaron Levinson
Purpose: Separated the call to check_init_output_file() from init_output_stream(), and now check_init_output_file() is called by the parent after calling init_output_stream(). Additionally, moved some static function declarations to the beginning of the file. Signed-off-by: Aaron Levinson

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Made execution of reap_filters() more deterministic with respect to when headers are written

2017-05-12 Thread Aaron Levinson
tion to the output stream's codecpar (mux_par->field_order in do_video_out()). However, check_init_output_file() calls avformat_write_header() prior to the initial call to do_video_out(), so field_order is populated too late, and the header is written with the default field_order value,

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-12 Thread Aaron Levinson
On 5/12/2017 5:51 PM, Michael Niedermayer wrote: On Fri, May 12, 2017 at 01:19:43PM -0700, Aaron Levinson wrote: On 5/9/2017 11:56 AM, Michael Niedermayer wrote: On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote: I've provided a new version of the patch. When I create

  1   2   >