The entire patch set LGTM.

Aaron Levinson

On 5/3/2017 6:41 PM, James Almer wrote:
On 5/3/2017 9:39 PM, Aaron Levinson wrote:
James,

Can you document which patches depend on other patches in this patch set
to make it easier to review this patch set in chunks?

Patch 2 depends on 1. Patches 3, 4 and 5 are functionally standalone but
need previous patches to apply cleanly. Patches 7 and 6 depend on every
patch before themselves. Patch 8 depends on patches 1 and 2 (and maybe
others to apply cleanly).


Thanks,
Aaron Levinson

On 5/2/2017 2:55 PM, James Almer wrote:
Some changes and fixes suggested on IRC. Some patches are v3 as they have
been sent before outside the previous set.

James Almer (9):
  hevcdec: remove HEVCContext usage from hevc_sei
  hevcdec: move SEI message parsing into a separate header
  hevcdec: remove HEVCContext usage from ff_hevc_compute_poc()
  hevcdec: move SliceHeader struct definition to hevc_ps
  hevc_parser: use ff_h2645_packet_split() to parse NAL units
  hevc_parser: remove HEVCContext usage
  hevc_parser: move slice header parsing to its own function
  hevc_parse: decode SEI message NALUs in extradata
  doc/libav_merge: remove line about ADVANCED_PARSER

 doc/libav-merge.txt        |   1 -
 libavcodec/Makefile        |   4 +-
 libavcodec/hevc_parse.c    |  21 ++-
 libavcodec/hevc_parse.h    |   7 +-
 libavcodec/hevc_parser.c   | 415
++++++++++++++++-----------------------------
 libavcodec/hevc_ps.c       |  23 +++
 libavcodec/hevc_ps.h       |  88 ++++++++++
 libavcodec/hevc_refs.c     |  27 +--
 libavcodec/hevc_sei.c      | 193 +++++++++------------
 libavcodec/hevc_sei.h      | 125 ++++++++++++++
 libavcodec/hevcdec.c       |  94 +++++-----
 libavcodec/hevcdec.h       | 137 +--------------
 libavcodec/mediacodecdec.c |   4 +-
 13 files changed, 532 insertions(+), 607 deletions(-)
 create mode 100644 libavcodec/hevc_sei.h

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to