On 4/16/2017 4:25 PM, Aaron Levinson wrote:
On 4/16/2017 3:31 PM, Hendrik Leppkes wrote:
On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson
<alevi...@aracnet.com> wrote:
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
Thanks, applied.
Regards,
Marton
This seems to have broken the coverity builds:
https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds/222597943#L1103
It was suggested on IRC by James Almer that "it seems to complain about
ubitux's 'strict' pthread implementation (for assert levels above 0).
Maybe
it needs to be disabled for C++ sources."
The real problem is in av_err2str, which uses a temporary array, which
is either not valid in C++ (likely), or not supported by MSVC for
reasons (although in contrast to C support, its C++ support is
generally pretty good).
But considering how little C++ code we have, its probably best to
somehow avoid using it instead of trying to fix it.
- Hendrik
I don't think this has much to do with MSVC here, because coverity is
doing a gcc/g++ build. I suspect that it is failing with any gcc/g++
build because of the patch. I'll work on this now.
Aaron
The build issue occurs with g++ and an assert level greater than 1,
although it would also occur with MSVC++ if pthreads is enabled. I will
submit a separate patch e-mail that fixes the build error.
Aaron
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
