[FFmpeg-devel] [PATCH 2/2] aacenc: remove support for AAC LTP profile

2025-02-07 Thread Lynne
The LTP profile of AAC is... terrible. It was an early 90's attempt at bridging the gap between speech codecs and general purpose codecs. It did so by trying to exploit the fact that most speech patterns are regular. Unfortunately, it went about it the same way as AAC Main, by taking the previous

[FFmpeg-devel] [PATCH 1/2] aacenc: remove support for AAC Main profile

2025-02-07 Thread Lynne
The Main profile of AAC is... terrible. It enables the use of delta coding across coefficients of two frames to try to increase compression, and it enabled one more pole for TNS filters. What the AAC authors failed to take into account were basic mathematics, as MDCT leakage (e.g. the spread of ea

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Zhao Zhili
> On Feb 8, 2025, at 00:05, Ronald S. Bultje wrote: > > Hi, > > On Fri, Feb 7, 2025 at 8:44 AM Zhao Zhili < > quinkblack-at-foxmail@ffmpeg.org> wrote: > >>> On Feb 7, 2025, at 21:26, Ronald S. Bultje wrote: >>> On Fri, Feb 7, 2025 at 6:22 AM Andreas Rheinhardt < >>> andreas.rheinha...@ou

[FFmpeg-devel] [PATCH] aacenc: move to libavcodec/aac/

2025-02-07 Thread Lynne
The decoder was already moved there. --- libavcodec/Makefile | 5 +- libavcodec/aac/Makefile | 2 + libavcodec/{ => aac}/aaccoder.c | 0 libavcodec/aac/aaccoder.h | 46 +++ libavcodec/{ => aac}/aac

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 5:18 PM Marth64 wrote: > (libavcodec’s definition of AV_CODEC_ID_EIA_608 is a fallacy, it is > actually A/53 Part 4 coding that is passed around with this codec ID, > which can contain multiple sub-streams including EIA-608 and CEA-708) I probably wouldn't call it a "fallac

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
> > Unfortunately, there's no bug which could be "fixed". > For a proper solution, a CEA-608 ENcoder is required. > And more - like already said. Is a CEA-608 encoder actually required for a frame rate change, or is it possible to just redistribute the packets of the 608 stream in a manner that d

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 2:31 PM Devlist Archive wrote: > > > > > The cc_fifo mechanism is actually implemented within the various > > filters which change the framerate (deinterlacing, framerate > > conversion, interlacing), so no extra command line arguments are > > required. There are some edge

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
> > One thing worth noting is that the filenames in that Google drive > don't match up with the example commands you've provided. I would > recommend if you decide to open a ticket to either rename the files or > change the commands so whoever tries to reproduce the issue knows they > are working

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 2:52 PM Devlist Archive wrote: > > > > > Unfortunately, there's no bug which could be "fixed". > > For a proper solution, a CEA-608 ENcoder is required. > > And more - like already said. > > > Is a CEA-608 encoder actually required for a frame rate change, or is it > possibl

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 2:55 PM Devin Heitmueller wrote: > And encoder itself should be required. Correction: I meant to say "An encoder itself should *not* be required". Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.co

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 3:58 PM Soft Works wrote: > You have never successfully "embedded" an scc file as CEA-608. > I had told you that twice already. Marth64 has told you the same. > > That's not possible right now. Your commands are adding the scc > captions as mov_text (TTXT) subtitle stream, n

Re: [FFmpeg-devel] [PATCH] avfilter/scale*: add option reset_sar

2025-02-07 Thread Gyan Doshi
On 2025-02-07 08:24 pm, Leo Izen wrote: On 1/31/25 8:00 AM, Gyan Doshi wrote: diff --git a/doc/filters.texi b/doc/filters.texi index a14c7e7e77..71de1ab2dc 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -21285,6 +21285,13 @@ This option can be handy if you need to have a video fit

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Marth64
Hi, agreed to move on from this thread. One parting thought, for future readers -- the RCWT muxer in FFmpeg preserves the A/53 Part 4 coding intact from decoders which provide it as side data. So, it would include EIA608 and CEA708 (DTVCC) pairs since the A/53 Part 4 frames from the SEI messages (

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
> > You have never successfully "embedded" an scc file as CEA-608. > I had told you that twice already. Marth64 has told you the same. > > That's not possible right now. Your commands are adding the scc > captions as mov_text (TTXT) subtitle stream, not as 608 CC. That is why this discussion of e

[FFmpeg-devel] [PATCH 2/2] avfilter/delogo: change delogo round area to superellipse area

2025-02-07 Thread Jörg Habenicht via ffmpeg-devel
Changed the delogo area to a definition of a superellipse. See here https://en.wikipedia.org/wiki/Superellipse Changed the meaning of the parameter 'r'. 'r' = 0.0 resolves to a rectangular area. 0 <'r' < 1 resolves to a star with concave sides. 'r' = 1.0 resolves to a rhombus. 1 < 'r' < 2 resolves

[FFmpeg-devel] [PATCH 0/2] Extend delogo area to a superellipse

2025-02-07 Thread Jörg Habenicht via ffmpeg-devel
Dear list, with help from Michael I extended the ellipse area to a superellipse. The user parameter 'r' has changed to become a float value. Values 0 < r < 1 the area looks like a four edge star. Value r = 1 the area get a rhombus. Values 1 < r < 2 the area is a rhombus with concave sides. Value

[FFmpeg-devel] [PATCH 1/2] avfilter/delogo: changed type of parameter 'r' to float

2025-02-07 Thread Jörg Habenicht via ffmpeg-devel
Changed the type of the parameter 'r' from int to float. To be able to flex the area as superellipse from rounded rectangle ('r' > 2.0) to a concave shaped star ('r' < 1.0). Check the input value to be 'r' >= 0.0, else error exit Signed-off-by: Jörg Habenicht --- libavfilter/vf_delogo.c | 21 +++

[FFmpeg-devel] [PATCH] aacenc_tns: clamp filter direction energy measurement

2025-02-07 Thread Lynne
The issue is that: float en[2]; ... tns->n_filt[w] = is8 ? 1 : order != TNS_MAX_ORDER ? 2 : 3; for (g = 0; g < tns->n_filt[w]; g++) { tns->direction[w][g] = slant != 2 ? slant : en[g] < en[!g]; When using the AAC Main profile, n_filt = 3, and slant is by default 2 (normal long frames), g can

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
> > The cc_fifo mechanism is actually implemented within the various > filters which change the framerate (deinterlacing, framerate > conversion, interlacing), so no extra command line arguments are > required. There are some edge cases though that don't properly handle > it, and those mainly rela

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
> > One thing worth noting is that the filenames in that Google drive > don't match up with the example commands you've provided. I would > recommend if you decide to open a ticket to either rename the files or > change the commands so whoever tries to reproduce the issue knows they > are working

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marth64 > Sent: Friday, February 7, 2025 11:18 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > (libavcodec’s definition of AV_CODEC_ID_EIA_608 is a fallacy, it

[FFmpeg-devel] [PATCH v2 2/2] avfilter/delogo: change delogo round area to superellipse area

2025-02-07 Thread Jörg Habenicht via ffmpeg-devel
Changed the delogo area to a definition of a superellipse. See here https://en.wikipedia.org/wiki/Superellipse Changed the meaning of the parameter 'r'. 'r' = 0.0 resolves to a rectangular area. 0 <'r' < 1 resolves to a star with concave sides. 'r' = 1.0 resolves to a rhombus. 1 < 'r' < 2 resolves

[FFmpeg-devel] [PATCH v2 1/2] avfilter/delogo: changed type of parameter 'r' to float

2025-02-07 Thread Jörg Habenicht via ffmpeg-devel
Changed the type of the parameter 'r' from int to float. To be able to flex the area as superellipse from rounded rectangle ('r' > 2.0) to a concave shaped star ('r' < 1.0). Check the input value to be 'r' >= 0.0, else error exit Signed-off-by: Jörg Habenicht --- libavfilter/vf_delogo.c | 21 +++

[FFmpeg-devel] [PATCH v2 0/2] Extend delogo area to a superellipse

2025-02-07 Thread Jörg Habenicht via ffmpeg-devel
Version 2 of the pathset. One test "if (isnan(yf))" was missing. Corrected in this version with help from Michael I extended the ellipse area to a superellipse. The user parameter 'r' has changed to become a float value. Values 0 < r < 1 the area looks like a four edge star. Value r = 1 the area

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Tom > Vaughan > Sent: Friday, February 7, 2025 7:36 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > Soft Works said... "the CC data needs to get into the video fra

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-07 Thread Marth64
Backported to 6.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 1:32 PM Devlist Archive wrote: > That is good to hear, FYI any time 708 captions present in a DTVCC video > stream there also must be 608 captions wrapped in that stream for legal > compliance and backwards compatibility with older downstream equipment > that downscales to S

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Devlist Archive > Sent: Friday, February 7, 2025 8:52 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > > > > Unfortunately, there's no bug which could be "fixed".

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Marth64
(libavcodec’s definition of AV_CODEC_ID_EIA_608 is a fallacy, it is actually A/53 Part 4 coding that is passed around with this codec ID, which can contain multiple sub-streams including EIA-608 and CEA-708) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Tom Vaughan
Soft Works said... "the CC data needs to get into the video frames - so that it exists as input to the video encoder. For the same reason, it is also not possible to add CCs at the muxer level. It always requires video encoding because the data needs to get into the video stream itself, so there

Re: [FFmpeg-devel] 10bit MV-HEVC decoding support

2025-02-07 Thread Danny Hong
On Fri, Feb 7, 2025 at 5:52 PM Vittorio Giovara wrote: > As far as I know, 10bit bitdepth is not specified in the MV profile for > HEVC, therefore, any 10 bit support would be out of standard. Thanks for the reply. You are right that the initial versions of the standard did not specify a 10bit

[FFmpeg-devel] [PATCH] avcodec/aarch64/opusdsp_neon: Simplify opus_postfilter_neon

2025-02-07 Thread Krzysztof Pyrkosz via ffmpeg-devel
This change removes one extra floating point operation and simplifies load operations at the beginning of the loop by using dedicated register for each of the 5 pointers and interleaving it with calculations. The first case seems to be a bit slower, but the performance increase is substantial in th

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Devlist Archive > Sent: Friday, February 7, 2025 9:50 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > At some point we will need to separate the embed/extract

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Rémi Denis-Courmont
Le perjantaina 7. helmikuuta 2025, 10.16.51 UTC+2 Soft Works a écrit : > The big evil with LLVMs is not the fact they are making mistakes but the > extreme level of confidence at which they are presenting these mistakes - > like no human would do. That's why we tend to fall so easily into taking >

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Rémi Denis-Courmont
Le perjantaina 7. helmikuuta 2025, 11.44.36 UTC+2 Jack Lau a écrit : > Hi softworkz, > > Thank you very much for your patient reply and kind suggestions. I am new to > the FFmpeg devel mailing list, and English is not my native language, so > there is still a lot for me to learn. It should be com

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Rémi Denis-Courmont > Sent: Friday, February 7, 2025 6:31 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > Le perjantaina 7. helmikuuta 2025, 10.16.51 UTC+2 Soft W

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 11:42 AM Devlist Archive wrote: > As such, I may be able to work out an edit workflow by using RCWT to make a > .bin file, using ccextractor to make an mcc file and importing into an edit > suite for transcode. The part I will still be missing is something to take > the .ss

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Devlist Archive > Sent: Friday, February 7, 2025 8:31 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > > > > The cc_fifo mechanism is actually implemented withi

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
At some point we will need to separate the embed/extract conversation from the transcode conversation. I have made a ticket over on Trac that covers the information for the transcode issue. Let's focus on what needs to happen to be able to generate a valid CEA-608 .scc file and embed such a file

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
> I've actually got code in the tree to handle framerate changes for > captions (the cc_fifo mechanism). It works for CC within video > streams (e.g. user_data or SEI), but isn't implemented in the case > where you have C608 packets. It might be possible to insert the > "cc_repack" filter and fra

[FFmpeg-devel] [PATCH] avdevice/alsa: simplify passing ff_alsa_open a channel layout

2025-02-07 Thread James Almer
This also ensures the layout set during the indev init is used instead of the blank one in st->codecpar. Signed-off-by: James Almer --- libavdevice/alsa.c | 14 +++--- libavdevice/alsa.h | 4 ++-- libavdevice/alsa_dec.c | 2 +- libavdevice/alsa_enc.c | 2 +- 4 files changed, 1

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/opusdsp_neon: Simplify opus_postfilter_neon

2025-02-07 Thread Lynne
On 07/02/2025 20:42, Krzysztof Pyrkosz via ffmpeg-devel wrote: This change removes one extra floating point operation and simplifies load operations at the beginning of the loop by using dedicated register for each of the 5 pointers and interleaving it with calculations. The first case seems to b

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Tom Vaughan
I know what an elementary video stream is. I founded and led development of x265, which produces elementary video streams. Elementary video streams can contain SEI messages. It's common to refer to the integration of closed captions into an elementary video stream as multiplexing. For example, s

Re: [FFmpeg-devel] 10bit MV-HEVC decoding support

2025-02-07 Thread James Almer
On 2/7/2025 5:13 PM, Danny Hong wrote: On Fri, Feb 7, 2025 at 5:52 PM Vittorio Giovara wrote: As far as I know, 10bit bitdepth is not specified in the MV profile for HEVC, therefore, any 10 bit support would be out of standard. Thanks for the reply. You are right that the initial versions

[FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb_neon: Implemented uyvytoyuv422

2025-02-07 Thread Krzysztof Pyrkosz via ffmpeg-devel
The patch contains NEON code that splits the uyvy input array into 3 separate buffers. The existing test cases are covering scenarios with odd height and odd stride, but width is even in every instance. Is it safe to make that assumption about the width? Just as I'm about to send this patch, I'm

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Marth64
Hi Devin & Softworks, I have been working on a slide deck in my spare time with suggestions and a roadmap to improve general digital Closed Captions support. I hope to share this with you and the community for feedback in the next 2 weeks. I meant to wrap it up sooner but had some IRL stuff come

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marth64 > Sent: Saturday, February 8, 2025 12:59 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > Hi Devin & Softworks, > > I have been working on a slide deck

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Jack Lau
> > Hi Jack, > > "paying attention next time"? That's not the right answer. > > Please make sure that there won't be a next time. > > The big evil with LLVMs is not the fact they are making mistakes but the > extreme level of confidence at which they are presenting these mistakes - > like n

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Jack Lau > Sent: Friday, February 7, 2025 9:26 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > > > > > Hi Jack, > > > > "paying attention next time"? That's n

Re: [FFmpeg-devel] [PATCH v2 2/2] checkasm: aacencdsp: Actually test nonzero values in quant_bands

2025-02-07 Thread Martin Storsjö
On Wed, 5 Feb 2025, Martin Storsjö wrote: Previously, we read elements from ff_aac_pow34sf_tab; however that table is initialized to zero; one needs to call ff_aac_float_common_init() to make sure that the table is initialized. However, given the range of the input values, a large number of ent

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Jack Lau > Sent: Friday, February 7, 2025 8:58 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > > > > > > Hi Zack, > > > > that message from "Jack" had confused

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Jack Lau
Hi softworkz, Thank you very much for your patient reply and kind suggestions. I am new to the FFmpeg devel mailing list, and English is not my native language, so there is still a lot for me to learn. May I ask a question? How long does it usually take for a patch to be reviewed? A few days a

Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags

2025-02-07 Thread Tobias Rapp
On 07/02/2025 08:57, softworkz wrote: From: softworkz This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents timing to be printed when exiting. Signed-off-by: sof

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Ronald S. Bultje: >> Fixes #11456. >> --- >> libavcodec/threadprogress.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c >> index 62c4fd898b..aa72ff80e7 100644 >> --- a/libavcodec/threadpr

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Zhao Zhili
> On Feb 7, 2025, at 19:39, Andreas Rheinhardt > wrote: > > Andreas Rheinhardt: >> Ronald S. Bultje: >>> Fixes #11456. >>> --- >>> libavcodec/threadprogress.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogres

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Andreas Rheinhardt
Zhao Zhili: > > >> On Feb 7, 2025, at 19:22, Andreas Rheinhardt >> wrote: >> >> Ronald S. Bultje: >>> Fixes #11456. >>> --- >>> libavcodec/threadprogress.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c >

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: log unsupported subtitle codec name

2025-02-07 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > It's more user friendly than codec ID. > --- > libavformat/matroskaenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 3285735a7f..2e06f68304 100644 > --- a/libavformat/

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Zhao Zhili
> On Feb 7, 2025, at 19:46, Zhao Zhili > wrote: > > > >> On Feb 7, 2025, at 19:39, Andreas Rheinhardt >> wrote: >> >> Andreas Rheinhardt: >>> Ronald S. Bultje: Fixes #11456. --- libavcodec/threadprogress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) >>

Re: [FFmpeg-devel] [PATCH v2 1/3] libavformat/oggdec: Allow first parameter in ff_vorbis_comment to be a generic AVClass struct

2025-02-07 Thread Andreas Rheinhardt
Romain Beauxis: > Firt argument in these function is only used to pass to av_log. This > makes it possible to re-use them with any type of AVClass struct. > > --- > libavformat/oggdec.h | 5 - > libavformat/oggparsevorbis.c | 4 ++-- > 2 files changed, 6 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Friday, February 7, 2025 12:27 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > time and datetime log flags > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: make ff_frame_new_side_data_from_buf behave like the function it's a wrapper for

2025-02-07 Thread Andreas Rheinhardt
James Almer: > It's less confusing to have ff_frame_new_side_data_from_buf() be a drop in > replacement for av_frame_side_data_add(), and the addition of the missing > flags > field will make it more versatile, as will be seen in the following commit. > > Signed-off-by: James Almer > --- > liba

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Andreas Rheinhardt
Ronald S. Bultje: > Fixes #11456. > --- > libavcodec/threadprogress.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c > index 62c4fd898b..aa72ff80e7 100644 > --- a/libavcodec/threadprogress.c > +++ b/libavcodec/t

Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Friday, February 7, 2025 11:42 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > time and datetime log flags > > On 07/02/2025 08:57, softworkz wrote: > >

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Zhao Zhili
> On Feb 7, 2025, at 19:22, Andreas Rheinhardt > wrote: > > Ronald S. Bultje: >> Fixes #11456. >> --- >> libavcodec/threadprogress.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c >> index 62c4fd898b..aa72

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/output.S: refactor ff_yuv2plane1_8_neon

2025-02-07 Thread Martin Storsjö
On Fri, 31 Jan 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: The benchmarks (before vs after) were gathered using ./tests/checkasm/checkasm --test=sw_scale --bench --runs=6 | grep yuv2yuv1 Thanks for the numbers! To keep it more readable and concise, we'd only need to see the numbers for th

[FFmpeg-devel] [PATCH 1/2] avformat/wavdec: Fix overflow of intermediate in block_align check

2025-02-07 Thread Michael Niedermayer
Fixes: signed integer overflow: -251517880 * 32 cannot be represented in type 'int' Fixes: 385224934/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-4909298151915520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

[FFmpeg-devel] [PATCH 2/2] avformat/mlvdec: fix size checks

2025-02-07 Thread Michael Niedermayer
Fixes: heap-buffer-overflow Fixes: 391962476/clusterfuzz-testcase-minimized-ffmpeg_dem_MLV_fuzzer-5746746587676672 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mlvdec.c | 11 --- 1

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb: Implemented NEON shuf routines

2025-02-07 Thread Martin Storsjö
On Tue, 28 Jan 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: The key idea is to pass the pre-generated tables to the TBL instruction and churn through the data 16 bytes at a time. The remaining 4 elements are handled with a specialized block located at the end of the routine. The 3210 variant

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Rémi Denis-Courmont
Le 7 février 2025 13:53:22 GMT+02:00, Zhao Zhili a écrit : > > >> On Feb 7, 2025, at 19:46, Zhao Zhili >> wrote: >> >> >> >>> On Feb 7, 2025, at 19:39, Andreas Rheinhardt >>> wrote: >>> >>> Andreas Rheinhardt: Ronald S. Bultje: > Fixes #11456. > --- > libavcodec/threadp

Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags

2025-02-07 Thread Tobias Rapp
On 07/02/2025 12:27, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Tobias Rapp Sent: Friday, February 7, 2025 11:42 AM To:ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags On 07/02/2025 08:57,

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Ronald S. Bultje
Hi, On Fri, Feb 7, 2025 at 6:22 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Ronald S. Bultje: > > Fixes #11456. > > --- > > libavcodec/threadprogress.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libavcodec/threadprogress.c b/libavcodec/t

[FFmpeg-devel] [PATCH v6 2/3] fftools/opt_common: add time and datetime log flags

2025-02-07 Thread softworkz
From: softworkz This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Signed-off-by: softworkz --- fftools/opt_common.c | 12 1 file changed, 12 insertions(+) diff --git a/fftools/opt_common.c b/fftools/opt_comm

[FFmpeg-devel] [PATCH v6 0/3] Add option to log timing

2025-02-07 Thread ffmpegagent
This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Update V1 * Fix merge conflicts Update V2 * Rebased Update V3 * Fix print timing on exit (as reported by Michael Niedermayer) Update V4 * Rename variable * Rename

[FFmpeg-devel] [PATCH v6 3/3] doc/fftools-common-opts: document log timing flags

2025-02-07 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 8b0931a86d..f6d452c40e 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi

[FFmpeg-devel] [PATCH v6 1/3] avutil/log: support logging of date and time information

2025-02-07 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 32 +--- libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges

Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags

2025-02-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Friday, February 7, 2025 2:22 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add > time and datetime log flags > > On 07/02/2025 12:27, Soft Works wrote: > >

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Zhao Zhili
> On Feb 7, 2025, at 21:26, Ronald S. Bultje wrote: > > Hi, > > On Fri, Feb 7, 2025 at 6:22 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Ronald S. Bultje: >>> Fixes #11456. >>> --- >>> libavcodec/threadprogress.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions

Re: [FFmpeg-devel] [PATCH] avfilter/scale*: add option reset_sar

2025-02-07 Thread Leo Izen
On 1/31/25 8:00 AM, Gyan Doshi wrote: For anamorphic videos, enabling this option leads to adjustment of output dimensions to obtain square pixels when the user requests proportional scaling through either of the w/h expressions or force_original_aspect_ratio. Output SAR is always reset to 1. O

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Marth64
Hi folks Zach (Devlist Archive): Thanks for sharing your experience and I hope a resolution comes out of it. I encourage you to write this email instead to the ffmpeg-user list (or possibly TRAC, our bug trucker), which is better suited for discussing issues like yours. Let us pivot this conversat

[FFmpeg-devel] 10bit MV-HEVC decoding support

2025-02-07 Thread Danny Hong
Hello, is there any plan to add 10bit support to MV-HEVC decoding? Thank you Danny Hong ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ..

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-07 Thread Marth64
Planning to backport in 48-72 hours ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: make ff_frame_new_side_data_from_buf behave like the function it's a wrapper for

2025-02-07 Thread James Almer
On 2/7/2025 9:17 AM, Andreas Rheinhardt wrote: James Almer: It's less confusing to have ff_frame_new_side_data_from_buf() be a drop in replacement for av_frame_side_data_add(), and the addition of the missing flags field will make it more versatile, as will be seen in the following commit. Sign

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Marth64
Hey Zach, Thanks for the additional context. Embedding in the traditional sense is not available now. If archival is also a primary goal, have you checked out the RCWT muxer? This muxer can collect the original EIA608/CEA708 bytes with all fields, in A53 Part 4 format, to a preservable file. The

[FFmpeg-devel] [PATCH] avcodec/hevc_mp4toannexb: prepend extradata before the leading PS for an IRAP

2025-02-07 Thread James Almer
Parameter sets may be coded in the packet before an IRAP (as is the case for the hev1 ISO-BMFF brand), and they should have priority as they may override the extradata ones. As such, prepend the extradata PS NALUs to the packet PS NALUs if they are present before an IRAP, instead of prepending them

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-07 Thread James Almer
On 2/7/2025 12:46 PM, Marth64 wrote: Planning to backport in 48-72 hours Backporting it is obviously ok, so no need to wait. OpenPGP_signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://f

Re: [FFmpeg-devel] [PATCH v6 0/3] Add option to log timing

2025-02-07 Thread Tobias Rapp
On 07/02/2025 15:34, ffmpegagent wrote: This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Update V1 * Fix merge conflicts Update V2 * Rebased Update V3 * Fix print timing on exit (as reported by Michael Niederma

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-07 Thread Marth64
Re: James > Backporting it is obviously ok, so no need to wait. Good deal, will take care of it shortly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
My intent with starting this thread was to recruit at least one developer to help make sure a solution is found. It kind of got sent off topic to the user space by some of the replies. My current understanding is that the tools used in the ffmpeg commands I was using are actually extracting subti

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-07 Thread Ronald S. Bultje
Hi, On Fri, Feb 7, 2025 at 8:44 AM Zhao Zhili < quinkblack-at-foxmail@ffmpeg.org> wrote: > > On Feb 7, 2025, at 21:26, Ronald S. Bultje wrote: > > On Fri, Feb 7, 2025 at 6:22 AM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > >> Ronald S. Bultje: > >>> Fixes #11456. > >>> -

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Marth64
Added bit: RCWT will preserve more than what the SCC muxer does You can also convert the RCWT back to SCC with a single EIA608 field array, again with either tool ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devlist Archive
My application is actually to generate a playout library for over the air TV, then implement a captions data path into a sub project that relies on ffmpeg for decode/encode. So I need to not just do archival, but build a library in a usable format. This requires an ingest process for both an edi

[FFmpeg-devel] [PATCH] avcodec/vorbisdec: don't abort on EOD when decoding residuals

2025-02-07 Thread James Almer
Fixes ticket #11427 Signed-off-by: James Almer --- It may be a good idea to ensure the timeout fuzzer case doesn't regress after this. libavcodec/vorbisdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index 218e855f7a..321

Re: [FFmpeg-devel] 10bit MV-HEVC decoding support

2025-02-07 Thread Vittorio Giovara
On Fri, Feb 7, 2025 at 4:31 PM Danny Hong wrote: > Hello, is there any plan to add 10bit support to MV-HEVC decoding? As far as I know, 10 bit bitdepth is not specified in the MV profile for HEVC, therefore, any 10 bit support would be out of standard. -- Vittorio _