On 2/7/2025 9:17 AM, Andreas Rheinhardt wrote:
James Almer:It's less confusing to have ff_frame_new_side_data_from_buf() be a drop in replacement for av_frame_side_data_add(), and the addition of the missing flags field will make it more versatile, as will be seen in the following commit.Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/av1dec.c | 6 ++++-- libavcodec/decode.c | 13 +++++-------- libavcodec/decode.h | 11 +++++++---- libavcodec/h2645_sei.c | 12 ++++++++---- libavcodec/hevc/hevcdec.c | 7 +++++-- libavcodec/hevc/refs.c | 6 ++++-- libavcodec/libdav1d.c | 6 ++++-- libavcodec/libjxldec.c | 6 ++++-- libavcodec/mpeg12dec.c | 6 ++++-- 9 files changed, 45 insertions(+), 28 deletions(-)
[...]
It makes the function have the same semantics as av_frame_side_data_add(), including the addition of the flags argument, so it can be a direct drop in replacement in lavc. This does result in a potential extra cleaning step for callers, but it's hardly a problem.This adds these cleanup av_buffer_unref() everywhere. That is not an improvement.
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
