Re: [FFmpeg-devel] root access voting

2024-11-07 Thread Vittorio Giovara
On Tue, Nov 5, 2024 at 3:56 PM Michael Niedermayer wrote: > ronald, you are someone knowing about buisness, I think you know this. If > a CEO is or other > executive is voted out against his will. They dont stay in the company > normally. > Iam saying this so people understand. Because i believe

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix reading lz77-pair as initial entropy symbol

2024-11-07 Thread Leo Izen
The JPEG XL parser has an entropy decoder inside, which supports LZ77 length-distance pairs. If the first symbol from the entropy stream is an LZ77 pair, the bitstream is invalid, so we should abort immediately rather than attempt to read it anyway (which would read from the uninitialized starting

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate/pixfmts: extend the high bit depth test

2024-11-07 Thread Leo Izen
On 11/7/24 8:41 AM, James Almer wrote: On 11/7/2024 6:02 AM, Martin Storsjö wrote: I don't know what's going on. I tried on mingw-w64 and Ubuntu x86_64 22.04 and i get no failures, with CPUFLAGS=0, CPUFLAGS=mmx+mmxext, or CPUFLAGS=all (avx2). I see all x86 systems in FATE failing on fate-pix

[FFmpeg-devel] [PATCH] avcodec/libopenjpeg: set guard bits to 1 for 2K cinema

2024-11-07 Thread Marc-Antoine ARNAUD
Signed-off-by: Marc-Antoine Arnaud --- libavcodec/libopenjpegenc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c index 06937cb9cac..ee2513d2a38 100644 --- a/libavcodec/libopenjpegenc.c +++ b/libavcodec/libopenjpegenc.c @

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-07 Thread Nicolas George
James Almer (12024-11-07): > Linux x86_32 is pretty much obsolete and deprecated. Source? -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or e

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-07 Thread Rémi Denis-Courmont
Le torstaina 7. marraskuuta 2024, 20.34.30 EET Nicolas George a écrit : > James Almer (12024-11-07): > > Linux x86_32 is pretty much obsolete and deprecated. > > Source? It is very hard to believe that someone such as you would be unable to trivially obtain any such sources with about as much ef

Re: [FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-07 Thread Ronald S. Bultje
Hi, You raise good questions that certainly deserve further exploration, in fact I'd be deeply supportive of such discussions. However... On Sat, Nov 2, 2024 at 7:56 PM Michael Niedermayer wrote: > That said, I find the discussions about such key decissions being done > each year > on "videolan

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-07 Thread Nicolas George
Rémi Denis-Courmont (12024-11-07): > It is very hard to believe that someone such as you would be unable to > trivially obtain any such sources with about as much efforts that it would > have > taken to write that mail. > > At this point even slow-moving Debian "anticipate[d] that the kernel, d

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Michael Niedermayer
Hi all On Thu, Nov 07, 2024 at 12:11:49AM +0100, Michael Niedermayer wrote: > Hi all > > Should libpostproc be split out into a seperate source repository ? > > Several people did over the years want libpostproc removed, and such > a task was part of the submitted and approved STF 2024 projects.

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Vittorio Giovara
On Thu, Nov 7, 2024 at 1:03 PM Michael Niedermayer wrote: > Hi all > > On Thu, Nov 07, 2024 at 12:11:49AM +0100, Michael Niedermayer wrote: > > Hi all > > > > Should libpostproc be split out into a seperate source repository ? > > > > Several people did over the years want libpostproc removed, an

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Michael Niedermayer
On Thu, Nov 07, 2024 at 02:46:49PM +, Derek Buitenhuis wrote: > On 11/6/2024 11:11 PM, Michael Niedermayer wrote: > > 1. split libpostproc out so it builds and links fine (already done) > > (send to SPI/STF/Invoice in future) > > I did this in 2012, the git repo is still there: > http://

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Michael Niedermayer
On Thu, Nov 07, 2024 at 02:48:13PM +, Derek Buitenhuis wrote: > On 11/6/2024 11:11 PM, Michael Niedermayer wrote: > > 3. actually remove libpostproc from master repository (2025 future) > > (send to SPI/STF/Invoice in future) > > I also did this exact work for Libav in 2012. It was very l

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Derek Buitenhuis
On 11/7/2024 8:04 PM, Michael Niedermayer wrote: > This is slander > > libpostproc was simply deleted from libav. > > The messed up repository you created in 2012, was never maintained by anyone > > of course copying something in a messed up form and deleting support for it > is not worth 5k eu

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Derek Buitenhuis
On 11/7/2024 7:52 PM, Michael Niedermayer wrote: > It also did not achieve the intended result. libpostproc did continue to > live in FFmpeg since that 2012 till today. Interesting way you've defined 'intended result' for yourself here. > The goal of this project is to have a seperate libpostproc

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Michael Niedermayer
On Thu, Nov 07, 2024 at 12:11:49AM +0100, Michael Niedermayer wrote: > Hi all > > Should libpostproc be split out into a seperate source repository ? > > Several people did over the years want libpostproc removed, and such > a task was part of the submitted and approved STF 2024 projects. > But w

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-07 Thread James Almer
On 11/5/2024 3:18 PM, Nicolas George wrote: James Almer (12024-11-05): Asking for benchmarks on old CPUs that are running deprecated or obsolete OSes is not reasonable. I did not ask that they be running deprecated or obsolete OSes, so… Linux x86_32 is pretty much obsolete and deprecated.

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Kieran Kunhya via ffmpeg-devel
On Fri, 8 Nov 2024, 06:07 Vittorio Giovara, wrote: > On Thu, Nov 7, 2024 at 1:03 PM Michael Niedermayer > > wrote: > > > Hi all > > > > On Thu, Nov 07, 2024 at 12:11:49AM +0100, Michael Niedermayer wrote: > > > Hi all > > > > > > Should libpostproc be split out into a seperate source repository

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-07 Thread Pierre-Anthony Lemieux
I get with the following error with jpeg2000/itu-iso/codestreams_profile1/p1_03.j2k: `[jpeg2000 @ 0x5c20680] Mid mismatch 1 in pass 18 of 22` On Sat, Nov 2, 2024 at 9:49 PM Osamu Watanabe wrote: > > Fix for the integer version of the inverse 9-7 DWT processing > (FF_DWT97_INT, https://trac.ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: set FF_CODEC_PROPERTY_CLOSED_CAPTIONS in mpeg_set_cc_format()

2024-11-07 Thread Marth64
Will push in a few hours. Cheers ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Michael Niedermayer
Hi Vittorio On Thu, Nov 07, 2024 at 01:07:26PM -0800, Vittorio Giovara wrote: > On Thu, Nov 7, 2024 at 1:03 PM Michael Niedermayer > wrote: > > > Hi all > > > > On Thu, Nov 07, 2024 at 12:11:49AM +0100, Michael Niedermayer wrote: > > > Hi all > > > > > > Should libpostproc be split out into a se

[FFmpeg-devel] [PATCH] avcodec/speexdec: fix decoding regressions

2024-11-07 Thread shenleban tongying
fix ticket #11054 and #11078 * reduce false decoding errors * fix wrong frame_size Co-authored-by: Paul B Mahol Signed-off-by: shenleban tongying --- libavcodec/speexdec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c

[FFmpeg-devel] [PATCH] avcodec/speexdec: fix decoding regressions

2024-11-07 Thread shenleban tongying
* fix ticket #11054 and #11078 * reduce false decoding errors * fix wrong frame_size Co-authored-by: Paul B Mahol Signed-off-by: shenleban tongying --- libavcodec/speexdec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

2024-11-07 Thread Clément Péron
On Fri, 1 Nov 2024 at 18:39, Clément Péron wrote: > > From: Troy Benson > > Cuvid data packet have specific format that don't contain any side data. > In order to keep additional information and metadata, we need to implement > a ring buffer and reattach side data to decoded frame. > > Signed-off

[FFmpeg-devel] [PATCH] fate: Add a target for listing failed tests

2024-11-07 Thread Martin Storsjö
If running tests with "make -j fate", the execution will stop after the first failing test. To get an overview of the whole test suite, one rather would run "make -k -j fate", which then again buries the results about what tests actually failed further up in the console log. Add a target so one ca

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: set guard bits to 1 for 2K cinema

2024-11-07 Thread Marc-Antoine ARNAUD
Signed-off-by: Marc-Antoine Arnaud --- libavcodec/libopenjpegenc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c index 06937cb9cac..ee2513d2a38 100644 --- a/libavcodec/libopenjpegenc.c +++ b/libavcodec/libopenjpegenc.c @

[FFmpeg-devel] [PATCH v7] avformat/ogg: Add support for embedding cover art in Ogg

2024-11-07 Thread Zsolt Vadász via ffmpeg-devel
This version is basically https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10105 applied with a 3-way merge, squashed into a single commit, with an added NULL check added at the end of `ogg_finish_header`. --- libavformat/flac_picture.c | 133 +++ libavformat/flac_pi

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-07 Thread Nicolas George
Marton Balint (12024-11-06): > Feel free to test this yourself, but I agree with others in this thread, > testing on or optimizing for native 32bit CPUs is not something you can > reasonably expect from fellow developers to spend time on. Also I would like > to point out that accuracy and speed is

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Derek Buitenhuis
On 11/6/2024 11:11 PM, Michael Niedermayer wrote: > 1. split libpostproc out so it builds and links fine (already done) (send > to SPI/STF/Invoice in future) I did this in 2012, the git repo is still there: http://git.videolan.org/?p=libpostproc.git;a=summary This work was very easy and not

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-07 Thread Leo Izen
On 11/7/24 12:28 AM, Kacper Michajlow wrote: On Tue, 5 Nov 2024 at 11:05, Leo Izen wrote: This says reported by kacper, could you send me the fuzz testcase? I've sent you testcases privately. - Kacper Thanks, I received them. I'll take a look today. - Leo Izen __

Re: [FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-07 Thread Nicolas George
Michael Niedermayer (12024-11-03): > We can install gitlab on our infrastructure, if the community decides that it > wants gitlab. We can also install anything else the community wants. If we want a more-than-monthly emergency security update and the dozens of minutes of associated downtime, then

[FFmpeg-devel] [PATCH] avcodec/libopenjpeg: overwrite the bitrate

2024-11-07 Thread Marc-Antoine ARNAUD
Signed-off-by: Marc-Antoine Arnaud --- libavcodec/libopenjpegenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c index 01b67dffda4..06937cb9cac 100644 --- a/libavcodec/libopenjpegenc.c +++ b/libavcodec/libopenjpegenc.c @@ -301

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/asrc_sine: correct accumulating phase error at every second

2024-11-07 Thread Nicolas George
Marton Balint (12024-11-06): > This improves phase accuracy and for integer frequencies it makes the filter > bitexact periodic per every second and completely eliminates accumulating > errors. > > This code intentionally uses the same counters as the beep support, so the > additional overhead sho

[FFmpeg-devel] [PATCH 1/2] avcodec/x86/diracdsp_init: Remove unused macro

2024-11-07 Thread Kyosuke Kawakami
PIXFUNC macro is unused since d29a9c2aa68fc3eb6d61ff95c698e29316037583. Signed-off-by: Kyosuke Kawakami --- libavcodec/x86/diracdsp_init.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/x86/diracdsp_init.c b/libavcodec/x86/diracdsp_init.c index f678759dc0..6a31d3921f 100644 -

[FFmpeg-devel] [PATCH 2/2] avcodec/x86/diracdsp: Migrate last remaining MMX function to SSE2

2024-11-07 Thread Kyosuke Kawakami
The add_dirac_obmc8_mmx function was the only MMX function left. This patch migrates it to SSE2. Signed-off-by: Kyosuke Kawakami --- libavcodec/x86/diracdsp.asm| 4 +--- libavcodec/x86/diracdsp_init.c | 10 +++--- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/libavcode

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Derek Buitenhuis
On 11/6/2024 11:11 PM, Michael Niedermayer wrote: > 3. actually remove libpostproc from master repository (2025 future) (send > to SPI/STF/Invoice in future) I also did this exact work for Libav in 2012. It was very little work. Not 5k. - Derek ___

Re: [FFmpeg-devel] root access voting

2024-11-07 Thread Derek Buitenhuis
On 11/3/2024 4:37 PM, Michael Niedermayer wrote: > I very strongly object to you calling me "misleading and disparagin" I suspect this now deleted tweet meets the definition of "disparaging". See: https://imgur.com/a/RdPW15a The link was https://x.com/michael__ni/status/1853033116199219207 (I t

[FFmpeg-devel] [PATCH] avcodec/libopenjpeg: overwrite the bitrate

2024-11-07 Thread Marc-Antoine ARNAUD
Signed-off-by: Marc-Antoine Arnaud --- libavcodec/libopenjpegenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c index 01b67dffda4..06937cb9cac 100644 --- a/libavcodec/libopenjpegenc.c +++ b/libavcodec/libopenjpegenc.c @@ -301

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate/pixfmts: extend the high bit depth test

2024-11-07 Thread James Almer
On 11/7/2024 6:02 AM, Martin Storsjö wrote: On Thu, 7 Nov 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Sat Nov  2 20:06:24 2024 -0300| [271aea60a4cd211d92923c53b72cd074c3030897] | committer: James Almer fate/pixfmts: extend the high bit depth test Also test 8bit formats

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate/pixfmts: extend the high bit depth test

2024-11-07 Thread Martin Storsjö
On Thu, 7 Nov 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Sat Nov 2 20:06:24 2024 -0300| [271aea60a4cd211d92923c53b72cd074c3030897] | committer: James Almer fate/pixfmts: extend the high bit depth test Also test 8bit formats, and try bitdepth conversion paths. Signed-o

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-07 Thread Marton Balint
On Thu, 7 Nov 2024, Nicolas George wrote: Thanks for explaining. You have gotten the math wrong, and therefore are going for an incorrect fix. Sure, the 32 bits of precision will push the incorrectness very far in the future, but it is still invalid. The output is not supposed to be periodic

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: set FF_CODEC_PROPERTY_CLOSED_CAPTIONS in mpeg_set_cc_format()

2024-11-07 Thread Marth64
Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] fate/pixfmt: disable dithering in the scale filter

2024-11-07 Thread James Almer
Should fix fate failures across different systems. Signed-off-by: James Almer --- This only hides the bug in the dither path for unscaled planar yuv 8bit to hbd and vice-versa. Someone more familiar with the code should check what exactly is going on. tests/fate-run.sh | 2

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-07 Thread WATANABE Osamu
Hi Pierre, This message is not an error but a warning that stays there before this patch. I think the warning is a separate issue. Best, Osamu > 2024/11/08 9:02、Pierre-Anthony Lemieux のメール: > > ?I get with the following error with > jpeg2000/itu-iso/codestreams_profile1/p1_03.j2k: > > `[jpeg

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-07 Thread WATANABE Osamu
Thank you! > 2024/11/08 14:23、Pierre-Anthony Lemieux のメール: > > ?Ok will merge the patch below. > >> On Thu, Nov 7, 2024 at 9:21?PM WATANABE Osamu >> wrote: >> >> Hi Pierre, >> >> This message is not an error but a warning that stays there before this >> patch. >> >> I think the warning is a

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-07 Thread Pierre-Anthony Lemieux
Ok will merge the patch below. On Thu, Nov 7, 2024 at 9:21 PM WATANABE Osamu wrote: > > Hi Pierre, > > This message is not an error but a warning that stays there before this patch. > > I think the warning is a separate issue. > > Best, > Osamu > > > 2024/11/08 9:02、Pierre-Anthony Lemieux のメール: >

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-07 Thread Vittorio Giovara
On Thu, Nov 7, 2024 at 3:34 PM Michael Niedermayer wrote: > Hi Vittorio > Hi Michael > On Thu, Nov 07, 2024 at 01:07:26PM -0800, Vittorio Giovara wrote: > This discussion is a waste of money > > how much did you pay for the discussion ? > I hope you did not pay much, i dont think this discuss

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-11-07 Thread Frank Plowman
On 23/08/2024 13:36, Frank Plowman wrote: > This reverts commit 110d8549d575aae6b2f627cd63e2eb7082ab8926. > > I have been working through fixing bugs, particularly crashes I've > found using a fuzzer, in the VVC decoder for the past few months. > While I won't claim it is now bug-free, it is consi