[FFmpeg-devel] [PATCH v3 00/10] Refactor DNN

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili v3: 1. Init class with ff_dnn_filter_init_child_class and called by AVFilter preinit. 2. Fix crash in vf_dnn_detect (patch 10/10). Zhao Zhili (10): avfilter/dnn: Refactor DNN parameter configuration system avfilter/dnn_backend_openvino: Fix free context at random place av

[FFmpeg-devel] [PATCH v3 03/10] avfilter/dnn_backend_openvino: simplify memory allocation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 769ba0a54b..1acc54b791 100644 --- a/libavfilter/dnn/

[FFmpeg-devel] [PATCH v3 04/10] avfilter/dnn_backend_tf: Remove one level of indentation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index d24591b90b..60f9e57fb7 100644 --- a/libavfilter/dnn/dnn_backend_t

[FFmpeg-devel] [PATCH v3 02/10] avfilter/dnn_backend_openvino: Fix free context at random place

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index c4b0682f11..769ba0a54b 100644 --- a/libavfilter/dnn/dnn_b

[FFmpeg-devel] [PATCH v3 06/10] avfilter/dnn_backend_tf: Simplify memory allocation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 3b4de6d13f..c7716e696d 100644 --- a/libavfilter/dnn/dnn_backend_t

[FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_STRING backend_conf

[FFmpeg-devel] [PATCH v3 08/10] avfilter/dnn: Remove a level of dereference

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19 +-- libavfilter/dnn/dnn

[FFmpeg-devel] [PATCH v3 05/10] avfilter/dnn_backend_tf: Fix free context at random place

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 60f9e57fb7..3b4de6d13f 100644 --- a/libavfilter/dnn/dnn_bac

[FFmpeg-devel] [PATCH v3 07/10] avfilter/dnn_backend_torch: Simplify memory allocation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index abdef1f178..818ec5b713 100644 --- a/libavfilter/dnn/dn

[FFmpeg-devel] [PATCH v3 09/10] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h| 1 + 5 files changed

[FFmpeg-devel] [PATCH v3 10/10] avfilter/vf_dnn_detect: Fix null pointer dereference

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/vf_dnn_detect.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index 926966368a..1830bae181 100644 --- a/libavfilter/vf_dnn_detect.c +++ b/libavfilter/vf_dnn_detect.c @@ -80

Re: [FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-30 Thread Zhao Zhili
> On Apr 30, 2024, at 13:54, Chen, Wenbin > wrote: > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Zhao >> Zhili >> Sent: Sunday, April 28, 2024 2:47 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao Zhili >> Subject: [FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor D

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

2024-04-30 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1397741 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/avfiltergraph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfil

[FFmpeg-devel] [PATCH] checkasm: vc1dsp: Align buffers sufficiently for the mspel tests

2024-04-30 Thread Martin Storsjö
This fixes crashes in the mspel tests on x86. --- tests/checkasm/vc1dsp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c index 407d9e5fe8..f18f0f8251 100644 --- a/tests/checkasm/vc1dsp.c +++ b/tests/checkasm/vc1dsp.c @@

Re: [FFmpeg-devel] [PATCH 2/2] lavc/blockdsp: R-V V fill_block

2024-04-30 Thread flow gg
Since the number of stores is controlled by a3 and not by zero, it doesn't have to be exactly 16 bytes ? Rémi Denis-Courmont 于2024年4月30日周二 14:40写道: > > > Le 30 avril 2024 03:26:25 GMT+03:00, flow gg a > écrit : > >Hi, I initially used a loop, but according to libavcodec/blockdsp.h, > > > >the m

Re: [FFmpeg-devel] [PATCH 2/2] lavc/blockdsp: R-V V fill_block

2024-04-30 Thread Rémi Denis-Courmont
Le 30 avril 2024 11:22:31 GMT+03:00, flow gg a écrit : >Since the number of stores is controlled by a3 and not by zero, it doesn't >have to be exactly 16 bytes ? Yeah ok, I get it now > >Rémi Denis-Courmont 于2024年4月30日周二 14:40写道: > >> >> >> Le 30 avril 2024 03:26:25 GMT+03:00, flow gg a >> é

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

2024-04-30 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Chen, > Wenbin > Sent: Tuesday, April 30, 2024 10:55 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN > > > > On Apr 29, 2024, at 18:29, Guo, Yejun > >

[FFmpeg-devel] [PATCH 1/2] checkasm/rv40dsp: add chroma_mc test

2024-04-30 Thread flow gg
From 07c0b8a26b76e31c46ecabddb251f317c48c73a3 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Tue, 30 Apr 2024 12:43:57 +0800 Subject: [PATCH 1/2] checkasm/rv40dsp: add chroma_mc test This is similar to h264. --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm

[FFmpeg-devel] [PATCH 2/2] lavc/rv40dsp: R-V V chroma_mc

2024-04-30 Thread flow gg
From 3e66b2bbe257cc91a4c2169362163e92aba6760b Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Tue, 30 Apr 2024 18:24:00 +0800 Subject: [PATCH 2/2] lavc/rv40dsp: R-V V chroma_mc This is similar to h264, but here we use manual_avg instead of vaaddu because rv40's OP differs from h264. If we use vaa

Re: [FFmpeg-devel] [PATCH] doc/Doxfyile: Refactor for maintainability

2024-04-30 Thread Michael Niedermayer
On Mon, Apr 29, 2024 at 09:53:13AM +0100, Andrew Sayers wrote: > On Sun, Apr 28, 2024 at 11:46:18PM +0200, Michael Niedermayer wrote: > > Hi > > > > On Sun, Apr 28, 2024 at 11:10:22AM +0100, Andrew Sayers wrote: > > [...] > > > Ping ? > > > > > > Michael, this is in response to your request[0].

[FFmpeg-devel] [PATCH] avcodec/x86/vp3dsp_init: Set correct function pointer, fix crash

2024-04-30 Thread Andreas Rheinhardt
Regression since fd172185580c1ccdcfb90bbfdb59fa806fad3117; triggered by vp4/KTkvw8dg1J8.avi in the FATE suite, but not when running fate as this code is not used when the bitexact flag is set. Bisecting done by ami_stuff, patch from user Mika Fischer in ticket #10027 (which this commit fixes). Si

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Michael Niedermayer
On Mon, Apr 22, 2024 at 01:32:27PM +0200, Lynne wrote: > Apr 22, 2024, 13:07 by stefa...@gmail.com: > > > On date Sunday 2024-04-21 22:12:56 -0300, James Almer wrote: > > > >> On 4/17/2024 10:58 AM, Michael Niedermayer wrote: > >> > > [...] > > > >> A full rewrite of ffserver, using only public AP

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/x86/vvc: add alf filter luma and chroma avx2 optimizations

2024-04-30 Thread Nuo Mi
On Tue, Apr 30, 2024 at 12:34 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > toq...@outlook.com: > > vvc_alf_filter_chroma_16x12_10_c: 7235.5 > > vvc_alf_filter_chroma_16x12_10_avx2: 9751.0 > > Are these numbers correct? If so, the avx2 version should not be committed. > It could

Re: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

2024-04-30 Thread Nuo Mi
On Mon, Apr 29, 2024 at 11:38 PM Lynne wrote: > Apr 29, 2024, 17:25 by toq...@outlook.com: > > > From: Wu Jianhua > > > > Signed-off-by: Wu Jianhua > > --- > > tests/checkasm/Makefile | 2 +- > > tests/checkasm/checkasm.c | 3 +- > > tests/checkasm/checkasm.h | 1 + > > tests/checkasm/

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 08:01:14PM +0200, Tomas Härdin wrote: > lör 2024-04-27 klockan 12:53 +0200 skrev Michael Niedermayer: > > On Thu, Apr 25, 2024 at 12:26:00PM +0200, Tomas Härdin wrote: > > > tor 2024-04-25 klockan 02:07 +0200 skrev Michael Niedermayer: > > > > On Thu, Apr 25, 2024 at 12:50:0

Re: [FFmpeg-devel] [PATCH] avcodec/x86/vp3dsp_init: Set correct function pointer, fix crash

2024-04-30 Thread Martin Storsjö
On Tue, 30 Apr 2024, Andreas Rheinhardt wrote: Regression since fd172185580c1ccdcfb90bbfdb59fa806fad3117; triggered by vp4/KTkvw8dg1J8.avi in the FATE suite, but not when running fate as this code is not used when the bitexact flag is set. Bisecting done by ami_stuff, patch from user Mika Fisch

Re: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

2024-04-30 Thread Lynne
Apr 30, 2024, 20:05 by nuomi2...@gmail.com: > On Mon, Apr 29, 2024 at 11:38 PM Lynne wrote: > >> Apr 29, 2024, 17:25 by toq...@outlook.com: >> >> > From: Wu Jianhua >> > >> > Signed-off-by: Wu Jianhua >> > --- >> > tests/checkasm/Makefile | 2 +- >> > tests/checkasm/checkasm.c | 3 +- >>

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Ondřej Fiala
On Tue Apr 30, 2024 at 2:11 AM CEST, Hendrik Leppkes wrote: > On Mon, Apr 29, 2024 at 6:44 PM Ondřej Fiala wrote: > > > > I would really suggest you look at SourceHut. > > While SourceHut might be a slight improvement over the current > situation (and only slight), it being fundamentally still bas

Re: [FFmpeg-devel] [PATCH] checkasm: vc1dsp: Align buffers sufficiently for the mspel tests

2024-04-30 Thread James Almer
On 4/30/2024 4:18 AM, Martin Storsjö wrote: This fixes crashes in the mspel tests on x86. --- tests/checkasm/vc1dsp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c index 407d9e5fe8..f18f0f8251 100644 --- a/tests/ch

Re: [FFmpeg-devel] [PATCH 31/57] avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic

2024-04-30 Thread Michael Niedermayer
On Mon, Apr 29, 2024 at 11:14:12PM +0200, Andreas Rheinhardt wrote: > There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic) > that are directly part of MpegEncContext and an array of MPVPictures > that are separately allocated and are mostly accessed via pointers > (cur|last|next)

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Ondřej Fiala
On Mon Apr 29, 2024 at 9:04 PM CEST, Davy Durham wrote: > Presently do you not have to create an account on the devel mailing list to > contribute to ffmpeg? > > So on the flip side, I (actually) find it just as annoying to have to > create such accounts at every project rather than my having one a

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Hendrik Leppkes
On Tue, Apr 30, 2024 at 8:49 PM Ondřej Fiala wrote: > > On Tue Apr 30, 2024 at 2:11 AM CEST, Hendrik Leppkes wrote: > > On Mon, Apr 29, 2024 at 6:44 PM Ondřej Fiala wrote: > > > > > > I would really suggest you look at SourceHut. > > > > While SourceHut might be a slight improvement over the curr

Re: [FFmpeg-devel] [PATCH 31/57] avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic

2024-04-30 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Apr 29, 2024 at 11:14:12PM +0200, Andreas Rheinhardt wrote: >> There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic) >> that are directly part of MpegEncContext and an array of MPVPictures >> that are separately allocated and are mostly accessed via

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Ondřej Fiala
On Tue Apr 30, 2024 at 9:06 PM CEST, Hendrik Leppkes wrote: > I will take the replacement instead, thanks. Email is archaic. The > entire point is to get away from email, not dress it up. > SourceHut usage would likely make me even less interested then today. > > - Hendrik I guess that depends on h

Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool

2024-04-30 Thread Michael Niedermayer
On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: > This avoids constant allocations+frees and will also allow > to simply switch to the RefStruct API, thereby avoiding > the overhead of the AVBuffer API. > It also simplifies the code, because it removes the "needs_realloc" > fiel

Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool

2024-04-30 Thread James Almer
On 4/30/2024 5:40 PM, Michael Niedermayer wrote: On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: This avoids constant allocations+frees and will also allow to simply switch to the RefStruct API, thereby avoiding the overhead of the AVBuffer API. It also simplifies the code, b

Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool

2024-04-30 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: >> This avoids constant allocations+frees and will also allow >> to simply switch to the RefStruct API, thereby avoiding >> the overhead of the AVBuffer API. >> It also simplifies the code, because it removes

Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool

2024-04-30 Thread Andreas Rheinhardt
James Almer: > On 4/30/2024 5:40 PM, Michael Niedermayer wrote: >> On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: >>> This avoids constant allocations+frees and will also allow >>> to simply switch to the RefStruct API, thereby avoiding >>> the overhead of the AVBuffer API. >>>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/kvag: Check sample_rate

2024-04-30 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 02:48:52AM +0200, Michael Niedermayer wrote: > Fixes: Division by 0 > Fixes: -copyts -start_at_zero -itsoffset 00:00:01 -itsscale 1 -ss 00:00:02 > -i zgclab/ffmpeg_crash/poc1 output.mp4 > > Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: free the infe allocated item data on failure

2024-04-30 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 08:17:37PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/mov.c | 30 -- > 1 file changed, 24 insertions(+), 6 deletions(-) fixes 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4963488540721152 thx [..

Re: [FFmpeg-devel] [PATCH 3/3] avutil/opt: Preserve nb_channels in opt_free

2024-04-30 Thread James Almer
On 4/29/2024 9:48 PM, Michael Niedermayer wrote: Fixes: division by 0 Fixes: decoder modifying demuxer channels on failure Fixes: -sseof -5 -i zgclab/ffmpeg_crash/poc3 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavutil/opt.c | 6 +

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: free the infe allocated item data on failure

2024-04-30 Thread James Almer
On 4/30/2024 6:26 PM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 08:17:37PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavformat/mov.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) fixes 68212/clusterfuzz-testcase-minimized-f

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/atrac9dec: Check init_get_bits8() for failure

2024-04-30 Thread Michael Niedermayer
On Sun, Apr 28, 2024 at 11:41:48PM +0200, Lynne wrote: > Apr 28, 2024, 23:31 by mich...@niedermayer.cc: > > > Fixes: CID1439569 Unchecked return value > > Fixes: CID1439578 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavco

Re: [FFmpeg-devel] [PATCH] avformat/iamfdec: check nb_streams in header read

2024-04-30 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 08:58:22PM -0300, James Almer wrote: > On 4/27/2024 3:51 PM, Michael Niedermayer wrote: > > Fixes: Assertion pkt->stream_index < (unsigned)s->nb_streams && "Invalid > > stream index.\n" failed at libavformat/demux.c:572 > > Fixes: > > 67890/clusterfuzz-testcase-minimized-f

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Andrew Sayers
On Tue, Apr 30, 2024 at 09:05:05PM +0200, Ondřej Fiala wrote: > On Mon Apr 29, 2024 at 9:04 PM CEST, Davy Durham wrote: > > Presently do you not have to create an account on the devel mailing list to > > contribute to ffmpeg? > > > > So on the flip side, I (actually) find it just as annoying to hav

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread Michael Niedermayer
On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > This allows detecting issues in side data related code, same as what > > > > fra

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread James Almer
On 4/30/2024 8:25 PM, Michael Niedermayer wrote: On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: This allows detecting issues in side data rel

Re: [FFmpeg-devel] [PATCH v3] lavu/opt: Clarify the scope of AVOptions

2024-04-30 Thread Michael Niedermayer
On Wed, Apr 24, 2024 at 08:30:28AM +0100, Andrew Sayers wrote: > See discussion on the mailing list: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/326054.html > --- > libavutil/opt.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h >

Re: [FFmpeg-devel] [PATCH] doc/Doxfyile: Refactor for maintainability

2024-04-30 Thread Andrew Sayers
On Tue, Apr 30, 2024 at 07:26:39PM +0200, Michael Niedermayer wrote: > On Mon, Apr 29, 2024 at 09:53:13AM +0100, Andrew Sayers wrote: > > On Sun, Apr 28, 2024 at 11:46:18PM +0200, Michael Niedermayer wrote: > > > Hi > > > > > > On Sun, Apr 28, 2024 at 11:10:22AM +0100, Andrew Sayers wrote: > > > [

Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

2024-04-30 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 09:14:16AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1397741 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/avfiltergraph.c | 2 +- > > 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH 3/3] avutil/opt: Preserve nb_channels in opt_free

2024-04-30 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 06:27:23PM -0300, James Almer wrote: > On 4/29/2024 9:48 PM, Michael Niedermayer wrote: > > Fixes: division by 0 > > Fixes: decoder modifying demuxer channels on failure > > Fixes: -sseof -5 -i zgclab/ffmpeg_crash/poc3 > > > > Found-by: Wang Dawei and Zhou Geng, from Zhongg

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: > On 4/30/2024 8:25 PM, Michael Niedermayer wrote: > > On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > > > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhard

Re: [FFmpeg-devel] [PATCH 3/3] avutil/opt: Preserve nb_channels in opt_free

2024-04-30 Thread James Almer
On 4/30/2024 9:38 PM, Michael Niedermayer wrote: On Tue, Apr 30, 2024 at 06:27:23PM -0300, James Almer wrote: On 4/29/2024 9:48 PM, Michael Niedermayer wrote: Fixes: division by 0 Fixes: decoder modifying demuxer channels on failure Fixes: -sseof -5 -i zgclab/ffmpeg_crash/poc3 Found-by: Wang D

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread James Almer
On 4/30/2024 9:40 PM, Michael Niedermayer wrote: On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: On 4/30/2024 8:25 PM, Michael Niedermayer wrote: On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at

[FFmpeg-devel] [PATCH] avformat/mov: don't use stream duration to calculate bitrate with fragmented input

2024-04-30 Thread James Almer
sc->data_size may contain the size of a single fragment after probing, and using it alongside the duration of the entire stream to calculate bitrate will result in a bogus small value. Before: Duration: 00:00:05.00, start: 0.00, bitrate: 586 kb/s Stream #0:0[0x1](und): Video: h264 (High) (

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-30 Thread Rémi Denis-Courmont
Hi, Le 30 avril 2024 22:15:10 GMT+03:00, "Ondřej Fiala" a écrit  : >On Tue Apr 30, 2024 at 9:06 PM CEST, Hendrik Leppkes wrote: >> I will take the replacement instead, thanks. Email is archaic. The >> entire point is to get away from email, not dress it up. >> SourceHut usage would likely make me

[FFmpeg-devel] [PATCH 3/3] lavc/ac3dsp: R-V V min_exponents

2024-04-30 Thread Rémi Denis-Courmont
T-Head C908: ac3_exponent_min_reuse0_c: 7.5 ac3_exponent_min_reuse0_rvv_i32: 7.5 ac3_exponent_min_reuse1_c: 1820.7 ac3_exponent_min_reuse1_rvv_i32: 102.5 ac3_exponent_min_reuse2_c: 3088.5 ac3_exponent_min_reuse2_rvv_i32: 138.7 ac3_exponent_min_reuse3_c: 5073.7 ac3_exponent_

[FFmpeg-devel] [PATCH] avfilter/colorize: add speed option

2024-04-30 Thread Yannis Gerlach
The speed option allows to have a constant (per frame) change of hue. This allows for an easy way of creating an color changing effect without relying on somewhat complicated expressions. Signed-off-by: Yannis Gerlach --- libavfilter/vf_colorize.c | 17 + 1 file changed, 13 in