Re: [FFmpeg-devel] [RFC] financial sustainability Plan A (SPI)

On 26-10-2023 17:45, Michael Niedermayer wrote: To help 2. we should favor flashy, cool development that can bring in more donations Wouldn't it make more sense to fund grunt work that's needed, but no-one wants to do? I'd imagine there's more developers that like to have their name attache

Re: [FFmpeg-devel] [PATCH 2/2] aacdec: correctly skip padding at the start of frames and during seeking

Hello, Does this fix #2325 #9667? jb On Mon, 30 Oct 2023, at 06:10, Lynne wrote: > Presently, our AAC decoder didn't skip any samples, unless the side data > contained skip information. > > This uses the newly added ff_decoder_skip_samples function to skip samples > on two levels: base, and addi

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

Leo Izen (12023-10-29): > But it will be nul-terminated in either case, so > there's no real difference between the old and new code, other than the > warning. No real difference = you are not fixing the bug. There should be a difference: user data should not be silently tr

[FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: fix run on macOS

From: Zhao Zhili VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME is required on macOS, and VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR flag should be set. --- libavutil/hwcontext_vulkan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

Hello, On Sun, 29 Oct 2023, at 10:33, Anton Khirnov wrote: > vote question (unchanged): > How do we update the list of active members of the general assembly? > > Available answers: > * twice a year (1st Jan & 1st July, 0:00 UTC); > as an exception, the list will also be updated immediately

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Restrict disabling automatic copying of metadata

Fixes ticket #10638 and restores the behaviour from before 3c7dd5ed37da6d2de06c4850de5a319ca9cdd47f. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_mux_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c ind

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12: Remove "fast" mode

On Mon, 30 Oct 2023 at 06:41, Matthias Dressel wrote: > On 29.10.23 16:43, Kieran Kunhya wrote: > > $subj as discussed at VDD > > > > Kieran > > IMHO the commit message should have contained some reason as to *why* > this was removed. > Now, someone looking at the log needs to find this patch on

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

Am 30.10.23 um 09:18 schrieb Jean-Baptiste Kempf: Hello, On Sun, 29 Oct 2023, at 10:33, Anton Khirnov wrote: vote question (unchanged): How do we update the list of active members of the general assembly? Available answers: * twice a year (1st Jan & 1st July, 0:00 UTC); as an exception

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

On Mon, 30 Oct 2023, at 11:33, Thilo Borgmann via ffmpeg-devel wrote: > Am 30.10.23 um 09:18 schrieb Jean-Baptiste Kempf: >> Hello, >> >> On Sun, 29 Oct 2023, at 10:33, Anton Khirnov wrote: >>> vote question (unchanged): >>> How do we update the list of active members of the general assembly?

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

Am 30.10.23 um 11:50 schrieb Jean-Baptiste Kempf: On Mon, 30 Oct 2023, at 11:33, Thilo Borgmann via ffmpeg-devel wrote: Am 30.10.23 um 09:18 schrieb Jean-Baptiste Kempf: Hello, On Sun, 29 Oct 2023, at 10:33, Anton Khirnov wrote: vote question (unchanged): How do we update the list of ac

Re: [FFmpeg-devel] [PATCH 1/3] lavc/jpeg2000dsp: make coefficients extern

lör 2023-10-28 klockan 22:04 +0300 skrev Rémi Denis-Courmont: > This is so that they can be loaded from assembler, rather than > duplicated. Is loading these constants via immediates slower than the indirect load that the patchset does? /Tomas ___ ffmpe

[FFmpeg-devel] [PATCH] avcodec/mpegvideo: Remove spec-incompliant inverse quantisation

Section 7.4.4 of the MPEG-2 specifications requires that the last bit of the last coefficient be toggled so that the sum of all coefficients is odd; both our decoder and encoder did this only if the bitexact flag has been set (although stuff like this should be behind AV_CODEC_FLAG2_FAST). This pat

Re: [FFmpeg-devel] [PATCH] avcodec/mlp*: improvements

ons 2023-10-25 klockan 21:59 +0200 skrev Paul B Mahol: > On Wed, Oct 25, 2023 at 9:03 PM Tomas Härdin wrote: > > > On Wed, 2023-10-25 at 21:00 +0200, Paul B Mahol wrote: > > > On Wed, Oct 25, 2023 at 8:39 PM Tomas Härdin > > > wrote: > > > > > > > > > > > >     if (c) { > > > > >  

Re: [FFmpeg-devel] [PATCH v2] avformat: introduce AVStreamGroup

ons 2023-10-25 klockan 16:40 -0300 skrev James Almer: > On 10/25/2023 4:25 PM, Tomas Härdin wrote: > > >   > > > +enum AVStreamGroupParamsType { > > > +    AV_STREAM_GROUP_PARAMS_NONE, > > > > Maybe AV_STREAM_GROUP_PARAMS_NUM on the end? > > For what purpose? Usually, when we add those values th

Re: [FFmpeg-devel] [PATCH] avcodec/mlp*: improvements

On Mon, Oct 30, 2023 at 2:15 PM Tomas Härdin wrote: > ons 2023-10-25 klockan 21:59 +0200 skrev Paul B Mahol: > > On Wed, Oct 25, 2023 at 9:03 PM Tomas Härdin wrote: > > > > > On Wed, 2023-10-25 at 21:00 +0200, Paul B Mahol wrote: > > > > On Wed, Oct 25, 2023 at 8:39 PM Tomas Härdin > > > > wrot

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

On 10/30/23 03:51, Nicolas George wrote: Leo Izen (12023-10-29): But it will be nul-terminated in either case, so there's no real difference between the old and new code, other than the warning. No real difference = you are not fixing the bug. There should be a differ

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

Leo Izen (12023-10-30): > > difference: user data should not be silently truncated. > There isn't really a bug here, just an extraneous compiler warning. Truncating user data silently is a bug. The warning is right and needs proper fix. Regards, -- Nicolas George _

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

On 10/30/23 09:55, Nicolas George wrote: Leo Izen (12023-10-30): difference: user data should not be silently truncated. There isn't really a bug here, just an extraneous compiler warning. Truncating user data silently is a bug. The warning is right and needs proper fix. Regards, The warn

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

Leo Izen (12023-10-30): > Also, fwiw, info->assoc_language is the name of a language. It shouldn't > actually ever be 63 characters long for real streams in the wild, and > truncating it is just a memory-safety precaution. It's not a bug. It SHOULD not, but it CAN be, and properly reporting the e

Re: [FFmpeg-devel] [PATCH v2 1/5] avfilter/drawutils: ban XYZ formats

Will apply this after 24h if there is no further feedback. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "uns

[FFmpeg-devel] [PATCH v3 1/3] [PoC]avformat: introduce AVStreamGroup

Signed-off-by: James Almer --- No changes since last version. I'm resending this for the IAMF demuxer. I need opinions or reviews for this. We need to get this right from the start and i don't want to push something that will afterwards be considered unoptimal libavformat/avformat.c | 31 +

[FFmpeg-devel] [PATCH v3 2/3] avutil/mem: add av_dynarray2_add_nofree

Signed-off-by: James Almer --- No changes since last version. libavutil/mem.c | 17 + libavutil/mem.h | 32 +--- 2 files changed, 46 insertions(+), 3 deletions(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 36b8940a0c..bd37710968 100644 --- a

[FFmpeg-devel] [PATCH v3 3/3][WIP][RFC] avformat: Immersive Audio Model and Formats demuxer

Signed-off-by: James Almer --- Changes since last version: - AVOptions for most new public structs, and the helpers adapted for them. - Assorted fixes. libavcodec/avpacket.c |3 + libavcodec/packet.h | 24 + libavformat/Makefile|2 + libavformat/allformats.c|

[FFmpeg-devel] [PATCH v5] fftools/ffplay: add hwaccel decoding support

From: Zhao Zhili Add vulkan renderer via libplacebo. Simple usage: $ ffplay -hwaccel vulkan foo.mp4 Use cuda to vulkan map: $ ffplay -hwaccel cuda foo.mp4 Create vulkan instance by libplacebo, and enable debug: $ ffplay -hwaccel vulkan \ -vulkan_params create_by_placebo=1:debug=1 foo.m

Re: [FFmpeg-devel] [PATCH 2/2] aacdec: correctly skip padding at the start of frames and during seeking

Oct 30, 2023, 08:38 by j...@videolan.org: > Hello, > > Does this fix #2325 #9667? > It fully fixes the following:  - Decoding of MP4/M4A HE-AAC streams is delayed by 3009 samples  - Decoding of standalone ADTS AAC files generated by libavcodec's AAC encoder is delayed by 1024 samples It partial

Re: [FFmpeg-devel] [PATCH v5] fftools/ffplay: add hwaccel decoding support

Oct 30, 2023, 17:05 by quinkbl...@foxmail.com: > From: Zhao Zhili > > Add vulkan renderer via libplacebo. > > Simple usage: > $ ffplay -hwaccel vulkan foo.mp4 > > Use cuda to vulkan map: > $ ffplay -hwaccel cuda foo.mp4 > > Create vulkan instance by libplacebo, and enable debug: > $ ffplay -hwacc

Re: [FFmpeg-devel] [PATCH v5] fftools/ffplay: add hwaccel decoding support

On 2023/10/31 00:04, Zhao Zhili wrote: From: Zhao Zhili Add vulkan renderer via libplacebo. Simple usage: $ ffplay -hwaccel vulkan foo.mp4 Use cuda to vulkan map: $ ffplay -hwaccel cuda foo.mp4 Create vulkan instance by libplacebo, and enable debug: $ ffplay -hwaccel vulkan \ -vulk

Re: [FFmpeg-devel] [PATCH v5] fftools/ffplay: add hwaccel decoding support

On 2023/10/31 01:05, Lynne wrote: Oct 30, 2023, 17:05 by quinkbl...@foxmail.com: From: Zhao Zhili Add vulkan renderer via libplacebo. Simple usage: $ ffplay -hwaccel vulkan foo.mp4 Use cuda to vulkan map: $ ffplay -hwaccel cuda foo.mp4 Create vulkan instance by libplacebo, and enable deb

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Remove spec-incompliant inverse quantisation

On Mon, 30 Oct 2023 at 13:10, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Section 7.4.4 of the MPEG-2 specifications requires that the > last bit of the last coefficient be toggled so that the sum > of all coefficients is odd; both our decoder and encoder > did this only if the b

[FFmpeg-devel] [PATCH] avformat: add AVFMT_INIT_ZERO_SKIP flag and use it in MOV

Meant to be applied on top my AAC patchset. MOV trims both the decoder/codec's algorithmic delay, and additionally, any samples the encoder needs removed, via edit lists, which we export as skip_samples side data. The issue is that if there are no edit lists, with the recent AAC decoding algorith

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/get_bits: Avoid 2nd bitstream read in GET_VLC() if bits are known at build and small

Michael Niedermayer: > On Fri, Oct 27, 2023 at 05:10:32AM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/get_bits.h | 8 ++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavcodec/get_bits.h

Re: [FFmpeg-devel] [PATCH 01/61] avcodec/vlc: Add functions to init static VLCElem[] without VLC

Andreas Rheinhardt: > For lots of static VLCs, the number of bits is not read from > VLC.bits, but rather a compile-constant that is hardcoded > at the callsite of get_vlc2(). Only VLC.table is ever used > and not using it directly is just an unnecessary indirection. > > This commit adds helper fu

Re: [FFmpeg-devel] [PATCH v2 07/10] avfilter/vf_scale: preserve YUV range by default

On Sat, Oct 28, 2023 at 04:41:14PM +0200, Niklas Haas wrote: > From: Niklas Haas > > YUV->YUV conversions should preserve input range, if the output range is > unspecified. Ensures full-range YUV input comes out as full-range YUV > output by default, even through YUV->YUV pixel format conversions

Re: [FFmpeg-devel] [PATCH] web: move 5.0 to olddownloads

On Sun, Oct 29, 2023 at 11:34:23PM +, Cosmin Stejerean via ffmpeg-devel wrote: > > > > On Oct 20, 2023, at 9:01 AM, Michael Niedermayer > > wrote: > > > > our downstream list shows no maintained users of that release > > https://trac.ffmpeg.org/wiki/Downstreams > > I was trying to track

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/get_bits: Avoid 2nd bitstream read in GET_VLC() if bits are known at build and small

On Mon, Oct 30, 2023 at 09:49:07PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: [...] > > > > also i was wondering about a vlc reader thats entirely free of conditional > > branches. Just a loop that in each iteration would step by 0-n symbols > > forward and update a pointer to which

Re: [FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout

> On Feb 24, 2023, at 21:49, Jan Ekström wrote: > > On Fri, Feb 24, 2023 at 6:25 AM Zhao Zhili > wrote: >> >> From: Zhao Zhili mailto:zhiliz...@tencent.com>> >> >> Signed-off-by: Zhao Zhili > > > > Hah, I actually happened to rece

Re: [FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout

> On Feb 24, 2023, at 21:49, Jan Ekström wrote: > > On Fri, Feb 24, 2023 at 6:25 AM Zhao Zhili > wrote: >> >> From: Zhao Zhili mailto:zhiliz...@tencent.com>> >> >> Signed-off-by: Zhao Zhili > > > > Hah, I actually happened to rece

Re: [FFmpeg-devel] [PATCH v5] fftools/ffplay: add hwaccel decoding support

Oct 30, 2023, 18:35 by quinkbl...@foxmail.com: > > On 2023/10/31 01:05, Lynne wrote: > >> Oct 30, 2023, 17:05 by quinkbl...@foxmail.com: >> >>> From: Zhao Zhili >>> >>> Add vulkan renderer via libplacebo. >>> >>> Simple usage: >>> $ ffplay -hwaccel vulkan foo.mp4 >>> >>> Use cuda to vulkan map: >