> On Nov 14, 2022, at 15:46, tanwei (D) wrote:
>
> Fixes ticket #9949.
>
> Signed-off-by: tanwei123
> ---
> libavformat/mpegts.c| 20
> libavformat/mpegts.h| 1 +
> libavformat/rtpdec.c| 7 +++
> libavformat/rtpdec.h| 2 ++
> libavforma
Hi,
I preferred to check instead for HAVE_X86ASM, as those checks would only
hit on either a missing or crippled NASM. Moreover, the EXTERNAL_
macros do both the HAVE__EXTERNAL and the runtime CPU flag check.
The former of which would become redundant and duplicated with your
suggestion.
Should
Remove confusing references to "external" vs. "internal" developers.
---
doc/developer.texi | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index addee0d826..5cf3b19ee0 100644
--- a/doc/developer.texi
+++ b/doc/develop
Stop talking about commercial programs, since this applies to any
downstream user.
---
doc/developer.texi | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 5cf3b19ee0..2f0d2b7daa 100644
--- a/doc/developer.texi
+
It is very short and its main functions is linking to the
coding rules/submitting patches chapters.
---
doc/developer.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 2f0d2b7daa..2e050edc6a 100644
--- a/doc/developer.texi
+++ b/
Drop the reference to directly committing code, because
- it is highly discouraged and very rarely done these days
- there is no good reason NOT to submit patches for review
Add a link to the development policy chapter.
---
doc/developer.texi | 14 +-
1 file changed, 5 insertions(+),
Quoting Michael Niedermayer (2022-11-10 20:52:33)
> On Thu, Nov 10, 2022 at 01:31:44PM +0100, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2022-11-10 13:28:27)
> > > On Tue, Nov 08, 2022 at 12:25:47PM +0100, Anton Khirnov wrote:
> > > > Lavf only supports a very limited approximation of no
Will push the rest of this set soonish if noone has further comments.
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ..
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 10:13 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend the
> argument for submitting patches
>
> Stop talking about commercial progr
Quoting Soft Works (2022-11-14 10:35:40)
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Anton Khirnov
> > Sent: Monday, November 14, 2022 10:13 AM
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend the
> > argument for s
Anton Khirnov (12022-11-14):
> If noone has further objections, I'll push this patch soonish.
You will do no scu thing since it is bogus, as I explained.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailm
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 10:53 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patche
Quoting Nicolas George (2022-11-14 11:44:55)
> Anton Khirnov (12022-11-14):
> > If noone has further objections, I'll push this patch soonish.
>
> You will do no scu thing since it is bogus, as I explained.
I do not see any objections from you to this patch.
--
Anton Khirnov
___
Anton Khirnov (12022-11-14):
> I do not see any objections from you to this patch.
My explanations for the other patch apply to this one, obviously: if you
treat EAGAIN as REDO, you introduce a busy wait.
--
Nicolas George
___
ffmpeg-devel mailing li
Quoting Soft Works (2022-11-14 11:46:49)
> > Sorry, but you problems are entirely self-inflicted. You have been
> > told what changes need to happen right from the beginning,
> > repeatedly, and by several developers independently.
>
> And those are completed and settled, like I had state multiple
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Soft Works
> Sent: Wednesday, August 31, 2022 6:02 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022
>
>
>
> > -Original Message---
Quoting Nicolas George (2022-11-14 12:05:10)
> Anton Khirnov (12022-11-14):
> > I do not see any objections from you to this patch.
>
> My explanations for the other patch apply to this one, obviously: if you
> treat EAGAIN as REDO, you introduce a busy wait.
In what specific case would this supp
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 12:08 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patche
On 11/14/2022 2:58 AM, Wang, Bin wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of James Almer
Sent: Monday, November 14, 2022 10:43 AM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v7] libavfilter/x86/vf_convolution: add
sobel filter optimization and unit test
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 12:08 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patche
Anton Khirnov (12022-11-14):
> In what specific case would this supposed busy wait happen and why is it
> wrong?
See my mail from 9 Nov 2022 13:42:24 +0100 for explanations about the
semantic of EAGAIN.
--
Nicolas George
___
ffmpeg-devel mailing list
Anton Khirnov (12022-11-14):
> In your last resend, Hendrik yet again raised the start_pts question. As
> far as I can tell, your explanation for why it's supposedly needed did
> not convince ANYONE.
Not only that: this series is completely broken with regard to
negotiation, scheduling and utility
On 11/4/2022 5:29 AM, bin.wang-at-intel@ffmpeg.org wrote:
+.loop2:
+xor rd, rd
+pxor m4, m4
+
+;Gx
+SOBEL_MUL 0, data_n1
+SOBEL_MUL 1, data_n2
+SOBEL_MUL 2, data_n1
+SOBEL_ADD 6
+SOBEL_MUL 7, data_p2
+SOBEL_ADD 8
+
+cvtsi2ss xmm4, rd
+mulssxmm4
> By using xmm# you're not taking into account any x86inc SWAPing, so this is
> using xmm0 and xmm1 where the single scalar float input arguments reside (at
> least on unix64), instead of xm0 and xm1 (xmm16 and xmm17) where the
> broadcasted scalars were stored.
> This, again, only worked by chance
On 11/14/2022 10:30 AM, Wang, Bin wrote:
By using xmm# you're not taking into account any x86inc SWAPing, so this is
using xmm0 and xmm1 where the single scalar float input arguments reside (at
least on unix64), instead of xm0 and xm1 (xmm16 and xmm17) where the
broadcasted scalars were stored.
T
> -Original Message-
> From: ffmpeg-devel On Behalf Of James
> Almer
> Sent: Monday, November 14, 2022 9:36 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v7] libavfilter/x86/vf_convolution: add
> sobel filter optimization and unit test with intel AVX512 VNNI
>
>
On 11/14/2022 10:54 AM, Wang, Bin wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of James
Almer
Sent: Monday, November 14, 2022 9:36 PM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v7] libavfilter/x86/vf_convolution: add
sobel filter optimization and unit tes
Quoting Soft Works (2022-11-14 12:20:00)
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Anton Khirnov
> > Sent: Monday, November 14, 2022 12:08 PM
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/d
From: "Wang, Bin"
Signed-off-by: Wang, Bin
---
libavfilter/x86/vf_convolution.asm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavfilter/x86/vf_convolution.asm
b/libavfilter/x86/vf_convolution.asm
index c912d56752..a6be95690b 100644
--- a/libavfilter/x86/vf_convo
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 3:35 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patches
The inner loop never goes through more than 1 iteration, and so can be
replaced by an if().
Found-by: Andreas Rheinhardt
---
fftools/ffmpeg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index e6f6773f6a..0fa2fe8c52 100644
--- a/fftools/f
---
fftools/ffmpeg_mux_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index 7ccaf9da78..6ed30eb498 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -1727,6 +1727,8 @@ static int set_dispo
It cannot be true since 1959351aecf. Effectively reverts 6a3833e1411.
---
fftools/ffmpeg.h | 1 -
fftools/ffmpeg_demux.c| 2 --
fftools/ffmpeg_mux_init.c | 6 --
fftools/ffmpeg_opt.c | 5 -
4 files changed, 14 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
Frame limiting is now handled using sync queues. This code prevents the
sync queue from triggering EOF, resulting in unnecessarily many frames
being decoded, filtered, and then discarded.
Found-by: U. Artie Eoff
---
fftools/ffmpeg.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions
---
fftools/ffmpeg.h | 2 +-
fftools/ffmpeg_mux_init.c | 91 +--
fftools/ffmpeg_opt.c | 2 +-
3 files changed, 51 insertions(+), 44 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index ad53ad4ce8..b9262b373f 100644
--- a/fftools/f
Specificaly, the of_add_attachments() call (which can add attachment
streams to the output) and the check whether the output file contains
any streams. They both logically belong in create_streams().
---
fftools/ffmpeg_mux_init.c | 99 ---
1 file changed, 50 ins
It no longer needs to be visible outside of the muxing code.
---
fftools/ffmpeg.h | 1 -
fftools/ffmpeg_mux.c | 5 -
fftools/ffmpeg_mux.h | 7 +++
fftools/ffmpeg_mux_init.c | 23 +--
4 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/
---
fftools/ffmpeg_mux_init.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index 6ed30eb498..277cbd1f64 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -1737,13 +1737,12 @@ static void valid
On 11/14/22, Soft Works wrote:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of
>> Anton Khirnov
>> Sent: Monday, November 14, 2022 3:35 PM
>> To: FFmpeg development discussions and patches > de...@ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: exte
> >> On 11/14/2022 10:30 AM, Wang, Bin wrote:
> By using xmm# you're not taking into account any x86inc SWAPing, so
> this is using xmm0 and xmm1 where the single scalar float input
> arguments reside (at least on unix64), instead of xm0 and xm1
> (xmm16 and xmm17) where the bro
On 11/14/2022 11:35 AM, bin.wang-at-intel@ffmpeg.org wrote:
From: "Wang, Bin"
Signed-off-by: Wang, Bin
---
libavfilter/x86/vf_convolution.asm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavfilter/x86/vf_convolution.asm
b/libavfilter/x86/vf_convolution.as
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Paul B Mahol
> Sent: Monday, November 14, 2022 4:18 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patches
From: "Wang, Bin"
Signed-off-by: Wang, Bin
---
libavfilter/x86/vf_convolution.asm | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavfilter/x86/vf_convolution.asm
b/libavfilter/x86/vf_convolution.asm
index c912d56752..9ac9ef5d73 100644
--- a/libavfilter/x86/vf
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Paul B Mahol
> Sent: Monday, November 14, 2022 4:18 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patches
Quoting Soft Works (2022-11-14 16:13:29)
> > I did read your document, and my takeaway message from it is "doing
> > it
> > properly is too hard". As long as that continues to be your position,
> > you might as well not bother.
>
> This is ridiculous, and you know that. Or at least you would know
Quoting Nicolas George (2022-11-14 13:40:35)
> Anton Khirnov (12022-11-14):
> > In what specific case would this supposed busy wait happen and why is it
> > wrong?
>
> See my mail from 9 Nov 2022 13:42:24 +0100 for explanations about the
> semantic of EAGAIN.
You wrote a whole lot of text and I d
Anton Khirnov (12022-11-14):
> You wrote a whole lot of text and I don't see how any of it applies to
> this patch.
>
> The standard convention everywhere is that IO may return EAGAIN in
> non-blocking mode and blocks otherwise. And that is exactly what this
> patch implements.
To implement block
Quoting Marton Balint (2022-11-13 19:44:41)
> Signed-off-by: Marton Balint
> ---
> doc/demuxers.texi| 18
> libavformat/electronicarts.c | 42 +++-
> libavformat/version.h| 2 +-
> 3 files changed, 56 insertions(+), 6 deletions
On 11/14/2022 12:20 PM, bin.wang-at-intel@ffmpeg.org wrote:
From: "Wang, Bin"
Signed-off-by: Wang, Bin
---
libavfilter/x86/vf_convolution.asm | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavfilter/x86/vf_convolution.asm
b/libavfilter/x86/vf_convolut
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 5:14 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patches
Soft Works (12022-11-14):
> What are your points? Which are your objections? Please show the
> code that you think is wrong and say how it should be done instead.
For the record, I have, multiple times.
--
Nicolas George
___
ffmpeg-devel mailing lis
Hello here is the work I have pushed in a fork of FFmpeg integrated in
source code of xuggler (a Java/C++ wrapper of FFmpeg)
https://github.com/olivierayache/xuggle-xuggler/commit/98469ebea59c921f46a114bd954f7a27a7c95a41
For the limitations of NDK I agree with you and that is why I have made
some
Quoting mindm...@gmail.com (2022-10-02 01:05:12)
> From: Mark Reid
>
> floating point uses a slightly different predictor technique describe here
> http://chriscox.org/TIFFTN3d1.pdf
>
> Here is a link the test files, if someone could add them to fate me
> https://www.dropbox.com/s/fg59h2os4gb4wu
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Monday, November 14, 2022 5:40 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting patches
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 4:14 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: simplify
> ost_iter()
>
> The inner loop never goes through more than 1 iteration, and so
Soft Works (12022-11-14):
> You’ve been destructive from the very first moment when you realized
> that I was going to do something that you had been planning for a
> long time.
I would have been very happy if you had worked on doing properly, or at
least in a way compatible with doing it proper
On Sun, Nov 13, 2022 at 22:57:22 +0100, Oneric wrote:
> On Sun, Nov 13, 2022 at 21:01:34 +, Soft Works wrote:
> > I am unable to apply any of those patches. Neither v1 nor v2 neither
> > when downloading the series mbox or [2/3] from patchwork nor when
> > saving [2/3] from the e-mail.
>
> Re
On 11/14/22, Michael Niedermayer wrote:
> On Sun, Nov 06, 2022 at 07:28:48PM +0100, Paul B Mahol wrote:
>> On 11/6/22, Michael Niedermayer wrote:
>> > This case seems not to match the reference decoder and it also
>> > seems not reachable
>> >
>> > Signed-off-by: Michael Niedermayer
>> > ---
>>
On Mon, 14 Nov 2022, Anton Khirnov wrote:
Quoting Marton Balint (2022-11-13 19:44:41)
Signed-off-by: Marton Balint
---
doc/demuxers.texi| 18
libavformat/electronicarts.c | 42 +++-
libavformat/version.h| 2 +-
3 files c
On Mon, Nov 14, 2022 at 1:08 PM Michael Niedermayer
wrote:
> On Sun, Nov 13, 2022 at 05:50:37PM -0800, Mark Reid wrote:
> > On Sun, Nov 13, 2022 at 1:25 PM Michael Niedermayer <
> mich...@niedermayer.cc>
> > wrote:
> >
> > > On Wed, Nov 02, 2022 at 09:00:07PM -0700, mindm...@gmail.com wrote:
> >
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Monday, November 14, 2022 11:06 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] doc/developer.texi: extend
> the argument for submitting
61 matches
Mail list logo
