> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
> Anton Khirnov
> Sent: Monday, November 14, 2022 4:14 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: simplify
> ost_iter()
>
> The inner loop never goes through more than 1 iteration, and so can
> be
> replaced by an if().
>
> Found-by: Andreas Rheinhardt
> ---
> fftools/ffmpeg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index e6f6773f6a..0fa2fe8c52 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -612,7 +612,7 @@ static OutputStream *ost_iter(OutputStream *prev)
>
> for (; of_idx < nb_output_files; of_idx++) {
> OutputFile *of = output_files[of_idx];
> - for (; ost_idx < of->nb_streams; ost_idx++)
> + if (ost_idx < of->nb_streams)
> return of->streams[ost_idx];
>
> ost_idx = 0;
> --
> 2.35.1
I'm objecting the whole patchset.
I think it's not fundamental enough.
softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
