Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Nicolas George
Soft Works (12021-09-11): > v3 Update: > > - Reworked, revised, rebased, reorganized, refactored > - No more prototype/test-style code > - Additional subtitle filters added > - Filter documentation added > - Adjusted FATE tests Changes that add a third media type to libavfilter will not be accept

[FFmpeg-devel] [PATCH v4 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
v4 Update: - Re-sending due to Patchwork having failed to parse my patchset There seems to be a bug in Patchwork when parallel processing is enabled. This time, I'll send the e-mails slowly, one after another. v3 Update: - Reworked, revised, rebased, reorganized, refactored - No more pro

[FFmpeg-devel] [PATCH v4 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
This is the root commit for adding subtitle filtering capabilities. Adding the media type property to AVFrame replaces the previous way of distinction which was based on checking width and height to determine whether a frame is audio or video. Signed-off-by: softworkz --- libavutil/frame.c | 7

[FFmpeg-devel] [PATCH v4 02/18] avutil/subfmt: Move AVSubtitleType, AVSubtitle and AVSubtitleRect to avutil

2021-09-11 Thread Soft Works
Moving these type to avutil - analog to e.g. samplefmt, pixfmt Signed-off-by: softworkz --- libavutil/Makefile | 2 + libavutil/subfmt.c | 78 libavutil/subfmt.h | 125 + 3 files changed, 205 insertions(+) create mode 1

[FFmpeg-devel] [PATCH v4 03/18] avcodec/avcodec: Remove AVSubtitleType, AVSubtitle and AVSubtitleRect from avcodec

2021-09-11 Thread Soft Works
Moved to libavutil/subfmt, include subfmt.h from avcodec.h Signed-off-by: softworkz --- libavcodec/ass.c | 2 +- libavcodec/ass.h | 6 +-- libavcodec/assdec.c | 2 +- libavcodec/assenc.c | 4 +- libavcodec/avcodec.c | 19 -

[FFmpeg-devel] [PATCH v4 04/18] avcodec/avcodec: Add av_get_subtitle_format_from_codecdesc function

2021-09-11 Thread Soft Works
Introduce a single place for deriving an AVSubtitleType from AV_CODEC_PROP_xxx Signed-off-by: softworkz --- libavcodec/avcodec.h | 8 libavcodec/decode.c | 5 + libavcodec/utils.c | 11 +++ 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/libavcodec/avcod

[FFmpeg-devel] [PATCH v4 05/18] avcodec/avcodec: Remove sub_text_format parameter

2021-09-11 Thread Soft Works
It has never been used and going forward, there's no perspective that it would ever be. Signed-off-by: softworkz --- libavcodec/avcodec.h | 8 libavcodec/options_table.h | 2 -- libavcodec/version.h | 4 ++-- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH v4 06/18] avcodec/ass_split: Extend ass dialog parsing

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/ass_split.c | 12 ++-- libavcodec/ass_split.h | 2 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index 05c5453e53..e58585d3da 100644 --- a/libavcodec/ass_split.c +++ b/libavcodec/

[FFmpeg-devel] [PATCH v4 07/18] fftools/play, probe: Adjust for subtitle format type change

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 2 +- fftools/ffprobe.c | 23 ++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 46758b9f55..f6a4d242c3 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2250,7

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 10:09 AM Nicolas George wrote: > Soft Works (12021-09-11): > > v3 Update: > > > > - Reworked, revised, rebased, reorganized, refactored > > - No more prototype/test-style code > > - Additional subtitle filters added > > - Filter documentation added > > - Adjusted FATE test

[FFmpeg-devel] [PATCH v4 08/18] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffmpeg.c| 408 +--- fftools/ffmpeg.h| 12 +- fftools/ffmpeg_filter.c | 198 +-- fftools/ffmpeg_hw.c | 2 +- fftools/ffmpeg_opt.c| 3 +- 5 files changed, 323 insertions(+), 300 del

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Nicolas George
Paul B Mahol (12021-09-11): > Please stop immediately with your immature and childish behavior! > > Patches are welcome, if you do not like them, just leave project for once. > > Not welcoming patch - not welcomed to project. Patches that make the long-term maintenance harder for the sake of a q

[FFmpeg-devel] [PATCH v4 09/18] avfilter/subtitles: Add subtitles.c

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/Makefile | 1 + libavfilter/f_interleave.c | 3 ++ libavfilter/internal.h | 1 + libavfilter/subtitles.c| 61 ++ libavfilter/subtitles.h| 44 +++ 5 files changed, 110 insertio

[FFmpeg-devel] [PATCH v4 10/18] avfilter/avfilter: Handle subtitle frames

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 14 ++ libavfilter/formats.h | 3 +++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilt

[FFmpeg-devel] [PATCH v4 11/18] avfilter/subtitles: adjust for recent changes

2021-09-11 Thread Soft Works
- use new function av_get_subtitle_format_from_codecdesc - change error message - remove obsolete 'sub_text_format' parameter Signed-off-by: softworkz --- libavfilter/vf_subtitles.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_subtitles.c b/li

[FFmpeg-devel] [PATCH v4 12/18] avfilter/sbuffer: Add sbuffersrv and sbuffersink filters

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 10 +++--- libavfilter/buffersink.c | 63 +++ libavfilter/buffersink.h | 15 + libavfilter/buffersrc.c | 72 libavfilter/buff

[FFmpeg-devel] [PATCH v4 13/18] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_overlay_graphicsubs.c | 740 +++ 3 files changed, 744 insertions(+) create mode 100644 libavfilter/vf_overlay_graphicsubs.c diff --git

[FFmpeg-devel] [PATCH v4 14/18] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- configure | 2 + libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/avfilter.c| 18 +- libavfilter/vf_overlay_textsubs.c | 633 ++ 5 files changed, 652 in

[FFmpeg-devel] [PATCH v4 15/18] avfilter/textmod: Add textmod filter

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/Makefile | 3 + libavfilter/allfilters.c | 1 + libavfilter/sf_textmod.c | 409 +++ 3 files changed, 413 insertions(+) create mode 100644 libavfilter/sf_textmod.c diff --git a/libavfilter/Makefile b/libavfilter

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Hendrik Leppkes
On Sat, Sep 11, 2021 at 8:02 AM Soft Works wrote: > > At a future point in time, it might make sense merge AVSubtitle into > AVFrame. I haven't done that yet to avoid cluttering the patchset with > too much distraction and keep focus on the relevant changes. > Actually I would want to see subtitl

[FFmpeg-devel] [PATCH v4 16/18] avfilter/stripstyles: Add stripstyles filter

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 246 +++ 3 files changed, 248 insertions(+) create mode 100644 libavfilter/sf_stripstyles.c diff --git a/libavfilter/Makefile b

[FFmpeg-devel] [PATCH v4 17/18] docs/filters: Add documentation for all new subtitle filters

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- doc/filters.texi | 263 +++ 1 file changed, 263 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 9ad6031d23..a7b80acada 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -25016,6 +25016,269 @@ tool

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Nicolas George
Hendrik Leppkes (12021-09-11): > Actually I would want to see subtitles to fully move into AVFrames > before any filtering, if at all, and not half-assed. That means fully > convert avcodec, deprecate AVSubtitle entirely (and not just shove it > into AVFrame->data), and make them a first-class citi

[FFmpeg-devel] [PATCH v4 18/18] tests/fate: Update subtitle tests

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- tests/ref/fate/filter-overlay-dvdsub-2397 | 181 +++--- tests/ref/fate/sub-dvb| 162 ++- tests/ref/fate/sub2video | 178 - tests/ref/fate/sub2video_basic| 93 ++--

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, 11 September 2021 10:10 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > Soft Works (12021-09-11): > > v3 U

Re: [FFmpeg-devel] [PATCH v4 00/18] Subtitle Filtering

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > v4 Update: > > - Re-sending due to Patchwork having failed to parse my patchset > There seems to be a bug in Patchwork when parallel processing is > enabled. > This time, I'll send the e-mails slowly, one after another. > The reason is that there are no in-reply-to headers

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, 11 September 2021 10:22 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > On Sat, Sep 11, 2021 at 10:09 AM Nic

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Nicolas George
Soft Works (12021-09-11): > I tried to talk to you about it - you insulted me instead of being > collaborative, so this is out of question for me now. I have not insulted you, and I do not even understand what "being collaborative" means and how it might be an insult. This is the second time that

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, 11 September 2021 10:25 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > Paul B Mahol (12021-09-11): > > Pl

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Nicolas George
Soft Works (12021-09-11): > It's no longer quick and dirty. Please be specific and I'll try to > apply such changes. Adding subtitles support must be done in a way that does not require all utility filters to be declined in a third variant: concat, showinfo, setts, split, etc., must be able to det

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Saturday, 11 September 2021 10:40 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > On Sat, Sep 11, 2021 at 8:02 AM S

Re: [FFmpeg-devel] [PATCH v4 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, 11 September 2021 11:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 00/18] Subtitle Filtering > > Soft Works: > > v4 Update: > > > > - Re-sending due to Patchwork hav

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, 11 September 2021 11:21 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > Soft Works (12021-09-11): > > I tr

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Saturday, 11 September 2021 11:28 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > Soft Works (12021-09-11): > > It's

[FFmpeg-devel] [RFC] Reconnect and PUT file continue by ffmpeg base https on windows

2021-09-11 Thread Steven Liu
Hello everyone, There have two tickets about Reconnect and PUT file continue by hlsenc. The first one is https://trac.ffmpeg.org/ticket/7975. It be fixed use the way ff_http_get_shutdown_status after furl_shutdown, But it get second problem. The ff_http_get_shutdown_status will

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Hendrik Leppkes
On Sat, Sep 11, 2021 at 11:28 AM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Hendrik Leppkes > > Sent: Saturday, 11 September 2021 10:40 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATC

Re: [FFmpeg-devel] [PATCH v4 18/18] tests/fate: Update subtitle tests

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > Signed-off-by: softworkz > --- > tests/ref/fate/filter-overlay-dvdsub-2397 | 181 +++--- > tests/ref/fate/sub-dvb| 162 ++- > tests/ref/fate/sub2video | 178 - > tests/ref/fate/sub2video_basic

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Saturday, 11 September 2021 11:55 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering > > On Sat, Sep 11, 2021 at 11:28 AM

Re: [FFmpeg-devel] [PATCH v4 18/18] tests/fate: Update subtitle tests

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, 11 September 2021 12:02 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 18/18] tests/fate: Update > subtitle tests > > Soft Works: > > Signed-off-by: softworkz > > --- >

Re: [FFmpeg-devel] [PATCH v4 17/18] docs/filters: Add documentation for all new subtitle filters

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > Signed-off-by: softworkz > --- > doc/filters.texi | 263 +++ > 1 file changed, 263 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 9ad6031d23..a7b80acada 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi

Re: [FFmpeg-devel] [PATCH v4 17/18] docs/filters: Add documentation for all new subtitle filters

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, 11 September 2021 12:20 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 17/18] docs/filters: Add > documentation for all new subtitle filters > > Soft Works: > > Signed-o

Re: [FFmpeg-devel] [PATCH v3 00/18] Subtitle Filtering

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 11:28 AM Nicolas George wrote: > Soft Works (12021-09-11): > > It's no longer quick and dirty. Please be specific and I'll try to > > apply such changes. > > Adding subtitles support must be done in a way that does not require all > utility filters to be declined in a thir

Re: [FFmpeg-devel] [PATCH v4 18/18] tests/fate: Update subtitle tests

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Saturday, 11 September 2021 12:02 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v4 18/18] tests/fate: Update >> subtitle tests >> >> Soft Works: >>> Signed-off-b

Re: [FFmpeg-devel] [PATCH v4 16/18] avfilter/stripstyles: Add stripstyles filter

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 10:40 AM Soft Works wrote: > Signed-off-by: softworkz > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/sf_stripstyles.c | 246 +++ > 3 files changed, 248 insertions(+) > create mode 10064

Re: [FFmpeg-devel] [PATCH v4 05/18] avcodec/avcodec: Remove sub_text_format parameter

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > It has never been used and going forward, there's no perspective > that it would ever be. > > Signed-off-by: softworkz > --- > libavcodec/avcodec.h | 8 > libavcodec/options_table.h | 2 -- > libavcodec/version.h | 4 ++-- > 3 files changed, 2 insertions(+), 12

Re: [FFmpeg-devel] [PATCH v4 13/18] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-11 Thread Paul B Mahol
You are still duplicating core overlaying code from overlay filter, among other things. Filter should be in same file as vf_overlay filter, this is more demanding to do because its harder than code extraction/copy&paste and adding defines and extra variables/functions for different paths.

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 8:03 AM Soft Works wrote: > This is the root commit for adding subtitle filtering capabilities. > Adding the media type property to AVFrame replaces the previous > way of distinction which was based on checking width and height > to determine whether a frame is audio or vi

Re: [FFmpeg-devel] [WIP] [RFC] [PATCH] avfilter: add audio psychoacoustic clipper

2021-09-11 Thread Paul B Mahol
Will apply improved version soon! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [WIP] [RFC] [PATCH] avfilter: add audio psychoacoustic clipper

2021-09-11 Thread Nicolas George
Paul B Mahol (12021-09-11): > Will apply improved version soon! Why do you not send the final version for review on the list? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://f

Re: [FFmpeg-devel] [PATCH v4 05/18] avcodec/avcodec: Remove sub_text_format parameter

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, 11 September 2021 12:39 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4 05/18] avcodec/avcodec: Remove > sub_text_format parameter > > Soft Works: > > It has never been u

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, 11 September 2021 12:51 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle > Filtering - Add AVMediaType propert

Re: [FFmpeg-devel] [PATCH v4 13/18] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, 11 September 2021 12:49 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 13/18] > avfilter/overlay_graphicsubs: Add overlay_graphicsubs and

Re: [FFmpeg-devel] [PATCH v4 13/18] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 8:42 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Paul B Mahol > > Sent: Saturday, 11 September 2021 12:49 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v4

Re: [FFmpeg-devel] [PATCH v4 13/18] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, 11 September 2021 21:00 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 13/18] > avfilter/overlay_graphicsubs: Add overlay_graphicsubs and

[FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2021-09-11 Thread Paul B Mahol
From: bnnm Fixes trac issue #7473. Removes encoder delay (skip samples) and writes remaining frame samples after EOF to get correct sample count. Output is now accurate vs players that use Microsoft's codecs (Windows Media Format Runtime). Tested vs encode>decode WMAv2 with MS's codecs and m

[FFmpeg-devel] Structuring Commits in a Patchset

2021-09-11 Thread Soft Works
Hi, I have a question about structuring my patchset . IIUC, commits inside a patchset must be separated by library. Now, Andreas mentioned that every single commit in a patchset needs to pass FATE/compilation. What if both cannot be achieved at the same time, like when commit1 for libA breaks li

Re: [FFmpeg-devel] Structuring Commits in a Patchset

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > Hi, > > I have a question about structuring my patchset . > > IIUC, commits inside a patchset must be separated by library. Now, Andreas > mentioned that every single commit in a patchset needs to pass > FATE/compilation. > > What if both cannot be achieved at the same time, like

Re: [FFmpeg-devel] [PATCH v4 05/18] avcodec/avcodec: Remove sub_text_format parameter

2021-09-11 Thread Hendrik Leppkes
On Sat, Sep 11, 2021 at 8:25 PM Soft Works wrote: > > I had thought that FATE needs pass only for the whole patchset > not for individual commits. > Each commit needs to compile and pass FATE, if only for bisecting issues later, which is a giant pain if there is unrelated issues in between, even

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Hendrik Leppkes
On Sat, Sep 11, 2021 at 8:31 PM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Paul B Mahol > > Sent: Saturday, 11 September 2021 12:51 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v3

Re: [FFmpeg-devel] Structuring Commits in a Patchset

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, 11 September 2021 23:02 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Structuring Commits in a Patchset > > Soft Works: > > Hi, > > > > I have a question about structuring my pat

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Saturday, 11 September 2021 23:42 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle > Filtering - Add AVMediaType prop

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 11:43 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Hendrik Leppkes > > Sent: Saturday, 11 September 2021 23:42 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH

Re: [FFmpeg-devel] Structuring Commits in a Patchset

2021-09-11 Thread Paul B Mahol
On Sat, Sep 11, 2021 at 11:42 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Andreas Rheinhardt > > Sent: Saturday, 11 September 2021 23:02 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] Structuring Commits in a Patchset > > > > S

Re: [FFmpeg-devel] Structuring Commits in a Patchset

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Saturday, 11 September 2021 23:02 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] Structuring Commits in a Patchset >> >> Soft Works: >>> Hi, >>> >>> I have a question ab

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, 11 September 2021 23:45 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle > Filtering - Add AVMediaType propert

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Paul B Mahol >> Sent: Saturday, 11 September 2021 23:45 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle >> Filtering -

Re: [FFmpeg-devel] Structuring Commits in a Patchset

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Saturday, 11 September 2021 23:51 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Structuring Commits in a Patchset > > Soft Works: > > > > > >> -Original Message- > >> From: ffmpeg-

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, 12 September 2021 00:03 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle > Filtering - Add AVMediaType property to AVFrame > > Soft Works: > >

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Paul B Mahol
On Sun, Sep 12, 2021 at 12:02 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Soft Works: > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Paul B Mahol > >> Sent: Saturday, 11 September 2021 23:45 > >> To: FFmpeg development discussions and patche

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Andreas Rheinhardt
Paul B Mahol: > On Sun, Sep 12, 2021 at 12:02 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Soft Works: >>> >>> -Original Message- From: ffmpeg-devel On Behalf Of Paul B Mahol Sent: Saturday, 11 September 2021 23:45 To: FFmpeg development d

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Sunday, 12 September 2021 00:03 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle >> Filtering - Add AVMediaType property to AVFrame

Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, 12 September 2021 00:17 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 01/18] avutil/frame: Subtitle > Filtering - Add AVMediaType property to AVFrame > > Paul B Mahol: >

[FFmpeg-devel] [PATCH 01/39] avfilter/vf_maskedminmax: Simplify init

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_maskedminmax.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_maskedminmax.c b/libavfilter/vf_maskedminmax.c index afac145e2a..f0c499a0d5 100644 --- a/libavfilter/vf_maskedminmax.c +++ b/libavfilter/vf

[FFmpeg-devel] [PATCH 02/39] avfilter/internal: Add AVFILTER_DEFINE_CLASS_EXT

2021-09-11 Thread Andreas Rheinhardt
This macro will allow to share options between AVClasses without having to redefine the option name (as is currently done) and will also allow to share the AVClasses itself (which is possible now that AVClass.child_class_next is gone). Signed-off-by: Andreas Rheinhardt --- libavfilter/internal.h

[FFmpeg-devel] [PATCH 03/39] avfilter/af_agate: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_agate.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_agate.c b/libavfilter/af_agate.c index 0dc28ac080..284880833a 100644 --- a/libavfilter/af_agate.c +++ b/libavfilter/af_agate.c @@ -86,6 +86,

[FFmpeg-devel] [PATCH 04/39] avfilter/vf_convolution: Fix standalone build of kirsch, scharr filters

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Given that these options are static, the compiler can optimize them away if none of the filters using them are enabled. libavfilter/vf_convolution.c | 4 1 file changed, 4 deletions(-) diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolut

[FFmpeg-devel] [PATCH 14/39] avfilter/f_sendcmd: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_sendcmd.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c index 99d8ca939c..f71d211eb4 100644 --- a/libavfilter/f_sendcmd.c +++ b/libavfilter/f_sendcmd.c @@ -572,10

[FFmpeg-devel] [PATCH 05/39] avfilter/vf_convolution: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_convolution.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c index ccb3515bef..c1ebf4c791 100644 --- a/libavfilter/vf_convolution.c

[FFmpeg-devel] [PATCH 06/39] avfilter/af_asupercut: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_asupercut.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_asupercut.c b/libavfilter/af_asupercut.c index bd8b1cf44a..29f24c7055 100644 --- a/libavfilter/af_asupercut.c +++ b/libavfilter/af_asuper

[FFmpeg-devel] [PATCH 15/39] avfilter/f_streamselect: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_streamselect.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/f_streamselect.c b/libavfilter/f_streamselect.c index c5427672e2..80a133fec3 100644 --- a/libavfilter/f_streamselect.c +++ b/libavfilter/f_stre

[FFmpeg-devel] [PATCH 08/39] avfilter/af_sidechaincompress: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_sidechaincompress.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_sidechaincompress.c b/libavfilter/af_sidechaincompress.c index c964e0d27c..48d450fd50 100644 --- a/libavfilter/af_sidechaincomp

[FFmpeg-devel] [PATCH 07/39] avfilter/af_biquads: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_biquads.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index c110734458..828af05b20 100644 --- a/libavfilter/af_biquads.c +++ b/libavfilter/a

[FFmpeg-devel] [PATCH 09/39] avfilter/f_cue: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_cue.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavfilter/f_cue.c b/libavfilter/f_cue.c index e87b7a67c7..fd55e4bf5f 100644 --- a/libavfilter/f_cue.c +++ b/libavfilter/f_cue.c @@ -94,10 +94,9 @@ static co

[FFmpeg-devel] [PATCH 16/39] avfilter/f_zmq: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_zmq.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/f_zmq.c b/libavfilter/f_zmq.c index 5de22e2fbe..3bd195f0b2 100644 --- a/libavfilter/f_zmq.c +++ b/libavfilter/f_zmq.c @@ -203,10 +203,9 @@ static in

[FFmpeg-devel] [PATCH 11/39] avfilter/f_graphmonitor: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_graphmonitor.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavfilter/f_graphmonitor.c b/libavfilter/f_graphmonitor.c index b712c2fdd6..de91a863c2 100644 --- a/libavfilter/f_graphmonitor.c +++ b/libavfilter/f_gr

[FFmpeg-devel] [PATCH 10/39] avfilter/f_drawgraph: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_drawgraph.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavfilter/f_drawgraph.c b/libavfilter/f_drawgraph.c index a9b47483ad..9996eb3b0e 100644 --- a/libavfilter/f_drawgraph.c +++ b/libavfilter/f_drawgraph.c @@

[FFmpeg-devel] [PATCH 13/39] avfilter/f_realtime: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_realtime.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavfilter/f_realtime.c b/libavfilter/f_realtime.c index 125bd6131c..11bdb058ed 100644 --- a/libavfilter/f_realtime.c +++ b/libavfilter/f_realtime.c @@ -71,

[FFmpeg-devel] [PATCH 12/39] avfilter/f_perms: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_perms.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/f_perms.c b/libavfilter/f_perms.c index 8c449fbdfc..470db45bee 100644 --- a/libavfilter/f_perms.c +++ b/libavfilter/f_perms.c @@ -111,10 +111,9 @@

[FFmpeg-devel] [PATCH 17/38] avfilter/src_movie: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/src_movie.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 0d63c1e4bc..27b17c6a9d 100644 --- a/libavfilter/src_movie.c +++ b/libavfilter/src_movie.c @@ -630,9 +6

[FFmpeg-devel] [PATCH 18/38] avfilter/vf_blend: Don't redefine options name

2021-09-11 Thread Andreas Rheinhardt
Use AVFILTER_DEFINE_CLASS_EXT instead. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_blend.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index 84f1e9f5bb..73fdea3c79 100644 --- a/libavfilter/vf_blend.c +++ b/libavfi

[FFmpeg-devel] [PATCH 19/38] avfilter/vf_format: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_format.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_format.c b/libavfilter/vf_format.c index b34675b8e0..0a5c739db6 100644 --- a/libavfilter/vf_format.c +++ b/libavfilter/vf_format.c @@ -140,10

[FFmpeg-devel] [PATCH 20/38] avfilter/vf_lut: Deduplicate AVClasses

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_lut.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c index 812a5c1ee1..bc9af9f609 100644 --- a/libavfilter/vf_lut.c +++ b/libavfilter/vf_lut.c @@ -587

[FFmpeg-devel] [PATCH 21/38] avfilter/vf_lut: Remove empty init function

2021-09-11 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_lut.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c index bc9af9f609..d335fd6c39 100644 --- a/libavfilter/vf_lut.c +++ b/libavfilter/vf_lut.c @@ -607,13 +607,10 @@ AVFILTE

[FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

2021-09-11 Thread Soft Works
v5 Update: - Merge AVSubtitle into AVFrame - Move FATE test adjustments to corresponding commit - Move documentation updates to corresponding filter commits - Remove mediatype parameter from av_frame_get_buffer2 (still need some advice for splitting the commits in a way that every single one wil

[FFmpeg-devel] [PATCH v5 01/12] avutil/frame: Subtitle Filtering - Add AVMediaType property to AVFrame

2021-09-11 Thread Soft Works
This is the root commit for adding subtitle filtering capabilities. Adding the media type property to AVFrame replaces the previous way of distinction which was based on checking width and height to determine whether a frame is audio or video. Signed-off-by: softworkz --- libavutil/frame.c | 8

[FFmpeg-devel] [PATCH v5 02/12] global: Merge AVSubtitle into AVFrame

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/ass.c | 16 ++-- libavcodec/ass.h | 8 +- libavcodec/assdec.c | 18 ++--- libavcodec/assenc.c | 10 +-- libavcodec/avcodec.c | 19 - libavcodec/avcodec.h | 81 -

[FFmpeg-devel] [PATCH v5 03/12] fftools/play, probe: Adjust for subtitle format type change

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 30 ++--- fftools/ffprobe.c | 49 +++ 2 files changed, 51 insertions(+), 28 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 46758b9f55..b1cb44e804 100644 --- a

[FFmpeg-devel] [PATCH v5 04/12] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffmpeg.c | 435 +- fftools/ffmpeg.h | 14 +- fftools/ffmpeg_filter.c | 198 +++--- fftools/ffmpeg_hw.c | 2 +- fftools/ffmpeg_opt.c

[FFmpeg-devel] [PATCH v5 05/12] avfilter/subtitles: Add subtitles.c

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/Makefile | 1 + libavfilter/f_interleave.c | 3 ++ libavfilter/internal.h | 1 + libavfilter/subtitles.c| 61 ++ libavfilter/subtitles.h| 44 +++ 5 files changed, 110 insertio

[FFmpeg-devel] [PATCH v5 06/12] avfilter/avfilter: Handle subtitle frames

2021-09-11 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 14 ++ libavfilter/formats.h | 3 +++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilt

  1   2   >