Re: [FFmpeg-devel] [PATCH] avcodec: add jpeg2000_parser

2016-12-18 Thread Paul B Mahol
On 12/17/16, Michael Niedermayer wrote: > On Fri, Mar 25, 2016 at 02:07:22AM +0100, Michael Niedermayer wrote: >> On Fri, Mar 25, 2016 at 12:44:49AM +0100, Paul B Mahol wrote: >> > On 3/24/16, Paul B Mahol wrote: >> > > Hi, >> > > >> > > patch attached. >> > > >> > >> > Fixed version attached. >>

Re: [FFmpeg-devel] [PATCH] af_hdcd: more FATE tests

2016-12-18 Thread Hendrik Leppkes
On Sun, Dec 18, 2016 at 8:42 AM, Burt P wrote: > Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. > > Changed fate-suite sample files: > * filter/hdcd-encoding-errors.flac (1.3M) replaced by > filter/hdcd-encoding-errors2.flac (140K) > * filter/hdcd-mix.flac (2.2M) added

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-12-18 Thread Nicolas George
Le primidi 21 frimaire, an CCXXV, Nicolas George a écrit : > I will do so after the end of this week if I see no news. Done. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH] af_hdcd: more FATE tests

2016-12-18 Thread Burt P.
On Sun, Dec 18, 2016 at 3:30 AM, Hendrik Leppkes wrote: > On Sun, Dec 18, 2016 at 8:42 AM, Burt P wrote: >> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. >> >> Changed fate-suite sample files: >> * filter/hdcd-encoding-errors.flac (1.3M) replaced by >> filter/hdcd-en

Re: [FFmpeg-devel] [PATCH] avformat/tls: add tls url_get_file_handle

2016-12-18 Thread wm4
On Sat, 17 Dec 2016 20:17:54 +0100 Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 10:28:21AM -0400, jayri...@gmail.com wrote: > > From: Jay Ridgeway > > > > Support url_get_file_handle on TLS streams. > > --- > > libavformat/tls_gnutls.c | 7 +++ > > libavformat/tls_openssl.

Re: [FFmpeg-devel] [PATCH] avformat/tls: add tls url_get_file_handle

2016-12-18 Thread wm4
On Sat, 17 Dec 2016 20:17:54 +0100 Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 10:28:21AM -0400, jayri...@gmail.com wrote: > > From: Jay Ridgeway > > > > Support url_get_file_handle on TLS streams. > > --- > > libavformat/tls_gnutls.c | 7 +++ > > libavformat/tls_openssl.

[FFmpeg-devel] [PATCH 3/6] ffplay: use buffersink accessors.

2016-12-18 Thread Nicolas George
Signed-off-by: Nicolas George --- ffplay.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ffplay.c b/ffplay.c index 911fd7f..90bd97b 100644 --- a/ffplay.c +++ b/ffplay.c @@ -2075,7 +2075,7 @@ static int audio_thread(void *arg) goto the_end;

[FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-18 Thread Nicolas George
av_buffersink_get_frame_rate() did already exist; its argument becomes const. TODO minor version bump API-Change: libavfilter Signed-off-by: Nicolas George --- libavfilter/buffersink.c | 25 +++-- libavfilter/buffersink.h | 22 -- 2 files changed, 39 inse

[FFmpeg-devel] [PATCH 2/6] ffmpeg: use buffersink accessors.

2016-12-18 Thread Nicolas George
Signed-off-by: Nicolas George --- ffmpeg.c| 46 -- ffmpeg_filter.c | 12 ++-- 2 files changed, 30 insertions(+), 28 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index e4890a4..ff177e0 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -1014,6 +10

[FFmpeg-devel] [PATCH 4/6] lavd/lavfi: use buffersink accessors.

2016-12-18 Thread Nicolas George
Signed-off-by: Nicolas George --- libavdevice/lavfi.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c index f9b2694..eca3f15 100644 --- a/libavdevice/lavfi.c +++ b/libavdevice/lavfi.c @@ -312,31

[FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread Nicolas George
API-Change: libavfilter Signed-off-by: Nicolas George --- libavfilter/avfilter.h | 2 + libavfilter/internal.h | 199 + libavfilter/version.h | 3 + 3 files changed, 204 insertions(+) Not sure what the preferred delay would be. I suspect not

[FFmpeg-devel] [PATCH 5/6] lavfi/tests/filtfmts: include internal.h.

2016-12-18 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/tests/filtfmts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/tests/filtfmts.c b/libavfilter/tests/filtfmts.c index f59199c..199d74d 100644 --- a/libavfilter/tests/filtfmts.c +++ b/libavfilter/tests/filtfmts.c @@ -30,6 +30,7 @@ #

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread wm4
On Sun, 18 Dec 2016 13:22:21 +0100 Nicolas George wrote: > API-Change: libavfilter > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.h | 2 + > libavfilter/internal.h | 199 > + > libavfilter/version.h | 3 + > 3 files changed, 20

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread Nicolas George
L'octidi 28 frimaire, an CCXXV, wm4 a écrit : > Did you send the same patches to Libav? This makes the API incompatible > with Libav. Their API has been non-working for a long time, even if technically compatible with ours. Their problem. Regards, -- Nicolas Ge signature.asc Description: Di

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread wm4
On Sun, 18 Dec 2016 13:37:44 +0100 Nicolas George wrote: > L'octidi 28 frimaire, an CCXXV, wm4 a écrit : > > Did you send the same patches to Libav? This makes the API incompatible > > with Libav. > > Their API has been non-working for a long time, even if technically > compatible with ours. T

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 01:22:21PM +0100, Nicolas George wrote: > API-Change: libavfilter > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.h | 2 + > libavfilter/internal.h | 199 > + > libavfilter/version.h | 3 + > 3 files change

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-18 Thread James Almer
On 12/18/2016 9:22 AM, Nicolas George wrote: > av_buffersink_get_frame_rate() did already exist; its argument becomes const. > > TODO minor version bump What's the purpose of adding these accessors? The only reason we have done this before was because of the now dropped libav ABI compatibility, s

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-18 Thread Nicolas George
L'octidi 28 frimaire, an CCXXV, James Almer a écrit : > Is this to make AVFilterLink a fully internal struct? As you can see in patch 6/6 in this series. > What's the reason > to do that in that case, instead of simply making its private field

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread Nicolas George
L'octidi 28 frimaire, an CCXXV, Michael Niedermayer a écrit : > How does this patchset relate to the open-ness of the API ? > you arent saying anything about the plans, goals, intend of this (or > i missed it or fail to associate it with the patchset) I am doing this to accommodate people who obje

[FFmpeg-devel] [PATCHv2] af_hdcd: more FATE tests

2016-12-18 Thread Burt P
Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. Changed fate-suite sample files: * filter/hdcd-encoding-errors.flac (1.3M) replaced by a smaller version (140K). It can be replaced because the test only looks for a non-zero number of errors, so the existing test will

[FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

2016-12-18 Thread Burt P
Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. Changed fate-suite sample files: * filter/hdcd-encoding-errors.flac (1.3M) replaced by a smaller version (140K). It can be replaced because the test only looks for a non-zero number of errors, so the existing test will

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-18 Thread James Almer
On 12/18/2016 3:32 PM, Nicolas George wrote: > L'octidi 28 frimaire, an CCXXV, James Almer a écrit : >> Is this to make AVFilterLink a fully internal struct? > > As you can see in patch 6/6 in this series. > >> What's the reason >> to do that i

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-18 Thread Nicolas George
L'octidi 28 frimaire, an CCXXV, James Almer a écrit : > You didn't answer what's the gain here. Yes I did: discuss that with Hendrik, Andreas and Clément, not me. >How is this better than keeping the > struct public and letting library users keep accessing

[FFmpeg-devel] [PATCH 1/1] Fixing 3GPP Timed Text (TTXT / tx3g / mov_text) encoding for UTF-8 (ticket 6021)

2016-12-18 Thread Erik Bråthen Solem
According to the format specification (3GPP TS 26.245, section 5.2) "storage lengths are specified as byte-counts, wheras highlighting is specified using character offsets." This patch replaces byte counting with character counting for highlighting. See the following page for a link to the specific

Re: [FFmpeg-devel] [PATCH 1/6] lavfi/buffersink: add accessors for the stream properties.

2016-12-18 Thread wm4
On Sun, 18 Dec 2016 19:32:16 +0100 Nicolas George wrote: > By "actual internal structs", I suspect you mean something similar to > this: > > typedef struct AVFormatContext { > ... > AVFormatInternal *internal; > ... > }; > > Introducing these structures was a big mistake. For the re

Re: [FFmpeg-devel] [PATCH 1/1] libavcodec/movtextdec.c: fixing decoding for UTF-8 (ticket 6021)

2016-12-18 Thread Erik Bråthen Solem
Yes, it was supposed to be box_types, not ox_types. I must have removed the b by mistake after I tested the code. Should I resubmit the patch? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 6/6] lavfi: make AVFilterLink opaque in two major bumps.

2016-12-18 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 07:41:14PM +0100, Nicolas George wrote: > L'octidi 28 frimaire, an CCXXV, Michael Niedermayer a écrit : > > How does this patchset relate to the open-ness of the API ? > > you arent saying anything about the plans, goals, intend of this (or > > i missed it or fail to associa

Re: [FFmpeg-devel] [PATCH 1/1] Fixing 3GPP Timed Text (TTXT / tx3g / mov_text) encoding for UTF-8 (ticket 6021)

2016-12-18 Thread Erik Bråthen Solem
Good question. Since text_pos_chars never exceeds the existing variable text_pos, I did not think about this. No, there are no checks. The spec says that "Authors should limit the string in each text sample to not more than 2048 bytes, for maximum terminal interoperability", but the code does not

[FFmpeg-devel] live_start_index & ignoring "options not found"

2016-12-18 Thread Ibrahim Tachijian
Hey, I use live_start_index to control which segment ffmpeg starts with on a HLS live stream. This is working as expected. However, when the input file is NOT a HLS live stream then using "live_start_index" of course gives you a "Option live_start_index not found" and then quits ffmpeg. I'd like

Re: [FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

2016-12-18 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 12:48:45PM -0600, Burt P wrote: > Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. > > Changed fate-suite sample files: > * filter/hdcd-encoding-errors.flac (1.3M) replaced by > a smaller version (140K). It can be replaced because the test > onl

Re: [FFmpeg-devel] [PATCH 1/1] libavcodec/movtextdec.c: fixing decoding for UTF-8 (ticket 6021)

2016-12-18 Thread Michael Niedermayer
On Sun, Dec 18, 2016 at 08:44:29PM +, Erik Bråthen Solem wrote: > Yes, it was supposed to be box_types, not ox_types. I must have removed the b > by mistake after I tested the code. Should I resubmit the patch? the change is trivial but the code that was tested should be submted exactly, so p

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: Avoid false triggering an assertion failure

2016-12-18 Thread Marton Balint
On Sat, 17 Dec 2016, pkoshe...@gmail.com wrote: From: Pavel Koshevoy Steps to reproduce: ./ffmpeg_g -f s16be -i /dev/null -af atempo=0.5 -y /tmp/atempo.wav --- libavfilter/af_atempo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/

[FFmpeg-devel] [PATCH 1/1] Updated version of patch 1840 (ticket 6021)

2016-12-18 Thread Erik Bråthen Solem
Between testing and patch generation a character was deleted by mistake, which broke the patch. This updated version fixes this. Original patch description: Character offsets were interpreted as byte offsets, resulting in misplaced styling tags where multibyte characters were involved. The entire

Re: [FFmpeg-devel] [FFmpeg-devel, 1/1] libavcodec/movtextdec.c: fixing decoding for UTF-8 (ticket 6021)

2016-12-18 Thread Erik Bråthen Solem
Done. It was assigned its own patch number (1860), so I am changing the state of this one to "Superseded". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/1] Fixing 3GPP Timed Text (TTXT / tx3g / mov_text) encoding for UTF-8 (ticket 6021)

2016-12-18 Thread Erik Bråthen Solem
Accidental duplicate of patch 1818. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavfi/framequeue: avoid empty structs.

2016-12-18 Thread Nicolas George
Fix compilation on MSVC. Signed-off-by: Nicolas George --- libavfilter/framequeue.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/framequeue.h b/libavfilter/framequeue.h index 558ea3..f5ef744638 100644 --- a/libavfilter/framequeue.h +++ b/libavfilter/framequeue.h @@ -44,6 +

Re: [FFmpeg-devel] [PATCH] lavfi/framequeue: avoid empty structs.

2016-12-18 Thread Nicolas George
Le nonidi 29 frimaire, an CCXXV, Nicolas George a écrit : > Fix compilation on MSVC. Forgot to write in the comment beore sending: this is obviously untested. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel