On Sun, Dec 18, 2016 at 3:30 AM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Sun, Dec 18, 2016 at 8:42 AM, Burt P <pbu...@gmail.com> wrote: >> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. >> >> Changed fate-suite sample files: >> * filter/hdcd-encoding-errors.flac (1.3M) replaced by >> filter/hdcd-encoding-errors2.flac (140K) >> * filter/hdcd-mix.flac (2.2M) added >> * filter/hdcd-fake20bit.flac (168K) added >> * filter/hdcd.flac (910K) removed, although it was a nice tune and >> the samples that replace it are terrible sounds. >> Net change +290K. >> > > We cannot delete samples because that would break old versions of FATE > (which is vital for bisecting etc), so knowing and accounting for > that, would that change any of these choices to add/remove samples? > Because the net change goes to around +2.5M without any removals. >
Well, hdcd-encoding-errors2.flac could simply be named hdcd-encoding-errors.flac and it should not affect the test that uses it, even in an old version. There only needs to be a non-zero number of errors, 2 is as good as 4. The sample hdcd.flac is a nice sound, but it isn't a very interesting example of HDCD for testing. hdcd-mix.flac is a concatenation of three different samples, each one interesting in a different way, and it does quite a bit for code coverage. I will, however, try to make it smaller. -- Burt _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
