Re: [FFmpeg-devel] [PATCHv2] avfilter/vf_drawtext: add optional default value to metadata function

2016-04-08 Thread Tobias Rapp
On 07.04.2016 20:45, Stefano Sabatini wrote: On date Thursday 2016-04-07 12:32:47 +0200, Tobias Rapp encoded: Signed-off-by: Tobias Rapp --- doc/filters.texi | 7 ++- libavfilter/vf_drawtext.c | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/filters.

[FFmpeg-devel] [PATCH] avcodec/shorten: fix decoding on the last frame

2016-04-08 Thread Paul B Mahol
Hi, patch attached. Fixes ticket #4712. From e03ee9d75f0f9cb37498bd9ac613c460fadf1145 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 8 Apr 2016 10:35:11 +0200 Subject: [PATCH] avcodec/shorten: fix decoding of last frame Previously it would be always discarded. Signed-off-by: Paul B Mah

[FFmpeg-devel] [PATCH 1/2] avfilter: add readvitc filter

2016-04-08 Thread Tobias Rapp
Add a filter to scan the top lines of video frames for vertical interval timecode (VITC) information and attach it as metadata keys. Signed-off-by: Tobias Rapp --- Changelog | 1 + MAINTAINERS | 1 + doc/filters.texi | 26 + libavfilter/Makefile

[FFmpeg-devel] [PATCH 2/2] fate: add readvitc filter test

2016-04-08 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- tests/fate/filter-video.mak | 10 ++ tests/ref/fate/filter-metadata-readvitc-def | 5 + tests/ref/fate/filter-metadata-readvitc-thr | 5 + 3 files changed, 20 insertions(+) create mode 100644 tests/ref/fate/filter-metadata-readvitc

[FFmpeg-devel] [PATCH 0/2] add readvitc filter

2016-04-08 Thread Tobias Rapp
The following patches add a filter that allows to scan video frames for VITC lines, including FATE test. The sample file for the FATE test can be found at: https://cerebrum.noa-archive.com/noacloud/public.php?service=files&t=88eeb716819bba39584be03c2d1f053b (1.4MB) and is assumed to be stored as

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add readvitc filter

2016-04-08 Thread Paul B Mahol
On 4/8/16, Tobias Rapp wrote: > Add a filter to scan the top lines of video frames for vertical interval > timecode (VITC) information and attach it as metadata keys. > > Signed-off-by: Tobias Rapp > --- > Changelog | 1 + > MAINTAINERS | 1 + > doc/filters.texi

Re: [FFmpeg-devel] [PATCH]lavf/rawenc: Add a gsm muxer

2016-04-08 Thread Michael Niedermayer
On Tue, Apr 05, 2016 at 12:10:03PM +0200, Carl Eugen Hoyos wrote: > On Saturday 02 April 2016 03:23:31 pm Michael Niedermayer wrote: > > On Sat, Apr 02, 2016 at 10:29:20AM +0200, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached is a probe function for gsm and a patch for a gsm muxer to allow

Re: [FFmpeg-devel] [PATCH 8/8] lavf/movenc+dashenc: add automatic bitstream filtering

2016-04-08 Thread Moritz Barsnick
On Thu, Apr 07, 2016 at 19:38:09 -0500, Rodger Combs wrote: > --- > libavformat/dashenc.c | 43 +++- > libavformat/movenc-test.c | 3 ++ > libavformat/movenc.c | 100 > +++--- > 3 files changed, 121 insertions(+), 25 deletions(-)

Re: [FFmpeg-devel] [PATCH 4/8] lavf/segment: add deinit function

2016-04-08 Thread Michael Niedermayer
On Thu, Apr 07, 2016 at 07:38:05PM -0500, Rodger Combs wrote: > --- > libavformat/segment.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) applyg patches 1,2,3,4 leads to: src/libavformat/segment.c: In function ‘seg_init’: src/libavformat/segment.c:796:9: error: implicit declara

Re: [FFmpeg-devel] [PATCH 1/2 v2] avfilter: add readvitc filter

2016-04-08 Thread Tobias Rapp
On 08.04.2016 11:23, Paul B Mahol wrote: On 4/8/16, Tobias Rapp wrote: Add a filter to scan the top lines of video frames for vertical interval timecode (VITC) information and attach it as metadata keys. Signed-off-by: Tobias Rapp --- >> [...] >> + +static int query_formats(AVFilterContex

[FFmpeg-devel] [PATCH] swscale/arm: add ff_hscale_8_to_15_neon

2016-04-08 Thread Matthieu Bouron
From: Matthieu Bouron --- libswscale/arm/Makefile | 6 ++-- libswscale/arm/hscale.S | 70 +++ libswscale/arm/swscale.c | 37 +++ libswscale/swscale.c | 2 ++ libswscale/swscale_internal.h | 1 + 5 files chan

Re: [FFmpeg-devel] [PATCH 1/8] lavf: add a flag to enable/disable automatic bitstream filtering

2016-04-08 Thread Michael Niedermayer
On Thu, Apr 07, 2016 at 07:38:02PM -0500, Rodger Combs wrote: > This is mostly useful for muxers that wrap other muxers, such as dashenc > and segment. The actual duplicated bitstream filtering is largely harmless, > but delaying the header can cause problems when the muxer intended the header > to

Re: [FFmpeg-devel] [PATCH 1/2 v2] avfilter: add readvitc filter

2016-04-08 Thread Carl Eugen Hoyos
Tobias Rapp noa-archive.com> writes: > > AV_PIX_FMT_YUV440P? Also J variants... > > Good catch, I was lazy and just copied the function from vf_eq.c. The > updated patch should contain all pixel formats with planar 8bit luma > component. Instead of listing the formats, check for pix_fmts tha

Re: [FFmpeg-devel] [PATCH 2/8] lavf/mux: run AVCodec::deinit if write_header fails

2016-04-08 Thread Michael Niedermayer
On Thu, Apr 07, 2016 at 07:38:03PM -0500, Rodger Combs wrote: > --- > libavformat/mux.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not k

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add readvitc filter

2016-04-08 Thread Carl Eugen Hoyos
Tobias Rapp noa-archive.com> writes: > + item thr_b > +Set the luma threshold for black. Accepts float numbers in > the range [0.0,1.0], > +default value is code{0.2}. The value must be smaller > than code{thr_w}. > + > + item thr_w > +Set the luma threshold for white. Accepts float numbe

Re: [FFmpeg-devel] [PATCH 3/8] lavf/mux: add avformat_init_output

2016-04-08 Thread Michael Niedermayer
On Thu, Apr 07, 2016 at 07:38:04PM -0500, Rodger Combs wrote: > This allows a consumer to run the muxer's init function without actually > writing the header, which is useful in chained muxers that support > automatic bitstream filtering. > --- > libavformat/avformat.h | 30 +++

Re: [FFmpeg-devel] libavcodec/exr : Fix channel detection

2016-04-08 Thread Carl Eugen Hoyos
Martin Vignali gmail.com> writes: > -line = AV_RL32(src - 8); > +line = (int32_t)AV_RL32(src - 8); This change is ugly and should be unneeded. > +channel_buffer[0] += channelLineSize * line_to_skip; > +channel_buffer[1] += channelLineSize * line_to_skip; > +channel_b

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/tee: Fix leaks in tee muxer when open_slave fails

2016-04-08 Thread Jan Sebechlebsky
On 04/07/2016 12:28 AM, Marton Balint wrote: On Mon, 4 Apr 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky Calling close_slave in case error is to be returned from open_slave will free allocated resources. Since failure can happen before bsfs array is initialized, close_slave

Re: [FFmpeg-devel] [PATCH 5/8] lavf/segment: fix writing separate header with auto BSF

2016-04-08 Thread Michael Niedermayer
On Thu, Apr 07, 2016 at 07:38:06PM -0500, Rodger Combs wrote: > --- > libavformat/segment.c | 55 > ++- > 1 file changed, 41 insertions(+), 14 deletions(-) this with the previous patches seems to break: ./ffmpeg -fflags +genpts -i new_bad.vob -map

Re: [FFmpeg-devel] [PATCH 1/2 v2] avfilter: add readvitc filter

2016-04-08 Thread Paul B Mahol
On 4/8/16, Carl Eugen Hoyos wrote: > Tobias Rapp noa-archive.com> writes: > >> > AV_PIX_FMT_YUV440P? Also J variants... >> >> Good catch, I was lazy and just copied the function from vf_eq.c. The >> updated patch should contain all pixel formats with planar 8bit luma >> component. > > Instead of

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/tee: Handling slave failure in tee muxer

2016-04-08 Thread Jan Sebechlebsky
On 04/07/2016 12:37 AM, Marton Balint wrote: On Mon, 4 Apr 2016, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky Adds per slave option 'onfail' to the tee muxer allowing an output to fail,so other slave outputs can continue. Signed-off-by: Jan Sebechlebsky --- I've just added top

Re: [FFmpeg-devel] [PATCH 1/2 v2] avfilter: add readvitc filter

2016-04-08 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Instead of listing the formats, check for pix_fmts > > that are 8bit and planar. > > Nope, bad idea. Please elaborate: Why would yuva420p not be an allowed input format? Carl Eugen ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH] sws/aarch64/yuv2rgb: honor iOS calling convention

2016-04-08 Thread Clément Bœsch
From: Clément Bœsch y_offset and y_coeff being successive 32-bit integers, they are packed into 8 bytes instead of 2x8 bytes. See https://developer.apple.com/library/ios/documentation/Xcode/Conceptual/iPhoneOSABIReference/Articles/ARM64FunctionCallingConventions.html > iOS diverges from Proced

Re: [FFmpeg-devel] hardware codec for ffmpeg upstream

2016-04-08 Thread Moritz Barsnick
On Fri, Apr 08, 2016 at 14:30:13 +0800, Jung Zhao wrote: > Yes, I have written. Any code format and patch rules I need to abide? Yes, plenty. See http://ffmpeg.org/developer.html (all of it), and for the patches particularily http://ffmpeg.org/developer.html#Submitting-patches . Cheers, Moritz __

Re: [FFmpeg-devel] [PATCH 1/2 v2] avfilter: add readvitc filter

2016-04-08 Thread Paul B Mahol
On 4/8/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> > Instead of listing the formats, check for pix_fmts >> > that are 8bit and planar. >> >> Nope, bad idea. > > Please elaborate: Why would yuva420p not be an allowed > input format? Because it is not used. It can be added t

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread Tobias Rapp
On 08.04.2016 12:48, Carl Eugen Hoyos wrote: Tobias Rapp noa-archive.com> writes: AV_PIX_FMT_YUV440P? Also J variants... Good catch, I was lazy and just copied the function from vf_eq.c. The updated patch should contain all pixel formats with planar 8bit luma component. Instead of listing

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread Paul B Mahol
On 4/8/16, Tobias Rapp wrote: > On 08.04.2016 12:48, Carl Eugen Hoyos wrote: >> Tobias Rapp noa-archive.com> writes: >> AV_PIX_FMT_YUV440P? Also J variants... >>> >>> Good catch, I was lazy and just copied the function from vf_eq.c. The >>> updated patch should contain all pixel formats with

Re: [FFmpeg-devel] libavcodec/exr : add support for datawindow who exceed display window

2016-04-08 Thread Martin Vignali
I answer here to Carl, because his comments are about the display window/data window patch. 2016-04-08 13:00 GMT+02:00 Carl Eugen Hoyos : > Martin Vignali gmail.com> writes: > > > -line = AV_RL32(src - 8); > > +line = (int32_t)AV_RL32(src - 8); > > This change is ugly and should

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread Tobias Rapp
On 08.04.2016 14:54, Paul B Mahol wrote: On 4/8/16, Tobias Rapp wrote: On 08.04.2016 12:48, Carl Eugen Hoyos wrote: Tobias Rapp noa-archive.com> writes: AV_PIX_FMT_YUV440P? Also J variants... Good catch, I was lazy and just copied the function from vf_eq.c. The updated patch should contai

[FFmpeg-devel] ffservers future

2016-04-08 Thread Michael Niedermayer
Hi all If people want ffserver to continue to exist in a functional form then ffserver needs a new maintainer or developers taking care of it / giving it some love. There are a few known bugs in it like code depending on sizeof(AVStream) and general a little too much direct access into APIs these

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread Carl Eugen Hoyos
Tobias Rapp noa-archive.com> writes: > > Now, when someone adds 8bit X planar format which is not > > YUV it will break. > > It depends on whether the equation > "is_yuv_or_gray = (desc->flags & AV_PIX_FMT_FLAG_RGB) == 0)" > can be made or not. Wouldn't the algorithm also work for GBR? Carl

Re: [FFmpeg-devel] libavcodec/exr : add support for datawindow who exceed display window

2016-04-08 Thread Carl Eugen Hoyos
Martin Vignali gmail.com> writes: > I answer here to Carl, because his comments are about > the display window/data window patch. Sorry about it, I know it's annoying... > > > -line = AV_RL32(src - 8); > > > +line = (int32_t)AV_RL32(src - 8); > > > > This change is ugly and sho

Re: [FFmpeg-devel] [PATCH 0/2] add readvitc filter

2016-04-08 Thread Clément Bœsch
On Fri, Apr 08, 2016 at 10:50:23AM +0200, Tobias Rapp wrote: > The following patches add a filter that allows to scan video frames for VITC > lines, including FATE test. > > The sample file for the FATE test can be found at: > https://cerebrum.noa-archive.com/noacloud/public.php?service=files&t=88

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread Tobias Rapp
On 08.04.2016 15:38, Carl Eugen Hoyos wrote: Tobias Rapp noa-archive.com> writes: Now, when someone adds 8bit X planar format which is not YUV it will break. It depends on whether the equation "is_yuv_or_gray = (desc->flags & AV_PIX_FMT_FLAG_RGB) == 0)" can be made or not. Wouldn't the alg

Re: [FFmpeg-devel] [PATCH 0/2] add readvitc filter

2016-04-08 Thread Tobias Rapp
On 08.04.2016 15:49, Clément Bœsch wrote: On Fri, Apr 08, 2016 at 10:50:23AM +0200, Tobias Rapp wrote: The following patches add a filter that allows to scan video frames for VITC lines, including FATE test. The sample file for the FATE test can be found at: https://cerebrum.noa-archive.com/noa

Re: [FFmpeg-devel] [PATCH] sws/aarch64/yuv2rgb: honor iOS calling convention

2016-04-08 Thread Ronald S. Bultje
Hi, On Fri, Apr 8, 2016 at 7:41 AM, Clément Bœsch wrote: > From: Clément Bœsch > > y_offset and y_coeff being successive 32-bit integers, they are packed > into 8 bytes instead of 2x8 bytes. lgtm. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH 1/2 v4] avfilter: add readvitc filter

2016-04-08 Thread Tobias Rapp
On 08.04.2016 15:24, Tobias Rapp wrote: On 08.04.2016 14:54, Paul B Mahol wrote: On 4/8/16, Tobias Rapp wrote: On 08.04.2016 12:48, Carl Eugen Hoyos wrote: Tobias Rapp noa-archive.com> writes: AV_PIX_FMT_YUV440P? Also J variants... Good catch, I was lazy and just copied the function from

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread wm4
On Fri, 8 Apr 2016 15:24:56 +0200 Tobias Rapp wrote: > On 08.04.2016 14:54, Paul B Mahol wrote: > > On 4/8/16, Tobias Rapp wrote: > >> On 08.04.2016 12:48, Carl Eugen Hoyos wrote: > >>> Tobias Rapp noa-archive.com> writes: > >>> > > AV_PIX_FMT_YUV440P? Also J variants... > > >>

[FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc_parser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 4625e61..5558afc 100644 --- a/libavcodec/hevc_parser.c +++ b/libavcodec/hevc_parser.c @@ -202,6 +202,9 @@ static inline int pa

[FFmpeg-devel] [PATCH] sws/aarch64: add ff_yuv2planeX_8_neon

2016-04-08 Thread Clément Bœsch
From: Clément Bœsch --- libswscale/aarch64/Makefile | 1 + libswscale/aarch64/output.S | 66 libswscale/aarch64/swscale.c | 7 + libswscale/utils.c | 3 +- 4 files changed, 76 insertions(+), 1 deletion(-) create mode 100644 libswsc

Re: [FFmpeg-devel] [PATCH] sws/aarch64: add ff_yuv2planeX_8_neon

2016-04-08 Thread Clément Bœsch
On Fri, Apr 08, 2016 at 05:35:20PM +0200, Clément Bœsch wrote: > From: Clément Bœsch > > --- > libswscale/aarch64/Makefile | 1 + > libswscale/aarch64/output.S | 66 > > libswscale/aarch64/swscale.c | 7 + > libswscale/utils.c | 3

Re: [FFmpeg-devel] [PATCH] sws/aarch64/yuv2rgb: honor iOS calling convention

2016-04-08 Thread Clément Bœsch
On Fri, Apr 08, 2016 at 10:25:13AM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Apr 8, 2016 at 7:41 AM, Clément Bœsch wrote: > > > From: Clément Bœsch > > > > y_offset and y_coeff being successive 32-bit integers, they are packed > > into 8 bytes instead of 2x8 bytes. > > > lgtm. > appl

Re: [FFmpeg-devel] ffservers future

2016-04-08 Thread Derek Buitenhuis
On 4/8/2016 2:30 PM, Michael Niedermayer wrote: > There are a few known bugs in it like code depending on > sizeof(AVStream) and general a little too much direct access into APIs > these things will cause ffserver to frequently break if APIs change > even slightly. To calrify, the problem is acces

Re: [FFmpeg-devel] ffservers future

2016-04-08 Thread wm4
On Fri, 8 Apr 2016 18:13:53 +0100 Derek Buitenhuis wrote: > On 4/8/2016 2:30 PM, Michael Niedermayer wrote: > > There are a few known bugs in it like code depending on > > sizeof(AVStream) and general a little too much direct access into APIs > > these things will cause ffserver to frequently bre

Re: [FFmpeg-devel] [PATCH 8/8] lavf/movenc+dashenc: add automatic bitstream filtering

2016-04-08 Thread Derek Buitenhuis
On 4/8/2016 1:38 AM, Rodger Combs wrote: > @@ -617,6 +617,7 @@ static int dash_write_header(AVFormatContext *s) > ctx->opaque = s->opaque; > ctx->io_close = s->io_close; > ctx->io_open= s->io_open; > +av_dict_set(&opts, "fflags",

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > Signed-off-by: Will Kelleher > --- > libavcodec/hevc_parser.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c > index 4625e61..5558afc 100644 > --- a/libavcodec/hevc_p

Re: [FFmpeg-devel] [PATCH] fate: Add test for Ticket 2397

2016-04-08 Thread Michael Niedermayer
On Wed, Apr 06, 2016 at 12:25:48AM +0200, Clément Bœsch wrote: > On Sat, Apr 02, 2016 at 03:49:12AM +0200, Michael Niedermayer wrote: > > If someone can create a smaller test file (its 2.5Mb) that still has the > > same coverage that is welcome. > > otherwise ill upload the sample attached to the

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > > Signed-off-by: Will Kelleher > > --- > > libavcodec/hevc_parser.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c > > in

Re: [FFmpeg-devel] [PATCH] fate: Add test for Ticket 2397

2016-04-08 Thread wm4
On Sat, 2 Apr 2016 03:49:12 +0200 Michael Niedermayer wrote: > If someone can create a smaller test file (its 2.5Mb) that still has the same > coverage that is welcome. > otherwise ill upload the sample attached to the ticket The commit message should describe exactly what the test is about an

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 02:35:09PM -0500, Will Kelleher wrote: > On 04/08, Michael Niedermayer wrote: > > On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > > > Signed-off-by: Will Kelleher > > > --- > > > libavcodec/hevc_parser.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > >

Re: [FFmpeg-devel] [PATCH] fate: Add test for Ticket 2397

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 09:49:34PM +0200, wm4 wrote: > On Sat, 2 Apr 2016 03:49:12 +0200 > Michael Niedermayer wrote: > > > If someone can create a smaller test file (its 2.5Mb) that still has the > > same coverage that is welcome. > > otherwise ill upload the sample attached to the ticket > >

Re: [FFmpeg-devel] libavcodec/exr : add support for datawindow who exceed display window

2016-04-08 Thread Paul B Mahol
On 4/7/16, Martin Vignali wrote: > Hello, > > in attach, a patch with some modifications in size/data window management, > in order to manage > negative datawindow/display window, and datawindow who can exceed display > window > > Size of the picture is now set from min and max value of the displa

Re: [FFmpeg-devel] [PATCH] swscale/arm: add ff_hscale_8_to_15_neon

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 12:24:13PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > libswscale/arm/Makefile | 6 ++-- > libswscale/arm/hscale.S | 70 > +++ > libswscale/arm/swscale.c | 37 +++ > libswsc

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-08 Thread Kyle Swanson
On Wed, Apr 6, 2016 at 8:09 PM, Carl Eugen Hoyos wrote: > Kyle Swanson ylo.ph> writes: > >> Does anyone have any comments about this besides the fact >> that it links an external library? > > It is not ok to add an additional dependency to FFmpeg if the > features of the new dependency are alread

Re: [FFmpeg-devel] [PATCH 1/2 v3] avfilter: add readvitc filter

2016-04-08 Thread Carl Eugen Hoyos
Tobias Rapp noa-archive.com> writes: > > Wouldn't the algorithm also work for GBR? > > If VITC lines are green, yes . I just tested the sample you uploaded with the following command after adding AV_PIX_FMT_GBRP to the supported input formats: $ ffprobe -of compact=p=0 -show_entries frame=pkt

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-08 Thread Kyle Swanson
On Fri, Apr 8, 2016 at 4:07 PM, Kyle Swanson wrote: > On Wed, Apr 6, 2016 at 8:09 PM, Carl Eugen Hoyos wrote: >> Kyle Swanson ylo.ph> writes: >> >>> Does anyone have any comments about this besides the fact >>> that it links an external library? >> >> It is not ok to add an additional dependency

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > parsed, and then freed after it gets written to the output frame's > > side data in hevc_frame_start. > > and if an error happens between it leaks ? > If an error occurred after sei

Re: [FFmpeg-devel] [PATCH] avcodec/shorten: fix decoding on the last frame

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 10:37:28AM +0200, Paul B Mahol wrote: > Hi, > > patch attached. > > Fixes ticket #4712. > shorten.c |4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > b793144094b07fc17e0687139fb7afab983427b8 > 0001-avcodec-shorten-fix-decoding-of-last-frame.patch > From e

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 04:17:56PM -0500, Will Kelleher wrote: > On 04/08, Michael Niedermayer wrote: > > > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > > parsed, and then freed after it gets written to the output frame's > > > side data in hevc_frame_start. > > > > a

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 04:17:56PM -0500, Will Kelleher wrote: > > On 04/08, Michael Niedermayer wrote: > > > > > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > > > parsed, and then freed after it gets written to the output frame's

Re: [FFmpeg-devel] [PATCH] swscale/arm: add ff_hscale_8_to_15_neon

2016-04-08 Thread Matthieu Bouron
On Fri, Apr 8, 2016 at 10:27 PM, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 12:24:13PM +0200, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > --- > > libswscale/arm/Makefile | 6 ++-- > > libswscale/arm/hscale.S | 70 > +++

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-08 Thread Carl Eugen Hoyos
Kyle Swanson ylo.ph> writes: > Or adapt the libebur128 code, which has a couple of nice features Did you already explain which of the features is missing in current FFmpeg? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmp

Re: [FFmpeg-devel] [PATCH] avfilter: add loudnorm

2016-04-08 Thread Hendrik Leppkes
On Fri, Apr 8, 2016 at 11:15 PM, Kyle Swanson wrote: > On Fri, Apr 8, 2016 at 4:07 PM, Kyle Swanson wrote: >> On Wed, Apr 6, 2016 at 8:09 PM, Carl Eugen Hoyos wrote: >>> Kyle Swanson ylo.ph> writes: >>> Does anyone have any comments about this besides the fact that it links an externa

Re: [FFmpeg-devel] libavcodec/exr : add support for datawindow who exceed display window

2016-04-08 Thread Martin Vignali
2016-04-08 22:11 GMT+02:00 Paul B Mahol : > On 4/7/16, Martin Vignali wrote: > > Hello, > > > > in attach, a patch with some modifications in size/data window > management, > > in order to manage > > negative datawindow/display window, and datawindow who can exceed display > > window > > > > Size

[FFmpeg-devel] [PATCH] doc/filters: document testsrc2 source filter

2016-04-08 Thread Lou Logan
Signed-off-by: Lou Logan --- doc/filters.texi | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 82be06d..b4af424 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -14330,7 +14330,8 @@ ffplay -f lavfi life=s=300x200:mold=10:r

Re: [FFmpeg-devel] libavcodec/exr : add support for datawindow who exceed display window

2016-04-08 Thread Paul B Mahol
On 4/9/16, Martin Vignali wrote: > 2016-04-08 22:11 GMT+02:00 Paul B Mahol : > >> On 4/7/16, Martin Vignali wrote: >> > Hello, >> > >> > in attach, a patch with some modifications in size/data window >> management, >> > in order to manage >> > negative datawindow/display window, and datawindow wh