Martin Vignali <martin.vignali <at> gmail.com> writes: > I answer here to Carl, because his comments are about > the display window/data window patch.
Sorry about it, I know it's annoying... > > > - line = AV_RL32(src - 8); > > > + line = (int32_t)AV_RL32(src - 8); > > > > This change is ugly and should be unneeded. If my comment was wrong please ignore;-) [...] > > > + if (s->pixel_type == EXR_HALF) > > > + s->pixel_size = 2; > > > + else > > > + s->pixel_size = 4; > > > + > > > > Please add braces. > > > > Ok, i can add, it, i thought, in ffmpeg, you prefer to > doesn't add brace The reason if - else should always have braces is that this makes future changes much easier to read and costs only one line. Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
