[FFmpeg-devel] x11-grab error : Segmentation fault (core dumped)

2014-07-15 Thread Li Hui
I can use x11-grab to capture vnc screen with depth 16bit correctly. But with depth 24 or 32bit, it doesn’t work. I use this command: ffmpeg -f x11grab -video_size 1280x720 -framerate 25 -i :5 /tmp/out.yuv than, display this error: ffmpeg version N-64657-g2d91b3b Copyright (c) 2000-2014 the FFmpe

Re: [FFmpeg-devel] new webpage design patches

2014-07-15 Thread Clément Bœsch
On Mon, Jul 14, 2014 at 02:20:09AM +0200, Michael Niedermayer wrote: > Hi all > > Theres a pull request that modernises our webpage > https://github.com/FFmpeg/web/pull/1 > https://github.com/FFmpeg/FFmpeg/pull/77 > The new website can be previewed @ http://db0.galo.pe/ffmpeg-web/ (Note: all th

Re: [FFmpeg-devel] [PATCH] disable compule_edt in case of filters

2014-07-15 Thread Nicolas George
Le septidi 27 messidor, an CCXXII, Anshul a écrit : > User still have fix_sub_duration. Yes, but for that, they have to understand why changing something in the video filters did also change something in the subtitles encoding. > I was unable to frame ffmpeg command, when filter and transcoding b

Re: [FFmpeg-devel] x11-grab error : Segmentation fault (core dumped)

2014-07-15 Thread Nicolas George
Le septidi 27 messidor, an CCXXII, Li Hui a écrit : > I can use x11-grab to capture vnc screen with depth 16bit correctly. But with > depth 24 or 32bit, it doesn’t work. > > I use this command: > ffmpeg -f x11grab -video_size 1280x720 -framerate 25 -i :5 /tmp/out.yuv > than, display this error:

[FFmpeg-devel] [PATCH] lavd/x11grab: add an option to disable MIT-SHM.

2014-07-15 Thread Nicolas George
With remote displays supporting the MIT-SHM extension, the extension is detected and used, but attaching fails asynchronously. Signed-off-by: Nicolas George --- doc/indevs.texi | 4 libavdevice/x11grab.c | 5 - 2 files changed, 8 insertions(+), 1 deletion(-) It would probably be

Re: [FFmpeg-devel] x11-grab error : Segmentation fault (core dumped)

2014-07-15 Thread Li Hui
> I can not find a commit with shorthash 2d91b3b in the current Git tree. Can > you explain how you got your source tree exactly? An excerpt of "git log" > would probably help. I fork from 2a9b4c0 to add customize codec. > Can you explain how you arrived to that configuration? I tried with my > c

Re: [FFmpeg-devel] [PATCH] lavd/x11grab: add an option to disable MIT-SHM.

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 11:40:16AM +0200, Nicolas George wrote: > With remote displays supporting the MIT-SHM extension, > the extension is detected and used, but attaching fails > asynchronously. > > Signed-off-by: Nicolas George > --- > doc/indevs.texi | 4 > libavdevice/x11grab.c |

Re: [FFmpeg-devel] [PATCH] lavd/x11grab: add an option to disable MIT-SHM.

2014-07-15 Thread Nicolas George
Le septidi 27 messidor, an CCXXII, Michael Niedermayer a écrit : > probably ok Thanks. It looks like Xlib does not allow to make a really clean error handling. A suboptimal solution could probably be devised for this particular issue, but I feel it would not be worth it. To get something good, re

Re: [FFmpeg-devel] new webpage design patches

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 10:10:41AM +0200, Clément Bœsch wrote: > On Mon, Jul 14, 2014 at 02:20:09AM +0200, Michael Niedermayer wrote: > > Hi all > > > > Theres a pull request that modernises our webpage > > https://github.com/FFmpeg/web/pull/1 > > https://github.com/FFmpeg/FFmpeg/pull/77 > > > >

Re: [FFmpeg-devel] [PATCH 1/4] lavf: add directory listing API

2014-07-15 Thread Nicolas George
Le quartidi 24 messidor, an CCXXII, Lukasz Marek a écrit : > TODO: bump minor, update doc/APIchanges > > API allows protocol implementations to provide API that > allows to list directory content. > API is similar to POSIX opendir/readdir/closedir. > > Signed-off-by: Lukasz Marek > --- > libavf

Re: [FFmpeg-devel] [PATCH] doc/utils: add missing `@c man end` title

2014-07-15 Thread Michael Niedermayer
On Mon, Jul 14, 2014 at 04:21:15PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > doc/utils.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when

[FFmpeg-devel] [PATCH 1/3] lavd/x11grab: disable drawing mouse without XFixes.

2014-07-15 Thread Nicolas George
Fix a segfault if the XFixes extension is not available on the X11 server. Can be reproduced using the VNC server. Signed-off-by: Nicolas George --- libavdevice/x11grab.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavdevice/x11grab.c b/libavdevice/x11grab.c

[FFmpeg-devel] [PATCH 2/3] lavd/x11grab: change error code for unsupported visuals.

2014-07-15 Thread Nicolas George
Signed-off-by: Nicolas George --- libavdevice/x11grab.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavdevice/x11grab.c b/libavdevice/x11grab.c index eb75e62..3a4aaeb 100644 --- a/libavdevice/x11grab.c +++ b/libavdevice/x11grab.c @@ -287,7 +287,7 @@ x11grab_read_he

[FFmpeg-devel] [PATCH 3/3] lavd/x11grab: check 32-bits color masks.

2014-07-15 Thread Nicolas George
The X11 servers by VNC, at 32-bits depths, has the following masks: R:0x07ff G:0x003ff800 B:0xffc0 This is not compatible with AV_PIX_FMT_0RGB32, and the result is success with completely wrong colors. Signed-off-by: Nicolas George --- libavdevice/x11grab.c | 11 ++- 1 file chang

Re: [FFmpeg-devel] x11-grab error : Segmentation fault (core dumped)

2014-07-15 Thread Nicolas George
Le septidi 27 messidor, an CCXXII, Li Hui a écrit : > I fork from 2a9b4c0 to add customize codec. If you need help, you should try to use pristine Git, especially if it is not obvious to reproduce. > I use this command vncserver -geometry 1280x720 -depth 32 to get DISPLAY :5. Reproduced, analyze

[FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-15 Thread Michael Niedermayer
Found-by: kriegero1 Signed-off-by: Michael Niedermayer --- libavcodec/mjpegenc_common.c | 20 tests/ref/lavf/jpg |4 ++-- tests/ref/lavf/smjpeg |4 ++-- tests/ref/vsynth/vsynth1-ljpeg |4 ++-- tests/ref/vsynth/vsynth1-mjpeg

Re: [FFmpeg-devel] [PATCH] avutil & avdevice: remove av_bprint_fd_contents()

2014-07-15 Thread Nicolas George
Le sextidi 26 messidor, an CCXXII, Michael Niedermayer a écrit : > an alternative suggestion or after this patch > would be to switch to passing a filename string instead of a int fd > and treat "" as stdin "-" for stdin is more standard. Otherwise, it would be completely consistent with the av_fi

Re: [FFmpeg-devel] Support for metadata in libavutil/eval.c

2014-07-15 Thread Nicolas George
Le quintidi 25 messidor, an CCXXII, Stepan Bujnak a écrit : >Now, as far as I know the > expression evaluation is now optimized to only work with double values, > therefore the re-implementation of the expression evaluation to accept > string arguments would

Re: [FFmpeg-devel] One pass volume normalization (ebur128)

2014-07-15 Thread Nicolas George
(Sorry for the thread necromancy.) Le septidi 17 prairial, an CCXXII, Roger Pack a écrit : > So am I correct that there is no smoothed intermediate value available > as of today? Indeed. Patch welcome. > One liners are just sexy if it were possible to do > volume normalization on t

Re: [FFmpeg-devel] [PATCH 2/3] lavd/x11grab: change error code for unsupported visuals.

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 04:24:01PM +0200, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavdevice/x11grab.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dicti

Re: [FFmpeg-devel] [PATCH 3/3] lavd/x11grab: check 32-bits color masks.

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 04:24:02PM +0200, Nicolas George wrote: > The X11 servers by VNC, at 32-bits depths, has the following masks: > R:0x07ff G:0x003ff800 B:0xffc0 > This is not compatible with AV_PIX_FMT_0RGB32, and the result > is success with completely wrong colors. > > Signed-off-b

Re: [FFmpeg-devel] [PATCH 1/3] lavd/x11grab: disable drawing mouse without XFixes.

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 04:24:00PM +0200, Nicolas George wrote: > Fix a segfault if the XFixes extension is not available on > the X11 server. > Can be reproduced using the VNC server. > > Signed-off-by: Nicolas George > --- > libavdevice/x11grab.c | 11 +-- > 1 file changed, 9 insertion

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-15 Thread Andrey Utkin
Thanks, with this change streaming HTTP MJPEG stream into browsers work (with inserting boundaries, which is easy for scripting). -- Andrey Utkin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-15 Thread Nicolas George
Le septidi 27 messidor, an CCXXII, Andrey Utkin a écrit : > Thanks, with this change streaming HTTP MJPEG stream into browsers > work (with inserting boundaries, which is easy for scripting). Can you share your test procedure please? Regards, -- Nicolas George signature.asc Description: Dig

[FFmpeg-devel] [PATCH] lavfi: check refcount before merging.

2014-07-15 Thread Nicolas George
When merging the formats around the automatically inserted convert filters, the refcount of the format lists can not be 0. Coverity does not detect it, and suspects a memory leak, because if refcount is 0 the newly allocated lists are not stored anywhere. That gives CIDs 1224282, 1224283 and 122428

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-15 Thread Andrey Utkin
2014-07-15 19:16 GMT+03:00 Nicolas George : > Le septidi 27 messidor, an CCXXII, Andrey Utkin a écrit : >> Thanks, with this change streaming HTTP MJPEG stream into browsers >> work (with inserting boundaries, which is easy for scripting). > > Can you share your test procedure please? I'll work on

Re: [FFmpeg-devel] [PATCH] lavfi: check refcount before merging.

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 07:30:35PM +0200, Nicolas George wrote: > When merging the formats around the automatically inserted > convert filters, the refcount of the format lists can not be 0. > Coverity does not detect it, and suspects a memory leak, > because if refcount is 0 the newly allocated li

Re: [FFmpeg-devel] [PATCH] avutil & avdevice: remove av_bprint_fd_contents()

2014-07-15 Thread Michael Niedermayer
On Sun, Jul 13, 2014 at 04:01:05PM +0200, Michael Niedermayer wrote: > MSVC does not allow passing file pointers between libs > This API can thus not work with MSVC and as it was very recently added > and its it was in no release its removial should not cause any problems > > Found-by: Hendrik Lep

Re: [FFmpeg-devel] [PATCH v2] Blackframe video filter now sets metadata accordingly.

2014-07-15 Thread Michael Niedermayer
On Fri, Jul 11, 2014 at 11:40:07PM +0200, Stepan Bujnak wrote: > the libavfilter/vf_blackframe.c filter now not only logs detected > values, but also sets frame metadata. Currently, only `pblack` value is set > but `SET_META` macro has been introduced to ease development in the future. > > Signed-

[FFmpeg-devel] [PATCH 2/2] Rebase commit 'web/download: remove developer repos and cleanup'

2014-07-15 Thread Timothy Gu
Commit cb17d7339c2a12d8bb36d3000f229d924e092d0c rebased Signed-off-by: Timothy Gu --- src/download | 205 --- 1 file changed, 27 insertions(+), 178 deletions(-) diff --git a/src/download b/src/download index 3ccbb3d..2f4ef59 100644 --- a/s

[FFmpeg-devel] [PATCH 0/2] Incremental patches for some small improvments

2014-07-15 Thread Timothy Gu
This patch series is also available at https://github.com/db0company/web/pull/1 , which also includes a commit that regenerates dist/ Timothy Gu (2): Make W3C validator happy Rebase commit 'web/download: remove developer repos and cleanup' src/about| 8 +- src/bugreports

[FFmpeg-devel] [PATCH 1/2] Make W3C validator happy

2014-07-15 Thread Timothy Gu
Signed-off-by: Timothy Gu --- src/about| 8 src/bugreports | 8 src/download | 6 ++ src/index| 4 ++-- src/template_footer1 | 2 +- src/template_head1 | 1 - 6 files changed, 13 insertions(+), 16 deletions(-) diff --git a/src/about b

Re: [FFmpeg-devel] [PATCH] Move old Changelog entries to doc/Changelog.old

2014-07-15 Thread Michael Niedermayer
On Sun, Jul 13, 2014 at 07:15:04PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > > Here is the right patch... > > Changelog | 1264 > - > doc/Changelog.old | 1229 +++ > 2

Re: [FFmpeg-devel] [PATCH] Move old Changelog entries to doc/Changelog.old

2014-07-15 Thread James Almer
On 15/07/14 6:52 PM, Michael Niedermayer wrote: > On Sun, Jul 13, 2014 at 07:15:04PM -0700, Timothy Gu wrote: >> Signed-off-by: Timothy Gu >> --- >> >> Here is the right patch... >> >> Changelog | 1264 >> - >> doc/Changelog.old | 1229

Re: [FFmpeg-devel] [PATCH] Move old Changelog entries to doc/Changelog.old

2014-07-15 Thread Timothy Gu
On Tue, Jul 15, 2014 at 2:56 PM, James Almer wrote: > On 15/07/14 6:52 PM, Michael Niedermayer wrote: >> On Sun, Jul 13, 2014 at 07:15:04PM -0700, Timothy Gu wrote: >>> Signed-off-by: Timothy Gu >>> --- >>> >>> Here is the right patch... >>> >>> Changelog | 1264 >>>

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add WebM DASH Manifest Muxer

2014-07-15 Thread Michael Niedermayer
On Mon, Jul 14, 2014 at 09:52:23AM -0700, Vignesh Venkatasubramanian wrote: > This patch adds the ability to generate WebM DASH manifest XML using > ffmpeg. A sample command line would be as follows: > > ffmpeg \ > -f webm_dash_manifest -i video1.webm \ > -f webm_dash_manifest -i video2.webm \

[FFmpeg-devel] [PATCH] diracdec: remove unused dsputil context

2014-07-15 Thread James Almer
Signed-off-by: James Almer --- libavcodec/diracdec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index d1c3758..a18c867 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c @@ -27,7 +27,6 @@ */ #include "avcodec.h" -#include "

Re: [FFmpeg-devel] [PATCH 1/2] lavf/matroska: Add functions for WebM DASH Manifest

2014-07-15 Thread Michael Niedermayer
On Mon, Jul 07, 2014 at 12:52:37PM -0700, Vignesh Venkatasubramanian wrote: > Add functions and logic to matroskadec for use by the WebM DASH Manifest > XML Muxer. The actual muxer is added in a future patch. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/matroska.h| 12 +

Re: [FFmpeg-devel] [PATCH] diracdec: remove unused dsputil context

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 07:10:09PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/diracdec.c | 3 --- > 1 file changed, 3 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fa

Re: [FFmpeg-devel] [PATCH] kCVPixelFormatType_OneComponent8 only exists from 10.8 onward

2014-07-15 Thread Michael Niedermayer
On Sun, Jul 13, 2014 at 09:55:38PM -0500, Hanspeter Niederstrasser wrote: > The AVFoundation indev uses kCVPixelFormatType_OneComponent8, but that > only exists on 10.8 and up. This puts it behind a #if. > > Hanspeter > > -- > Disclaimer: > By sending an email to ANY of my addresses you are agr

Re: [FFmpeg-devel] [PATCH] kCVPixelFormatType_OneComponent8 only exists from 10.8 onward

2014-07-15 Thread Michael Niedermayer
On Mon, Jul 14, 2014 at 08:57:36AM +0200, Reimar Döffinger wrote: > On 14.07.2014, at 04:55, Hanspeter Niederstrasser > wrote: > > The AVFoundation indev uses kCVPixelFormatType_OneComponent8, but that > > only exists on 10.8 and up. This puts it behind a #if. > > It's not ideal. Maybe not wort

Re: [FFmpeg-devel] [PATCH v3] drawtext: Add basic text shaping using libfribidi - Fixes ticket #3758

2014-07-15 Thread Michael Niedermayer
On Sat, Jun 21, 2014 at 05:41:45AM +0100, Marc Jeffreys wrote: > Regarding positioning of the '|' operator: Unless anyone objects, I think it's > fine being at the end of the line (if anything, that's the style used for '||' > in vf_drawtext.c). > > ---8<--- > --- > configure |

[FFmpeg-devel] [Report][SPI] Summary of donations and expenses in the first semester of 2014

2014-07-15 Thread Stefano Sabatini
See attachment. For some reasons the expense refunds were not accounted in the monthly SPI reports, so I had to interpolate the effective available deposit amount. -- FFmpeg = Formidable and Furious Mystic Peaceful Ecumenical Gladiator The following table shows the donations in the period 2014-01-

[FFmpeg-devel] [PATCH] videodsp: move draw_edges from mpegvideoencdsp

2014-07-15 Thread James Almer
It's also used by some decoders Signed-off-by: James Almer --- configure | 4 +- libavcodec/diracdec.c | 12 ++-- libavcodec/mpegvideo_enc.c| 8 +-- libavcodec/mpegvideoencdsp.c | 30 libavcodec/mpegvideoencdsp.h

Re: [FFmpeg-devel] [PATCH] videodsp: move draw_edges from mpegvideoencdsp

2014-07-15 Thread Ronald S. Bultje
Hi, On Tue, Jul 15, 2014 at 7:53 PM, James Almer wrote: > It's also used by some decoders > > Signed-off-by: James Almer > --- > configure | 4 +- > libavcodec/diracdec.c | 12 ++-- > libavcodec/mpegvideo_enc.c| 8 +-- > libavcodec/

[FFmpeg-devel] [PATCH] RELEASE_NOTES: update

2014-07-15 Thread Timothy Gu
Signed-off-by: Timothy Gu --- RELEASE_NOTES | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/RELEASE_NOTES b/RELEASE_NOTES index 145abfa..4d76332 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -7,9 +7,10 @@ since the release of FFmpeg 2.2. In this rele

Re: [FFmpeg-devel] [PATCH] videodsp: move draw_edges from mpegvideoencdsp

2014-07-15 Thread James Almer
On 15/07/14 9:13 PM, Ronald S. Bultje wrote: > Hi, > > > On Tue, Jul 15, 2014 at 7:53 PM, James Almer wrote: > >> It's also used by some decoders >> >> Signed-off-by: James Almer >> --- >> configure | 4 +- >> libavcodec/diracdec.c | 12 ++-- >>

Re: [FFmpeg-devel] [PATCH] RELEASE_NOTES: update

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 05:39:24PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > RELEASE_NOTES | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you sho

Re: [FFmpeg-devel] FFmpeg 2.3

2014-07-15 Thread Michael Niedermayer
On Wed, Jul 09, 2014 at 02:44:54AM +0200, Michael Niedermayer wrote: > Hi > > its been quite a while since FFmpeg 2.2, so high time to make > FFmpeg 2.3 > > if you want something in it, now is the time to push/post it > if you want something fixed, now is the time to fix it release made 2.3.1 w

[FFmpeg-devel] [PATCH] diracdec: don't call ff_emulated_edge_mc_8 directly

2014-07-15 Thread James Almer
Use the videodsp function pointer instead. Signed-off-by: James Almer --- libavcodec/diracdec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index a18c867..30e6138 100644 --- a/libavcodec/diracdec.c +++ b/libavco

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add WebM DASH Manifest Muxer

2014-07-15 Thread Vignesh Venkatasubramanian
On Tue, Jul 15, 2014 at 3:08 PM, Michael Niedermayer wrote: > On Mon, Jul 14, 2014 at 09:52:23AM -0700, Vignesh Venkatasubramanian wrote: >> This patch adds the ability to generate WebM DASH manifest XML using >> ffmpeg. A sample command line would be as follows: >> >> ffmpeg \ >> -f webm_dash_m

Re: [FFmpeg-devel] [PATCH] diracdec: don't call ff_emulated_edge_mc_8 directly

2014-07-15 Thread Michael Niedermayer
On Tue, Jul 15, 2014 at 10:37:25PM -0300, James Almer wrote: > Use the videodsp function pointer instead. > > Signed-off-by: James Almer > --- > libavcodec/diracdec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH 2/3] vp9: remove unused assignment

2014-07-15 Thread Timothy Gu
Signed-off-by: Timothy Gu --- Already OK'd by BBB on IRC: 19:04 the first two seem correct 19:04 yeah they’re all correct 19:05 Timothy_Gu_: patch to remove these is fine --- libavcodec/vp9.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 5697

[FFmpeg-devel] [PATCH 1/3] get_bits: remove unused assignment

2014-07-15 Thread Timothy Gu
Signed-off-by: Timothy Gu --- libavcodec/get_bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index d8d7b6e..fd32535 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@ -408,7 +408,7 @@ static inline int init_ge

[FFmpeg-devel] [PATCH 3/3] aaccoder: remove unused assignment

2014-07-15 Thread Timothy Gu
Signed-off-by: Timothy Gu --- libavcodec/aaccoder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/aaccoder.c b/libavcodec/aaccoder.c index 50a246f..37548aa 100644 --- a/libavcodec/aaccoder.c +++ b/libavcodec/aaccoder.c @@ -776,7 +776,6 @@ static void search_for_quantizers_twoloo

Re: [FFmpeg-devel] [PATCH] kCVPixelFormatType_OneComponent8only exists from 10.8 onward

2014-07-15 Thread Reimar Döffinger
On 14.07.2014, at 15:21, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > >> In other words, I think the check should be about whether >> the header provides that definition, not what minimum OSX >> version we compile for. > > Isn't this exactly what the check does? It checks __M

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-15 Thread Reimar Döffinger
On 15.07.2014, at 16:31, Michael Niedermayer wrote: > Found-by: kriegero1 > Signed-off-by: Michael Niedermayer Nit: iNdependent in commit message. > +/* JFIF header */ > +put_marker(p, APP0); > +put_bits(p, 16, 16); > +avpriv_put_string(p, "JFIF", 1); /* this puts the trailin

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc_common: always store JFIF, idependent of the aspect ratio

2014-07-15 Thread Reimar Döffinger
On 15.07.2014, at 18:14, Andrey Utkin wrote: > Thanks, with this change streaming HTTP MJPEG stream into browsers > work (with inserting boundaries, which is easy for scripting). oh, and please add an explanation like this (assuming this is the reason for it) to the commit message. _