On 15.07.2014, at 16:31, Michael Niedermayer <michae...@gmx.at> wrote:

> Found-by: kriegero1
> Signed-off-by: Michael Niedermayer <michae...@gmx.at>

Nit: iNdependent in commit message.

> +    /* JFIF header */
> +    put_marker(p, APP0);
> +    put_bits(p, 16, 16);
> +    avpriv_put_string(p, "JFIF", 1); /* this puts the trailing zero-byte too 
> */
> +    put_bits(p, 16, 0x0102);         /* v 1.02 */
> +    put_bits(p,  8, 0);              /* units type: 0 - aspect ratio */

Would an empty JFIF header possibly help as well? (I think it's a collection of 
tags or am I wrong and it requires an aspect entry?)
I don't like specifying a 1:1 aspect explicitly when we actually don't know it.
Also, might the diff be more readable without reindenting?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to