Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2019-11-10 Thread Paul B Mahol
On 11/10/19, Vittorio Giovara wrote: > On Mon, Oct 28, 2019 at 10:48 PM Paul B Mahol wrote: > >> The new API is more extensible and allows for custom layouts. >> More accurate information is exported, eg for decoders that do not >> set a channel layout, lavc will not make one up for them. >> >> D

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2019-11-10 Thread Vittorio Giovara
On Mon, Oct 28, 2019 at 10:48 PM Paul B Mahol wrote: > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just uint64_

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2019-11-06 Thread Nicolas George
Paul B Mahol (12019-10-28): > +char *av_channel_layout_describe(const AVChannelLayout *channel_layout) > +{ > +int i; > + > +switch (channel_layout->order) { > +case AV_CHANNEL_ORDER_NATIVE: > +for (i = 0; channel_layout_map[i].name; i++) > +if (channel_layout->u.mas

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2019-10-30 Thread Nicolas George
Paul B Mahol (12019-10-28): > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just uint64_t bitmasks. > > Original

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2019-10-28 Thread Michael Niedermayer
On Mon, Oct 28, 2019 at 02:48:21PM +0100, Paul B Mahol wrote: > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> I will use +. > > That was my suggestion in the beginning, so I am obviously for. But what > happened to your reasons for rejecting it? I thought that adapted patch by me had this issue already resolved. I did not carefully read f

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > I will use +. That was my suggestion in the beginning, so I am obviously for. But what happened to your reasons for rejecting it? (Once again, too little information in your mail => wasted time for both of us.) -- Nicolas George signature.asc Description: PGP si

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> http://ffmpeg.org/ffmpeg-filters.html#aformat-1http://ffmpeg.org/ffmpeg-filters.html#aformat-1 > > Your link was slightly broken. > >> Do you want to change above thing too? > > No, but I would have objected if I had noticed at the

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > http://ffmpeg.org/ffmpeg-filters.html#aformat-1http://ffmpeg.org/ffmpeg-filters.html#aformat-1 Your link was slightly broken. > Do you want to change above thing too? No, but I would have objected if I had noticed at the time. But thanks for finding that example: th

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> aformat for example use | to split channel layouts. > > Where? http://ffmpeg.org/ffmpeg-filters.html#aformat-1http://ffmpeg.org/ffmpeg-filters.html#aformat-1 Do you want to change above thing too? What you propose instead? _

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > aformat for example use | to split channel layouts. Where? > Documentation follows old legacy usage. I am talking about the documentation of the patch you are proposing. > Can you please stop bikeshedding and arguing with me just because > you enjoy it? Can you ref

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> Please no, | is used in bunch of scripts. > > What scripts? How can they use an API that is still in early discussion? aformat for example use | to split channel layouts. > > Also, discussing this is moot until you rephrase the d

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > Please no, | is used in bunch of scripts. What scripts? How can they use an API that is still in early discussion? Also, discussing this is moot until you rephrase the documentation. -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> >> Input #0, wv, from >> >> '/home/computer/Downloads/Run_The_Race_-_3rd_Order_Ambisonic_SN3D.wv': >> >> Duration: 00:11:07.67, start: 0.00, bitrate: 6084 kb/s >> >> Stream #0:0: Audio: wavpack, 44100 Hz, 16 channels >> >

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > >> Input #0, wv, from > >> '/home/computer/Downloads/Run_The_Race_-_3rd_Order_Ambisonic_SN3D.wv': > >> Duration: 00:11:07.67, start: 0.00, bitrate: 6084 kb/s > >> Stream #0:0: Audio: wavpack, 44100 Hz, 16 channels > >> (FL+FR+FC+LFE+BL+BR+FLC+FRC+BC+SL+SR+TC+T

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> >> > av_get_channel_layout() used to use '+' instead of '|', and I think >> >> > it >> >> > is better. For once, '+' is not a special character for shells. >> >> >> >> Can not work if user wants to define custom channel layout from

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > >> > av_get_channel_layout() used to use '+' instead of '|', and I think it > >> > is better. For once, '+' is not a special character for shells. > >> > >> Can not work if user wants to define custom channel layout from > >> already available channels. > > > > Please e

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/30/18, Nicolas George wrote: > Paul B Mahol (2018-12-30): >> On 12/26/18, Nicolas George wrote: >> >> + * The input string can be represented by: >> >> + * - the formal channel layout name (returned by >> >> av_channel_layout_describe()) >> >> + * - single or multiple channel names (retur

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Nicolas George
Paul B Mahol (2018-12-30): > On 12/26/18, Nicolas George wrote: > >> + * The input string can be represented by: > >> + * - the formal channel layout name (returned by > >> av_channel_layout_describe()) > >> + * - single or multiple channel names (returned by av_channel_name() > >> + *or con

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-30 Thread Paul B Mahol
On 12/26/18, Nicolas George wrote: >> + * The input string can be represented by: >> + * - the formal channel layout name (returned by >> av_channel_layout_describe()) >> + * - single or multiple channel names (returned by av_channel_name() >> + *or concatenated with "|") >> + * - a hexadec

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread James Almer
On 12/26/2018 4:35 PM, Paul B Mahol wrote: > On 12/26/18, James Almer wrote: >> On 12/26/2018 12:07 PM, Paul B Mahol wrote: >>> On 12/26/18, Nicolas George wrote: > + > +/** > + * Initialize a native channel layout from a bitmask indicating which > channels > + * are present.

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Paul B Mahol
On 12/26/18, James Almer wrote: > On 12/26/2018 12:07 PM, Paul B Mahol wrote: >> On 12/26/18, Nicolas George wrote: + +/** + * Initialize a native channel layout from a bitmask indicating which channels + * are present. + * + * @note channel_layout should be pro

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread James Almer
On 12/26/2018 12:07 PM, Paul B Mahol wrote: > On 12/26/18, Nicolas George wrote: >>> + >>> +/** >>> + * Initialize a native channel layout from a bitmask indicating which >>> channels >>> + * are present. >>> + * >>> + * @note channel_layout should be properly allocated as described above. >>> + *

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Nicolas George
Paul B Mahol (2018-12-26): > Look folk, I'm not paid to do this nor I'm paid to read your "reviews" Neither am I. What does it have to do with anything? > so I will ignore this one. You are not allowed to do that. FFmpeg is not your personal project, it is a collective endeavour governed by cons

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Paul B Mahol
On 12/26/18, Nicolas George wrote: > Paul B Mahol (2018-12-24): >> The new API is more extensible and allows for custom layouts. >> More accurate information is exported, eg for decoders that do not >> set a channel layout, lavc will not make one up for them. >> >> Deprecate the old API working wi

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Nicolas George
Paul B Mahol (2018-12-24): > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just uint64_t bitmasks. > > Original c

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-25 Thread Michael Niedermayer
On Tue, Dec 25, 2018 at 02:11:45PM +0100, Paul B Mahol wrote: > On 12/25/18, Michael Niedermayer wrote: > > On Mon, Dec 24, 2018 at 06:34:30PM +0100, Paul B Mahol wrote: > > [...] > >> -static const char *get_channel_name(int channel_id) > >> +const char *av_channel_name(enum AVChannel channel_id)

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-25 Thread Paul B Mahol
On 12/25/18, Michael Niedermayer wrote: > On Mon, Dec 24, 2018 at 06:34:30PM +0100, Paul B Mahol wrote: > [...] >> -static const char *get_channel_name(int channel_id) >> +const char *av_channel_name(enum AVChannel channel_id) >> { > >> if (channel_id < 0 || channel_id >= FF_ARRAY_ELEMS(chan

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-24 Thread Michael Niedermayer
On Mon, Dec 24, 2018 at 06:34:30PM +0100, Paul B Mahol wrote: [...] > -static const char *get_channel_name(int channel_id) > +const char *av_channel_name(enum AVChannel channel_id) > { > if (channel_id < 0 || channel_id >= FF_ARRAY_ELEMS(channel_names)) > return NULL; > +if ((un