On 12/26/18, James Almer <jamr...@gmail.com> wrote: > On 12/26/2018 12:07 PM, Paul B Mahol wrote: >> On 12/26/18, Nicolas George <geo...@nsup.org> wrote: >>>> + >>>> +/** >>>> + * Initialize a native channel layout from a bitmask indicating which >>>> channels >>>> + * are present. >>>> + * >>>> + * @note channel_layout should be properly allocated as described >>>> above. >>>> + * >>>> + * @param channel_layout the layout structure to be initialized >>>> + * @param mask bitmask describing the channel layout >>>> + */ >>>> +void av_channel_layout_from_mask(AVChannelLayout *channel_layout, >>>> uint64_t mask); >>>> + >>>> +/** >>>> + * Initialize a channel layout from a given string description. >>> >>>> + * The input string can be represented by: >>>> + * - the formal channel layout name (returned by >>>> av_channel_layout_describe()) >>>> + * - single or multiple channel names (returned by av_channel_name() >>>> + * or concatenated with "|") >>>> + * - a hexadecimal value of a channel layout (eg. "0x4") >>>> + * - the number of channels with default layout (eg. "5") >>>> + * - the number of unordered channels (eg. "4 channels") >>> >>> av_get_channel_layout() used to use '+' instead of '|', and I think it >>> is better. For once, '+' is not a special character for shells. >> >> Look folk, I'm not paid to do this nor I'm paid to read your "reviews" >> so I will ignore this one. > What prompted you to reply this way? Was there a need to be this > aggressive with a review? > > What do you or anyone wins with this?
You called for this, I'm not gonna continue working on this. All thanks to very "nice" reviewers like all of you. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
