Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Nicolas George
Le primidi 21 ventôse, an CCXXIII, Reimar Döffinger a écrit : > Of course, it's just a pointless waste of server CPU time for already > compressed files. Possibly not just CPU time, user time too: on my box (rather fast for that kind of thing), the speed drops from 2500 Mo/s (based on used CPU tim

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Reimar Döffinger
On 11.03.2015, at 13:05, Lukasz Marek wrote: > On 11.03.2015 11:15, Nicolas George wrote: >> >> >> I firmly believe in the following principles: >> >> 1. If the user made an explicit choice, the application must obey, even if >>the choice seems stupid. >> >>In the case of SSH: compr

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Lukasz Marek
On 11.03.2015 11:15, Nicolas George wrote: Le primidi 21 ventôse, an CCXXIII, Florian Jacob a écrit : Do we have a way to apply ffmpeg-specific options? We can force to use no compression in the code, by adding this line: ssh_options_set(libssh->session, SSH_OPTIONS_COMPRESSION, "no"); after

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Reimar Döffinger
On 11.03.2015, at 11:15, Nicolas George wrote: > I firmly believe in the following principles: > > 1. If the user made an explicit choice, the application must obey, even if > the choice seems stupid. > > In the case of SSH: compression is disabled by default, so enabling it is > an explic

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Reimar Döffinger
On 11.03.2015, at 11:00, Florian Jacob wrote: > Am Mittwoch, 11. März 2015, 10:27:55 schrieb Reimar Döffinger: >> On 11.03.2015, at 10:13, Florian Jacob > wrote: >> If so, should they default to disabling compression? > I only use ffmpeg to play videos in already-compressed formats, so it woul

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Nicolas George
Le primidi 21 ventôse, an CCXXIII, Florian Jacob a écrit : > > Do we have a way to apply > > ffmpeg-specific options? > We can force to use no compression in the code, by adding this line: > > ssh_options_set(libssh->session, SSH_OPTIONS_COMPRESSION, "no"); > > after parsing the config file. I t

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Florian Jacob
Am Mittwoch, 11. März 2015, 10:27:55 schrieb Reimar Döffinger: > On 11.03.2015, at 10:13, Florian Jacob wrote: > > 11.03.2015, 00:51:39 by Timothy Gu: > >> Does this patch change the default behavior in any way? > > > > No, at least it's not intended to change for users who don't have a > > ~/.s

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Nicolas George
Le primidi 21 ventôse, an CCXXIII, Reimar Döffinger a écrit : > Well, I can think of one case: users that enable compression in the config > file. > That makes sense for interactive session and when copying normal files, but > for multimedia it is mostly nonsense. Yes, but that applies to all SS

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Reimar Döffinger
On 11.03.2015, at 10:13, Florian Jacob wrote: > 11.03.2015, 00:51:39 by Timothy Gu: >> Does this patch change the default behavior in any way? > > No, at least it's not intended to change for users who don't have a > ~/.ssh/config. > > If there are users who have a config lying around and expec

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-11 Thread Florian Jacob
11.03.2015, 00:51:39 by Timothy Gu: > Does this patch change the default behavior in any way? No, at least it's not intended to change for users who don't have a ~/.ssh/config. If there are users who have a config lying around and expecting it to be ignored, let's say they don's specify a usern

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Lukasz Marek
On 11.03.2015 01:51, Timothy Gu wrote: On Tue, Mar 10, 2015 at 5:47 PM Lukasz Marek wrote: On 11.03.2015 01:13, Florian Jacob wrote: libssh provides a function for parsing ~/.ssh/config for ssh connection parameters like user, hostname, identity file and port. This patch makes ffmpeg use th

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Timothy Gu
On Tue, Mar 10, 2015 at 5:47 PM Lukasz Marek wrote: > On 11.03.2015 01:13, Florian Jacob wrote: > > libssh provides a function for parsing ~/.ssh/config for ssh connection > parameters like user, hostname, identity file > > and port. This patch makes ffmpeg use this function to take parameters >

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Lukasz Marek
On 11.03.2015 01:13, Florian Jacob wrote: libssh provides a function for parsing ~/.ssh/config for ssh connection parameters like user, hostname, identity file and port. This patch makes ffmpeg use this function to take parameters from the config file for everything that's not explicitely set i

[FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Florian Jacob
libssh provides a function for parsing ~/.ssh/config for ssh connection parameters like user, hostname, identity file and port. This patch makes ffmpeg use this function to take parameters from the config file for everything that's not explicitely set in the url. It also supports host aliases, i.

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Florian Jacob
> > libavformat/libssh.c | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/libssh.c b/libavformat/libssh.c > > index 3ec60cb..1ed1d72 100644 > > --- a/libavformat/libssh.c > > +++ b/libavformat/libssh.c > > @@ -55,6 +55,10 @@ static av_cold

Re: [FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Lukasz Marek
On 11.03.2015 00:22, Florian Jacob wrote: libssh provides a function for parsing ~/.ssh/config for ssh connection parameters like user, hostname, identity file and port. This patch makes ffmpeg use this function to take parameters from the config file for everything that's not explicitely set i

[FFmpeg-devel] [PATCH] sftp: support reading config from ~/.ssh/config

2015-03-10 Thread Florian Jacob
libssh provides a function for parsing ~/.ssh/config for ssh connection parameters like user, hostname, identity file and port. This patch makes ffmpeg use this function to take parameters from the config file for everything that's not explicitely set in the url. It also supports host aliases, i.