Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-02 Thread Rostislav Pehlivanov
On 3 May 2018 at 00:10, Michael Niedermayer wrote: > On Wed, May 02, 2018 at 10:23:08PM +0100, Rostislav Pehlivanov wrote: > > On 2 May 2018 at 21:19, Carl Eugen Hoyos wrote: > > > > > 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov : > > > > On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: > >

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-02 Thread Michael Niedermayer
On Wed, May 02, 2018 at 10:23:08PM +0100, Rostislav Pehlivanov wrote: > On 2 May 2018 at 21:19, Carl Eugen Hoyos wrote: > > > 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov : > > > On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: > > > > > >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : >

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-02 Thread Carl Eugen Hoyos
2018-05-02 23:23 GMT+02:00, Rostislav Pehlivanov : > On 2 May 2018 at 21:19, Carl Eugen Hoyos wrote: > >> 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov : >> > On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: >> > >> >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : >> >> > Its a reminder of

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-02 Thread Rostislav Pehlivanov
On 2 May 2018 at 21:19, Carl Eugen Hoyos wrote: > 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov : > > On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: > > > >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : > >> > Its a reminder of a bygone era. Less flexible than the internal RC > >> > sys

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-02 Thread Carl Eugen Hoyos
2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov : > On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: > >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : >> > Its a reminder of a bygone era. Less flexible than the internal RC >> > system, probably worse and most definitely broken. Drop it. No on

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-02 Thread Moritz Barsnick
On Wed, May 02, 2018 at 04:35:21 +0100, Rostislav Pehlivanov wrote: > On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: > > 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : > > > ever used it either, except for mislead people. > > Is the above part of the commit message? > Yep, its part of the com

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-01 Thread Rostislav Pehlivanov
On 1 May 2018 at 21:58, Carl Eugen Hoyos wrote: > 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : > > Its a reminder of a bygone era. Less flexible than the internal RC > > system, probably worse and most definitely broken. Drop it. No one > > ever used it either, except for mislead people. >

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-01 Thread Carl Eugen Hoyos
2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov : > Its a reminder of a bygone era. Less flexible than the internal RC > system, probably worse and most definitely broken. Drop it. No one > ever used it either, except for mislead people. Sorry for my bad git knowledge: Is the above part of the co

Re: [FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-01 Thread Rostislav Pehlivanov
On 1 May 2018 at 20:00, Rostislav Pehlivanov wrote: > > {"ibias", "intra quant bias", > FF_MPV_OFFSET(intra_quant_bias), AV_OPT_TYPE_INT, {.i64 = > FF_DEFAULT_QUANT_BIAS }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS }, \ > {"pbias", "inter quant bias", > FF_MPV_OFFSET(inter_quant_bias), AV_OPT_TYPE

[FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

2018-05-01 Thread Rostislav Pehlivanov
Its a reminder of a bygone era. Less flexible than the internal RC system, probably worse and most definitely broken. Drop it. No one ever used it either, except for mislead people. --- MAINTAINERS| 1 - libavcodec/Makefile| 2 +- libavcodec/libxvid_rc.c| 164 --