Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:21 PM, Mats Peterson wrote: On 01/02/2016 03:13 PM, Mats Peterson wrote: please run md5sum on your file and tell me the value so we can be sure this is the same video file Yes, it's the same one. And once again, without applying the latest lavf/qtpalette patch the following

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:13 PM, Mats Peterson wrote: please run md5sum on your file and tell me the value so we can be sure this is the same video file Yes, it's the same one. And once again, without applying the latest lavf/qtpalette patch the following (original from the QuickTime Beta CD) file w

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:05 PM, Michael Niedermayer wrote: On Sat, Jan 02, 2016 at 02:16:12PM +0100, Mats Peterson wrote: [...] Furthermore, as I have written before, the 1-bit mode is not fully implemented/partly broken (the jagginess on the right edge shouldn't be there), but many files play OK in spi

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 03:03 PM, Michael Niedermayer wrote: Most interesting. I run Windows XP and MacOS 7.5 here for testing, so they are relatively old references. I suspect something has changed in the QuickTime Animation decoder in QuickTime since then. please run md5sum on your file and tell me the

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 02:16:12PM +0100, Mats Peterson wrote: [...] > Furthermore, as I have written before, the 1-bit mode is not fully > implemented/partly broken (the jagginess on the right edge shouldn't > be there), but many files play OK in spite of this. has this been reported on trac.ffmp

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 02:20:12PM +0100, Mats Peterson wrote: > On 01/02/2016 02:15 PM, Michael Niedermayer wrote: > >no, there is no white background with quicktime player 10.4 on a > >macbook air with the file i have > > Most interesting. I run Windows XP and MacOS 7.5 here for testing, > so th

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 02:15 PM, Michael Niedermayer wrote: no, there is no white background with quicktime player 10.4 on a macbook air with the file i have Most interesting. I run Windows XP and MacOS 7.5 here for testing, so they are relatively old references. I suspect something has changed in the

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 02:09 PM, Mats Peterson wrote: On 01/02/2016 01:33 PM, Michael Niedermayer wrote: One of the major peculiarities in my book is that the two blue colors in the video sample description and the white background are THREE colors together. Not exactly what I would call 1-bit video. I

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 02:09:36PM +0100, Mats Peterson wrote: > On 01/02/2016 01:33 PM, Michael Niedermayer wrote: > >> > >>One of the major peculiarities in my book is that the two blue > >>colors in the video sample description and the white background are > >>THREE colors together. Not exactly

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Mats Peterson
On 01/02/2016 01:33 PM, Michael Niedermayer wrote: One of the major peculiarities in my book is that the two blue colors in the video sample description and the white background are THREE colors together. Not exactly what I would call 1-bit video. I have absolutely no idea what they are doing in

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > I will thus apply this patch unless there are > some objections Please remove the Google Drive links from the commit message. (File names would be useful but as said, two different samples with the same name exist.) A remaining issue that may not

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2016-01-02 Thread Michael Niedermayer
On Wed, Dec 30, 2015 at 11:34:02AM +0100, Mats Peterson wrote: > On 12/30/2015 08:35 AM, Mats Peterson wrote: > >On 12/30/2015 08:17 AM, Mats Peterson wrote: > > > >> > >>When comparing the output in QuickTime and FFmpeg, I noticed that the > >>background is blue in FFmpeg, while it is white (or tr

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-30 Thread Mats Peterson
On 12/30/2015 08:35 AM, Mats Peterson wrote: On 12/30/2015 08:17 AM, Mats Peterson wrote: When comparing the output in QuickTime and FFmpeg, I noticed that the background is blue in FFmpeg, while it is white (or transparent, if you will) in QuickTime. Hold your horses on this patch. Mats I

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
On 12/30/2015 08:17 AM, Mats Peterson wrote: When comparing the output in QuickTime and FFmpeg, I noticed that the background is blue in FFmpeg, while it is white (or transparent, if you will) in QuickTime. Hold your horses on this patch. Mats I noticed that the "alpha" component (there is

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
On 12/29/2015 11:08 PM, Mats Peterson wrote: The following patch fixes the lack of palettized display of 1-bit video in the qtrle decoder. It is related to my previous patch of lavf/qtpalette, which added 1-bit video to the "palettized video" category. As far as I can see, everything works fine,

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
On 12/29/2015 11:54 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: Below are links to sample files, which should now be displayed properly with bluish colors Just to make sure: Please do not apply this patch until above is clarified. Carl Eugen I'm not the one to apply it.

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > Below are links to sample files, which should now be > displayed properly with bluish colors Just to make sure: Please do not apply this patch until above is clarified. Carl Eugen ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
On 12/29/2015 11:48 PM, Carl Eugen Hoyos wrote: Could you explain what "should" means in above sentence? Please try to answer this question, do not repeat things that all developers already understood when you told us two weeks ago. This is a whole different issue from the one I was ranti

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > On 12/29/2015 11:37 PM, Carl Eugen Hoyos wrote: > > Mats Peterson ffmpeg.org> writes: > > > >> Below are links to sample files, which should now be > >> displayed properly with bluish colors > > > > Sorry, I am not a native speaker: > > Could you explain what

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
On 12/29/2015 11:41 PM, Mats Peterson wrote: On 12/29/2015 11:37 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: Below are links to sample files, which should now be displayed properly with bluish colors Sorry, I am not a native speaker: Could you explain what "should" means i

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
On 12/29/2015 11:37 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: Below are links to sample files, which should now be displayed properly with bluish colors Sorry, I am not a native speaker: Could you explain what "should" means in above sentence? Please trim your quotes, Ca

Re: [FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > Below are links to sample files, which should now be > displayed properly with bluish colors Sorry, I am not a native speaker: Could you explain what "should" means in above sentence? Please trim your quotes, Carl Eugen

[FFmpeg-devel] [PATCH] lavc/qtrle: Use AV_PIX_FMT_PAL8 for 1-bit video

2015-12-29 Thread Mats Peterson
The following patch fixes the lack of palettized display of 1-bit video in the qtrle decoder. It is related to my previous patch of lavf/qtpalette, which added 1-bit video to the "palettized video" category. As far as I can see, everything works fine, but comments are of course welcome. Below are