On Sun, Jan 25, 2015 at 11:53:26PM +0530, arwa arif wrote:
> I have updated the patch.
>
> I checked the output with many combinations of parameters. It is bitexact
> now.
merged with pauls changes and applied
> I am facing problems in rebasing against the latest master.
i asked stefano to hel
On Mon, Jan 19, 2015 at 01:19:00PM +0100, Stefano Sabatini wrote:
> On date Monday 2015-01-19 04:04:45 +0530, Arwa Arif encoded:
[...]
> > +{ "gamma_b","gamma value for the luma plane",
> > +OFFSET(gamma_b),AV_OPT_TYPE_DOUBLE, {.dbl = 1.0}, 0.1, 10.0,
> > FLAGS },
> > +{ "
I have updated the patch.
I checked the output with many combinations of parameters. It is bitexact
now.
I am facing problems in rebasing against the latest master.
From f6c6a66b306475e3bc7977f59287c920f5e867a7 Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Mon, 19 Jan 2015 03:56:48 +0530
Subject
On 1/23/15, Stefano Sabatini wrote:
> On date Friday 2015-01-23 20:44:01 +0530, Arwa Arif encoded:
> [...]
>> > Looks good otherwise, assuming it is bitexact with the mp=eq2.
>> >
>>
>> The default is bit-exact with mp=eq2, I can't check it with other values,
>> because the range of values in mp i
On date Friday 2015-01-23 20:44:01 +0530, Arwa Arif encoded:
[...]
> > Looks good otherwise, assuming it is bitexact with the mp=eq2.
> >
>
> The default is bit-exact with mp=eq2, I can't check it with other values,
> because the range of values in mp is different from the range of values in
> thi
On Fri, Jan 23, 2015 at 8:05 PM, Stefano Sabatini
wrote:
> On date Thursday 2015-01-22 01:38:11 +0530, Arwa Arif encoded:
> > On Thu, Jan 22, 2015 at 12:09 AM, Paul B Mahol wrote:
> [...]
> > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001
> > From: Arwa Arif
> > Date: Mo
On date Thursday 2015-01-22 01:38:11 +0530, Arwa Arif encoded:
> On Thu, Jan 22, 2015 at 12:09 AM, Paul B Mahol wrote:
[...]
> From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Mon, 19 Jan 2015 03:56:48 +0530
> Subject: [PATCH] Port mp=eq/eq2 to FFmp
On date Wednesday 2015-01-21 20:38:20 +0530, Arwa Arif encoded:
> >
> > I still expect that eq and eq2 should have the same performances,
> > since the adjust callback is set depending on the parameter values. So
> > we should have a single eq filter.
> >
> > Please investigate about why you get di
So...
2015-01-21 21:08 GMT+01:00 arwa arif :
> Updated the patch.
There are trailing spaces, and the patch does not apply here (error on
libavfilter/x86/Makefile)
Furthemore, I think that hunk is incorrect:
+set_gamma(eq);
+set_contrast(eq);
+set_brightness(eq);
+set_saturation(
On Wed, 21 Jan 2015 20:38:20 +0530
arwa arif wrote:
> >
> > I still expect that eq and eq2 should have the same performances,
> > since the adjust callback is set depending on the parameter values. So
> > we should have a single eq filter.
> >
> > Please investigate about why you get different be
On Thu, Jan 22, 2015 at 09:45:04PM +0530, arwa arif wrote:
[...]
> I checked the runtime of the codes with and without asm, it turns out that
> there is not much difference. The difference is coming out to be in
> milliseconds.
>
> 26.014s with asm and
> 26.129 without asm.
>
> So, should I remo
On Thu, 22 Jan 2015 16:59:24 -0300
James Almer wrote:
> On 22/01/15 4:52 PM, wm4 wrote:
> > On Thu, 22 Jan 2015 16:43:16 -0300
> > James Almer wrote:
> >
> >> On 22/01/15 4:27 PM, wm4 wrote:
> >>> Then I'd definitely vote for remove.
> >>>
> >>> The asm probably mattered on ancient CPUs and anc
On 22/01/15 4:52 PM, wm4 wrote:
> On Thu, 22 Jan 2015 16:43:16 -0300
> James Almer wrote:
>
>> On 22/01/15 4:27 PM, wm4 wrote:
>>> Then I'd definitely vote for remove.
>>>
>>> The asm probably mattered on ancient CPUs and ancient compilers, but
>>> there's no reason to keep it anymore.
>>
>> No.
On Thu, 22 Jan 2015 16:43:16 -0300
James Almer wrote:
> On 22/01/15 4:27 PM, wm4 wrote:
> > Then I'd definitely vote for remove.
> >
> > The asm probably mattered on ancient CPUs and ancient compilers, but
> > there's no reason to keep it anymore.
>
> No. If the handwritten asm is better than t
On 22/01/15 4:27 PM, wm4 wrote:
> Then I'd definitely vote for remove.
>
> The asm probably mattered on ancient CPUs and ancient compilers, but
> there's no reason to keep it anymore.
No. If the handwritten asm is better than the C code, even if slightly, then
it should not be removed.
And if so
On Thu, 22 Jan 2015 21:45:04 +0530
arwa arif wrote:
> On Thu, Jan 22, 2015 at 2:59 PM, wm4 wrote:
>
> > On Thu, 22 Jan 2015 01:38:11 +0530
> > arwa arif wrote:
> >
> > > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001
> > > From: Arwa Arif
> > > Date: Mon, 19 Jan 2015 0
On 22/01/15 6:29 AM, wm4 wrote:
> IMO the asm shouldn't be added at all. It's not important enough for a
> ported video filter, but has high maintenance overhead - there's a
> reason the FFmpeg loathes inline asm, right?
Unless the asm is slower than the C code as compiled by recent versions of gc
On Thu, Jan 22, 2015 at 2:59 PM, wm4 wrote:
> On Thu, 22 Jan 2015 01:38:11 +0530
> arwa arif wrote:
>
> > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001
> > From: Arwa Arif
> > Date: Mon, 19 Jan 2015 03:56:48 +0530
> > Subject: [PATCH] Port mp=eq/eq2 to FFmpeg
> >
> > Co
On Thu, 22 Jan 2015 01:38:11 +0530
arwa arif wrote:
> From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Mon, 19 Jan 2015 03:56:48 +0530
> Subject: [PATCH] Port mp=eq/eq2 to FFmpeg
>
> Code adapted from James Darnley's previous commits
> [...]
> +
On 21/01/15 5:08 PM, arwa arif wrote:
> diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile
> index b93154e..8222e3f 100644
> --- a/libavfilter/x86/Makefile
> +++ b/libavfilter/x86/Makefile
> @@ -1,3 +1,4 @@
> +OBJS-$(CONFIG_EQ_FILTER) += x86/vf_eq.o
> OBJS-$(CONFI
On Thu, Jan 22, 2015 at 12:09 AM, Paul B Mahol wrote:
> On 1/21/15, arwa arif wrote:
> >>
> >> I still expect that eq and eq2 should have the same performances,
> >> since the adjust callback is set depending on the parameter values. So
> >> we should have a single eq filter.
> >>
> >> Please in
On 1/21/15, arwa arif wrote:
>>
>> I still expect that eq and eq2 should have the same performances,
>> since the adjust callback is set depending on the parameter values. So
>> we should have a single eq filter.
>>
>> Please investigate about why you get different benchmark values.
>>
>
> I used
>
> I still expect that eq and eq2 should have the same performances,
> since the adjust callback is set depending on the parameter values. So
> we should have a single eq filter.
>
> Please investigate about why you get different benchmark values.
>
I used this command: ffmpeg -benchmark -i matr
On date Tuesday 2015-01-20 22:30:54 +0530, Arwa Arif encoded:
[...]
> > Add also an entry to add support to .process_command(). You can
> > implement it in a later patch.
> >
> >
> What is meant by adding support to process_command?
grep for .process_command in the libavfilter dir, and you will kn
>
> > @@ -0,0 +1,342 @@
>
> +/*
> > + * Original MPlayer filters by Richard Felker, Hampa Hug, Daniel Moreno,
> > + * and Michael Niedermeyer.
> > + *
> > + * Copyright (c) 2014 James Darnley
> > + * Copyright (c) 2015 Arwa Arif
> > + *
> > + * This file is part of FFmpeg.
> > + *
> > + * FFmpeg
On 1/19/15, arwa arif wrote:
> On Mon, Jan 19, 2015 at 8:53 PM, Stefano Sabatini
> wrote:
>
>> On date Monday 2015-01-19 15:20:54 +0100, Clement Boesch encoded:
>> > On Mon, Jan 19, 2015 at 02:09:33PM +, Paul B Mahol wrote:
>> > > On 1/18/15, arwa arif wrote:
>> > > > Attached the patch.
>>
On Mon, Jan 19, 2015 at 8:53 PM, Stefano Sabatini
wrote:
> On date Monday 2015-01-19 15:20:54 +0100, Clément Bœsch encoded:
> > On Mon, Jan 19, 2015 at 02:09:33PM +, Paul B Mahol wrote:
> > > On 1/18/15, arwa arif wrote:
> > > > Attached the patch.
> > > >
> > >
> > > I'm for dropping eq cod
On Mon, 19 Jan 2015 16:23:46 +0100
Stefano Sabatini wrote:
> On date Monday 2015-01-19 15:20:54 +0100, Clément Bœsch encoded:
> > On Mon, Jan 19, 2015 at 02:09:33PM +, Paul B Mahol wrote:
> > > On 1/18/15, arwa arif wrote:
> > > > Attached the patch.
> > > >
> > >
> > > I'm for dropping eq
On date Monday 2015-01-19 15:20:54 +0100, Clément Bœsch encoded:
> On Mon, Jan 19, 2015 at 02:09:33PM +, Paul B Mahol wrote:
> > On 1/18/15, arwa arif wrote:
> > > Attached the patch.
> > >
> >
> > I'm for dropping eq code and rename eq2 to eq.
>
> Yes please let's not add 2 filters for this
On Mon, Jan 19, 2015 at 02:09:33PM +, Paul B Mahol wrote:
> On 1/18/15, arwa arif wrote:
> > Attached the patch.
> >
>
> I'm for dropping eq code and rename eq2 to eq.
Yes please let's not add 2 filters for this, it's insane. Also, "eq" is
quite a bad name, but well...
What happened to the
On 1/18/15, arwa arif wrote:
> Attached the patch.
>
I'm for dropping eq code and rename eq2 to eq.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On date Monday 2015-01-19 04:04:45 +0530, Arwa Arif encoded:
> Attached the patch.
> From 79298b4f6d08abacb387dbd3f75fabe329d96772 Mon Sep 17 00:00:00 2001
> From: Arwa Arif
> Date: Mon, 19 Jan 2015 03:56:48 +0530
> Subject: [PATCH] Port mp=eq/eq2 to FFmpeg
Mention James Darnley in the log messa
On 18/01/15 7:34 PM, arwa arif wrote:
> +static int initialize(AVFilterContext *ctx)
> +{
> +EQ2Context *eq2 = ctx->priv;
> +int i;
> +
> +set_gamma(eq2);
> +set_contrast(eq2);
> +set_brightness(eq2);
> +set_saturation(eq2);
> +
> +if (IS_FILTER_EQ(ctx->filter)) {
> +
Attached the patch.
From 79298b4f6d08abacb387dbd3f75fabe329d96772 Mon Sep 17 00:00:00 2001
From: Arwa Arif
Date: Mon, 19 Jan 2015 03:56:48 +0530
Subject: [PATCH] Port mp=eq/eq2 to FFmpeg
---
configure|2 +
doc/filters.texi | 68 +
libavfilter/Makefile |
34 matches
Mail list logo
