Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: DX12 Reference-only feature support

2025-01-30 Thread Benjamin Cheng via ffmpeg-devel
. Reference textures must also be separated from output textures. This feature is not supported in the current version of ffmpeg. Since AMD GPU uses this feature in Direct 12 decoder, ffmpeg does not support AMD GPU Direct 12 decoding. To properly support the Reference-Only feature, two parallel

Re: [FFmpeg-devel] [PATCH] avcodec/hevc/hevcdec: Don't add to null pointer

2025-01-29 Thread Vitaly Buka via ffmpeg-devel
Hello, Would it be possible to merge this patch? Thanks, Vitaly ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] Democratization

2025-01-29 Thread Kieran Kunhya via ffmpeg-devel
transparency about infrastructure, but Michael refuses to publish. The community doesn't want arbitrary censorship, but Michael and his surrogates do. etc. Just ask ChatGPT to rewrite Vittorio's email. Kieran ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] GSoC 2025

2025-01-29 Thread Kieran Kunhya via ffmpeg-devel
rs is becoming older, (meaning there are fewer new > developers joining than in the past) > > many now are payed by companies to do specific work for a company. > Meaning they have less time to do what the community and FFmpeg needs > as they spend time to do what the company need

[FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb: Implemented NEON shuf routines

2025-01-28 Thread Krzysztof Pyrkosz via ffmpeg-devel
1203, "shuffle_bytes_1203"); +report("shuffle_bytes_1203"); + +check_shuffle_bytes(shuffle_bytes_2130, "shuffle_bytes_2130"); +report("shuffle_bytes_2130"); + check_uyvy_to_422p(); report("uyvytoyuv422"); -- 2.45.2 ___

Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

2025-01-27 Thread Kieran Kunhya via ffmpeg-devel
On Mon, Jan 27, 2025 at 7:03 PM Soft Works wrote: > > > From: ffmpeg-devel On Behalf Of > > Kieran Kunhya via ffmpeg-devel > > Sent: Monday, January 27, 2025 10:40 AM > > > While this is a very valid concern for some kinds of frame side > > data, it > >

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/aacencdsp: NEON implementation

2025-01-27 Thread Krzysztof Pyrkosz via ffmpeg-devel
m not > sure if they change enough to make much of a difference there, especially on > the cores you've measured on.) > > // Martin I don't mind these changes, I'm perfectly fine with applying any improvements on top of the patch. The speeds on A78 and x13s did not change

Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

2025-01-27 Thread Kieran Kunhya via ffmpeg-devel
have no opinions about the rest of the text. Kieran > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
> > Or is there any reason to not call it what it is (Dish)? There are Sega or > Nintendo audio decoders and other examples and a cryptic description like > "DVB 0502" renders it useless for almost everybody. > Agreed. Kieran > ____

Re: [FFmpeg-devel] Democratization

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
On Sun, Jan 26, 2025 at 9:24 PM Michael Niedermayer wrote: > > Hi Kieran > > On Sun, Jan 26, 2025 at 07:39:38PM +, Kieran Kunhya via ffmpeg-devel > wrote: > > > I remember such a IRC session before the libav fork. > > > It is very similar to this here > &g

Re: [FFmpeg-devel] Democratization

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
On Sun, Jan 26, 2025 at 8:51 PM Kieran Kunhya wrote: > > On Sun, Jan 26, 2025 at 8:40 PM Rémi Denis-Courmont wrote: > > > > With my CC hat on, > > > > Le sunnuntaina 26. tammikuuta 2025, 21.39.38 UTC+2 Kieran Kunhya via ffmpeg- > > devel a écrit : > > &

Re: [FFmpeg-devel] Democratization

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
On Sun, Jan 26, 2025 at 8:40 PM Rémi Denis-Courmont wrote: > > With my CC hat on, > > Le sunnuntaina 26. tammikuuta 2025, 21.39.38 UTC+2 Kieran Kunhya via ffmpeg- > devel a écrit : > > With Anton leaving the project because of you, Paul forking and James > > lea

Re: [FFmpeg-devel] Democratization

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
ng and James leaving the CC because of your behaviour of banning and censoring, have you ever considered the problem might be you? Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] Democratization

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
, censorship etc) and the CC should have dealt with it. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
On Sun, 26 Jan 2025, 00:31 Soft Works, wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Marth64 > > Sent: Sunday, January 26, 2025 1:14 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subj

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Kieran Kunhya via ffmpeg-devel
lob/master/src/lib_ccx/es_userdata.c#L275 Kieran > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Democratization

2025-01-25 Thread Kieran Kunhya via ffmpeg-devel
t to CC? > Hi Remi, Are you not aware than when Michael does something inflammatory like that it's a "joke", but any criticism of his behaviour is an "attack"? Just wanted to be sure you understood the correct terminology used on this ML. Regards, Kieran Kunhya >

[FFmpeg-devel] [PATCH] avcodec/aarch64/aacencdsp: NEON implementation

2025-01-24 Thread Krzysztof Pyrkosz via ffmpeg-devel
This patch supplies handwritten NEON code for AAC. The benchmarks below were collected by invoking these two commands on each of my boards, A78, A72 and Thinkpad x13s: 1) ./tests/checkasm/checkasm --test=aacencdsp --bench --runs=12 2) ./ffmpeg -y -t 10:00 -f lavfi -i sine /tmp/foo.aac (the first

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/nvenc: Enable recovery point SEI for intra refresh mode

2025-01-24 Thread Kieran Kunhya via ffmpeg-devel
tput > recovery point SEI with useless fields, which makes user who want to use > intra refresh > encoding must specify -flags output_corrupt for decoding. That is, without > recovery point > SEI, user should have prior knowledge on encoding configuration before > decoding. >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-23 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 23 Jan 2025, 00:11 Michael Niedermayer, wrote: > Hi Kieran > > On Wed, Jan 22, 2025 at 10:47:52PM +, Kieran Kunhya via ffmpeg-devel > wrote: > > On Wed, 22 Jan 2025, 20:36 Michael Niedermayer, > > wrote: > > > > > This blocks disallowed extensi

Re: [FFmpeg-devel] [PATCH 3/7] avutil/frame: add a param change side data type

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
ss there we add a field with > individual size greater than end_padding, hence intmax_t. Sorry, couldn't really follow the problem and this solution idea yet. Just think we shouldn't use intmax_t as I think it wasn't a good idea to have it in the C standard at all. Is it es

Re: [FFmpeg-devel] [PATCH] avutil/aarch64/float_dsp_neon: Refactor ff_vector_fmul_add_neon

2025-01-23 Thread Krzysztof Pyrkosz via ffmpeg-devel
On Sun, Jan 19, 2025 at 10:57:57PM +0200, Martin Storsjö wrote: > On Sun, 19 Jan 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: > > > Removed a branch, unrolled loop. Speed increase bumped from 3.95 to 5.60. > > On what core is that? Please quote the actual output incl

Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
> 2.25.1 > > > > Ping Seems like your mail client/editor does it (automatically?) to avoid overly long lines, which might be fine for email texts but isn't in patches. Hope you can find the setting for easier contribution in the future. Another approach for single patches o

Re: [FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-22 23:19 +0100, epira...@gmail.com wrote: > > On 22 Jan 2025, at 22:59, Alexander Strasser via ffmpeg-devel wrote: > > > Since av_match_list was added in commit 0d92b0d5f445d4f2 , this > > function changed its semantics shortly after, especially with > &

[FFmpeg-devel] [PATCH v2] libavutil/avstring: av_match_list: Update API documentation

2025-01-23 Thread Alexander Strasser via ffmpeg-devel
FFmpeg libavutil/avstring.h | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index fc095349d2..1a5405581a 100644 --- a/libavutil/avstring.h +++ b/libavutil/avstring.h @@ -409,9 +409,21 @@ int av_utf8_decode(int32_t

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-23 Thread Kieran Kunhya via ffmpeg-devel
. You say heuristics are not needed and then just claim an issue that obviously needs heuristics is "out of scope". Kieran _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
but what stops an attacker from faking the extension? Kieran > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavutil/avstring: av_match_list: Update API documentation

2025-01-22 Thread Alexander Strasser via ffmpeg-devel
separator Character that separates items in the given lists. + * + * @returns 0 if no match was found, otherwise 1. */ int av_match_list(const char *name, const char *list, char separator); -- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
> Can you please stop this "my way or no way" The irony is not lost on me of this sentence (from the person banning people, censoring people, creating paranoid theories about the GA). Kieran _______ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
he FEC > matrix within with the current packet belongs to. > * Beside that, the decoder keeps a maximum number of packets and FEC > packets. I don't see any evidence of wraparound handling unless I miss something. An FEC matrix can span a wraparound. Kieran ______

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 4:37 PM Michael Niedermayer wrote: > > Hi > > On Mon, Jan 20, 2025 at 03:00:17PM +, Kieran Kunhya via ffmpeg-devel > wrote: > [...] > > > Error recovery protocols are complicated - > > everything is complicated > > > > this

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 4:53 PM Romain Beauxis wrote: > > Le mer. 22 janv. 2025 à 10:29, Kieran Kunhya via ffmpeg-devel > a écrit : > > > > On Wed, Jan 22, 2025 at 3:33 PM Michael Niedermayer > > wrote: > > > > > > On Mon, Jan 20, 2025 at 06:

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 4:37 PM Michael Niedermayer wrote: > > Hi > > On Mon, Jan 20, 2025 at 03:00:17PM +, Kieran Kunhya via ffmpeg-devel > wrote: > [...] > > > Error recovery protocols are complicated - > > everything is complicated > > > > this

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-22 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 22, 2025 at 3:33 PM Michael Niedermayer wrote: > > On Mon, Jan 20, 2025 at 06:46:46AM +, Kieran Kunhya via ffmpeg-devel > wrote: > > > > > > > The data arrives on multiple sockets, leading to all sorts > > > > of opportunities

Re: [FFmpeg-devel] FOSDEM meeting

2025-01-21 Thread Kieran Kunhya via ffmpeg-devel
On Tue, Jan 21, 2025 at 6:59 PM Vittorio Giovara wrote: > > Greetings FFmpeg community > > There will be a community meeting during the conference, dates and times > TBA! > > I believe there will be means to connect remotely, and everybody is invited > to join, especially

Re: [FFmpeg-devel] Is the GA democratic ?

2025-01-21 Thread Kieran Kunhya via ffmpeg-devel
On Tue, 21 Jan 2025, 18:57 James Almer, wrote: > On 1/21/2025 3:13 PM, Kieran Kunhya via ffmpeg-devel wrote: > > On Tue, Jan 21, 2025 at 5:42 PM Michael Niedermayer > > wrote: > >> > >> Hi > >> > >> As people likely know i belive it

Re: [FFmpeg-devel] Is the GA democratic ?

2025-01-21 Thread Kieran Kunhya via ffmpeg-devel
llenging the validity of an election is rather in vogue these days. Regards, Kieran Kunhya _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-re

Re: [FFmpeg-devel] Regarding Git Tooling

2025-01-20 Thread Kieran Kunhya via ffmpeg-devel
for new contributors? Running two systems concurrently is a recipe for disaster and makes a difficult process essentially impossible. Kieran > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To u

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-20 Thread Kieran Kunhya via ffmpeg-devel
On Mon, Jan 20, 2025 at 2:51 PM Nicolas George wrote: > > Kieran Kunhya via ffmpeg-devel (12025-01-17): > > I am the author of the only known functional OSS implementation of FEC. > > Seen from here, your rejection of this proposal looks a teeny tiny > little bit like trying

[FFmpeg-devel] Seek to the specified position takes a long time

2025-01-20 Thread zjd via ffmpeg-devel
The current issue is that when dealing with a long interval between keyframes, seeking to a specified position takes a considerable amount of time. Please provide possible solutions ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH v2] fix stride calculation in slice_table for multi-slice field video deblocking

2025-01-20 Thread Kieran Kunhya via ffmpeg-devel
On Tue, Dec 24, 2024 at 9:34 AM Lingyi Kong wrote: > > add fate test case > > Signed-off-by: Lingyi Kong For whatever reason PATCHv4 is in neither of my email boxes, one of which is subscribed to ffmpeg-devel, the other of which is not subscribed but I still receive the emails.

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-19 Thread Kieran Kunhya via ffmpeg-devel
y delays between the two links. You can't just "buffer N packets". Another edge case. Kieran > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] Democratization

2025-01-19 Thread Kieran Kunhya via ffmpeg-devel
to get STF money for work the community does not want because it's already been done? It's funny how all roads appear to end up going to "Michael does what he wants". Kieran > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-19 Thread Kieran Kunhya via ffmpeg-devel
ndred or so edge cases, and make sure they don't interact. Like I said, it's hard to unit test, so remember, you'll have to test all of these by hand. Protocols are not easy. There's a reason Zoom is so good and all the alternatives (OSS included) suck. Regards, Kieran Kunhya

[FFmpeg-devel] [PATCH] avutil/aarch64/float_dsp_neon: Refactor ff_butterflies_float_neon

2025-01-19 Thread Krzysztof Pyrkosz via ffmpeg-devel
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avutil/aarch64/float_dsp_neon: Refactor ff_vector_fmul_add_neon

2025-01-19 Thread Krzysztof Pyrkosz via ffmpeg-devel
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: minor spell fix

2025-01-19 Thread Alexander Strasser via ffmpeg-devel
> +av_log(ctx, AV_LOG_ERROR, "Failed init OpenVINO executable > network or inference request\n"); > return ret; > } > } > -- LGTM, will push it soon'ish if Guo doesn't beat me to it. Thanks, Alexander ______

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Remove audio_drift_threshold

2025-01-19 Thread Alexander Strasser via ffmpeg-devel
(and should be non-controversial to push at this point) Thanks, Alexander ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avutil/aarch64/float_dsp_neon: Refactor ff_vector_fmac_scalar_neon

2025-01-19 Thread Krzysztof Pyrkosz via ffmpeg-devel
{v18.4s, v19.4s}, [x0], #32 +stp q18, q19, [x0], #32 b.ne1b ret endfunc -- 2.45.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe

[FFmpeg-devel] avutil/aarch64/float_dsp_neon: Refactor ff_vector_fmac_scalar_neon

2025-01-19 Thread Krzysztof Pyrkosz via ffmpeg-devel
Removed two redundant pointer arithmetic operations and split load section into two smaller ones. Speedup compared to C increased from 4.50 to 5.80. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
ad and to improve on later. > > > > > > > > > > This is not academia. FEC is about maximising error recovery and > there > > > > > are tons of edge cases to create something that works 24/7. > > > > > > > > > > > I should

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote: > On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: > > My confusion here is that it looks like ffmpeg developers care about UB, > I > > see from time to time large cleanups, but there are a bunch of unfixed >

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there are a bunch of unfixed reports. Maybe forcing no-recover by default will improve this situation? On Fri, Jan 17, 2025 at 11:57 AM Frank Plowman wrote: > On 16/01/2025

Re: [FFmpeg-devel] [PATCH] avutil/vulkan_glslang: windows build improvements

2025-01-17 Thread Benjamin Cheng via ffmpeg-devel
+16,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#include +#include "thread.h" This is fine. #include #include _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
plementation does) > > You seem to claim that mpeg FEC cannot be implemented cleanly > A receiver of any protocol designed to be transmitted over a lossy network can by definition not be implemented cleanly as there are real world practicalities that need to be dealt with. Note how FFm

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
> A simple and clean mpeg FEC implementation will do no harm to FFmpeg, > instead it will improve FFmpegs capabilities. For the reasons I have described this is not possible. It's similar to the way the kernel hides all the idiosyncrasies of real world T

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
ash, infinite loop etc. Nor can it be "elegant". The reality is it has heuristics to deal with the real world like any loss tolerant protocol. This is in addition to the other issues this implementation has. Regards, Kieran Kunhya ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
real world (academia vs engineering) is exponentially harder. Kieran _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
nd there > > > are tons of edge cases to create something that works 24/7. > > > > > > > I should have also said that I'm hoping that this implementation is an > > > > initial one that provides the functionality for the most "simple" > >

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
error recovery and there > > are tons of edge cases to create something that works 24/7. > > > > > I should have also said that I'm hoping that this implementation is an > > > initial one that provides the functionality for the most "simple" > &g

Re: [FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
Sorry, I messed up my subscription, so will reply slightly off-thread. Timo Rothenpieler via ffmpeg-devel wrote: > I don't think the fate-suite should be sitting in the source tree. > Also, there is no guarantee every user/developer will name it that exact > name? Or is that

[FFmpeg-devel] [PATCH] avcodec/hevc/hevcdec: Don't add to null pointer

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
(((x) >> sps->hshift[c_idx]) << sps->pixel_shift)] + (((x) >> sps->hshift[c_idx]) << sps->pixel_shift)] : NULL const HEVCContext *const s = lc->parent; int merge_idx = 0; struct MvField current_mv = {{{ 0 }}}; -- 2.48.0.

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Kieran Kunhya via ffmpeg-devel
n is an > initial one that provides the functionality for the most "simple" > situations and that could be improved later. > > > The biggest question I have, is how do you decide to schedule packets? In > > the FEC spec, the incoming streams are CBR so the matrix dur

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Kieran Kunhya via ffmpeg-devel
do you decide to schedule packets? In > the FEC spec, the incoming streams are CBR so the matrix duration is fixed. > So if there is packet loss you know when to schedule the output packets > because the latency is fixed. But in FFmpeg you don't know the incoming > streams are CBR, no

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Kieran Kunhya via ffmpeg-devel
ss you know when to schedule the output packets because the latency is fixed. But in FFmpeg you don't know the incoming streams are CBR, nor do you have a concept of time. Min and max packets is complete guesswork in a VBR stream and the code takes a bursty stream and makes it even more bursty. A

Re: [FFmpeg-devel] [PATCH] doc/protocols: fix/improve RTP documentation

2025-01-16 Thread Stefan Pöschel via ffmpeg-devel
Sorry, I tried git send-email the first time and didn't check the wrapping before sending. Please find the patch attached as file. Am 16.01.25 um 20:47 schrieb Michael Niedermayer: On Wed, Jan 15, 2025 at 05:27:39PM +0100, Stefan Pöschel via ffmpeg-devel wrote: Signed-off-by: Stefan Pö

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
ndex dae3f45df9..0cb1c02cfa 100644 > --- a/libswscale/swscale_unscaled.c > +++ b/libswscale/swscale_unscaled.c > @@ -677,6 +677,7 @@ static int palToGbrpWrapper(SwsInternal *c, const > uint8_t *const src[], > return srcSliceH; > } > > +__attribute__((no_sanitize("pointer-overflow"))) // FIXME: Remove. > static void packed16togbra16(const uint8_t *src, int srcStride, > uint16_t *dst[], const int dstStride[], int > srcSliceH, > int src_alpha, int swap, int shift, int > width) > @@ -811,6 +812,7 @@ static void packed16togbra16(const uint8_t *src, int > srcStride, > } > } > > +__attribute__((no_sanitize("pointer-overflow"))) // FIXME: Remove. > static void packed30togbra10(const uint8_t *src, int srcStride, > uint16_t *dst[], const int dstStride[], int > srcSliceH, > int swap, int bpc, int width) > @@ -882,6 +884,7 @@ static void packed30togbra10(const uint8_t *src, int > srcStride, > } > } > > +__attribute__((no_sanitize("pointer-overflow"))) // FIXME: Remove. > static int Rgb16ToPlanarRgb16Wrapper(SwsInternal *c, const uint8_t *const > src[], > const int srcStride[], int > srcSliceY, int srcSliceH, > uint8_t *const dst[], const int > dstStride[]) > -- > 2.48.0.rc2.279.g1de40edade-goog > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
ceH, int swap, int bpc, int width) @@ -882,6 +884,7 @@ static void packed30togbra10(const uint8_t *src, int srcStride, } } +__attribute__((no_sanitize("pointer-overflow"))) // FIXME: Remove. static int Rgb16ToPlanarRgb16Wrapper(SwsInternal *c, const uint8_

[FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
/ -- 2.48.0.rc2.279.g1de40edade-goog ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] doc/protocols: fix/improve RTP documentation

2025-01-15 Thread Stefan Pöschel via ffmpeg-devel
. - -This is a deprecated option. Instead, @option{localrtpport} should be -used. - @end table Important notes: -- 2.39.5 _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, o

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild/bin2c: misc fix

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
or(input) || !feof(input)) +if (ferror(input) || !feof(input)) { +fclose(input); return -1; +} fclose(input); -- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Fix handling of 32bit unsigned sambols

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
> -const int a = FFABS(v); > +const unsigned a = is_signed ? FFABS(v) : v; > const int e = av_log2(a); > put_rac(c, state + 0, 0); > if (e <= 9) { > -- LGTM but s/sambols/symbols/ in the Subject/Git-short-message I suspect. Alexander _

Re: [FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
them and partially tested locally. Nice clean ups. Thank you! Best regards, Alexander _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: Check FLV1 resolution limits

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
produce broken video streams before this patch? Something else only a little related to this patch, but somehow to this one and all that came before. As this is in ff_mpv_encode_init and there are dozens of checks like this and the whole function is around 600 lines, it would be good to refactor t

Re: [FFmpeg-devel] [PATCH] avformat/mov: merge stts and ctts arrays into one

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 10:40 -0300, James Almer wrote: > On 1/10/2025 10:05 AM, James Almer wrote: > > On 1/7/2025 6:50 PM, Alexander Strasser via ffmpeg-devel wrote: > > > On 2025-01-07 10:55 -0300, James Almer wrote: > > > > Should reduce memory usage as w

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: int overflow in start_time_realtime

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
rst_rtcp_ntp_time) - NTP_OFFSET_US; > > if (rtpctx->st) { > > s->start_time_realtime -= > > av_rescale_q (rtpctx->rtcp_ts_offset, > > rtpctx->st->time_base, AV_TIME_BASE_Q); > > --

Re: [FFmpeg-devel] [PATCH] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-08 Thread Alexander Strasser via ffmpeg-devel
hing new AFAICT. > */ > #define AV_FRAME_FLAG_LOSSLESS(1 << 5) > /** > -- LGTM maybe Marton can also comment. Thanks, Alexander ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
led by their employers. > > +@section What is the future plan for FFmpeg Governance? > + > +Governance has 2 goals, 1st to make good decissions for FFmpeg. And 2nd is > to create > +an inclusive and motivating environment where contributors feel valued and > inspired to >

Re: [FFmpeg-devel] [PATCH 2/4] doc/faq: Anwser some questions about he GA, which keep popping up

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
t thru as intended with many people. Third, AFAIU this was to start discussing that issue, but I think it's rather weird to to that in this mixed patch series. Not sure how to proceed, but I would think it's better to at least change the subject when discussing this further or maybe start a new thread by optionally quoting this patch. [...] Best regards, Alexander ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/ipfsgateway: fix capitalizaton mistake

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-07 14:18 -0500, Leo Izen wrote: > Fix the incorrect capitalization of the project name in a comment. > The project is named FFmpeg, not FFMpeg. > > Signed-off-by: Leo Izen > Reported-by: NyanMaths > --- > libavformat/ipfsgateway.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avformat/mov: merge stts and ctts arrays into one

2025-01-07 Thread Alexander Strasser via ffmpeg-devel
, 11,1, 921600, 0x01a16629 > -- Alexander ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/4] doc/faq: Anwser some questions about he GA, which keep popping up

2025-01-06 Thread Kieran Kunhya via ffmpeg-devel
by their employers. > + > @bye > -- > Hi Michael, Can you add that you are exempt from this as you are incorruptible? Regards, Kieran Kunhya > _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] [RFC PATCH] avformat/rtpdec: fix another int overflow in start_time_realtime

2025-01-06 Thread Alexander Strasser via ffmpeg-devel
objections from other developers. Thanks for submitting this patch! Best regards, Alexander _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_grayworld: Use the correct pointer for av_log()

2025-01-06 Thread Alexander Strasser via ffmpeg-devel
uot;Gray world color correction works on > linear light only.\n"); > } > > td.in = in; > -- LGTM Alexander ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_addroi: Add missing NULL termination to addroi_var_names[]()

2025-01-05 Thread Alexander Strasser via ffmpeg-devel
POV they can be variable, from the POV of the single expression evaluation they are constant :) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Backporting makefile targets fate-list-failing and fate-clear-reports

2025-01-04 Thread Alexander Strasser via ffmpeg-devel
Hi all! I'm thinking about backporting commit 1e76bd2f394a01c1 [1] to all releases listed on our download page. It is a new feature for the build system, but not used to build ffmpeg or otherwise related to the generated binaries. It's of utility when doing backports because it makes

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Add max_request_size option

2025-01-02 Thread Lynne via ffmpeg-devel
*1000*reconnect_delay, &h->interrupt_callback); +if (err != AVERROR(ETIMEDOUT)) +return err; +reconnect_delay_total += reconnect_delay; + reconnect_delay = 1 + 2*reconnect_delay; +conn_attempts++; +} seek_re

Re: [FFmpeg-devel] Democratization

2025-01-02 Thread Kieran Kunhya via ffmpeg-devel
Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Democratization

2025-01-02 Thread Kieran Kunhya via ffmpeg-devel
where you are in control as usual. Your recent behaviour of condoning censorship during an election and blocking of contributors on spurious grounds shows that. Read Tom's quote again and practice what you preach. Regards, Kieran Kunhya > _______

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_frei0r: support mixer2 and mixer3 plugins

2025-01-02 Thread Stefan Breunig via ffmpeg-devel
goto end; +} This of course needs to be "if (ret < 0) goto end;", which I missed during review/testing. I'll amend the FATE tests to cover this code path. - Stefan _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:

Re: [FFmpeg-devel] FFmpeg governance

2025-01-02 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 2 Jan 2025, 06:49 compn, wrote: > On Thu, 2 Jan 2025 02:23:08 +, Kieran Kunhya via ffmpeg-devel wrote: > > > On Wed, Jan 1, 2025 at 11:10 PM compn wrote: > > > > > > On Tue, 31 Dec 2024 17:28:31 +, Kieran Kunhya via ffmpeg-devel > > > wrote

Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2025-01-02 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-28 12:56 +0100, Alexander Strasser via ffmpeg-devel wrote: > On 2024-12-27 08:13 -0500, Leo Izen wrote: [...] > > > > I did a bit of testing and I believe the issue is >=, specifically, it's > > being interpreted as a redirect-out to a file named "=&q

Re: [FFmpeg-devel] FFmpeg governance

2025-01-01 Thread Kieran Kunhya via ffmpeg-devel
On Wed, Jan 1, 2025 at 11:10 PM compn wrote: > > On Tue, 31 Dec 2024 17:28:31 +, Kieran Kunhya via ffmpeg-devel > wrote: > > > I personally don't want any control (I am not in GA or CC), I want the > > people to control FFmpeg. > > iirc someone wanted, to

Re: [FFmpeg-devel] [PATCH v2] avformat/vqf: Propagate errors from add_metadata()

2025-01-01 Thread Alexander Strasser via ffmpeg-devel
default: > -add_metadata(s, chunk_tag, len, header_size); > +ret = add_metadata(s, chunk_tag, len, header_size); > +if (ret < 0) > + return ret; > break; > } > > -- LGTM regarding my review comments. Alexand

[FFmpeg-devel] [PATCH 3/4] fate/filter-video: add frei0r and frei0r_src tests

2025-01-01 Thread Stefan Breunig via ffmpeg-devel
6, 0xe2b9de94 +0, 3, 3,1, 16, 0xe2b9de94 +0, 4, 4,1, 16, 0xe2b9de94 -- 2.45.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To uns

[FFmpeg-devel] [PATCH 4/4] avfilter/vf_frei0r: support mixer2 and mixer3 plugins

2025-01-01 Thread Stefan Breunig via ffmpeg-devel
|0.8/0.2 @end example + +@item +Apply the addition effect, which takes two inputs. +@example +ffmpeg -i INPUT1 -i INPUT2 -filter_complex "[0][1]frei0r=addition" OUTPUT +@end example @end itemize +If multiple inputs are given, they all must have the same width and height. +Properties are

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_frei0r: fix time when input is realigned

2025-01-01 Thread Stefan Breunig via ffmpeg-devel
av_frame_copy doesn't copy the input's PTS property, which resulted in the frei0r filter always receiving the same (non-sensical) time. For example, this results in a static distortion, when it should be changing over time: ffmpeg -filter_complex "testsrc2=s=342x142:d=5,frei0r=dis

[FFmpeg-devel] [PATCH 1/4] avfilter/vf_frei0r: fix time not being passed in seconds

2025-01-01 Thread Stefan Breunig via ffmpeg-devel
The frei0r API expects the time in seconds, but was given it in milliseconds. The bug might exist since 41f1d3a (~14 years ago), but plugins depending on the time are unwatchable without this patch. For example: ffmpeg -filter_complex "testsrc2=d=5,frei0r=distort0r" out.mp4 Signed-off-

[FFmpeg-devel] [PATCH 3/3] vulkan_decode: remove informative queries

2025-01-01 Thread Lynne via ffmpeg-devel
m, avctx->thread_count), - nb_q, VK_QUERY_TYPE_RESULT_STATUS_ONLY_KHR, 0, - profile); + 0, 0, 0, profile); if (err < 0) goto fail; -- 2.45.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] ffv1enc_vulkan: allow setting the number of slices via -slices

2025-01-01 Thread Lynne via ffmpeg-devel
t;= 0) { f->num_v_slices = 1024 / f->num_h_slices; } else if (f->num_v_slices && f->num_h_slices <= 0) { -- 2.45.2 _______ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

  1   2   3   4   5   6   7   8   9   10   >