[FFmpeg-devel] STF 2025 grant request (2025-09-01 target)

2025-07-29 Thread Pierre-Anthony Lemieux
Hi all, As with last year, Michael asked me to help coordinate the creation of grant request to the STF: https://trac.ffmpeg.org/wiki/SponsoringPrograms/STF/2025 The objective remains to unlock funds for individuals that are interested in contributing to the FFMPEG codebase. The proposed deadli

Re: [FFmpeg-devel] Funding Proposals

2025-05-23 Thread Pierre-Anthony Lemieux
On Fri, May 23, 2025 at 11:38 AM Leo Izen wrote: > > I'm actually quite out of the loop on how to request funding. I've been > meaning to do it since I'm putting a lot of hours into my EXIF work, and > still got a bunch more. A lot of code is written but much of it is not > tested, and that's impo

Re: [FFmpeg-devel] [PATCH 2/2] avformat/imfdec: inherit opaque from parent AVFormatContext

2025-05-16 Thread Pierre-Anthony Lemieux
On Fri, May 16, 2025 at 8:51 PM Kacper Michajłow wrote: > > io_open and io_close2 callbacks may use opaque pointer stored in the > context. They are already inherited, so opaque should also be passed > through. > > Fixes IMF playback in mpv. > > Signed-off-by: Kacper Michajłow > --- > libavforma

Re: [FFmpeg-devel] [PATCH 2/2] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2025-01-25 Thread Pierre-Anthony Lemieux
On Sat, Jan 25, 2025 at 6:24 PM Michael Niedermayer wrote: > > Hi > > On Tue, Jan 21, 2025 at 06:20:27PM -0800, Pierre-Anthony Lemieux wrote: > > You will need to add "c1p1_04-0.j2c" [1] to > > "fate-suite\jpeg2000\itu-iso\codestreams_profile1". >

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2025-01-22 Thread Pierre-Anthony Lemieux
On Sat, Nov 9, 2024 at 5:40 PM Michael Niedermayer wrote: > > On Fri, Nov 08, 2024 at 01:09:34PM -0800, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > --- > > tests/fate/jpeg2000.mak | 122 ++- > > tes

Re: [FFmpeg-devel] [PATCH 2/2] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2025-01-21 Thread Pierre-Anthony Lemieux
You will need to add "c1p1_04-0.j2c" [1] to "fate-suite\jpeg2000\itu-iso\codestreams_profile1". [1] https://github.com/user-attachments/files/18033833/c1p1_04-0.zip On Tue, Jan 21, 2025 at 6:04 PM wrote: > > From: Pierre-Anthony Lemieux > >

Re: [FFmpeg-devel] Check MSE bound in FATE

2024-12-05 Thread Pierre-Anthony Lemieux
On Mon, Dec 2, 2024 at 11:52 AM Michael Niedermayer wrote: > > Hi > > On Sun, Dec 01, 2024 at 10:17:15PM -0800, Pierre-Anthony Lemieux wrote: > > Hi all, > > > > Osamu and I are looking at adding FATE tests that checks that the MSE > > of a decode image co

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Fix undefined behaviour in left shift operations

2024-12-05 Thread Pierre-Anthony Lemieux
The following no longer return a UB warning after the patch: ./configure --extra-cflags='-fno-sanitize-recover=undefined' --toolchain=gcc-usan make fate-jpeg2000dec make fate-j2k-dwt make fate-vsynth{1,2,3, _lena} Anything else should be included? If not, I will merge at week's end. On Wed, Dec

[FFmpeg-devel] Check MSE bound in FATE

2024-12-01 Thread Pierre-Anthony Lemieux
Hi all, Osamu and I are looking at adding FATE tests that checks that the MSE of a decode image compared to a reference image does not exceed a conformance threshold (see [1]). Is there a precedent for adding small shell scripts along the lines of the following to FATE? https://gist.github.com/p

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2024-11-17 Thread Pierre-Anthony Lemieux
an then apply the conformance requirements specified in the standard? > > > > On Nov 10, 2024, at 10:40, Michael Niedermayer > > wrote: > > > > On Fri, Nov 08, 2024 at 01:09:34PM -0800, p...@sandflow.com wrote: > >> From: Pierre-Anthony Lemieux > >>

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fix undefined behaviour in left shift operations

2024-11-13 Thread Pierre-Anthony Lemieux
On Mon, Nov 11, 2024 at 12:35 AM Osamu Watanabe wrote: > > This patch fixes undefined behaviour error in left shift > operations in jpeg2000dec.c and jpeg2000htdec.c. > > Signed-off-by: Osamu Watanabe > --- > libavcodec/jpeg2000dec.c | 6 +++--- > libavcodec/jpeg2000htdec.c | 6 +++--- > 2 fil

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-07 Thread Pierre-Anthony Lemieux
Ok will merge the patch below. On Thu, Nov 7, 2024 at 9:21 PM WATANABE Osamu wrote: > > Hi Pierre, > > This message is not an error but a warning that stays there before this patch. > > I think the warning is a separate issue. > > Best, > Osamu > > > 2024/11

Re: [FFmpeg-devel] [PATCH v7] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-07 Thread Pierre-Anthony Lemieux
I get with the following error with jpeg2000/itu-iso/codestreams_profile1/p1_03.j2k: `[jpeg2000 @ 0x5c20680] Mid mismatch 1 in pass 18 of 22` On Sat, Nov 2, 2024 at 9:49 PM Osamu Watanabe wrote: > > Fix for the integer version of the inverse 9-7 DWT processing > (FF_DWT97_INT, https://trac.ffmpe

Re: [FFmpeg-devel] [PATCH v6] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-11-02 Thread Pierre-Anthony Lemieux
The patch LTGM with the following nits: - the commit message width - an extra empty line in decode_refpass() Both can be fixed at merge time. A larger question, which is probably best left to later or never, is whether we care that the compression ratio has been changed for a given value of the

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-29 Thread Pierre-Anthony Lemieux
LGTM On Tue, Oct 29, 2024 at 8:43 AM Tomas Härdin wrote: > > tis 2024-10-29 klockan 12:21 -0300 skrev James Almer: > > > From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 > > > 2001 > > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= > > > Date: Tue, 29 Oct 2024 16:13:04 +0100 > > > Subj

Re: [FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file (V2).

2024-10-28 Thread Pierre-Anthony Lemieux
av_pix_fmt_count_planes() in On Thu, Dec 21, 2023 at 3:11 AM Tomas Härdin wrote: > > ons 2023-12-20 klockan 18:04 +0100 skrev Cédric Le Barz: > > Le 19/12/2023 à 14:36, Tomas Härdin a écrit : > > > > +for ( comp = 0; comp < component_count; comp++ ) { > > > > +avio_write(pb, &sc->j2k_

Re: [FFmpeg-devel] [PATCH] jpeg200dec: reset in_tile_headers flag between frames

2024-10-25 Thread Pierre-Anthony Lemieux
The patch has been confirmed to pass all the test cases defined in > ISO/IEC 15444-4. > > > On Oct 25, 2024, at 9:28, Pierre-Anthony Lemieux wrote: > > > > Fixes https://trac.ffmpeg.org/ticket/11266 > > > > On Thu, Oct 24, 2024 at 5:23?PM

Re: [FFmpeg-devel] [PATCH] jpeg200dec: reset in_tile_headers flag between frames

2024-10-24 Thread Pierre-Anthony Lemieux
Fixes https://trac.ffmpeg.org/ticket/11266 On Thu, Oct 24, 2024 at 5:23 PM wrote: > > From: Pierre-Anthony Lemieux > > --- > libavcodec/jpeg2000dec.c | 19 ++- > libavcodec/jpeg2000dec.h | 1 - > 2 files changed, 10 insertions(+), 10 deletions(-) > &

Re: [FFmpeg-devel] [PATCH v5] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-09-12 Thread Pierre-Anthony Lemieux
Looks like a nice improvement. It looks like the size of the codestreams obtained when running `-q: 20` are larger after the patch -- maybe related to the change in the step size calculation, which is now the same for both bitexact and non-bit-exact. Is that expected? I realize `-q` is arbitrary bu

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/jpeg2000dec: Update to JPEG 2000 related FATE refs with the fix of FF_DWT97_INT (integer implementation of inverse DWT 97)

2024-08-29 Thread Pierre-Anthony Lemieux
Looks like more files need to be regenerated: tests/ref/vsynth/vsynth1-jpeg2000-97 tests/ref/vsynth/vsynth2-jpeg2000-97 tests/ref/vsynth/vsynth3-jpeg2000-97 tests/ref/vsynth/vsynth_lena-jpeg2000-97 On Thu, Aug 29, 2024 at 7:07 PM Osamu Watanabe wrote: > > Signed-off-by: Osamu Watanabe > --- >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Update FATE refs for conformance testing defined in ISO/IEC 15444-4

2024-08-29 Thread Pierre-Anthony Lemieux
On Thu, Aug 29, 2024 at 1:29 AM Osamu Watanabe wrote: > > The FATE refs are updated to reflect changes in the [PATCH 1/2]. It looks like the fate-j2k-dwt and fate-jpeg2000-dcinema fate files need to be regenerated as well. > > Signed-off-by: Osamu Watanabe > --- > tests/ref/fate/jpeg2000dec-p0

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add selected conformance codestreams from ISO/IEC 15444-4

2024-08-22 Thread Pierre-Anthony Lemieux
> I have confirmed that FFMPEG passes all the test cases without the flag. > > The problem has been locally solved with the updated code, however, the patch > set is not yet ready. > (It won't take long) > > Best, > Osamu > > > > 2024/08/22 1:01、Pierre-Ant

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add selected conformance codestreams from ISO/IEC 15444-4

2024-08-21 Thread Pierre-Anthony Lemieux
On Wed, Aug 21, 2024 at 8:54 AM Tomas Härdin wrote: > > mån 2024-08-19 klockan 23:03 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > tests/fate/jpeg2000.mak | 129 > > I presume you've tested that the fram

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

2024-08-21 Thread Pierre-Anthony Lemieux
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote: > > tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > > > > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > &

Re: [FFmpeg-devel] [PATCH v8 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-08-06 Thread Pierre-Anthony Lemieux
I plan to apply on Friday, after fixing the few errant trailing spaces. On Tue, Aug 6, 2024 at 8:48 PM Osamu Watanabe wrote: > > This commit adds support for CAP and CPF markers. Decoding will exit when > encountering Ilegal input codestreams. > > Signed-off-by: Osamu Watanabe > --- > libavcod

Re: [FFmpeg-devel] [PATCH v7 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-08-05 Thread Pierre-Anthony Lemieux
Hi Osamu, Below are suggested improvements to error messages. There are also a couple of errant trailing white spaces in jpeg2000htdec.c. Can you fix them? Best, -- Pierre On Sat, Aug 3, 2024 at 10:27 PM Osamu Watanabe wrote: > > This commit adds support for CAP and CPF markers. Decoding wi

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-26 Thread Pierre-Anthony Lemieux
On Fri, Jul 26, 2024 at 2:29 PM Michael Niedermayer wrote: > > On Thu, Jul 25, 2024 at 05:06:04PM -0700, Pierre-Anthony Lemieux wrote: > > On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote: > > > > > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-26 Thread Pierre-Anthony Lemieux
On Fri, Jul 26, 2024 at 1:04 AM Tomas Härdin wrote: > > tor 2024-07-25 klockan 17:06 -0700 skrev Pierre-Anthony Lemieux: > > On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote: > > > > > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux: > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-25 Thread Pierre-Anthony Lemieux
On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote: > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux: > > On Sat, Jul 20, 2024 at 5:12 PM Tomas Härdin wrote: > > > > > > tor 2024-07-18 klockan 23:10 +0900 skrev Pierre-Anthony Lemieux: > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-20 Thread Pierre-Anthony Lemieux
On Sat, Jul 20, 2024 at 5:12 PM Tomas Härdin wrote: > > tor 2024-07-18 klockan 23:10 +0900 skrev Pierre-Anthony Lemieux: > > On Mon, Jul 15, 2024 at 10:33 PM Tomas Härdin wrote: > > > > > > fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux: > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-18 Thread Pierre-Anthony Lemieux
On Mon, Jul 15, 2024 at 10:33 PM Tomas Härdin wrote: > > fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux: > > On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote: > > > > > > > +if (s->in_tile_headers == 1 &am

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-12 Thread Pierre-Anthony Lemieux
On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote: > > > +if (s->in_tile_headers == 1 && s->isHT && (!s- > > >Ccap15_b11)) > > +av_log(s->avctx, AV_LOG_WARNING, "COD marker is > > found in HOMOGENEOUS HT set\n"); > > How bad is this and the other markers being present

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-11 Thread Pierre-Anthony Lemieux
I checked that the patch results in FFMPEG decoding without error the additional conformance codestreams at [1]. [1] https://ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329727.html @Osamu, did you check if the decoded images fall within the tolerances specified in 15444-4? There is an errant spa

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

2024-06-20 Thread Pierre-Anthony Lemieux
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote: > > tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > > > > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > &

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

2024-06-18 Thread Pierre-Anthony Lemieux
On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > p0_10.j2k is one of the reference codestreams included in Rec. ITU-T > > T.803 | ISO/IEC 15444-4. > &

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Add support for placeholder passes, CAP, and CPF markers

2024-06-14 Thread Pierre-Anthony Lemieux
Hi Osamu, Can you provide the list of J2K reference codestreams that this code allows FFMPEG to support -- not including those already supported [1]? [1] https://github.com/FFmpeg/FFmpeg/blob/master/tests/fate/jpeg2000.mak Best, -- Pierre On Fri, Jun 14, 2024 at 8:15 PM Osamu Watanabe wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix tilepart processing

2024-06-13 Thread Pierre-Anthony Lemieux
LGTM. Will merge over the weekend unless I hear otherwise. On Thu, Jun 6, 2024 at 5:25 PM Osamu Watanabe wrote: > > From: Osamu Watanabe <65328111+osamu...@users.noreply.github.com> > > Fix http://trac.ffmpeg.org/ticket/10121 > > Signed-off-by: Osamu Watanabe > --- > libavcodec/jpeg2000dec.c |

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-13 Thread Pierre-Anthony Lemieux
On Sun, Jun 9, 2024 at 9:00 AM Pierre-Anthony Lemieux wrote: > > On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote: > > > > On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote: > > > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > > >> > > &g

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-09 Thread Pierre-Anthony Lemieux
On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote: > > On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote: > > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > >> > >> On 6/8/2024 9:59 PM, p...@sandflow.com wrote: > >>> From: Pierre-Anthony Lemi

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-08 Thread Pierre-Anthony Lemieux
On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > > On 6/8/2024 9:59 PM, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a > > false positive. > > I can't

Re: [FFmpeg-devel] [PATCH 3/9] avformat/imfdec: Simplify get_next_track_with_minimum_timestamp()

2024-06-02 Thread Pierre-Anthony Lemieux
LGTM On Sun, Jun 2, 2024 at 7:16 PM Michael Niedermayer wrote: > > This also makes the code more robust > > Fixes: CID1512414 Uninitialized pointer read > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/imfdec.c | 5 + > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH] configure: correct libopenjpeg description

2024-05-31 Thread Pierre-Anthony Lemieux
On Fri, May 31, 2024 at 8:32 AM Gyan Doshi wrote: > > Decoding is no longer possible as the decoder wrapper was removed > in 60ccb3fe78 > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 96b181fd21..6c5b8aab9a 100755 > --- a/co

Re: [FFmpeg-devel] [PATCH v3] avcodec/jpeg2000dec: fix HT block decoder

2024-05-27 Thread Pierre-Anthony Lemieux
Will apply on 5/30 unless I hear otherwise. On Mon, May 27, 2024 at 9:25 AM wrote: > > From: Pierre-Anthony Lemieux > > Addresses https://trac.ffmpeg.org/ticket/10905 > > Co-authored-by: Osamu Watanabe > Signed-off-by: Pierre-Anthony Lemieux > --- >

Re: [FFmpeg-devel] [RFC PATCH] all: Adapt BSD license headers to avoid fate-source exceptions

2024-05-25 Thread Pierre-Anthony Lemieux
On Sat, May 25, 2024 at 7:57 AM Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > This is against the 80 char line length limit, but it is not > > a hard rule anyway. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > This is an alternative to modifying check-source.sh (for which I also >

Re: [FFmpeg-devel] [RFC PATCH 2/2] tests/fate/source-check: Relax BSD licence check

2024-05-25 Thread Pierre-Anthony Lemieux
On Wed, May 22, 2024 at 4:38 AM Andreas Rheinhardt wrote: > > Several files already had standard license header (namely > 2-clause BSD files), yet due to the 80 char line length limit, > they were not treated as such by source-check.sh (which > fate-source uses). Therefore relax the BSD check. LG

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder

2024-05-19 Thread Pierre-Anthony Lemieux
On Sun, May 19, 2024 at 9:02 AM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Addresses https://trac.ffmpeg.org/ticket/10905 > > > > Co-authored-by: Osamu Watanabe > > Signed-off-by: Pierre-Ant

[FFmpeg-devel] SOW deadline + lessons

2024-02-08 Thread Pierre-Anthony Lemieux
On Thu, Feb 8, 2024 at 5:37 AM Derek Buitenhuis wrote: > > Hello, > > On 2/8/2024 6:02 AM, Pierre-Anthony Lemieux wrote: > > The suggested approach is that interested individuals email me, no > > later than Feb 10 at 23:59 UTC, a completed SOW using the template at > &

[FFmpeg-devel] Call for SOWs [due Feb 10 at 23:59 UTC]

2024-02-07 Thread Pierre-Anthony Lemieux
Hi all, Below is a proposal for creating a proposal to the STF -- I offered to Michael to help, and here we are. The objective, as I understand it, is to unlock funds for individuals that are interested in contributing to the FFMPEG codebase, subject to the STF criteria [1]. The suggested approa

Re: [FFmpeg-devel] [PATCH] [MXF] - Set aspect ratio for jpeg2000 images

2024-01-26 Thread Pierre-Anthony Lemieux
On Fri, Jan 26, 2024 at 10:02 AM Cédric Le Barz wrote: > > Set aspect ratio for jpeg2000 images. "The image area on the reference grid is defined by its upper left hand reference grid point at location (XOsiz, YOsiz), and its lower right hand reference grid point at location (Xsiz – 1, Ysiz – 1)"

[FFmpeg-devel] J2K in HEIF was: [RFC]avformat: introduce AVStreamGroup

2023-09-13 Thread Pierre-Anthony Lemieux
On Wed, Sep 13, 2023 at 2:35 AM Tomas Härdin wrote: > > ons 2023-09-06 klockan 16:16 -0300 skrev James Almer: > > On 9/6/2023 2:53 PM, Tomas Härdin wrote: > > > ons 2023-09-06 klockan 11:38 -0300 skrev James Almer: > > > > Signed-off-by: James Almer > > > > --- > > > > This is an initial proof of

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-14 Thread Pierre-Anthony Lemieux
On Mon, Aug 14, 2023 at 1:14 AM Tomas Härdin wrote: > > lör 2023-08-12 klockan 13:31 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Intended to replace > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.26482-3-mich...@n

Re: [FFmpeg-devel] [PATCH v1] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-12 Thread Pierre-Anthony Lemieux
On Sat, Aug 12, 2023 at 1:31 PM Pierre-Anthony Lemieux wrote: > > On Sat, Aug 12, 2023 at 11:39 AM Michael Niedermayer > wrote: > > > > On Thu, Aug 10, 2023 at 04:48:56PM -0700, p...@sandflow.com wrote: > > > From: Pierre-Anthony Lemieux > > >

Re: [FFmpeg-devel] [PATCH v1] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-12 Thread Pierre-Anthony Lemieux
On Sat, Aug 12, 2023 at 11:39 AM Michael Niedermayer wrote: > > On Thu, Aug 10, 2023 at 04:48:56PM -0700, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Intended to replace > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-10 Thread Pierre-Anthony Lemieux
On Sun, Aug 6, 2023 at 9:28 AM Pierre-Anthony Lemieux wrote: > > On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer > wrote: > > > > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote: > > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-06 Thread Pierre-Anthony Lemieux
On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer wrote: > > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote: > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer > > wrote: > > > > > > This also fixes assertion failures > > >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000htdec: Consolidate jpeg2000 spec bits in jpeg2000_bitbuf_refill_backwards()

2023-08-04 Thread Pierre-Anthony Lemieux
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer wrote: > > Code should make more sense now > > Fixes: out of array access > Fixes: > 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6627570448465920 > > Found-by: continuous fuzzing process > https://github.com/google/os

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-04 Thread Pierre-Anthony Lemieux
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer wrote: > > This also fixes assertion failures > > Fixes: shift exponent 95 is too large for 64-bit type 'unsigned long long' > Fixes: > 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5828618092937216 > > Found-by: continu

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Pierre-Anthony Lemieux
On Thu, Aug 3, 2023 at 1:50 PM Tomas Härdin wrote: > > tor 2023-08-03 klockan 17:36 +0200 skrev Michael Niedermayer: > > On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas Härdin wrote: > > > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > > > > Fixes: freeing of uninitialized pointer

Re: [FFmpeg-devel] [PATCH 1/3] avformat/imf_cpl: Replace NULL content_title_utf8 by ""

2023-07-24 Thread Pierre-Anthony Lemieux
LGTM. On Mon, Jul 24, 2023 at 5:46 PM Michael Niedermayer wrote: > > Suggested-by: Pierre-Anthony Lemieux > Signed-off-by: Michael Niedermayer > --- > libavformat/imf_cpl.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/imf_cpl.c b/libav

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf_cpl: xmlNodeListGetString() can return NULL

2023-07-23 Thread Pierre-Anthony Lemieux
Would this patch be an opportunity to set `cpl->content_title_utf8` to an empty string at fill_content_title() at libavformat/imf_cpl.c if xmlNodeListGetString() returns NULL? It could be done as a separate patch alternatively. LGTM otherwise. On Sun, Jul 23, 2023 at 11:03 AM Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

2023-07-03 Thread Pierre-Anthony Lemieux
+1 On Mon, Jul 3, 2023 at 19:32 Tomas Härdin wrote: > tis 2023-07-04 klockan 01:00 +0200 skrev Michael Niedermayer: > > Suggested-by: Anton > > > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/d

Re: [FFmpeg-devel] [PATCH v2] avformat/imf: clean-up logging * remove log to NULL * remove extraneous logging

2023-05-30 Thread Pierre-Anthony Lemieux
Will apply "soon". On Mon, May 29, 2023 at 9:59 AM wrote: > > From: Pierre-Anthony Lemieux > > --- > libavformat/imf.h | 6 +- > libavformat/imf_cpl.c | 179 +++- > libavformat/imfdec.c| 2 +- > libavform

Re: [FFmpeg-devel] [PATCH] avformat/tests/imf: fix memleak

2023-05-19 Thread Pierre-Anthony Lemieux
On Fri, May 19, 2023 at 5:21 AM "zhilizhao(赵志立)" wrote: > > > > On May 20, 2023, at 01:40, Zhao Zhili wrote: > > > > From: Zhao Zhili > > > > It breaks fate test with asan. > > > > Signed-off-by: Zhao Zhili > > --- > > libavformat/tests/imf.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > I

Re: [FFmpeg-devel] [PATCH v3 1/2] fate/imf: fix memory leak

2023-05-18 Thread Pierre-Anthony Lemieux
Will apply shortly. On Mon, May 15, 2023 at 11:33 AM wrote: > > From: Pierre-Anthony Lemieux > > --- > libavformat/tests/imf.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tests/imf.c b/libavformat/tests/imf.c > i

Re: [FFmpeg-devel] [PATCH] MXF - Add jpeg2000 subdescriptor - Sponsored by INA

2023-05-09 Thread Pierre-Anthony Lemieux
Couple of follow-up comments. - "mxf_parse_jpeg2000_frame" could be moved to one of jpeg2000 source files, to keep J2K parsing code together. Maybe there is a way to reuse jpeg2000_read_main_headers() at jpeg2000dec.c? - when defining the J2K descriptor items, please refer to the symbol name from

Re: [FFmpeg-devel] [PATCH 2/3] avformat/imfdec: fail on probing non xml file extension

2023-05-08 Thread Pierre-Anthony Lemieux
On Mon, May 8, 2023 at 3:01 PM Michael Niedermayer wrote: > > On Mon, May 08, 2023 at 11:40:49AM -0700, Pierre-Anthony Lemieux wrote: > > On Mon, May 8, 2023 at 11:23 AM Michael Niedermayer > > wrote: > > > > > > On Sun, May 07, 2023 at 10:09:58PM -0700, Pier

Re: [FFmpeg-devel] [PATCH 2/3] avformat/imfdec: fail on probing non xml file extension

2023-05-08 Thread Pierre-Anthony Lemieux
On Mon, May 8, 2023 at 11:23 AM Michael Niedermayer wrote: > > On Sun, May 07, 2023 at 10:09:58PM -0700, Pierre-Anthony Lemieux wrote: > > On Sun, May 7, 2023 at 12:18 PM Michael Niedermayer > > wrote: > > > > > > On Sat, May 06, 2023 at 11:01:20AM -0700, Pier

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: fail on probing non mpd file extension

2023-05-08 Thread Pierre-Anthony Lemieux
On Mon, May 8, 2023 at 10:11 AM Michael Niedermayer wrote: > > On Mon, May 08, 2023 at 04:05:40PM +0200, Tobias Rapp wrote: > > On 08/05/2023 14:00, James Almer wrote: > > > > > On 5/6/2023 10:25 AM, Michael Niedermayer wrote: > > > > Its unexpected that a .avi or other "standard" file turns into

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: fail on probing non mpd file extension

2023-05-08 Thread Pierre-Anthony Lemieux
On Mon, May 8, 2023 at 7:05 AM Tobias Rapp wrote: > > On 08/05/2023 14:00, James Almer wrote: > > > On 5/6/2023 10:25 AM, Michael Niedermayer wrote: > >> Its unexpected that a .avi or other "standard" file turns into a > >> playlist. > >> The goal of this patch is to avoid this unexpected behavior

Re: [FFmpeg-devel] [PATCH 2/3] avformat/imfdec: fail on probing non xml file extension

2023-05-07 Thread Pierre-Anthony Lemieux
On Sun, May 7, 2023 at 12:18 PM Michael Niedermayer wrote: > > On Sat, May 06, 2023 at 11:01:20AM -0700, Pierre-Anthony Lemieux wrote: > > On Sat, May 6, 2023 at 6:25 AM Michael Niedermayer > > wrote: > > > > > > Its unexpected that a .avi or other &

Re: [FFmpeg-devel] [PATCH 2/3] avformat/imfdec: fail on probing non xml file extension

2023-05-06 Thread Pierre-Anthony Lemieux
On Sat, May 6, 2023 at 6:25 AM Michael Niedermayer wrote: > > Its unexpected that a .avi or other "standard" file turns into a playlist. > The goal of this patch is to avoid this unexpected behavior and possible > privacy or security differences. Per the IMF specification, a CPL can have any exte

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Explicitly cast quad_width and quad_height to size_t

2023-04-25 Thread Pierre-Anthony Lemieux
On Tue, Apr 25, 2023 at 11:25 AM wrote: > > From: caleb > > Prevents un-necessary casts when calculating buf_size This is to address Coverity CID 1528149: """Suspicious implicit sign extension: "quad_height" with type "uint16_t const" (16 bits, unsigned) is promoted in "4 * quad_width * quad_hei

Re: [FFmpeg-devel] [PATCH] MXF - Add jpeg2000 subdescriptor - Sponsored by INA

2023-04-22 Thread Pierre-Anthony Lemieux
On Wed, Mar 29, 2023 at 1:54 PM Cédric Le Barz wrote: > > Add jpeg2000 subdescriptor in MXF file. > > Signed-off-by: Cedric Le Barz > --- > ffmpeg/libavformat/mxf.h| 1 + > ffmpeg/libavformat/mxfenc.c | 74 - > 2 files changed, 74 insertions(+), 1 dele

Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/jpeg2000dec: add support for HTJ2K block decoding

2023-04-19 Thread Pierre-Anthony Lemieux
On Wed, Apr 19, 2023 at 1:55 PM Tomas Härdin wrote: > > Looks like my comments have been addressed, especially per-CB style Thanks for the review. I plan to merge the patchset this weekend. > > /Tomas > > ___ > ffmpeg-devel mailing list > ffmpeg-devel

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-03-13 Thread Pierre-Anthony Lemieux
On Mon, Mar 13, 2023 at 3:30 PM Marton Balint wrote: > > > > On Fri, 10 Mar 2023, Marton Balint wrote: > > > > > > > On Mon, 6 Mar 2023, Nicolas Gaullier wrote: > > > > The width is one thing; for whatever reason, there is a divergence > > between DV100 on one hand and AVCI/XDCAMHD35 on

[FFmpeg-devel] Making progress re: jpeg2000dec patchsets

2023-02-26 Thread Pierre-Anthony Lemieux
Hi Caleb, Tomas et al., I have been experimenting with combining the HTJ2K patchset [1] and the J2K test patchset [2]: (a) neither valgrind nor the fuzzer seem to complain (b) there are code style/cosmetic issues (c) the HTJ2K block decoder does not yet support placeholder passes [3], which are n

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-02-20 Thread Pierre-Anthony Lemieux
On Mon, Feb 20, 2023 at 9:55 AM Anton Khirnov wrote: > > Quoting p...@sandflow.com (2023-01-06 00:29:44) > > From: Pierre-Anthony Lemieux > > > > --- > > libavformat/imfdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/vf_colorspace: Add SMPTE ST 2084 support

2023-02-03 Thread Pierre-Anthony Lemieux
On Fri, Feb 3, 2023 at 7:54 AM Tomas Härdin wrote: > > We need something better for proper tonemap support, but this is at > least useful for getting the HDR discussion going. Below is a demonstration of two tonemap methods: https://www.sandflow.com/public/tone-mapping/index.html > > /Tomas > _

Re: [FFmpeg-devel] [PATCH] lavf/matroska: add support for ARIB captions

2023-01-13 Thread Pierre-Anthony Lemieux
On Fri, Jan 13, 2023 at 9:27 AM rcombs wrote: > > Not yet ready for merge, pending finalization of the standard proposal for > this mapping: > https://github.com/ietf-wg-cellar/matroska-specification/pull/724 Is sample ARIB caption available? > --- > libavformat/matroska.c| 1 + > libavfo

Re: [FFmpeg-devel] [PATCH v1] fate/imfdec: add audio test

2023-01-09 Thread Pierre-Anthony Lemieux
Quick ping. This adds an audio test for the IMF demuxer FATE suite, which currently only has image tests. On Thu, Dec 29, 2022 at 11:12 PM wrote: > > From: Pierre-Anthony Lemieux > > Adds an audio test for the IMF demuxer. > > FATE content at https://www.sandflow.com/public/c

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-01-06 Thread Pierre-Anthony Lemieux
On Fri, Jan 6, 2023 at 8:09 AM Tomas Härdin wrote: > > fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux: > > On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin wrote: > > > > > > tor 2023-01-05 klockan 15:29 -0800 skrev p...@sandflow.com: > &

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-01-06 Thread Pierre-Anthony Lemieux
On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin wrote: > > tor 2023-01-05 klockan 15:29 -0800 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > libavformat/imfdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > &g

Re: [FFmpeg-devel] GSoC 2023

2022-12-15 Thread Pierre-Anthony Lemieux
I have updated the page with the HTJ2K project. This is a good opportunity to ask for help completing the review of the patchset: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=8078 All known issues have been resolved and it would be good to merge soon, i.e. beat the iron while it is h

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for HTJ2K decoding.

2022-12-12 Thread Pierre-Anthony Lemieux
On Fri, Dec 2, 2022 at 10:46 AM Tomas Härdin wrote: > > fre 2022-12-02 klockan 21:11 +0300 skrev etemesica...@gmail.com: > > > > +/** > > + * Given a precomputed c, checks whether n % d == 0 > > + */ > > +static av_always_inline uint32_t is_divisible(uint32_t n, uint64_t > > c) > > +{ > > +re

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: use CPL start timecode if available

2022-10-28 Thread Pierre-Anthony Lemieux
Hi Zane et al., Quick ping on the revised patchset below. It addresses https://trac.ffmpeg.org/ticket/9842. Best, -- Pierre On Sun, Oct 2, 2022 at 9:28 AM wrote: > > From: Pierre-Anthony Lemieux > > The IMF CPL contains an optional timecode start address. This patch reads the

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Pierre-Anthony Lemieux
On Tue, Oct 4, 2022 at 7:59 AM Tomas Härdin wrote: > > tis 2022-10-04 klockan 07:50 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > > > > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > > >

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Pierre-Anthony Lemieux
On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > Thanks, Pierre-Anthony. I've updated the patch to remove the > > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV > > packet. > > > > Signed-off-by: Richard Ayres

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-03 Thread Pierre-Anthony Lemieux
On Mon, Oct 3, 2022 at 1:11 AM Julio C. Rocha wrote: > > On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux > wrote: > > > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler > > wrote: > > > > > > On 03.10.2022 01:47, Julio C. Rocha

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-02 Thread Pierre-Anthony Lemieux
On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler wrote: > > On 03.10.2022 01:47, Julio C. Rocha wrote: > > --- > > configure | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 6712d045d9..f5f5eb29dd 100755 > > --- a/configure > >

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available

2022-10-02 Thread Pierre-Anthony Lemieux
On Tue, Sep 27, 2022 at 5:40 AM Zane van Iperen wrote: > > Looks mostly ok from a cursory glance, just one minor nit. > > On 23/8/22 15:10, p...@sandflow.com wrote: > > > > +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value) > > +{ > > +xmlChar *element_text = NULL; > > +in

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-09-30 Thread Pierre-Anthony Lemieux
On Fri, Sep 30, 2022 at 7:08 AM Richard Ayres wrote: > > We had an issue where ffmpeg was unable to unpack the EKLV of an encrypted 3D > SMPTE DC MXF. > > The patch adds the SMPTE UL for EKLV packets > (060e2b34.02040101.0d010301.027e0100), to mxfdec.c in order to unpack an EKLV > packet found

[FFmpeg-devel] Ping Re: [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available

2022-09-25 Thread Pierre-Anthony Lemieux
/48fa27e77a6d71be89f216cee13ae7e99d2b5003 Now that [1] has been merged, On Mon, Sep 5, 2022 at 11:06 AM Pierre-Anthony Lemieux wrote: > > Just a quick ping. > > Looking forward to feedback. > > This patchset is intended to address https://trac.ffmpeg.org/ticket/9842. > > > On Mon, Aug

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-19 Thread Pierre-Anthony Lemieux
On Mon, Sep 19, 2022 at 7:42 AM Michael Niedermayer wrote: > > On Sat, Sep 17, 2022 at 08:57:37AM -0700, Pierre-Anthony Lemieux wrote: > > On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer > > wrote: > > > > > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pier

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-17 Thread Pierre-Anthony Lemieux
On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer wrote: > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer > > wrote: > > > > > > On Fri, Sep 16, 2022 at 10:39:22AM -0700, Pier

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-16 Thread Pierre-Anthony Lemieux
On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer wrote: > > On Fri, Sep 16, 2022 at 10:39:22AM -0700, Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer > > wrote: > > > > > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-16 Thread Pierre-Anthony Lemieux
On Fri, Sep 16, 2022 at 10:39 AM Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer > wrote: > > > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p...@sandflow.com wrote: > > > From: Pierre-Anthony Lemieux > >

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-16 Thread Pierre-Anthony Lemieux
On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer wrote: > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Addresses coverity 1512414 > > > > --- > > libavformat/imfdec.c | 15

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add maintainer for the imf demuxer

2022-09-15 Thread Pierre-Anthony Lemieux
On Thu, Sep 15, 2022 at 4:07 PM Lynne wrote: > > Sep 16, 2022, 00:46 by p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINER

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-14 Thread Pierre-Anthony Lemieux
Ping. This patchset addresses a coverity issue #1512414. On Wed, Sep 7, 2022 at 1:02 PM wrote: > > From: Pierre-Anthony Lemieux > > Addresses coverity 1512414 > > --- > libavformat/imfdec.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/mxf: set stream frame rates for ST 422 essence containers

2022-09-14 Thread Pierre-Anthony Lemieux
Ping. All outstanding feedback has been addressed AFAIK. This patchset addresses https://trac.ffmpeg.org/ticket/9856 On Tue, Sep 6, 2022 at 2:51 PM wrote: > > From: Pierre-Anthony Lemieux > > The MXF demuxer does not currently set AVStream::avg_frame_rate and > ::r_frame_

  1   2   3   >