On Tue, Sep 27, 2022 at 5:40 AM Zane van Iperen <z...@zanevaniperen.com> wrote:
>
> Looks mostly ok from a cursory glance, just one minor nit.
>
> On 23/8/22 15:10, p...@sandflow.com wrote:
> >
> > +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value)
> > +{
> > + xmlChar *element_text = NULL;
> > + int ret = 0;
> > +
> > + element_text = xmlNodeListGetString(element->doc,
> > element->xmlChildrenNode, 1);
> > +
>
> No need for "element_text = NULL".
Addressed at v2.
>
> >
> > +static int digit_to_int(char digit)
> > +{
> > + if (digit >= '0' && digit <= '9')
> > + return digit - '0';
> > + return -1;
> > +}
> > +
>
> I feel like there should be a av_* helper for this, but apparently there
> isn't.
> Maybe it's worth adding one in a future patch? av_isdigit() is in avstring.h,
> so
> perhaps there?
Ok. This probably requires more planning since the idioms `x >= '0' &&
x <= '9'` and `x >= 'a' && x <= 'z'` are used in many places.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
