Re: [FFmpeg-devel] [PATCH v4 1/8] lavc/vaapi_dec: Create VA parameters dynamically

2024-10-29 Thread Xiang, Haihao
On Ma, 2024-10-28 at 16:55 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_decode.c | 34 +- >  libavcodec/vaapi_decode.h |  7 ++- >  2 files changed, 27 insertions(+), 14 deletions(-) > >

Re: [FFmpeg-devel] Add support for LJ92 compressed MLV files, attempt 02

2024-10-29 Thread South East
Thanks for taking a look! On Tue, 29 Oct 2024 at 15:25, Tomas Härdin wrote: > > -#define MLV_CLASS_FLAG_DELTA 0x40 > > #define MLV_CLASS_FLAG_LZMA 0x80 > > +#define MLV_CLASS_FLAG_DELTA 0x40 > > +#define MLV_CLASS_FLAG_LJ92 0x20 > > This hunk could be simpler if you didn't move MLV_CLASS_FLAG_

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-29 Thread James Almer
On 10/29/2024 4:29 PM, Michael Niedermayer wrote: On Tue, Oct 29, 2024 at 01:03:21PM +0100, Michael Niedermayer wrote: On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: On 10/25/2024 7:18 PM, Michael Niedermayer wrote: On Wed, Oct 23, 2024 at 04:36:44PM -0300, James Almer wrote: Si

[FFmpeg-devel] [PATCH v3] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-10-29 Thread IndecisiveTurtle
Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths. Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes about 30 seconds on my NVIDIA

Re: [FFmpeg-devel] [PATCH v2] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-10-29 Thread Michael Niedermayer
On Sun, Oct 27, 2024 at 04:28:27PM +0200, IndecisiveTurtle wrote: > Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets > and should work with all wavelet depths. > > Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 > minutes with the cpu encoder

Re: [FFmpeg-devel] [PATCH 11/15] avformat/flacdec:Return correct error-codes on read-failure

2024-10-29 Thread Tomas Härdin
tis 2024-10-29 klockan 18:42 +0100 skrev Michael Niedermayer: > On Tue, Oct 29, 2024 at 03:50:05PM +0100, Tomas Härdin wrote: > > Reasonable enough. Might want a sample > > > > Spotify comments > > > > Unexpected EOF is treated as invalid data > > > > /Tomas > > >  flacdec.c |  

[FFmpeg-devel] [PATCH] swscale/output: fix x2rbg10/x2bgr10 output

2024-10-29 Thread James Almer
Checking for AV_PIX_FMT_X2RGB10 means the condition will succeed only for the version matching the host's endinaness, when only LE is supported, and thus the wrong path will be taken on BE systems. Signed-off-by: James Almer --- libswscale/output.c | 12 +--- 1 file changed, 5 insertions

[FFmpeg-devel] [PATCH] Patch to add interlaced HEVC decoding to HEVCDEC

2024-10-29 Thread Jose Santiago
From 349d0751a6aee1f7380a379d207311c161451a83 Mon Sep 17 00:00:00 2001 From: Jose Santiago Date: Tue, 29 Oct 2024 15:58:30 -0500 Subject: [PATCH] Patch to add interlaced HEVC decoding to HEVCDEC --- src/libavcodec/hevc/hevcdec.c |  24 +- src/libavcodec/hevc/hevcdec.h |  13 ++ src/libavcode

[FFmpeg-devel] [PATCH] Cosmetics; be consistant in printing Master Display side data info

2024-10-29 Thread Grozdan
Hi, This is a small one-liner. Correct a few inconsistencies when printing Master Display Metadata info. --- ffmpeg.old/libavcodec/h2645_sei.c 2024-10-29 21:42:27.630338816 +0100 +++ ffmpeg/libavcodec/h2645_sei.c 2024-10-29 21:49:24.026514630 +0100 @@ -668,7 +668,7 @@ av_log(avctx

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-29 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 01:03:21PM +0100, Michael Niedermayer wrote: > On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: > > On 10/25/2024 7:18 PM, Michael Niedermayer wrote: > > > On Wed, Oct 23, 2024 at 04:36:44PM -0300, James Almer wrote: > > > > Signed-off-by: James Almer > > > > --

[FFmpeg-devel] [PATCH] swscale/swscale_unscaled: add unscaled conversion for AYUV/VUYA/UYVA

2024-10-29 Thread James Almer
Signed-off-by: James Almer --- libswscale/rgb2rgb.c | 4 libswscale/rgb2rgb.h | 4 libswscale/rgb2rgb_template.c | 8 libswscale/swscale_unscaled.c | 21 + 4 files changed, 37 insertions(+) diff --git a/libswscale/rgb2rgb.c b/libswscale

Re: [FFmpeg-devel] [PATCH 11/15] avformat/flacdec:Return correct error-codes on read-failure

2024-10-29 Thread Michael Niedermayer
On Tue, Oct 29, 2024 at 03:50:05PM +0100, Tomas Härdin wrote: > Reasonable enough. Might want a sample > > Spotify comments > > Unexpected EOF is treated as invalid data > > /Tomas > flacdec.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > 8cf

Re: [FFmpeg-devel] [PATCH 04/19] fate/audio: fix ffprobe dependency instead of ffmpeg

2024-10-29 Thread Tomas Härdin
sön 2024-10-27 klockan 02:09 +0200 skrev Nicolas Gaullier: > Signed-off-by: Nicolas Gaullier > --- >  tests/fate/audio.mak | 6 -- >  1 file changed, 4 insertions(+), 2 deletions(-) Fixes fate-flcl1905 on a clean build /Tomas ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-29 Thread Tomas Härdin
tis 2024-10-29 klockan 12:21 -0300 skrev James Almer: > > From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 > > 2001 > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= > > Date: Tue, 29 Oct 2024 16:13:04 +0100 > > Subject: [PATCH] lavf/mxfenc: Use nb_components, not > > av_pix_fmt_count_pla

Re: [FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file (V2).

2024-10-29 Thread Tomas Härdin
sön 2024-10-27 klockan 21:06 -0700 skrev Pierre-Anthony Lemieux: > av_pix_fmt_count_planes() in > > On Thu, Dec 21, 2023 at 3:11 AM Tomas Härdin wrote: > > > > ons 2023-12-20 klockan 18:04 +0100 skrev Cédric Le Barz: > > > Le 19/12/2023 à 14:36, Tomas Härdin a écrit : > > > > > +    for ( comp =

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-29 Thread Pierre-Anthony Lemieux
LGTM On Tue, Oct 29, 2024 at 8:43 AM Tomas Härdin wrote: > > tis 2024-10-29 klockan 12:21 -0300 skrev James Almer: > > > From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 > > > 2001 > > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= > > > Date: Tue, 29 Oct 2024 16:13:04 +0100 > > > Subj

[FFmpeg-devel] [PATCH 10/15] Add statistic for number of avio_seek() calls done

2024-10-29 Thread Tomas Härdin
I think we can drop this one. I thought I'd post it to the list either way Spotify comments To be able to detect severely fragmented MP4 files, and trigger special handling for them (reducing Photon chunk concurrency). For these files, the default handling causes so much I/O from

Re: [FFmpeg-devel] [PATCH 05/15] libavformat/flacdec: Export samples md5 as metadata

2024-10-29 Thread Tomas Härdin
tis 2024-10-29 klockan 11:57 -0300 skrev James Almer: > On 10/29/2024 11:47 AM, Tomas Härdin wrote: > > Could maybe use some kind of compile-time assert that > > FLAC_STREAMINFO_SIZE == MD5_BYTE_SIZE + 18. I'm thinking putting in > > st- > > > codecpar->extradata + st->codecpar->extradata_size - >

[FFmpeg-devel] [PATCH 07/15] avformat/mov:Heuristic search for moov

2024-10-29 Thread Tomas Härdin
Needs sample. Also might be incorrect if mdat has moov atoms inside mdat for some reason. But the concept is reasonable enough - mov files tend to have the moov atom either in the header or in the footer. The need for this patch may have been deprecated by the introduction of mfra parsing, which is

Re: [FFmpeg-devel] Add support for LJ92 compressed MLV files, attempt 02

2024-10-29 Thread Tomas Härdin
tor 2024-10-24 klockan 18:59 +0100 skrev South East: > ffmpeg has existing support for MLV raw video files; > libavformat/mlvdec.c. > Since this was added, MLV has been extended to support LJ92 > compressed > image data.  These patches build on lossless DNG support in 7.2-dev > to > enable handling

[FFmpeg-devel] [PATCH 04/15] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors

2024-10-29 Thread Tomas Härdin
Needs a sample. Spotify comments a known broken wma input file fails with ambiguous error code and is treated as a transient instead of a permanent error. /Tomas From 5715032d028695ecc6bf69e88046dbe37620aa12 Mon Sep 17 00:00:00 2001 From: Jonathan Murray Date: Wed, 9 Jun 2021 1

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-29 Thread James Almer
From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 29 Oct 2024 16:13:04 +0100 Subject: [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes() This fixed https://trac.ffmpeg.org/ticket/11267 --- libavformat/mxfen

[FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-10-29 Thread Tomas Härdin
From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 29 Oct 2024 16:13:04 +0100 Subject: [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes() This fixed https://trac.ffmpeg.org/ticket/11267 --- libavformat/mxfen

[FFmpeg-devel] [PATCH 05/15] libavformat/flacdec: Export samples md5 as metadata

2024-10-29 Thread Tomas Härdin
Could maybe use some kind of compile-time assert that FLAC_STREAMINFO_SIZE == MD5_BYTE_SIZE + 18. I'm thinking putting in st- >codecpar->extradata + st->codecpar->extradata_size - MD5_BYTE_SIZE for the offset Spotify comments Make it possible to verify sample checksum for FLAC fil

Re: [FFmpeg-devel] [PATCH 05/15] libavformat/flacdec: Export samples md5 as metadata

2024-10-29 Thread James Almer
On 10/29/2024 11:47 AM, Tomas Härdin wrote: Could maybe use some kind of compile-time assert that FLAC_STREAMINFO_SIZE == MD5_BYTE_SIZE + 18. I'm thinking putting in st- codecpar->extradata + st->codecpar->extradata_size - MD5_BYTE_SIZE for the offset Spotify comments Make it

[FFmpeg-devel] [PATCH 11/15] avformat/flacdec:Return correct error-codes on read-failure

2024-10-29 Thread Tomas Härdin
Reasonable enough. Might want a sample Spotify comments Unexpected EOF is treated as invalid data /Tomas From 4d803c5f5c13e194a0e52d287f021b73ec7172bd Mon Sep 17 00:00:00 2001 From: Ulrik Date: Thu, 26 Jan 2023 17:51:02 +0100 Subject: [PATCH 11/15] avformat/flacdec:Return correc

[FFmpeg-devel] [PATCH 15/15] Make mime-type award a bonus probe score

2024-10-29 Thread Tomas Härdin
Some samples would be nice. The commit messages mentions many millions of files, which we obviously can't fit into the FATE suite. But one or two would be nice Spotify comments None /Tomas From 30e364f3b8d382f2ec59254ca41fc8a25f1133ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pete

[FFmpeg-devel] [PATCH 14/15] avformat/mp3dec: Subtract known padding from duration

2024-10-29 Thread Tomas Härdin
Reasonable enough Spotify comments Wrong duration due to not distracting padding samples. Reported upstream: https://trac.ffmpeg.org/ticket/10163 (has patch) was also sent as a patch to the dev mailing with subject “[FFmpeg-devel] [PATCH v3] avformat/mp3dec: Subtract known paddi

[FFmpeg-devel] [PATCH 13/15] avformat/mov: Add more moov and moov child heuristic checks

2024-10-29 Thread Tomas Härdin
This makes me feel we should probably just rely on mfra Spotify comments None /Tomas From c3adfabb5ad565f562c6a187c2fa2913755d4345 Mon Sep 17 00:00:00 2001 From: Mattias Wadman Date: Fri, 26 May 2023 14:16:58 +0200 Subject: [PATCH 13/15] avformat/mov: Add more moov and moov chil

[FFmpeg-devel] [PATCH 12/15] GOL-1361: Remove invalid CTTS sample_offset check

2024-10-29 Thread Tomas Härdin
Needs a sample Spotify comments mp4 file fails to demux due to CTTS sample offset check that seems to contradict specification https://github.com/FFmpeg/FFmpeg/commit/4093220029a4d77f272c491e9299680480a08c00 the trac ticket for that change: https://trac.ffmpeg.org/ticket/385 a n

[FFmpeg-devel] [PATCH 09/15] rtmp: Set correct message stream id when writing as server

2024-10-29 Thread Tomas Härdin
Don't know enough RTMP to comment on. Since the ticket is still open on red5's github repo I presume this is still an issue Spotify comments Interop issue with red5 RTMP server. Is unknown if this is a bug in red5 or ffmpeg as the RTMP spec is vague and the ffmpeg code uses differ

[FFmpeg-devel] [PATCH 08/15] avformat/mov:Do not set `next_root_atom` for unfragmented files

2024-10-29 Thread Tomas Härdin
Needs sample. Not a huge fan of heuristics like this - surely there's a way to tell within the first mdat/moov/moof seen? Spotify comments Failure to parse non-fragmented file with many mdat-boxes /Tomas From 1c67cfd91cc3d18a2e4e1402bb439fe4db0f76b2 Mon Sep 17 00:00:00 2001 From

[FFmpeg-devel] [PATCH 06/15] flac: Increase change penalty and header lookahead

2024-10-29 Thread Tomas Härdin
Needs sample 'Revert "flac: Increase change penalty and header lookahead"' reverts this, so it seems it's no longer necessary. I therefore haven't bothered mailing in that patch Spotify comments Decrease possibility for flac demuxer frame detect heuristics to find false frame sta

[FFmpeg-devel] [PATCH 03/15] libaformat/mp3dec: Register the MIME type "audio/mpeg" to the mp3 decoder.

2024-10-29 Thread Tomas Härdin
Reasonable enough Spotify comments mp3 input misdetected as mpeg ps and fails to decode Possible other solutions: • Improve mp3 probe code to give higher score • Improve mpeg ps probe code to give lower score • Make it possible at runtime to enable/disable format/code

[FFmpeg-devel] [PATCH 02/15] avformat/http: Return EIO for prematurely broken connection

2024-10-29 Thread Tomas Härdin
Use of stdbool.h might cause issues on some platforms. Otherwise looks reasonable to me. Spotify comments Might not be a priority anymore when we’re using a caching http proxy to hide some network problems. /Tomas From d42ebdc41d02ade1921b91f278e90a15ce33a32f Mon Sep 17 00:00:00

[FFmpeg-devel] [PATCH 01/15] libavformat: Increase probe buffer to 16MB

2024-10-29 Thread Tomas Härdin
Needs a sample. An option or setting for probe size might be a good idea Spotify comments In mp3 files, id3v2 tag with huge cover art causes the probe code to not identify valid mp3 files as mp3. Increase default buffer so that probe can see mp3 frames. Might not be a priority as

[FFmpeg-devel] [PATCH 00/15] Spotify patchset

2024-10-29 Thread Tomas Härdin
Hi This is a set of patches that Spotify wants upstreamed, based on n6.0.1. I have rebased all of them except except "[PATCH 03/18] fftools/ffmpeg: Always exit_program(1) for I/O-errors" which seems to need a rewrite due to large changes in fftools since n6.0.1. For now I want feedback on the patc

[FFmpeg-devel] HEVC: video_delay is larger in decoder than demuxer

2024-10-29 Thread Danny Wilson
I would like transcode a file with HEVC to a live stream with AVC. The HEVC demuxer reports many errors: > [hevc @ 0x25a3140] video_delay is larger in decoder than demuxer > If you want to help, upload a sample of this file to > https://streams.videolan.org/upload/ and contact the ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-29 Thread Michael Niedermayer
On Fri, Oct 25, 2024 at 07:56:29PM -0300, James Almer wrote: > On 10/25/2024 7:18 PM, Michael Niedermayer wrote: > > On Wed, Oct 23, 2024 at 04:36:44PM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libswscale/output.c | 37 +++

Re: [FFmpeg-devel] [PATCH v4 00/13] major refactor and new scaling API

2024-10-29 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 12:25:10PM +0200, Niklas Haas wrote: > Changes since v3: > - Make SwsInternal a superset of SwsContext, instead of a separate struct > - Fix minor bug in the calculation of SWS_STRICT > > I overall prefer this version, it simplifies things and allows us to split > apart the

Re: [FFmpeg-devel] [PATCH v4 01/13] swscale: rename SwsContext to SwsInternal

2024-10-29 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 12:25:11PM +0200, Niklas Haas wrote: > From: Niklas Haas > > And preserve the public SwsContext as separate name. The motivation here > is that I want to turn SwsContext into a public struct, while keeping the > internal implementation hidden. Additionally, I also want to

Re: [FFmpeg-devel] [PATCH v4 13/13] avfilter/vf_scale: switch to new swscale API

2024-10-29 Thread Michael Niedermayer
On Thu, Oct 24, 2024 at 12:25:23PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Most logic from this filter has been co-opted into swscale itself, > allowing the resulting filter to be substantially simpler as it no > longer has to worry about context initialization, interlacing, etc. > > S