Needs a sample. An option or setting for probe size might be a good
idea

Spotify comments
----------------
In mp3 files, id3v2 tag with huge cover art causes the probe code to
not identify valid mp3 files as mp3. Increase default buffer so that
probe can see mp3 frames.

Might not be a priority as we could use an option to change this. The
reason we did it this way historically is to make sure ffmpeg in
different services behaved the same.

/Tomas
From 0d350c8e2debfbbc6e0b516bec4d0107bcad66ba Mon Sep 17 00:00:00 2001
From: Mattias Wadman <mattias.wad...@gmail.com>
Date: Tue, 6 Oct 2020 12:18:23 +0200
Subject: [PATCH 01/15] libavformat: Increase probe buffer to 16MB

---
 libavformat/internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/internal.h b/libavformat/internal.h
index b909adf209..dc60f31cdf 100644
--- a/libavformat/internal.h
+++ b/libavformat/internal.h
@@ -31,7 +31,7 @@
 
 /** size of probe buffer, for guessing file type from file contents */
 #define PROBE_BUF_MIN 2048
-#define PROBE_BUF_MAX (1 << 20)
+#define PROBE_BUF_MAX (16 << 20)
 
 #ifdef DEBUG
 #    define hex_dump_debug(class, buf, size) av_hex_dump_log(class, AV_LOG_DEBUG, buf, size)
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to