Re: [FFmpeg-devel] [PATCH] avformat/mov: Ignore duplicate ftyp

2023-12-01 Thread epirat07
On 2 Dec 2023, at 0:26, Michael Niedermayer wrote: > Fixes: switch_1080p_720p.mp4 > Found-by: Dale Curtis > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > inde

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Disallow FTYP after streams

2023-12-01 Thread Michael Niedermayer
On Fri, Dec 01, 2023 at 10:27:20AM -0800, Dale Curtis wrote: > FWIW, this ends up breaking files which are basically just > concatenated fragmented mp4 files -- which is pretty sketchy, but we had > some test content doing that: > https://storage.googleapis.com/chromiumos-test-assets-public/Shaka-D

[FFmpeg-devel] [PATCH] avformat/mov: Ignore duplicate ftyp

2023-12-01 Thread Michael Niedermayer
Fixes: switch_1080p_720p.mp4 Found-by: Dale Curtis Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f7b5ec7a352..fb5d6f49138 100644 --- a/libavformat/mov.c +++ b/libavfor

Re: [FFmpeg-devel] [PATCH] Fix integer overflow in mov_read_packet().

2023-12-01 Thread Michael Niedermayer
On Fri, Dec 01, 2023 at 10:52:21AM -0800, Dale Curtis wrote: > On Fri, Nov 24, 2023 at 3:38 PM Michael Niedermayer > wrote: > > > On Wed, Nov 22, 2023 at 02:20:59PM -0800, Dale Curtis wrote: > > > Fixes https://crbug.com/1499669: > > > > > runtime error: signed integer overflow: 92233720368533342

[FFmpeg-devel] [PATCH] avfilter/libvmaf: small cleanup for style, whitespace, unused

2023-12-01 Thread Kyle Swanson
Hi, Small cleanup patch for vf_libvmaf.c. Will apply soon. Thanks, Kyle 0001-avfilter-libvmaf-small-cleanup-for-style-whitespace-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-12-01 Thread Paul B Mahol
On Fri, Dec 1, 2023 at 10:13 PM Kyle Swanson wrote: > Hi, > > On Fri, Dec 1, 2023 at 2:37 AM Paul B Mahol wrote: > > Keeping old code will not make patch any prettier. > > It's not really about pretty, it's about splitting up the patch so we > can do things one at a time. I think the change to u

Re: [FFmpeg-devel] RISC-V dev kit recommendations

2023-12-01 Thread Rémi Denis-Courmont
Le perjantaina 1. joulukuuta 2023, 21.44.24 EET Sean McGovern a écrit : > If I wanted to purchase a RISC-V developer kit, does anyone have > suggestions of what to buy? Or even what to steer clear of? As this is FFmpeg-devel, I don't suppose you are looking for a microcontroller. To run Linux, th

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-12-01 Thread Kyle Swanson
Hi, On Fri, Dec 1, 2023 at 2:37 AM Paul B Mahol wrote: > Keeping old code will not make patch any prettier. It's not really about pretty, it's about splitting up the patch so we can do things one at a time. I think the change to use f_ebur128.c loudness computation might have some advantages, bu

Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

2023-12-01 Thread flow gg
I forgot to modify the Makefile; I've made the changes in this reply. flow gg 于2023年12月2日周六 03:50写道: > Okay, changed and attached > > Rémi Denis-Courmont 于2023年12月2日周六 02:38写道: > >> Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a >> écrit : >> > Le perjantaina 24. marrasku

Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

2023-12-01 Thread flow gg
Okay, changed and attached Rémi Denis-Courmont 于2023年12月2日周六 02:38写道: > Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a > écrit : > > Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit : > > > Okay, changed > > > > src/libavcodec/riscv/ac3dsp_init.c: In functi

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Anton Khirnov
Quoting Nicolas George (2023-12-01 16:25:04) > Anton Khirnov (12023-12-01): > > http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-November/316787.html > > So not Wednesday but Tursday three weeks ago. The Wednesday email was the one I linked to two emails ago. Here it is again: http://lists.ffm

[FFmpeg-devel] RISC-V dev kit recommendations

2023-12-01 Thread Sean McGovern
Hi, If I wanted to purchase a RISC-V developer kit, does anyone have suggestions of what to buy? Or even what to steer clear of? Thanks, Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/6] lavc/aarch64: new optimization for 8-bit hevc_pel_bi_pixels

2023-12-01 Thread Martin Storsjö
On Fri, 24 Nov 2023, Martin Storsjö wrote: Hi Logan, On Fri, 24 Nov 2023, Logan.Lyu wrote: And  can you try those .patch files I attached in every email?  I downloaded the attachment from the ffmpeg-devel mailing list I subscribed to and applied it, and it seems to work. Oh, I see - I didn

Re: [FFmpeg-devel] [PATCH] Fix integer overflow in mov_read_packet().

2023-12-01 Thread Dale Curtis
On Fri, Nov 24, 2023 at 3:38 PM Michael Niedermayer wrote: > On Wed, Nov 22, 2023 at 02:20:59PM -0800, Dale Curtis wrote: > > Fixes https://crbug.com/1499669: > > > runtime error: signed integer overflow: 9223372036853334272 + 1375731456 > > this looks a bit close to AV_NOPTS_VALUE but its not ac

Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

2023-12-01 Thread Rémi Denis-Courmont
Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a écrit : > Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit : > > Okay, changed > > src/libavcodec/riscv/ac3dsp_init.c: In function ‘ff_ac3dsp_init_riscv’: > src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assi

Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

2023-12-01 Thread Rémi Denis-Courmont
Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit : > Okay, changed src/libavcodec/riscv/ac3dsp_init.c: In function ‘ff_ac3dsp_init_riscv’: src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assignment to ‘void (*) (int32_t *, const float *, size_t)’ {aka ‘void (*)(int *, const floa

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Disallow FTYP after streams

2023-12-01 Thread Dale Curtis
FWIW, this ends up breaking files which are basically just concatenated fragmented mp4 files -- which is pretty sketchy, but we had some test content doing that: https://storage.googleapis.com/chromiumos-test-assets-public/Shaka-Dash/switch_1080p_720p.mp4 Is that intentional? Or should an alternat

Re: [FFmpeg-devel] [PATCH 2/6] lavc/aarch64: new optimization for 8-bit hevc_epel_bi_h

2023-12-01 Thread Martin Storsjö
On Sat, 18 Nov 2023, Logan.Lyu wrote: diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S b/libavcodec/aarch64/hevcdsp_epel_neon.S index 74165273d7..070c8c9990 100644 --- a/libavcodec/aarch64/hevcdsp_epel_neon.S +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S @@ -423,6 +423,263 @@ function ff_hevc

Re: [FFmpeg-devel] [PATCH 5/6] lavc/aarch64: new optimization for 8-bit hevc_qpel_bi_v

2023-12-01 Thread Martin Storsjö
On Sat, 18 Nov 2023, Logan.Lyu wrote: +function ff_hevc_put_hevc_qpel_bi_v48_8_neon, export=1 +mov x8, #32 +str x8, [sp, #-80]! Why are you storing an immediate constant on the stack here? +stp x4, x5, [sp, #16] +stp

Re: [FFmpeg-devel] [PATCH 4/6] lavc/aarch64: new optimization for 8-bit hevc_epel_bi_hv

2023-12-01 Thread Martin Storsjö
On Sat, 18 Nov 2023, Logan.Lyu wrote: diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S b/libavcodec/aarch64/hevcdsp_epel_neon.S index 54e55cd508..b60091bf23 100644 --- a/libavcodec/aarch64/hevcdsp_epel_neon.S +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S +function ff_hevc_put_hevc_epel_bi_

Re: [FFmpeg-devel] [PATCH 1/6] lavc/aarch64: new optimization for 8-bit hevc_pel_bi_pixels

2023-12-01 Thread Martin Storsjö
On Sat, 18 Nov 2023, Logan.Lyu wrote: diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S b/libavcodec/aarch64/hevcdsp_epel_neon.S index 708b903b00..74165273d7 100644 --- a/libavcodec/aarch64/hevcdsp_epel_neon.S +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S @@ -244,6 +244,185 @@ function ff_hevc

[FFmpeg-devel] [PATCH] avfilter/avfilter: fix OOM case for default activate

2023-12-01 Thread Paul B Mahol
Attached. From 2ea2a0df61cbd5519a1c1e88be27a3f8eb883aac Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 1 Dec 2023 16:59:07 +0100 Subject: [PATCH] avfilter/avfilter: fix OOM case for default activate Fixes OOM when caller keeps adding frames into filtergraph that reached EOF by other means

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Nicolas George
Anton Khirnov (12023-12-01): > http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-November/316787.html So not Wednesday but Tursday three weeks ago. I did not agree that the current code was broken. > The current code is broken because its output depends on the order in > which the frames from

Re: [FFmpeg-devel] [POC][PATCHSET] Add qrencodesrc source

2023-12-01 Thread Tomas Härdin
tor 2023-11-30 klockan 15:39 + skrev Cosmin Stejerean via ffmpeg- devel: > > > On Nov 30, 2023, at 03:07, Tomas Härdin wrote: > > > > tor 2023-11-30 klockan 01:49 +0100 skrev Stefano Sabatini: > > > This is meant to introduce functionality to handle QR codes. > > > > Why? > > > > The why

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Anton Khirnov
Quoting Nicolas George (2023-12-01 15:50:39) > Anton Khirnov (12023-12-01): > > > When something succeeds with the current code and fails with “Error > > > while add the frame to buffer source(Cannot allocate memory)”, that is > > > broken. > > Not necessarily, when the current code is broken (whic

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Nicolas George
Anton Khirnov (12023-12-01): > > When something succeeds with the current code and fails with “Error > > while add the frame to buffer source(Cannot allocate memory)”, that is > > broken. > Not necessarily, when the current code is broken (which you agreed with > in the last thread). I do not know

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Anton Khirnov
Quoting Nicolas George (2023-12-01 15:42:38) > Anton Khirnov (12023-12-01): > > See my email from wednesday, it's not actually broken. > > I do not have a mail from you from Wednesday. http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-November/317536.html > When something succeeds with the cur

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Nicolas George
Anton Khirnov (12023-12-01): > See my email from wednesday, it's not actually broken. I do not have a mail from you from Wednesday. When something succeeds with the current code and fails with “Error while add the frame to buffer source(Cannot allocate memory)”, that is broken. -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Anton Khirnov
Quoting Nicolas George (2023-12-01 15:24:52) > Anton Khirnov (12023-12-01): > > Change the main loop and every component (demuxers, decoders, filters, > > encoders, muxers) to use the previously added transcode scheduler. Every > > instance of every such component was already running in a separate

Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Nicolas George
Anton Khirnov (12023-12-01): > Change the main loop and every component (demuxers, decoders, filters, > encoders, muxers) to use the previously added transcode scheduler. Every > instance of every such component was already running in a separate > thread, but now they can actually run in parallel.

Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

2023-12-01 Thread Rémi Denis-Courmont
Le 1 décembre 2023 09:55:15 GMT+02:00, "Martin Storsjö" a écrit : >On Fri, 1 Dec 2023, Rémi Denis-Courmont wrote: > >> Le 30 novembre 2023 23:13:59 GMT+02:00, "Martin Storsjö" >> a écrit : >>> On Thu, 30 Nov 2023, Rémi Denis-Courmont wrote: >> In other words, is publishing on the FATE w

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2023-12-01 Thread Paul B Mahol
On Fri, Dec 1, 2023 at 12:24 PM Gyan Doshi wrote: > > > On 2023-09-25 11:35 pm, Paul B Mahol wrote: > > On 9/11/23, Harshit Karwal wrote: > >> 1. Replaced ring buffer ADT with AVAudioFifo from libavutil/audio_fifo.h > >> 2. Fixed potential freeing of uninitialised pointers in uninit > >> 3. Mino

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2023-12-01 Thread Gyan Doshi
On 2023-09-25 11:35 pm, Paul B Mahol wrote: On 9/11/23, Harshit Karwal wrote: 1. Replaced ring buffer ADT with AVAudioFifo from libavutil/audio_fifo.h 2. Fixed potential freeing of uninitialised pointers in uninit 3. Minor changes like removing unused headers Will apply with more fixes soon

[FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

2023-12-01 Thread Anton Khirnov
Change the main loop and every component (demuxers, decoders, filters, encoders, muxers) to use the previously added transcode scheduler. Every instance of every such component was already running in a separate thread, but now they can actually run in parallel. Changes the results of ffmpeg-fix_su

Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-12-01 Thread Paul B Mahol
On Fri, Dec 1, 2023 at 12:29 AM Kyle Swanson wrote: > Hi, > > On Thu, Nov 30, 2023 at 2:43 PM Paul B Mahol wrote: > > But how you could refactor code if one filter shares nothing with another > > filter code? > > > > Its not possible. You all seem to not understand problem at all. > > I get that

Re: [FFmpeg-devel] [PATCH] lavfi/af_pan: fix sscanf return value check

2023-12-01 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] lavfi/af_pan: fix sscanf return value check

2023-12-01 Thread Nicolas George
sscanf() can return -1 when it reach the end of the string. Fix track ticket #10677. Signed-off-by: Nicolas George --- libavfilter/af_pan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index cfed9f146a..9ab827b396 100644 -