Re: [FFmpeg-devel] [PATCH] libavcodec/hevc_mp4toannexb_bsf: ignore extra data if possible

2021-10-07 Thread Xiang, Haihao
On Wed, 2021-09-22 at 04:37 +, Xiang, Haihao wrote: > > LGTM. > > Thanks for reviewing the patch. Could someone please merge this patch if no > more > comment ? Ping again, Thanks Haihao > > Regards > Haihao > > > > > On Fri, 10 Sept 2021 at 05:10, Haihao Xiang wrote: > > > > > > It i

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2021-10-07 Thread Xiang, Haihao
On Wed, 2021-09-22 at 15:42 +0800, Haihao Xiang wrote: > Usually a HW decoder is expected when user specifies a HW acceleration > method via -hwaccel option, however the current implementation doesn't > take HW acceleration method into account, it is possible to select a SW > decoder. > > For exam

Re: [FFmpeg-devel] [PATCH] README.md: fix typo

2021-10-07 Thread Gyan Doshi
On 2021-10-08 09:34 am, Gyan Doshi wrote: On 2021-10-07 04:10 pm, Arif Driessen wrote: Hi, I think this is a typo... The patch is corrupt. But it's ok I'll apply it. Pushed as f79be02be0abb7f4264fdc8467639eea7cd23d62 Regards, Gyan ___ ffmpeg

Re: [FFmpeg-devel] [PATCH] README.md: fix typo

2021-10-07 Thread Gyan Doshi
On 2021-10-07 04:10 pm, Arif Driessen wrote: Hi, I think this is a typo... The patch is corrupt. But it's ok I'll apply it. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

[FFmpeg-devel] [PATCH v2 3/3] libavfilter/vf_avgblur_vulkan: fix incorrect conditional judgement

2021-10-07 Thread Wu Jianhua
Signed-off-by: Wu Jianhua --- libavfilter/vf_avgblur_vulkan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_avgblur_vulkan.c b/libavfilter/vf_avgblur_vulkan.c index 5e38a80822..93a7f0d62a 100644 --- a/libavfilter/vf_avgblur_vulkan.c +++ b/libavfilter/vf_avgblu

[FFmpeg-devel] [PATCH v2 2/3] libavfilter/x86/vf_threshold: add ff_threshold8/16_avx512

2021-10-07 Thread Wu Jianhua
Performance(Less is better) 8bit: ff_threshold8_sse432.7555351 ff_threshold8_avx232.1713562 ff_threshold8_avx512 32.0103531 16bit: ff_threshold16_sse4 37.7713432 ff_threshold16_avx2 35.3348312 ff_threshold16_avx512 32.6976166 Signed-off-by: Wu Jianhua --- lib

[FFmpeg-devel] [PATCH v2 1/3] libavfilter/x86/vf_hflip: add ff_flip_byte/short_avx512()

2021-10-07 Thread Wu Jianhua
Performance(Less is better): 8bit: ff_hflip_byte_ssse3 0.61 ff_hflip_byte_avx20.37 ff_hflip_byte_avx512 0.19 16bit: ff_hflip_short_ssse3 1.27 ff_hflip_short_avx2 0.76 ff_hflip_short_avx512 0.40 Signed-off-by: Wu Jianhua --- libavfilter/x86/vf_hflip.asm| 23 +

[FFmpeg-devel] [PATCH] avfilter: add xcorrelate video filter

2021-10-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_convolve.c | 356 +- 3 files changed, 314 insertions(+), 44 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index d22fcb5

[FFmpeg-devel] [PATCH 5/5] avformat/imf: Build system

2021-10-07 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Modify the FFMPEG build system to add support for an IMF demuxer. MAINTAINERS | 1 + configure| 3 ++- doc/demuxers.texi| 6 ++ libavformat/Makefile | 2 ++ libavform

[FFmpeg-devel] [PATCH 4/5] avformat/imf: Tests

2021-10-07 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Tests for the public API of the IMF demuxer. libavformat/tests/imf.c | 490 1 file changed, 490 insertions(+) create mode 100644 libavformat/tests/imf.c diff --git a/li

[FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-07 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements the IMF demuxer. libavformat/imfdec.c | 660 +++ 1 file changed, 660 insertions(+) create mode 100644 libavformat/imfdec.c diff --git a/libavformat/imfdec.c b

[FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-07 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements IMF Composition Playlist (CPL) parsing. libavformat/imf_cpl.c | 666 ++ 1 file changed, 666 insertions(+) create mode 100644 libavformat/imf_cpl.c diff --git

[FFmpeg-devel] [PATCH 1/5] avformat/imf: Headers

2021-10-07 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: The IMF demuxer accepts as input an IMF CPL. The assets referenced by the CPL can be contained in multiple deliveries, each defined by an ASSETMAP file: ffmpeg -assetmaps ,,... -i If -asset

[FFmpeg-devel] ARM Hardware Request

2021-10-07 Thread J. Dekker
Hi, I'm writing ARM64 ASM and testing on Apple M1 and Graviton2 N1 devices. This, however, is not a good spread of micro-architectures among commonly used ARM64 devices. Additional micro-architectures which I would like to test are 'High Efficiency' A53 and A55; 'high performance' A72, A73, a

Re: [FFmpeg-devel] libavformat/rtpdec_jpeg.c patch to allow fragmentation offset to include q header and table data

2021-10-07 Thread Hayden Myers
On Fri, Sep 10, 2021, 2:48 PM Hayden Myers wrote: > From fb2b280e44b785b99b27c24503c61574168701b9 Mon Sep 17 00:00:00 2001 > From: Hayden Myers > Date: Fri, 10 Sep 2021 14:35:28 -0400 > Subject: [PATCH] libavformat/rtpdec_jpeg.c: Allow fragmentation offset to > include q header and data > > Som

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/apedec: Use 64bit to avoid overflow

2021-10-07 Thread Michael Niedermayer
On Wed, Sep 29, 2021 at 09:16:28PM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 727298502 * 3 cannot be > represented in type 'int' > Fixes: > 39172/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-638602483033702 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/apedec: Fix undefined integer overflow in long_filter_ehigh_3830()

2021-10-07 Thread Michael Niedermayer
On Tue, Sep 28, 2021 at 12:37:21AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2145648640 - 3357696 cannot be represented > in type 'int' > Fixes: > 38899/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5358815017566208 > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [PATCH 1/2] oavformat/avidec_ Check offset in odml

2021-10-07 Thread Michael Niedermayer
On Sun, Sep 19, 2021 at 10:35:35PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775807 + 8 cannot be represented > in type 'long' > Fixes: > 38787/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-485984579980 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegts: use actually read packet size in mpegts_resync special case

2021-10-07 Thread Michael Niedermayer
On Sat, Sep 18, 2021 at 09:10:40PM +0200, Marton Balint wrote: > > > On Fri, 17 Sep 2021, Michael Niedermayer wrote: > > > Fixes: infinite loop > > Fixes: > > 37986/clusterfuzz-testcase-minimized-ffmpeg_dem_MPEGTSRAW_fuzzer-5292311517462528 > > - > > LGTM, thanks. will apply thx [...] --

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegutils: consolidate single byte av_log()

2021-10-07 Thread Michael Niedermayer
On Sat, Sep 04, 2021 at 01:37:26PM -0300, James Almer wrote: > On 9/4/2021 12:28 PM, Michael Niedermayer wrote: > > On Fri, Sep 03, 2021 at 03:45:55PM -0300, James Almer wrote: > > > On 9/3/2021 3:39 PM, Michael Niedermayer wrote: > > > > Fixes: Timeout (56sec -> 15sec) > > > > Fixes: > > > > 3714

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-07 Thread Pierre-Anthony Lemieux
On Thu, Oct 7, 2021 at 1:03 PM Lynne wrote: > > 6 Oct 2021, 02:45 by p...@sandflow.com: > > > On Tue, Oct 5, 2021 at 5:03 PM Lynne wrote: > > > >> > >> 5 Oct 2021, 17:22 by p...@sandflow.com: > >> > >> > Hi Lynne, > >> > > >> > Can you be more specific? > >> > > >> > The file header we used look

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-07 Thread Lynne
6 Oct 2021, 02:45 by p...@sandflow.com: > On Tue, Oct 5, 2021 at 5:03 PM Lynne wrote: > >> >> 5 Oct 2021, 17:22 by p...@sandflow.com: >> >> > Hi Lynne, >> > >> > Can you be more specific? >> > >> > The file header we used look consistent with the header of other >> > BSD-licensed files, like aacd

Re: [FFmpeg-devel] [PATCH] avcodec: add native Speex decoder

2021-10-07 Thread Andreas Rheinhardt
Paul B Mahol: > +typedef struct SpeexBMode { > +int frame_size; /**< Size of frames used for decoding */ > +int subframe_size; /**< Size of sub-frames used for decoding */ > +int lpc_size; /**< Order of LPC filter */ > +float folding_gain; /**< Folding gain */ > +const SpeexSubm

Re: [FFmpeg-devel] [PATCH] avcodec: add native Speex decoder

2021-10-07 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: add sharpen_npp video filter

2021-10-07 Thread Timo Rothenpieler
On 30.09.2021 20:51, Roman Arzumanyan wrote: Thanks for review, Timo. Please find revised patch attached. (de)interlacing is now removed, doc entry was added as well. applied with a few minor amendments, thanks! While testing this via "-vf scale_npp=format=yuv420p,sharpen_npp" I discovered

Re: [FFmpeg-devel] [PATCH 14/20] tests/fate-run: Set bitexact flag for output, too

2021-10-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > James Almer: >> On 10/1/2021 6:08 PM, Andreas Rheinhardt wrote: >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> One could also do this more generically in the ffmpeg function. >>> >>>   tests/fate-run.sh | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> dif

Re: [FFmpeg-devel] [PATCH 14/20] tests/fate-run: Set bitexact flag for output, too

2021-10-07 Thread Andreas Rheinhardt
James Almer: > On 10/1/2021 6:08 PM, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> One could also do this more generically in the ffmpeg function. >> >>   tests/fate-run.sh | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/fate-run.sh b/t

Re: [FFmpeg-devel] [PATCH 14/20] tests/fate-run: Set bitexact flag for output, too

2021-10-07 Thread James Almer
On 10/1/2021 6:08 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- One could also do this more generically in the ffmpeg function. tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index bc1efa22d7..

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 11:32 AM, Michael Niedermayer wrote: On Thu, Oct 07, 2021 at 10:23:44AM -0300, James Almer wrote: On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 br

Re: [FFmpeg-devel] [PATCH 13/20] avformat/allformats: Fix data race when accessing devices lists

2021-10-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now setting the input and output devices lists is guarded > by a mutex. This prevents data races emanating from multiple concurrent > calls to avpriv_register_devices() (triggered by multiple concurrent > calls to avdevice_register_all()). Yet reading the lists pointe

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Michael Niedermayer
On Thu, Oct 07, 2021 at 10:23:44AM -0300, James Almer wrote: > On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: > > Hello, > > > > On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: > > > I do plan to make releases from > > > 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches > > > why ? > > > > I

[FFmpeg-devel] [PATCH 4/4] lavc/aarch64: clean-up sao band 8x8 function formatting

2021-10-07 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_sao_neon.S | 103 +++--- 1 file changed, 44 insertions(+), 59 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S b/libavcodec/aarch64/hevcdsp_sao_neon.S index 263747149f..c2519da7f5 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 3/4] lavc/aarch64: add hevc sao band 8x8 tiling

2021-10-07 Thread J. Dekker
--bench on AWS Graviton: hevc_sao_band_8x8_8_c: 317.5 hevc_sao_band_8x8_8_neon: 97.5 hevc_sao_band_16x16_8_c: 1115.0 hevc_sao_band_16x16_8_neon: 322.7 hevc_sao_band_32x32_8_c: 4599.2 hevc_sao_band_32x32_8_neon: 1246.2 hevc_sao_band_48x48_8_c: 10021.7 hevc_sao_band_48x48_8_neon: 2740.5 hevc_sao_ban

[FFmpeg-devel] [PATCH 1/4] lavc/aarch64: add hevc sao edge 16x16

2021-10-07 Thread J. Dekker
--bench on AWS Graviton: hevc_sao_edge_16x16_8_c: 1857.0 hevc_sao_edge_16x16_8_neon: 211.0 hevc_sao_edge_32x32_8_c: 7802.2 hevc_sao_edge_32x32_8_neon: 808.2 hevc_sao_edge_48x48_8_c: 16764.2 hevc_sao_edge_48x48_8_neon: 1796.5 hevc_sao_edge_64x64_8_c: 32647.5 hevc_sao_edge_64x64_8_neon: 3118.5 Sign

[FFmpeg-devel] [PATCH 2/4] lavc/aarch64: add hevc sao edge 8x8

2021-10-07 Thread J. Dekker
--bench on AWS Graviton: hevc_sao_edge_8x8_8_c: 516.0 hevc_sao_edge_8x8_8_neon: 81.0 Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 3 ++ libavcodec/aarch64/hevcdsp_sao_neon.S | 52 +++ 2 files changed, 55 insertions(+) diff --git a/libavcodec

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Michael Niedermayer
On Thu, Oct 07, 2021 at 11:26:53AM -0300, James Almer wrote: > On 10/7/2021 11:23 AM, Michael Niedermayer wrote: > > On Thu, Oct 07, 2021 at 10:34:12AM -0300, James Almer wrote: > > > On 10/7/2021 10:29 AM, Jean-Baptiste Kempf wrote: > > > > > > > > > > > > On Thu, 7 Oct 2021, at 15:23, James Alm

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 11:23 AM, Michael Niedermayer wrote: On Thu, Oct 07, 2021 at 10:34:12AM -0300, James Almer wrote: On 10/7/2021 10:29 AM, Jean-Baptiste Kempf wrote: On Thu, 7 Oct 2021, at 15:23, James Almer wrote: On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Michael Niedermayer
On Thu, Oct 07, 2021 at 10:34:12AM -0300, James Almer wrote: > On 10/7/2021 10:29 AM, Jean-Baptiste Kempf wrote: > > > > > > On Thu, 7 Oct 2021, at 15:23, James Almer wrote: > > > On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: > > > > Hello, > > > > > > > > On Wed, 6 Oct 2021, at 11:35, Micha

Re: [FFmpeg-devel] [PATCH] README.md: fix typo

2021-10-07 Thread Arif Driessen
> I think it's missing an article too: 'provides a means to alter decoded > Audio and Video through a chain of filters' might be better here, > alternatively: 'provides a means to alter decoded Audio and Video > through a filtergraph'. Yes, I did consider that, the problem was 'means' was critical

Re: [FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

2021-10-07 Thread Michael Niedermayer
On Tue, Oct 05, 2021 at 11:08:19PM +0200, Paul B Mahol wrote: > On Tue, Oct 5, 2021 at 11:03 PM James Almer wrote: > > > On 10/5/2021 5:51 PM, Michael Niedermayer wrote: > > > Fixes: division by 0 > > > Fixes: > > 39562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-54488349609820

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Steven Liu
> 在 2021年10月7日,17:15,Jan Ekström 写道: > > On Thu, Oct 7, 2021 at 12:13 PM Jan Ekström wrote: >> >> On Thu, Oct 7, 2021 at 11:09 AM Steven Liu wrote: >>> >>> Steven Liu 于2021年10月7日周四 上午10:41写道: Michael Niedermayer 于2021年10月6日周三 下午5:35写道: > > Hi all > > I do plan

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 10:29 AM, Jean-Baptiste Kempf wrote: On Thu, 7 Oct 2021, at 15:23, James Almer wrote: On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Jean-Baptiste Kempf
On Thu, 7 Oct 2021, at 15:23, James Almer wrote: > On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: >> Hello, >> >> On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: >>> I do plan to make releases from >>> 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches >>> why ? >> >> I think this is too m

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why ? I think this is too many to maintain. I would argue you should only support: 2.8, 3.2, 3.4, 4.1 a

Re: [FFmpeg-devel] next release

2021-10-07 Thread Jean-Baptiste Kempf
On Wed, 6 Oct 2021, at 14:41, James Almer wrote: > freeze, they will skip 5.0 for their upcoming releases, keep using 4.4, > and that one will therefore become an LTS release by force, like it's > currently the case with 4.3, 4.1, and 3.2. Being de-facto maintained long, because of those disbtri

Re: [FFmpeg-devel] [PATCH 1] avfilter/vf_avgblur: switch to faster algorithm

2021-10-07 Thread Paul B Mahol
On Thu, Oct 7, 2021 at 2:56 PM myp...@gmail.com wrote: > On Thu, Sep 30, 2021 at 12:01 AM Paul B Mahol wrote: > > > > will apply soon. > Ok, in my testbed, the patch gets about twice the performance gain > with small radius > With gcc compiler? > __

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Jean-Baptiste Kempf
Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: > I do plan to make releases from > 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches > why ? I think this is too many to maintain. I would argue you should only support: 2.8, 3.2, 3.4, 4.1 and 4.4 2.8 (Ubuntu LTS 16.04 + RHEL7) 3.2 (Deb

Re: [FFmpeg-devel] next release

2021-10-07 Thread J. Dekker
On 6 Oct 2021, at 11:57, Michael Niedermayer wrote: Hi Should the next release be called "LTS"? No, we can specify it *as* LTS but it should still have an actual name. The danger in calling it 'LTS' is that it will then be confusing if we specify other releases as LTS: do we mean an LTS releas

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 9:58 AM, James Almer wrote: On 10/6/2021 6:35 AM, Michael Niedermayer wrote: Hi all I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why ? they are used by maintained distributions as listed on https://trac.ffmpeg.org/wiki/Downstreams (hint, please keep th

Re: [FFmpeg-devel] [PATCH] avfilter: add limitdiff video filter

2021-10-07 Thread Thilo Borgmann
On 7 Oct 2021, at 14:13, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_limitdiff.c | 370 + 3 files changed, 372 insertions(+) create mode 100644 libavfilter/vf

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/6/2021 6:35 AM, Michael Niedermayer wrote: Hi all I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why ? they are used by maintained distributions as listed on https://trac.ffmpeg.org/wiki/Downstreams (hint, please keep this page updated so release work is targete

Re: [FFmpeg-devel] [PATCH 1] avfilter/vf_avgblur: switch to faster algorithm

2021-10-07 Thread myp...@gmail.com
On Thu, Sep 30, 2021 at 12:01 AM Paul B Mahol wrote: > > will apply soon. Ok, in my testbed, the patch gets about twice the performance gain with small radius ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH] README.md: fix typo

2021-10-07 Thread J. Dekker
On 7 Oct 2021, at 12:40, Arif Driessen wrote: Hi, I think this is a typo... --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 447347c700..f54299d340 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ such as audio, video, subtitl

Re: [FFmpeg-devel] [PATCH] avfilter: add limitdiff video filter

2021-10-07 Thread Andreas Rheinhardt
Paul B Mahol: > + > +AVFILTER_DEFINE_CLASS_EXT(limitdiff, "limitdiff", limitdiff_options); This is equivalent to AVFILTER_DEFINCE_CLASS(limitdiff); Why are you using the _EXT version? - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

[FFmpeg-devel] [PATCH] avfilter: add limitdiff video filter

2021-10-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_limitdiff.c | 370 + 3 files changed, 372 insertions(+) create mode 100644 libavfilter/vf_limitdiff.c diff --git a/libavfilter/Makefile b/li

[FFmpeg-devel] [PATCH] Revert "avfilter/vf_idet: reduce noisyness if the filter has been auto inserted"

2021-10-07 Thread Andreas Rheinhardt
This reverts commit 723c37d3b7bf23bfdfe3e5c3599543c06332. Said commit was in preparation for auto-inserting the idet filter. This has never happened; even if it did, the code is wrong, because it segfaults if the filter instance doesn't have a name (having one is not mandatory). Furthermore, it

Re: [FFmpeg-devel] [PATCH 5/8] avfilter/asrc_flite: Don't segfault when using list_voices option

2021-10-07 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/asrc_flite: Fix use-after-frees

2021-10-07 Thread Paul B Mahol
probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 8/8] avfilter/asrc_flite: Remove double '; '

2021-10-07 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] README.md: fix typo

2021-10-07 Thread Arif Driessen
Hi, I think this is a typo... --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 447347c700..f54299d340 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ such as audio, video, subtitles and related metadata. * `libavcodec` provides

[FFmpeg-devel] [PATCH] doc/filters: note values for format pix_fmts

2021-10-07 Thread Arif Driessen
Hi, It took me a while to figure this out, so I think it's worth documenting... --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 1994467f46..2dbe530f2e 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12558

[FFmpeg-devel] [PATCH] avformat/format: Improve const-correctness

2021-10-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavformat/format.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/format.c b/libavformat/format.c index cc214741bd..387627009e 100644 --- a/libavformat/format.c +++ b/libavformat/format.c @@ -52,

Re: [FFmpeg-devel] [PATCH 4/8] avfilter/aeval: Fix leak of expressions upon reallocation error

2021-10-07 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/8] avfilter/af_surround: Fix memleaks upon allocation error

2021-10-07 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 3/8] avfilter/af_vibrato: Fix segfault upon allocation error

2021-10-07 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 8/8] avfilter/asrc_flite: Remove double ';'

2021-10-07 Thread Andreas Rheinhardt
(Inside a function a stray ';' is an empty statement; outside of a function it is actually invalid, but compilers happen to accept it without complaint (unless e.g. using -pedantic).) Signed-off-by: Andreas Rheinhardt --- libavfilter/asrc_flite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[FFmpeg-devel] [PATCH 7/8] avfilter/asrc_flite: Fix races upon (un)registering voices

2021-10-07 Thread Andreas Rheinhardt
The voice registration system in libflite is broken: It is not thread-safe and also not based on internal counters; instead any call to unregister a voice frees said voice even if there are still many other users of said voice who have also registered said voice. While there is no way to guard agai

[FFmpeg-devel] [PATCH 6/8] avfilter/asrc_flite: Fix use-after-frees

2021-10-07 Thread Andreas Rheinhardt
When an flite filter instance is uninitialized and the refcount of the corresponding voice_entry reaches zero, the voice is unregistered, yet the voice_entry's pointer to the voice is not reset. (Whereas some other pointers are needlessly reset.) Because of this a new flite filter instance will bel

[FFmpeg-devel] [PATCH 5/8] avfilter/asrc_flite: Don't segfault when using list_voices option

2021-10-07 Thread Andreas Rheinhardt
Could also happen if initializing flite failed* or if an unknown voice has been selected or if registering the voice failed. *: which it currently can't, because it is a no-op. Signed-off-by: Andreas Rheinhardt --- libavfilter/asrc_flite.c | 10 ++ 1 file changed, 6 insertions(+), 4 del

[FFmpeg-devel] [PATCH 4/8] avfilter/aeval: Fix leak of expressions upon reallocation error

2021-10-07 Thread Andreas Rheinhardt
Fix this by switching to av_dynarray_add_nofree() which is more natural anyway because the entries of the array are pointers. Signed-off-by: Andreas Rheinhardt --- libavfilter/aeval.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/aeval.c b/libavfilter/aev

[FFmpeg-devel] [PATCH 3/8] avfilter/af_vibrato: Fix segfault upon allocation error

2021-10-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_vibrato.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_vibrato.c b/libavfilter/af_vibrato.c index c0cbcbf6f2..2cf1364273 100644 --- a/libavfilter/af_vibrato.c +++ b/libavfilter/af_vibrato.c @@ -127,11 +127,

[FFmpeg-devel] [PATCH 2/8] avfilter/af_surround: Fix memleaks upon allocation error

2021-10-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_surround.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_surround.c b/libavfilter/af_surround.c index e3601b9df0..efdf91a391 100644 --- a/libavfilter/af_surround.c +++ b/libavfilter/af_surround.c @@ -200

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Jan Ekström
On Thu, Oct 7, 2021 at 12:13 PM Jan Ekström wrote: > > On Thu, Oct 7, 2021 at 11:09 AM Steven Liu wrote: > > > > Steven Liu 于2021年10月7日周四 上午10:41写道: > > > > > > Michael Niedermayer 于2021年10月6日周三 下午5:35写道: > > > > > > > > Hi all > > > > > > > > I do plan to make releases from > > > > 4.4, 4.2, 4

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/vf_w3fdif: Fix segfault on allocation error

2021-10-07 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Jan Ekström
On Thu, Oct 7, 2021 at 11:09 AM Steven Liu wrote: > > Steven Liu 于2021年10月7日周四 上午10:41写道: > > > > Michael Niedermayer 于2021年10月6日周三 下午5:35写道: > > > > > > Hi all > > > > > > I do plan to make releases from > > > 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches > > Why not include 4.3 or have some reaso

[FFmpeg-devel] [PATCH 1/8] avfilter/vf_w3fdif: Fix segfault on allocation error

2021-10-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- One could btw allocate the work lines jointly. libavfilter/vf_w3fdif.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_w3fdif.c b/libavfilter/vf_w3fdif.c index ea304164b6..c2ea76dfa3 100644 --- a/libavfilter/vf_w3fdi

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Steven Liu
Steven Liu 于2021年10月7日周四 上午10:41写道: > > Michael Niedermayer 于2021年10月6日周三 下午5:35写道: > > > > Hi all > > > > I do plan to make releases from > > 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches > Why not include 4.3 or have some reason? Ok, i get it, because it have not present in downstreams page :D > >