[FFmpeg-devel] [PATCH V3] tests/dnn/mathunary: fix the issue of NAN

2020-07-07 Thread Ting Fu
When one of output[i] & expected_output is NAN, the unit test will always pass. Signed-off-by: Ting Fu --- tests/dnn/dnn-layer-mathunary-test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/dnn/dnn-layer-mathunary-test.c b/tests/dnn/dnn-layer-mathunary-test.c ind

Re: [FFmpeg-devel] RfP Candidates

2020-07-07 Thread Jean-Baptiste Kempf
On Tue, Jul 7, 2020, at 10:02, Paul B Mahol wrote: > On 7/6/20, Jean-Baptiste Kempf wrote: > > On Mon, Jul 6, 2020, at 09:48, Paul B Mahol wrote: > >> On 7/3/20, Jean-Baptiste Kempf wrote: > >> > On Thu, Jul 2, 2020, at 12:46, Jean-Baptiste Kempf wrote: > >> >> We'll accept candidates until Satur

[FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-07 Thread Josef Zlomek
Fixes: 4907 Adds support for demuxing of animated WebP. The WebP demuxer splits the input stream into packets containing one frame. It also sets the timing information properly. Signed-off-by: Josef Zlomek --- Changelog| 1 + doc/demuxers.texi| 28 libavformat/M

[FFmpeg-devel] [PATCH 1/2] libavcodec: add support for animated WebP decoding

2020-07-07 Thread Josef Zlomek
Fixes: 4907 Adds support for decoding of animated WebP. The WebP parser now splits the input stream into packets containing one frame. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of

Re: [FFmpeg-devel] [PATCH v4] avdevice/xcbgrab: Add select_region option

2020-07-07 Thread Andriy Gelman
On Sun, 05. Jul 13:28, Omar Emara wrote: > This patch adds a select_region option to the xcbgrab input device. > If set to 1, the user will be prompted to select the grabbing area > graphically by clicking and dragging. A rectangle will be drawn to > mark the grabbing area. A single click with no d

Re: [FFmpeg-devel] [PATCH] tests/dnn/mathunary: fix the issue of NAN

2020-07-07 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: Wednesday, July 8, 2020 10:39 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] tests/dnn/mathunary: fix the issue of NAN > > > > > -Original Message- > > From:

[FFmpeg-devel] [PATCH V2] tests/dnn/mathunary: fix the issue of NAN

2020-07-07 Thread Ting Fu
When one of output[i] & expected_output is NAN, the unit test will always pass. Signed-off-by: Ting Fu --- tests/dnn/dnn-layer-mathunary-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/dnn/dnn-layer-mathunary-test.c b/tests/dnn/dnn-layer-mathunary-test.c index

Re: [FFmpeg-devel] [PATCH] avutil: Add NV61 pixel format and enable IO support for NV16 and NV61 pixel formats

2020-07-07 Thread Cristian Bicheru
It's been some time since there was any activity on this thread so I'm wondering if this new patch with just the NV16 format is okay? If there are any other suggestions I'd be glad to implement them. On Sat, Jun 20, 2020 at 1:59 PM Cristian Bicheru wrote: > > NV16 is an interleaved 4:2:2 8-bit f

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Lynne
Jul 8, 2020, 00:08 by s...@jkqxz.net: > On 07/07/2020 23:54, Lynne wrote: > >> Jul 7, 2020, 23:47 by yongle.lin...@gmail.com: >> >>> add block type field to AVVideoBlockParams so we could either export or >>> visualize it later. >>> --- >>> libavutil/video_enc_params.h | 16 >>>

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Lynne
Jul 7, 2020, 23:47 by yongle.lin...@gmail.com: > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > --- > libavutil/video_enc_params.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/libavutil/video_enc_params.h b/libavutil/

Re: [FFmpeg-devel] [PATCH] tests/dnn/mathunary: fix the issue of NAN

2020-07-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年7月2日 21:51 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] tests/dnn/mathunary: fix the issue of NAN > > When one of output[i] & expected_output is NAN, the unit test will always > pass. > > Si

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Lynne
Jul 7, 2020, 23:11 by yongle.lin...@gmail.com: > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > --- > libavutil/video_enc_params.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/libavutil/video_enc_params.h b/libavutil/

Re: [FFmpeg-devel] [PATCH v6 3/3] avdevice/decklink_dec: export timecode with s12m side data

2020-07-07 Thread lance . lmwang
On Wed, Jul 01, 2020 at 09:39:58PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavdevice/decklink_dec.cpp | 16 > 1 file changed, 16 insertions(+) > > diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp >

[FFmpeg-devel] Bug in FFMPEG video filter TINTERLACE needs fixing

2020-07-07 Thread Ben Hutchinson
According to the documentation on the TINTERLACE video filter, the filter mode called MERGEX2 will "Move odd frames into the upper field, even into the lower field, generating a double height frame at same frame rate." But it doesn't do this, at least in some cases (not sure about all cases). The f

[FFmpeg-devel] [PATCH 3/4] avcodec/filter_units_bsf: Use separate contexts for reading/writing

2020-07-07 Thread James Almer
Based on code from 235a5734e0 Signed-off-by: James Almer --- libavcodec/filter_units_bsf.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavcodec/filter_units_bsf.c b/libavcodec/filter_units_bsf.c index 354594ac50..14960761d2 100644 --- a/libavcod

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/hevcdec: add timecode metadata

2020-07-07 Thread lance . lmwang
On Thu, Jul 02, 2020 at 10:33:24PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/hevcdec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index e363e68..3691814 100644 > --- a/

[FFmpeg-devel] [PATCH 2/4] avcodec/av1_frame_merge_bsf: Use separate contexts for reading/writing

2020-07-07 Thread James Almer
Based on code from 235a5734e0 Signed-off-by: James Almer --- libavcodec/av1_frame_merge_bsf.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/av1_frame_merge_bsf.c b/libavcodec/av1_frame_merge_bsf.c index baea5596d7..fce5bdb67e 100644 --- a/libav

[FFmpeg-devel] [PATCH 4/4] Revert "avcodec/cbs_av1: keep separate reference frame state for reading and writing"

2020-07-07 Thread James Almer
This reverts commit 4e2bef6a82b356772a5919c51c9be1530268bd79. It's no longer needed now that all the bsfs use separate contexts for reading and writing. --- libavcodec/cbs_av1.c | 4 libavcodec/cbs_av1.h | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/libavcodec/cbs_av

[FFmpeg-devel] [PATCH 1/4] avcodec/av1_metadata_bsf: Use separate contexts for reading/writing

2020-07-07 Thread James Almer
Based on code from 235a5734e0 Signed-off-by: James Almer --- libavcodec/av1_metadata_bsf.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c index 3e3cbfd174..3158ba995b 100644 --- a/libavcod

[FFmpeg-devel] [PATCH] swscale/tests: check return value of sws_scale

2020-07-07 Thread Lynne
Patch attached. >From a89bfd810cf40e3005fbcbdcf43a7b858b4dd12c Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 7 Jul 2020 22:19:14 +0100 Subject: [PATCH] swscale/tests: check return value of sws_scale --- libswscale/tests/swscale.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] yuv2rgb_neon: fix return value

2020-07-07 Thread Lynne
Jul 7, 2020, 20:58 by mar...@martin.st: > On Tue, 7 Jul 2020, Lynne wrote: > >> We return 0 for this particular architecture but should instead be >> returning the number of lines. >> Fixes users who check the return value matches what they expect. >> > > The change looks good in itself, but it al

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Lynne
Jul 7, 2020, 21:25 by yongle.lin...@gmail.com: > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > --- > libavutil/video_enc_params.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/libavutil/video_enc_params.h b/libavutil/v

Re: [FFmpeg-devel] [PATCH] avformat/isom: allow ISO 639 codes for mov

2020-07-07 Thread Baptiste Coudurier
Hey Yongle, > On Jul 7, 2020, at 10:41 AM, Yongle Lin wrote: > > On Mon, Jul 6, 2020 at 3:23 PM Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > >> Hi Yongle, I hope you are doing well >> >>> On Jul 6, 2020, at 11:04 AM, Yongle Lin wrote: >>> >>> On Fri, Jun 19, 2020 at 5:11 PM

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
On Tue, Jul 7, 2020 at 4:08 PM Mark Thompson wrote: > On 07/07/2020 23:54, Lynne wrote: > > Jul 7, 2020, 23:47 by yongle.lin...@gmail.com: > > > >> add block type field to AVVideoBlockParams so we could either export or > visualize it later. > >> --- > >> libavutil/video_enc_params.h | 16 +

[FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h index 43fa443154..8bf5f240c9 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg.c: Use the streams from the first output in print_final_stats.

2020-07-07 Thread Wang Cao
Friendly ping here. Is there something I need to change for this patch set? Any comments are welcome. Thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or e

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Lynne
Jul 7, 2020, 19:22 by yonglel-at-google@ffmpeg.org: > On Tue, Jul 7, 2020 at 12:59 AM Anton Khirnov wrote: > >> Quoting Yongle Lin (2020-07-06 23:08:17) >> > add block type field to AVVideoBlockParams so we could either export or >> visualize it later. >> > --- >> > libavutil/video_enc_param

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Mark Thompson
On 07/07/2020 23:54, Lynne wrote: Jul 7, 2020, 23:47 by yongle.lin...@gmail.com: add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 16 1 file changed, 16 insertions(+) diff --git a/libavutil/video

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
On Tue, Jul 7, 2020 at 10:54 PM Lynne wrote: > Jul 7, 2020, 23:47 by yongle.lin...@gmail.com: > > > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > > --- > > libavutil/video_enc_params.h | 16 > > 1 file changed, 16 insertions(+) >

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Moritz Barsnick
On Tue, Jul 07, 2020 at 10:03:34 -0300, James Almer wrote: > On 7/7/2020 8:33 AM, Steinar H. Gunderson wrote: > > FWIW, the “less secure” part is about not supporting 2FA (POP/IMAP has no > > OAuth-like authentication methods). > > This is not true. Thunderbird and i assume any modern IMAP/SMTP cli

[FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 16 1 file changed, 16 insertions(+) diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h index 43fa443154..52c0058f5b 100644 --- a/

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
On Tue, Jul 7, 2020 at 3:33 PM Lynne wrote: > Jul 7, 2020, 23:11 by yongle.lin...@gmail.com: > > > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > > --- > > libavutil/video_enc_params.h | 16 > > 1 file changed, 16 insertions(+) >

[FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 16 1 file changed, 16 insertions(+) diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h index 43fa443154..c18dba7879 100644 --- a/

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
On Tue, Jul 7, 2020 at 2:09 PM Lynne wrote: > Jul 7, 2020, 21:25 by yongle.lin...@gmail.com: > > > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > > --- > > libavutil/video_enc_params.h | 15 +++ > > 1 file changed, 15 insertions(+) > >

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-07 Thread James Almer
On 7/7/2020 5:07 PM, Brian Kim wrote: > On Tue, Jul 7, 2020 at 6:34 AM James Almer wrote: >> >> If i understand this right, you could easily solve it with just the >> following changes: >> >>> diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c >>> index 7f9c1b632c..48a373db01 100644 >>> ---

[FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h index 43fa443154..bff5354a8d 100644 --- a/l

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-07 Thread Brian Kim
On Tue, Jul 7, 2020 at 4:35 AM Michael Niedermayer wrote: [...] > I wonder if linesizes for newly added functions should be ptrdiff_t > this would add some type converting loops though > > And size probably should be ptrdiff_t or int64_t to similarly be more future > proof Can these values be neg

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-07 Thread Brian Kim
On Tue, Jul 7, 2020 at 6:34 AM James Almer wrote: > > If i understand this right, you could easily solve it with just the > following changes: > > > diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c > > index 7f9c1b632c..48a373db01 100644 > > --- a/libavutil/imgutils.c > > +++ b/libavutil/i

Re: [FFmpeg-devel] [PATCH] yuv2rgb_neon: fix return value

2020-07-07 Thread Martin Storsjö
On Tue, 7 Jul 2020, Lynne wrote: We return 0 for this particular architecture but should instead be returning the number of lines. Fixes users who check the return value matches what they expect. The change looks good in itself, but it also looks like we have the same issue in the arm version

[FFmpeg-devel] [PATCH] yuv2rgb_neon: fix return value

2020-07-07 Thread Lynne
We return 0 for this particular architecture but should instead be returning the number of lines. Fixes users who check the return value matches what they expect. >From e68f705c3882bc55726eccc67f90566789a3af86 Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 7 Jul 2020 16:01:58 +0100 Subject: [PA

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
On Tue, Jul 7, 2020 at 12:59 AM Anton Khirnov wrote: > Quoting Yongle Lin (2020-07-06 23:08:17) > > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > > --- > > libavutil/video_enc_params.h | 20 > > 1 file changed, 20 insertions(

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Yongle Lin
On Mon, Jul 6, 2020 at 3:08 PM Mark Thompson wrote: > On 06/07/2020 22:08, Yongle Lin wrote: > > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > > --- > > libavutil/video_enc_params.h | 20 > > 1 file changed, 20 insertions(+

Re: [FFmpeg-devel] [PATCH] avformat/isom: allow ISO 639 codes for mov

2020-07-07 Thread Yongle Lin
On Mon, Jul 6, 2020 at 3:23 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > Hi Yongle, I hope you are doing well > > > On Jul 6, 2020, at 11:04 AM, Yongle Lin wrote: > > > > On Fri, Jun 19, 2020 at 5:11 PM Yongle Lin > wrote: > > > >> Allow ISO 639

Re: [FFmpeg-devel] [PATCH 0/2] avformat movenc add flag to allow disabling limit on timescale

2020-07-07 Thread Gyan Doshi
On 07-07-2020 04:42 pm, vectronic wrote: On 11 May 2020, at 16:46, Gyan Doshi wrote: On 11-05-2020 06:44 pm, vectronic wrote: On 5 May 2020, at 06:19, Gyan Doshi wrote: On 05-05-2020 03:16 am, vectronic wrote: On 4 May 2020, at 17:56, Gyan Doshi wrote: On 04-05-2020 09:54 pm, vect

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: Fix unaligned read of uint32_t and endian-dependance in mov_read_default

2020-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 06:39:52PM +0200, Andreas Rheinhardt wrote: > Zhao Zhili: > > --- > > libavformat/mov.c | 11 +-- > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index df5bebdff1..da438e4e2c 100644 > > --- a/libavf

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Jean-Baptiste Kempf
On Tue, Jul 7, 2020, at 13:13, Anton Khirnov wrote: > > But be very careful to not make them mandatory. > > +1 > Any change that makes it necessary to use a web browser for development > a big step back IMO. Github has a quite nice CLI, so you don't need the web part for that. Best, -- Jean-Bap

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Jean-Baptiste Kempf
On Tue, Jul 7, 2020, at 15:15, Nicolas George wrote: > Jean-Baptiste Kempf (12020-07-05): > > With tools and organization. > > Sure, but you are forgetting one wing: responsibility. > > The reason many patches go a long time without review is that nobody > feels responsible for reviewing them. I

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

2020-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 04:00:10PM +0200, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-05): > > The section has been expanded to outline how to manage patch revisions. > > --- > > doc/developer.texi | 37 ++--- > > 1 file changed, 26 insertions(+), 11

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: Fix unaligned read of uint32_t and endian-dependance in mov_read_default

2020-07-07 Thread Andreas Rheinhardt
Zhao Zhili: > --- > libavformat/mov.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index df5bebdff1..da438e4e2c 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -6945,13 +6945,12 @@ static int mov_read_

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: Fix unaligned read of uint32_t and endian-dependance in mov_read_default

2020-07-07 Thread Zhao Zhili
Please help review the patch, thanks! > On Jul 5, 2020, at 12:51 AM, Zhao Zhili wrote: > > --- > libavformat/mov.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index df5bebdff1..da438e4e2c 100644 > --- a/libavformat/

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/loco: Fix integer overflow with large values from loco_get_rice()

2020-07-07 Thread Michael Niedermayer
On Tue, Jun 30, 2020 at 10:28:29PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 155 + 2147483647 cannot be represented in > type 'int' > Fixes: > 23421/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5652849097965568 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/apedec: Fix undefined integer overflow with 24bit

2020-07-07 Thread Michael Niedermayer
On Tue, Jun 30, 2020 at 10:28:31PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 8683744 * 256 cannot be represented in type > 'int' > Fixes: > 23527/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5679885932822528 > > Found-by: continuous fuzzing process > ht

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Andriy Gelman
On Tue, 07. Jul 16:29, Oneric wrote: > On Sun 2020 Jul 5 20:01 +0300 Kieran Kunhya wrote: > > > > Going back to the original point in hand. > > Many patches aren't getting reviewed and pushed any more. > > > > In part this is because in 2020 whether we like it or not mailing > > lists are not the

Re: [FFmpeg-devel] [PATCH v1 2/3] doc/developer.texi: Restructured "Submitting patches" section.

2020-07-07 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 16:07, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-05): > > > +@item If you send your patches with an external email client > > +(i.e. not @code{git send-email}), make sure to send each patch as a > separate > > +email. Do not attach several patches to the sam

Re: [FFmpeg-devel] [PATCH v2] avfilter: add nonlinearstretch filter.

2020-07-07 Thread Mathias Rasmussen
Thanks a lot for your review! > On 7 Jul 2020, at 16.23, Nicolas George wrote: > > Mathias Rasmussen (12020-06-25): >> +@table @option >> +@item width >> +Set output width. > > I am ok with that for a first version, but it is not very convenient to > not be able to select the width not as a fun

[FFmpeg-devel] [PATCH 1/1] MAINTAINERS: add myself and gpg fingerprint

2020-07-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 02af52101e..30c2ec59e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,7 +393,10 @@ Muxers/Demuxers: afc.c Paul B Mahol

[FFmpeg-devel] [PATCH 0/1] add myself and gpg fingerprint

2020-07-07 Thread Zane van Iperen
Per suggestion at https://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265840.html I've added several new formats, it's only proper that I volunteer to maintain them. Although my commit count may not be the highest, I'd like to think I've shown myself to be responsible. I will not abuse this pri

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Jean-Baptiste Kempf (12020-07-05): > Also in this example, noone is telling them to fork, just to use the > API to register their custom protocol. About this, I think there are two separate issues. One is that recent effort to get rid of mutable global state. Registering custom protocols involves

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Manolis Stamatogiannakis (12020-07-07): > And some quick grepping reveals that 45% of the emails in the list for > 2019-2020 were from 236 unique Gmail addresses. > That's an awful lot of people with bad habits to ignore. Ah, but a gmail address is not the sign of bad habits. You can use a gmail a

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Oneric (12020-07-07): > As someone who recently only submitted a single, simple patch, I haven't seen > mail-based dev as an annoyance, rather the contrary as this avoids the burden > of creating yet another account on some website, that I'll have to manage. > > There also already seems to be so

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 14:38, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-07): > > I believe I have adequately explained that "less secure" needs to be > > enabled, not to make your Google account more secure, but to contain > > the damage from a potential compromise. > > > > Yes, "

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Oneric
On Sun 2020 Jul 5 20:01 +0300 Kieran Kunhya wrote: > > Going back to the original point in hand. > Many patches aren't getting reviewed and pushed any more. > > In part this is because in 2020 whether we like it or not mailing > lists are not the way to do Git based development. > The kernel is t

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Manolis Stamatogiannakis (12020-07-07): > If I reply to the email, my response will appear online in the issue/PR > page. That is good to know. I have never noticed it documented. Does it work reliably? > Now, if you also want to review the code of a PRs from mutt, that's another > discussion. N

Re: [FFmpeg-devel] [PATCH v2] avfilter: add nonlinearstretch filter.

2020-07-07 Thread Nicolas George
Mathias Rasmussen (12020-06-25): > --- > Changelog | 1 + > doc/filters.texi | 34 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h | 2 +- > lib

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 14:59, Nicolas George wrote: > > Is there a way of interacting with the discussions in GitHub issues > outside their web interface? > > If there is, I never found it. If there is not, then GitHub's issue > system is just not usable for serious work. > Any activity on issues

Re: [FFmpeg-devel] [PATCH v1 2/3] doc/developer.texi: Restructured "Submitting patches" section.

2020-07-07 Thread Nicolas George
Manolis Stamatogiannakis (12020-07-05): > - Main text split to two sections. > - Detailed checklist for new codecs or formats demoted to section. > - Detailed checklist for patch submission demoted to section. > > Signed-off-by: Manolis Stamatogiannakis > --- > doc/developer.texi | 64 ++

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

2020-07-07 Thread Paul B Mahol
On 7/7/20, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-05): >> The section has been expanded to outline how to manage patch revisions. >> --- >> doc/developer.texi | 37 ++--- >> 1 file changed, 26 insertions(+), 11 deletions(-) >> >> diff --git a/do

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

2020-07-07 Thread Paul B Mahol
On 7/7/20, Michael Niedermayer wrote: > On Tue, Jul 07, 2020 at 02:52:23PM +0200, Paul B Mahol wrote: >> On 7/7/20, Michael Niedermayer wrote: >> > On Tue, Jul 07, 2020 at 09:46:27AM +, Zane van Iperen wrote: >> >> On Mon, 6 Jul 2020 18:29:57 +0200 >> >> "Michael Niedermayer" wrote: >> >> >>

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

2020-07-07 Thread Nicolas George
Manolis Stamatogiannakis (12020-07-05): > The section has been expanded to outline how to manage patch revisions. > --- > doc/developer.texi | 37 ++--- > 1 file changed, 26 insertions(+), 11 deletions(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > i

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

2020-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 02:52:23PM +0200, Paul B Mahol wrote: > On 7/7/20, Michael Niedermayer wrote: > > On Tue, Jul 07, 2020 at 09:46:27AM +, Zane van Iperen wrote: > >> On Mon, 6 Jul 2020 18:29:57 +0200 > >> "Michael Niedermayer" wrote: > >> > >> > On Mon, Jul 06, 2020 at 09:24:20AM +,

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-07 Thread James Almer
On 7/1/2020 3:14 PM, Brian Kim wrote: > While running under Clang's UndefinedBehaviorSanitizer, I found a few > places where av_image_fill_pointers is called before buffers for the image > are allocated, so ptr is passed in as NULL. > > This leads to (currently harmless) UB when the plane sizes ar

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Paul B Mahol
On 7/7/20, Nicolas George wrote: > Jean-Baptiste Kempf (12020-07-05): >> With tools and organization. > > Sure, but you are forgetting one wing: responsibility. > > The reason many patches go a long time without review is that nobody > feels responsible for reviewing them. > > If it is an area of

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Jean-Baptiste Kempf (12020-07-05): > With tools and organization. Sure, but you are forgetting one wing: responsibility. The reason many patches go a long time without review is that nobody feels responsible for reviewing them. If it is an area of the code we know well, an area for which we have

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Soft Works (12020-07-05): > When then reviewer would not have to look for code style and could > assume that this is all right, he would be free to focus on the actual things. > And when it's only about code-style, a reviewer would not need to > review a patch two times (original + corrected) for c

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread James Almer
On 7/7/2020 8:33 AM, Steinar H. Gunderson wrote: > On Tue, Jul 07, 2020 at 01:30:52PM +0200, Nicolas George wrote: >>> We don't live in a world of innocence. Enabling "less secure" applications >>> is trouble waiting to happen. >> Please don't believe that "less secure" applications are actually le

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
vectronic (12020-07-07): > I think the key is choice. For example on GitHub people are able to > contribute to the same project using any or all of: IDE plugins, the > GitHub web UI or the standard git client CLI. Is there a way of interacting with the discussions in GitHub issues outside their we

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
James Almer (12020-07-04): > Just a few quick Saturday morning thoughts that don't cover your entire > email and may be just me rambling, but some of this could be linked to > the completely different world we're living in today than in say 2010, > regarding what is expected of multimedia projects.

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

2020-07-07 Thread Paul B Mahol
On 7/7/20, Michael Niedermayer wrote: > On Tue, Jul 07, 2020 at 09:46:27AM +, Zane van Iperen wrote: >> On Mon, 6 Jul 2020 18:29:57 +0200 >> "Michael Niedermayer" wrote: >> >> > On Mon, Jul 06, 2020 at 09:24:20AM +, Zane van Iperen wrote: >> > > Signed-off-by: Zane van Iperen > [...] >>

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Kieran Kunhya (12020-07-07): > I don't disagree with the point about Gmail, however the reality of the > situation is this is how 95% of the world now use email. I would argue that 95% of the world has nothing of value to bring to FFmpeg anyway. And I would add there is probably a very strong cor

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Manolis Stamatogiannakis (12020-07-07): > I believe I have adequately explained that "less secure" needs to be > enabled, not to make your Google account more secure, but to contain > the damage from a potential compromise. > > Yes, "less secure" sounds a lot like marketing slang. But Gmail is not

Re: [FFmpeg-devel] [PATCH] avformat/smjpegdec: Check the existence of referred streams

2020-07-07 Thread Michael Niedermayer
On Mon, Jul 06, 2020 at 08:53:53PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 23758/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5160954605338624.fuzz > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

2020-07-07 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 09:46:27AM +, Zane van Iperen wrote: > On Mon, 6 Jul 2020 18:29:57 +0200 > "Michael Niedermayer" wrote: > > > On Mon, Jul 06, 2020 at 09:24:20AM +, Zane van Iperen wrote: > > > Signed-off-by: Zane van Iperen [...] > > You also may want to add yourself to the MAINT

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

2020-07-07 Thread Paul B Mahol
On 7/7/20, Zane van Iperen wrote: > On Mon, 6 Jul 2020 18:29:57 +0200 > "Michael Niedermayer" wrote: > >> On Mon, Jul 06, 2020 at 09:24:20AM +, Zane van Iperen wrote: >> > Signed-off-by: Zane van Iperen >> > --- >> > libavformat/Makefile | 2 +- >> > libavformat/apm.c| 62 >> >

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Anton Khirnov
Quoting Manolis Stamatogiannakis (2020-07-07 13:28:55) > On Tue, 7 Jul 2020 at 12:46, Nicolas George wrote: > > > > > * GMail's warnings about "less secure" applications are scare tactics to > > get you to exclusively use their products, because they cannot feed > > you advertisement when you

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Jean-Baptiste Kempf (12020-07-05): > You are missing the point here: > Lego Racers demuxer is in the scope of "play everything under the sun" > that the FFmpeg project is, while AMQP/ZMQ is not. > > The issue is not usefulness, but correctly defining the scope of the > project (aka the orienttati

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 13:31, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-07): > > We don't live in a world of innocence. Enabling "less secure" > applications > > is trouble waiting to happen. > > Please don't believe that "less secure" applications are actually less > secure. The

Re: [FFmpeg-devel] [PATCH 0/2] avformat movenc add flag to allow disabling limit on timescale

2020-07-07 Thread vectronic
> On 11 May 2020, at 16:46, Gyan Doshi wrote: > > > > On 11-05-2020 06:44 pm, vectronic wrote: >> >>> On 5 May 2020, at 06:19, Gyan Doshi wrote: >>> >>> >>> >>> On 05-05-2020 03:16 am, vectronic wrote: > On 4 May 2020, at 17:56, Gyan Doshi wrote: > > > > On 04-05-2

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-07 Thread Michael Niedermayer
Hi On Wed, Jul 01, 2020 at 11:14:13AM -0700, Brian Kim wrote: > While running under Clang's UndefinedBehaviorSanitizer, I found a few > places where av_image_fill_pointers is called before buffers for the image > are allocated, so ptr is passed in as NULL. > > This leads to (currently harmless) U

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Steinar H. Gunderson
On Tue, Jul 07, 2020 at 01:30:52PM +0200, Nicolas George wrote: >> We don't live in a world of innocence. Enabling "less secure" applications >> is trouble waiting to happen. > Please don't believe that "less secure" applications are actually less > secure. The only thing they are less secure for i

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Manolis Stamatogiannakis (12020-07-07): > We don't live in a world of innocence. Enabling "less secure" applications > is trouble waiting to happen. Please don't believe that "less secure" applications are actually less secure. The only thing they are less secure for is advertisers' business model

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 12:46, Nicolas George wrote: > > * GMail's warnings about "less secure" applications are scare tactics to > get you to exclusively use their products, because they cannot feed > you advertisement when you use a real mail client with their IMAP and > SMTP servers. > > I

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread vectronic
> On 7 Jul 2020, at 12:13, Anton Khirnov wrote: > > Quoting Nicolas George (2020-07-07 12:46:39) >> >> * GMail's warnings about "less secure" applications are scare tactics to >> get you to exclusively use their products, because they cannot feed >> you advertisement when you use a real mail c

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Kieran Kunhya
On Tue, 7 Jul 2020 at 12:13, Anton Khirnov wrote: > Quoting Nicolas George (2020-07-07 12:46:39) > > > > * GMail's warnings about "less secure" applications are scare tactics to > > get you to exclusively use their products, because they cannot feed > > you advertisement when you use a real m

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Anton Khirnov
Quoting Nicolas George (2020-07-07 12:46:39) > > * GMail's warnings about "less secure" applications are scare tactics to > get you to exclusively use their products, because they cannot feed > you advertisement when you use a real mail client with their IMAP and > SMTP servers. VERY much a

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Nicolas George
Kieran Kunhya (12020-07-05): > Going back to the original point in hand. This was not the original point at all, but it does not matter much. > Many patches aren't getting reviewed and pushed any more. > > In part this is because in 2020 whether we like it or not mailing > lists are not the way

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Mattias Wadman
On Mon, Jul 6, 2020 at 5:59 PM Olly Woodman wrote: > > On Mon, 6 Jul 2020 at 05:54, Jim DeLaHunt wrote: > > > On 2020-07-04 07:43, Nicolas George wrote: > > > [In the FFmpeg project,] [t]here is work in making highly-optimized > > > decoders, this work is impressive and creative…. But as far as I

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

2020-07-07 Thread Zane van Iperen
On Mon, 6 Jul 2020 18:29:57 +0200 "Michael Niedermayer" wrote: > On Mon, Jul 06, 2020 at 09:24:20AM +, Zane van Iperen wrote: > > Signed-off-by: Zane van Iperen > > --- > > libavformat/Makefile | 2 +- > > libavformat/apm.c| 62 > > 2 files c

Re: [FFmpeg-devel] [PATCH] lavfi/vsrc_testsrc: switch to activate.

2020-07-07 Thread Paul B Mahol
Why this was never applied? On 6/26/20, Nicolas George wrote: > Allow to set the EOF timestamp. > > Also: doc/filters/testsrc*: specify the rounding of the duration option. > > The changes in the ref files are right. > > For filter-fps-down, the graph is testsrc2=r=7:d=3.5,fps=3. > 3.5=24.5/7, so

Re: [FFmpeg-devel] RfP Candidates

2020-07-07 Thread Paul B Mahol
On 7/6/20, Jean-Baptiste Kempf wrote: > On Mon, Jul 6, 2020, at 09:48, Paul B Mahol wrote: >> On 7/3/20, Jean-Baptiste Kempf wrote: >> > On Thu, Jul 2, 2020, at 12:46, Jean-Baptiste Kempf wrote: >> >> We'll accept candidates until Saturday night, 23:59UTC. >> > >> > 24-hours remaining ping. >> >

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-07 Thread Anton Khirnov
Quoting Yongle Lin (2020-07-06 23:08:17) > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > --- > libavutil/video_enc_params.h | 20 > 1 file changed, 20 insertions(+) We generally require new APIs to be immediately useful. So i

  1   2   >