Re: [FFmpeg-devel] [PATCH 1/1] libavdevice/v4l2enc: support additional v4l2 output formats

2019-01-26 Thread James Hilliard
The purpose of this patch is to fix a bug where ffmpeg would only output rawvideo to a v4l2loopback device even though v4l2loopback accepts other formats such as mjpeg. On Wed, Jan 23, 2019 at 7:55 PM wrote: > > From: James Hilliard > > Signed-off-by: James Hilliard > --- > libavdevice/v4l2enc

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

2019-01-26 Thread Gyan
On 26-01-2019 08:23 PM, Carl Eugen Hoyos wrote: 2019-01-26 15:42 GMT+01:00, Gyan : On 26-01-2019 07:49 PM, Carl Eugen Hoyos wrote: 2019-01-26 15:10 GMT+01:00, Gyan : Try feeding a few images of different sizes to the crop filter with reinit disabled Sorry, not sure if I understand: The wa

Re: [FFmpeg-devel] gdigrab: fix HIDPI support

2019-01-26 Thread Carl Eugen Hoyos
2019-01-26 18:53 GMT+01:00, Dilshod Mukhtarov : > HI, this is the patch that fixes HIDPI support in gdigrab > +double h_dpr; // Horizontal device pixel ratio > +double v_dpr; // Vertical device pixel ratio I would expect these to be AVRational, if this is not possible, it should be ex

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1: Simplify update_vlc_state()

2019-01-26 Thread Michael Niedermayer
About 0.5% faster Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index 7c29d01f51..f0bb19350a 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@ -174,19 +174

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: Simplify fold()

2019-01-26 Thread Michael Niedermayer
No speed difference, or slightly faster (the difference is too small so it may be noise that this appears faster) Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index 653138b07

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-26 Thread Peter Ross
On Sat, Jan 26, 2019 at 02:46:59PM -0500, FeRD wrote: > On Tue, Jan 22, 2019 at 8:15 AM Moritz Barsnick wrote: > > > On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote: > > > Well... not *purely* cosmetic. See [1] for an example of one issue. > > Ruby's > > > > > `ruby/config.h` header also defin

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-26 Thread FeRD
On Tue, Jan 22, 2019 at 8:15 AM Moritz Barsnick wrote: > On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote: > > Well... not *purely* cosmetic. See [1] for an example of one issue. > Ruby's > > > `ruby/config.h` header also defines an `RSHIFT` macro, with different > > semantics (it doesn't round

Re: [FFmpeg-devel] [PATCH] avfilter: Add delay filter

2019-01-26 Thread Paul B Mahol
On 1/26/19, Meredydd Luff wrote: > So far, we have an audio delay filter (adelay), but no video delay. > This patch adds one. > > (NB the difference with tpad - tpad does not alter the pts of the > passed-through frames, which causes A/V sync badness with large delays > [at least when running live

Re: [FFmpeg-devel] [PATCH] vf_showinfo: Fix timecode display

2019-01-26 Thread Paul B Mahol
On 1/24/19, Kieran Kunhya wrote: > $subj - Indexing is wrong, off by one > > Kieran > Does FATE need update? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: Add delay filter

2019-01-26 Thread Marton Balint
On Sat, 26 Jan 2019, Meredydd Luff wrote: On Sat, 26 Jan 2019 at 10:19, Marton Balint wrote: On Sat, 26 Jan 2019, Meredydd Luff wrote: Why do you need an internal queue for this? If I am getting this right, you inject blank frames and then pass the input as is. A possible real world use cas

[FFmpeg-devel] gdigrab: fix HIDPI support

2019-01-26 Thread Dilshod Mukhtarov
HI, this is the patch that fixes HIDPI support in gdigrab: 1) Mouse position was not calculated properly in area or window mode 2) In window mode the size of window was not calculated properly (cropped) -- With the best regards, Dilshod >From 98043face18a5fae93ed01c14a15140a60dd7ad4 Mon Sep 1

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

2019-01-26 Thread Carl Eugen Hoyos
2019-01-26 15:42 GMT+01:00, Gyan : > > > On 26-01-2019 07:49 PM, Carl Eugen Hoyos wrote: >> 2019-01-26 15:10 GMT+01:00, Gyan : >> >>> Try feeding a few images of different sizes to the crop >>> filter with reinit disabled >> Sorry, not sure if I understand: >> The warning you want to add is only sh

Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail for unknown atoms with negative size.

2019-01-26 Thread Paul B Mahol
On 1/26/19, Carl Eugen Hoyos wrote: > 2019-01-25 17:49 GMT+01:00, Paul B Mahol : >> On 1/23/19, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch allows to read a user's file that plays fine with QT. >>> The patch duplicates the behaviour of QT. >>> >>> Please comment, Carl Eugen >> >> lgtm

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

2019-01-26 Thread Gyan
On 26-01-2019 07:49 PM, Carl Eugen Hoyos wrote: 2019-01-26 15:10 GMT+01:00, Gyan : Try feeding a few images of different sizes to the crop filter with reinit disabled Sorry, not sure if I understand: The warning you want to add is only shown if the filter reinit was disabled by the user? Yes

Re: [FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail for unknown atoms with negative size.

2019-01-26 Thread Carl Eugen Hoyos
2019-01-25 17:49 GMT+01:00, Paul B Mahol : > On 1/23/19, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch allows to read a user's file that plays fine with QT. >> The patch duplicates the behaviour of QT. >> >> Please comment, Carl Eugen > > lgtm Sorry, I had attached the wrong patch. New pat

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

2019-01-26 Thread Carl Eugen Hoyos
2019-01-26 15:10 GMT+01:00, Gyan : > Try feeding a few images of different sizes to the crop > filter with reinit disabled Sorry, not sure if I understand: The warning you want to add is only shown if the filter reinit was disabled by the user? Carl Eugen

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

2019-01-26 Thread Gyan
On 26-01-2019 06:40 PM, Carl Eugen Hoyos wrote: 2019-01-26 5:42 GMT+01:00, Gyan : On 26-01-2019 01:17 AM, Carl Eugen Hoyos wrote: 2019-01-25 14:02 GMT+01:00, Gyan : On 25-01-2019 06:25 PM, Carl Eugen Hoyos wrote: 2019-01-25 13:52 GMT+01:00, Gyan : On 25-01-2019 06:11 PM, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

2019-01-26 Thread Carl Eugen Hoyos
2019-01-26 5:42 GMT+01:00, Gyan : > > > On 26-01-2019 01:17 AM, Carl Eugen Hoyos wrote: >> 2019-01-25 14:02 GMT+01:00, Gyan : >>> On 25-01-2019 06:25 PM, Carl Eugen Hoyos wrote: 2019-01-25 13:52 GMT+01:00, Gyan : > On 25-01-2019 06:11 PM, Carl Eugen Hoyos wrote: >> 2019-01-25 13:35 GMT

Re: [FFmpeg-devel] [PATCH] avfilter: Add delay filter

2019-01-26 Thread Meredydd Luff
On Sat, 26 Jan 2019 at 11:22, Gyan wrote: > On 26-01-2019 05:54 AM, Meredydd Luff wrote: > Locally, I see that tpad does offset > the PTS of the input. Apologies, yes, I misspoke in the original email. That's what I get for submitting something a couple of weeks after writing it and assuming I sti

Re: [FFmpeg-devel] [PATCH] avfilter: Add delay filter

2019-01-26 Thread Meredydd Luff
On Sat, 26 Jan 2019 at 10:19, Marton Balint wrote: > On Sat, 26 Jan 2019, Meredydd Luff wrote: > Why do you need an internal queue for this? If I am getting this right, > you inject blank frames and then pass the input as is. > > A possible real world use case would be useful for me to better unde

Re: [FFmpeg-devel] [PATCH] avfilter: Add delay filter

2019-01-26 Thread Gyan
On 26-01-2019 05:54 AM, Meredydd Luff wrote: So far, we have an audio delay filter (adelay), but no video delay. This patch adds one. (NB the difference with tpad - tpad does not alter the pts of the passed-through frames, which causes A/V sync badness with large delays Can you share the log

Re: [FFmpeg-devel] [PATCH] avfilter: Add delay filter

2019-01-26 Thread Marton Balint
On Sat, 26 Jan 2019, Meredydd Luff wrote: So far, we have an audio delay filter (adelay), but no video delay. This patch adds one. (NB the difference with tpad - tpad does not alter the pts of the passed-through frames, which causes A/V sync badness with large delays [at least when running li