2019-01-26 18:53 GMT+01:00, Dilshod Mukhtarov <dilsh...@gmail.com>: > HI, this is the patch that fixes HIDPI support in gdigrab
> + double h_dpr; // Horizontal device pixel ratio > + double v_dpr; // Vertical device pixel ratio I would expect these to be AVRational, if this is not possible, it should be explained why. Please put "else" on the same line as "}", no linebreak between "}" and "else". > 1) Mouse position was not calculated properly in area or window mode > 2) In window mode the size of window was not calculated properly (cropped) This may not apply here, but typically, if a patch says "fixes A and B", it should be split in two patches to ease review and future debugging. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
