[FFmpeg-devel] [PATCH] avcodec/mips: [loongson] optimize theora decoding in vp3dsp.

2018-12-26 Thread gxw
Optimize theora decoding with msa in functions: 1. ff_vp3_idct_add_msa 2. ff_vp3_idct_put_msa 3. ff_vp3_idct_dc_add_msa 4. ff_vp3_v_loop_filter_msa 5. ff_vp3_h_loop_filter_msa 6. ff_put_no_rnd_pixels_l2_msa Theora decoding speed improved about 36%(from 22fps to 30fps, Tested on loongson 2K1000).

[FFmpeg-devel] [PATCH V3 3/3] add an example to show how to fill the ROI info

2018-12-26 Thread Guo, Yejun
This patch is just a quick example to show how to fill the ROI info, it does not ask for upstreaming, just for your reference. to verify the ROI feature with this example, the command line looks like: ./ffmpeg -i .../path_to_1920x1080_video_file -vf scale=1920:1080 -c:v libx264 -b:v 2000k -y tmp.

[FFmpeg-devel] [PATCH V3 2/3] avcodec/libx264: add support for ROI-based encoding

2018-12-26 Thread Guo, Yejun
This patch just enables the path from ffmpeg to libx264, the more encoders can be added later. Signed-off-by: Guo, Yejun --- libavcodec/libx264.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index a68d0a7

[FFmpeg-devel] [PATCH V3 1/3] avutil: add ROI data struct and bump version

2018-12-26 Thread Guo, Yejun
The encoders such as libx264 support different QPs offset for different MBs, it makes possible for ROI-based encoding. It makes sense to add support within ffmpeg to generate/accept ROI infos and pass into encoders. Typical usage: After AVFrame is decoded, a ffmpeg filter or user's code generates

Re: [FFmpeg-devel] [PATCH V2 1/2] add support for ROI-based encoding

2018-12-26 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Thursday, December 27, 2018 12:44 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2 1/2] add support f

Re: [FFmpeg-devel] [PATCH] avfilter/f_realtime: add option to scale speed

2018-12-26 Thread Moritz Barsnick
On Wed, Dec 26, 2018 at 18:37:42 +0100, Nicolas George wrote: > > I'm not sure scaling the limit by the factor is the correct idea. It feels > > right regarding the discontinuities, but not according to the limit option's > > description. > > I think it would be more logical to keep limit express

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Paul B Mahol
On 12/26/18, Michael Niedermayer wrote: > On Wed, Dec 26, 2018 at 10:02:15PM +0100, Paul B Mahol wrote: >> On 12/26/18, Michael Niedermayer wrote: >> > On Wed, Dec 26, 2018 at 04:32:17PM +0100, Paul B Mahol wrote: >> >> On 12/25/18, Michael Niedermayer wrote: >> >> > Fixes: Timeout >> >> > Fixes

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Marton Balint
On Wed, 26 Dec 2018, Paul B Mahol wrote: On 12/26/18, Michael Niedermayer wrote: On Wed, Dec 26, 2018 at 04:32:17PM +0100, Paul B Mahol wrote: On 12/25/18, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Michael Niedermayer
On Wed, Dec 26, 2018 at 10:02:15PM +0100, Paul B Mahol wrote: > On 12/26/18, Michael Niedermayer wrote: > > On Wed, Dec 26, 2018 at 04:32:17PM +0100, Paul B Mahol wrote: > >> On 12/25/18, Michael Niedermayer wrote: > >> > Fixes: Timeout > >> > Fixes: > >> > 11502/clusterfuzz-testcase-minimized-ff

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Paul B Mahol
On 12/26/18, Michael Niedermayer wrote: > On Wed, Dec 26, 2018 at 04:32:17PM +0100, Paul B Mahol wrote: >> On 12/25/18, Michael Niedermayer wrote: >> > Fixes: Timeout >> > Fixes: >> > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 >> > Before: Executed >> > c

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread James Almer
On 12/26/2018 4:35 PM, Paul B Mahol wrote: > On 12/26/18, James Almer wrote: >> On 12/26/2018 12:07 PM, Paul B Mahol wrote: >>> On 12/26/18, Nicolas George wrote: > + > +/** > + * Initialize a native channel layout from a bitmask indicating which > channels > + * are present.

Re: [FFmpeg-devel] [PATCH] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

2018-12-26 Thread James Almer
On 12/26/2018 4:40 PM, Mohammad Izadi wrote: > Decode HDR10+ metadata from SEI message and propagate it to side data. > --- > libavcodec/avcodec.h | 10 +- > libavcodec/avpacket.c | 1 + > libavcodec/decode.c | 2 +- > libavcodec/hevc_sei.c | 234 --

[FFmpeg-devel] [PATCH] avcodec/dxva2_mpeg2.c: don't try to get surface index for absent frame

2018-12-26 Thread Anton Fedchin
From: Anton Fedchin after 153b36f there is a possibility to crash when trying to get index of a surface which points to nirvana. it may occurs when a mpeg2 stream starts with non i-frame. --- libavcodec/dxva2_mpeg2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavco

[FFmpeg-devel] [PATCH] Support HDR dynamic metdata (HDR10+) in HEVC decoder.

2018-12-26 Thread Mohammad Izadi
Decode HDR10+ metadata from SEI message and propagate it to side data. --- libavcodec/avcodec.h | 10 +- libavcodec/avpacket.c | 1 + libavcodec/decode.c | 2 +- libavcodec/hevc_sei.c | 234 -- libavcodec/hevc_sei.h | 7 ++ libavcodec/hevcdec.c |

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Michael Niedermayer
On Tue, Dec 25, 2018 at 10:12:13PM -0300, James Almer wrote: > On 12/25/2018 7:15 PM, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > > Before: Executed > > clusterfuzz-testcase-minimized-ffmpeg_AV

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Michael Niedermayer
On Wed, Dec 26, 2018 at 04:32:17PM +0100, Paul B Mahol wrote: > On 12/25/18, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > > Before: Executed > > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Paul B Mahol
On 12/26/18, James Almer wrote: > On 12/26/2018 12:07 PM, Paul B Mahol wrote: >> On 12/26/18, Nicolas George wrote: + +/** + * Initialize a native channel layout from a bitmask indicating which channels + * are present. + * + * @note channel_layout should be pro

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize float yuv2plane1

2018-12-26 Thread Michael Niedermayer
On Mon, Dec 24, 2018 at 07:39:18PM +0200, Lauri Kasanen wrote: > On Sun, 16 Dec 2018 11:06:53 +0200 > Lauri Kasanen wrote: > > > This function wouldn't benefit from VSX instructions, so I put it > > under altivec. > > > > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > >

Re: [FFmpeg-devel] [PATCH] avfilter/f_realtime: add option to scale speed

2018-12-26 Thread Nicolas George
Moritz Barsnick (2018-12-25): > Signed-off-by: Moritz Barsnick > --- > This adds two double precision divisions per frame, which seems acceptable. > > I'm not sure scaling the limit by the factor is the correct idea. It feels > right regarding the discontinuities, but not according to the limit

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Uwe Freese
Hello, attached you can find a new patch, with no trailing spaces and avoiding additional indentation in existing code. Regards, Uwe Am 26.12.18 um 16:48 schrieb Uwe Freese: Hello, so now I've taken the time to integrate the alternative interpolation algorithm 'uglarm' into the delogo filte

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Moritz Barsnick
On Wed, Dec 26, 2018 at 15:23:58 +0100, Uwe Freese wrote: Just some initial remarks (no full review): > Can someone please review and add the code? Who would be primarily > responsible to add this to libavfilter? > ./ffmpeg -i "yourtestvideo.mkv" -map 0:v:0 -vframes 100 -filter_complex > "crop

Re: [FFmpeg-devel] [PATCH V2 1/2] add support for ROI-based encoding

2018-12-26 Thread Michael Niedermayer
On Wed, Dec 26, 2018 at 04:11:35AM +0800, Guo, Yejun wrote: > This patchset contains two patches. > - the first patch (this patch) finished the code and ask for upstream. > - the second patch is just a quick example on how to generate ROI info. > > The encoders such as libx264 support different QP

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Nicolas George
Uwe Freese (2018-12-26): > Parts of the previous code are now in an "if" statement block (function > apply_delogo), so indentation is correct. Even it would maybe be better to > read the diff, it wouldn't be correctly indented. > > In the parameter lists, spaces are added to have the same layout o

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Uwe Freese
Hello, so now I've taken the time to integrate the alternative interpolation algorithm 'uglarm' into the delogo filter. Please do not re-indent existing code in this patch as this makes reviewing the changes more difficult Parts of the previous code are now in an "if" statement block (functi

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-26 Thread Paul B Mahol
On 12/25/18, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > Before: Executed > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > in 11294 ms > After : Executed > clusterfuz

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread James Almer
On 12/26/2018 12:07 PM, Paul B Mahol wrote: > On 12/26/18, Nicolas George wrote: >>> + >>> +/** >>> + * Initialize a native channel layout from a bitmask indicating which >>> channels >>> + * are present. >>> + * >>> + * @note channel_layout should be properly allocated as described above. >>> + *

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Nicolas George
Paul B Mahol (2018-12-26): > Look folk, I'm not paid to do this nor I'm paid to read your "reviews" Neither am I. What does it have to do with anything? > so I will ignore this one. You are not allowed to do that. FFmpeg is not your personal project, it is a collective endeavour governed by cons

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Paul B Mahol
On 12/26/18, Nicolas George wrote: > Paul B Mahol (2018-12-24): >> The new API is more extensible and allows for custom layouts. >> More accurate information is exported, eg for decoders that do not >> set a channel layout, lavc will not make one up for them. >> >> Deprecate the old API working wi

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Carl Eugen Hoyos
> Am 26.12.2018 um 15:23 schrieb Uwe Freese : > so now I've taken the time to integrate the alternative interpolation > algorithm 'uglarm' into the delogo filter. Please do not re-indent existing code in this patch as this makes reviewing the changes more difficult and please do not add trail

[FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Uwe Freese
Hello, so now I've taken the time to integrate the alternative interpolation algorithm 'uglarm' into the delogo filter. I took the code from ffdshow's logoaway, which took over the code from LogoAway for VirtualDub, where I originally added it 2001. :) I tested the code with several differe

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2018-12-26 Thread Nicolas George
Paul B Mahol (2018-12-24): > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just uint64_t bitmasks. > > Original c

Re: [FFmpeg-devel] [PATCH] avcodec/mjpeg: don't override color information from demuxer

2018-12-26 Thread Steinar H. Gunderson
On Wed, Dec 05, 2018 at 09:31:48AM +0100, Steinar H. Gunderson wrote: >> We don't have a solution for that, and its really something the user >> application currently has to solve. > The user application doesn't feel like the right place for this. How would it > be in a better position than FFmpeg

Re: [FFmpeg-devel] [PATCH] avcodec: add AV1 frame split bitstream filter

2018-12-26 Thread James Almer
On 12/17/2018 9:56 PM, James Almer wrote: > This will be needed by the eventual native AV1 decoder. > > Signed-off-by: James Almer > --- > Missing Changelog entry, version bump > > configure| 1 + > libavcodec/Makefile | 1 + > libavcodec/av1_frame_split

Re: [FFmpeg-devel] [PATCH v3] Fix usage of temp_file flag in hls_flags option

2018-12-26 Thread Liu Steven
> 在 2018年12月20日,上午12:19,Aleksey Skripka 写道: > > All my tests ok. > Thank you, Adrian. > >> On 19 Dec 2018, at 12:41, Adrian wrote: >> >> Okay, so given you two have some valid points, I've combined both and ended >> up with final version of the patch: >> - it uses temp file for playlist whe

Re: [FFmpeg-devel] [PATCH v2] lavc/libdavs2: enable multithread

2018-12-26 Thread Steven Liu
hwrenx 于2018年12月15日周六 上午11:41写道: > > From: hwrenx > > Signed-off-by: hwrenx > --- > libavcodec/libdavs2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c > index 37635bb..2846ecf 100644 > --- a/libavcodec/libdavs2.c > +++ b/

Re: [FFmpeg-devel] [PATCH] avformat/hls.c: Properly free prev_segments dynarray after playlist parsing

2018-12-26 Thread Liu Steven
> 在 2018年12月24日,下午5:24,Valery Kot 写道: > > Updated commit message for hls.c memory leak fix > <0001-avformat-hls.c-Properly-free-prev_segments-dynarray-.txt>___ Pushed Thanks Steven > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpe

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/lagarith: Optimize case with singleton probability distribution

2018-12-26 Thread Michael Niedermayer
On Tue, Dec 25, 2018 at 04:43:24PM +0100, Paul B Mahol wrote: > On 12/25/18, Michael Niedermayer wrote: > > On Mon, Dec 24, 2018 at 11:54:31PM +, Kieran Kunhya wrote: > >> > > >> > commit 0ca7a8deeffd33e05ae15a447259b32b6678c727 (HEAD -> master) > >> > Author: Michael Niedermayer > >> > Date:

[FFmpeg-devel] [PATCH v3] avcodec/fft_template: improve performance of the ff_fft_init in fft_template

2018-12-26 Thread Steven Liu
Before patch: init nbits = 17, get 1 samples, average cost: 16175 us After patch: init nbits = 17, get 1 samples, average cost: 14989 us Signed-off-by: Steven Liu --- libavcodec/fft_template.c | 46 +++--- 1 file changed, 35 insertions(+), 11 delet