[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Fix 3 'discards qualifiers' clang compiler warnings

2017-06-05 Thread Patrick Earnest
This email should have the patch. Sorry for the duplicate. When compiled by clang, libavcodec/videotoolboxenc.c produces three 'discards qualifiers' warnings. Changing type of nums[2] from void * to CFNumberRef silences the first two warnings. Adding a pointer (numsptr) to nums[2], and using th

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-05 Thread Hendrik Leppkes
On Tue, Jun 6, 2017 at 4:59 AM, Michael Niedermayer wrote: >> >> The issue is about subsets of the URL space. Files from one URL should >> be allowed to access data from URLs in the same relevant subset (same >> subdirectory or same web server maybe?), but not outside. > > What percentage of hls f

[FFmpeg-devel] [PATCH] libavutil/eval: Add round function to expression parser

2017-06-05 Thread Kevin Mark
We have floor, ceil, and trunc. Let's add round. Signed-off-by: Kevin Mark --- doc/utils.texi | 3 +++ libavutil/eval.c | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/utils.texi b/doc/utils.texi index 1734439459..d65bdf0b0e 100644 --- a/doc/utils.texi +++ b/doc/ut

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-05 Thread Michael Niedermayer
On Mon, Jun 05, 2017 at 05:33:29PM +0200, Nicolas George wrote: > Le septidi 17 prairial, an CCXXV, Michael Niedermayer a écrit : [...] > > You dont need to convince me that the extension check or changes > > within just hls are not a complete solution. Iam quite well aware > > of this. This is int

[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Fix 3 'discards qualifiers' clang compiler warnings

2017-06-05 Thread Patrick Earnest
When compiled by clang, libavcodec/videotoolboxenc.c produces three warnings: libavcodec/videotoolboxenc.c:962:13: warning: assigning to 'void *' from 'CFNumberRef' (aka 'const struct __CFNumber *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] nums[0] = bytes_per

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Vittorio Giovara
On Mon, Jun 5, 2017 at 4:46 PM Aaron Colwell wrote > Attached a new patch that fixes a bug and the indentation in the previous > patch. This should be good now. Sorry for the spam. > > Aaron > > On Mon, Jun 5, 2017 at 12:32 PM Aaron Colwell wrote: > [...] Yeah this version looks much better, tha

[FFmpeg-devel] [PATCH v3] lavc: add mpeg2 decoder/hwaccel to mediacodec

2017-06-05 Thread Aman Gupta
From: Aman Gupta Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. --- configure | 2 ++ libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 2 ++ libavcodec/mediacodecdec.c| 40

[FFmpeg-devel] [PATCH] vf_colorspace: Add support for gbr color space

2017-06-05 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- libavfilter/vf_colorspace.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 0024505a44..0b1bc81f99 100644 --- a/libavfilter/vf_colorspace.c +++ b/libavfilter/vf_colorspace.c @@ -1

Re: [FFmpeg-devel] [PATCH v2] lavc: add mpeg2 decoder/hwaccel to mediacodec

2017-06-05 Thread Aman Gupta
On Mon, Jun 5, 2017 at 1:29 PM, Aman Gupta wrote: > From: Aman Gupta > > Android TV and FireOS hardware supports mpeg2 hardware decoding via > MediaCodec. > --- > configure | 2 ++ > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c| 2 ++ >

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Attached a new patch that fixes a bug and the indentation in the previous patch. This should be good now. Sorry for the spam. Aaron On Mon, Jun 5, 2017 at 12:32 PM Aaron Colwell wrote: > Comments below.. > > On Mon, Jun 5, 2017 at 12:02 PM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote:

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Comments below.. On Mon, Jun 5, 2017 at 12:02 PM Vittorio Giovara wrote: > Hey Aaron > > This allows adding AVSphericalMapping information to files > > that don't already have it. > > --- > > ffmpeg.h | 3 ++ > > ffmpeg_opt.c | 29 - > > libavutil/spherical.

[FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-05 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/cache.c b/libavformat/cache.c index 6aabca2e78..66bbbf54c9 100644 --- a/libavformat/cache.c +++ b/libavformat/cache.c @@ -201,7 +201,7 @@ static int cache_read(

Re: [FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Vittorio Giovara
Hey Aaron > This allows adding AVSphericalMapping information to files > that don't already have it. > --- > ffmpeg.h | 3 ++ > ffmpeg_opt.c | 29 - > libavutil/spherical.c | 113 > ++ > libavutil/spherical.h |

[FFmpeg-devel] [PATCH] libavformat/avio: fix retry_transfer_wrapper return value on error

2017-06-05 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/avio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 1e79c9dd5c..909cad564f 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -394,7 +394,7 @@ static inline int retry_transfe

[FFmpeg-devel] [PATCH] libavformat/file: return AVERROR_EOF on EOF

2017-06-05 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 264542a36a..1fb83851c0 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -112,6 +112,8 @@ static int file_read(URLContext *h, unsigned

[FFmpeg-devel] [PATCH] libavformat/subfile: return AVERROR_EOF on EOF

2017-06-05 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/subfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/subfile.c b/libavformat/subfile.c index fa971e1902..497cf85211 100644 --- a/libavformat/subfile.c +++ b/libavformat/subfile.c @@ -102,7 +102,7 @@ static int subfi

[FFmpeg-devel] [PATCH] libavformat/wtvdec: return AVERROR_EOF on EOF

2017-06-05 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/wtvdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c index 3ac4501306..ee19fd84da 100644 --- a/libavformat/wtvdec.c +++ b/libavformat/wtvdec.c @@ -65,7 +65,7 @@ static int64_t seek

[FFmpeg-devel] [PATCH] libavformat/wtvdec: return AVERROR_EOF on EOF

2017-06-05 Thread Daniel Kucera
--- libavformat/wtvdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c index 3ac4501306..ee19fd84da 100644 --- a/libavformat/wtvdec.c +++ b/libavformat/wtvdec.c @@ -65,7 +65,7 @@ static int64_t seek_by_sector(AVIOContext *pb, in

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: ipred_dl_32x32_16 avx2 implementation

2017-06-05 Thread James Almer
On 6/4/2017 2:52 PM, Ilia Valiakhmetov wrote: > vp9_diag_downleft_32x32_8bpp_c: 580.2 > vp9_diag_downleft_32x32_8bpp_sse2: 75.6 > vp9_diag_downleft_32x32_8bpp_ssse3: 73.7 > vp9_diag_downleft_32x32_8bpp_avx: 72.7 > vp9_diag_downleft_32x32_10bpp_c: 1101.2 > vp9_diag_downleft_32x32_10bpp_sse2: 145.4 >

[FFmpeg-devel] [PATCH v2] lavc: add mpeg2 decoder/hwaccel to mediacodec

2017-06-05 Thread Aman Gupta
From: Aman Gupta Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. --- configure | 2 ++ libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 2 ++ libavcodec/mediacodecdec.c| 23 ++- lib

[FFmpeg-devel] [PATCH] Add spherical_mapping command-line argument to ffmpeg.

2017-06-05 Thread Aaron Colwell
Add spherical_mapping command-line argument to ffmpeg. This allows adding AVSphericalMapping information to files that don't already have it. From eaa84a5f86d37e7de8bd0d6f72a308af57f3ef1d Mon Sep 17 00:00:00 2001 From: Aaron Colwell Date: Fri, 2 Jun 2017 16:11:21 -0700 Subject: [PATCH] Add spheri

Re: [FFmpeg-devel] [PATCH] cmdutils: add log time info into report log file

2017-06-05 Thread Nicolas George
Le quintidi 15 prairial, an CCXXV, Steven Liu a écrit : > I get some problem of the log output: > > 1. the log output by multiple av_log to one line, > for example: > av_log(NULL, "major_brand :"); > av_log(NULL, "isom\n"); > then if add the

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-05 Thread Nicolas George
Le sextidi 16 prairial, an CCXXV, Ronald S. Bultje a écrit : > This reminds me of g_return_val_if_fail in glib, and in some situations > it's quite sensible and helpful. I think so too. But g_return_val_if_fail() has a flaw: it prints a warning and returns, at least with default builds of the lib

[FFmpeg-devel] [PATCH] avformat/file: increase max packet size to 256k for written files

2017-06-05 Thread Marton Balint
Another huge performance improvement when using SMB/CIFS as output. Signed-off-by: Marton Balint --- libavformat/file.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 264542a36a..ae7231a484 100644 --- a/libavformat/file.c +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-05 Thread Nicolas George
Le sextidi 16 prairial, an CCXXV, Daniel Kučera a écrit : > Ok, I see only suggestions and ideas here. If you have any exact > request for change in my patch, let me know. I am not your foreman or anything like that, it is not my place to order you around. What I can tell you is that patches need

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-05 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Michael Niedermayer a écrit : > thats "ad hominem" I am sorry, I did not realize it was, please forgive me and allow me to reformulate. The pattern is: someone is made aware of a minor security exploit in parts of the code not their direct responsibility. Nonethe

Re: [FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux

2017-06-05 Thread James Almer
On 6/5/2017 11:33 AM, Hendrik Leppkes wrote: > On Mon, Jun 5, 2017 at 4:29 PM, James Almer wrote: >> On 6/4/2017 8:49 PM, Michael Niedermayer wrote: >>> On Sun, Jun 04, 2017 at 01:08:39PM -0300, James Almer wrote: This test the demuxer discarding non ADTS frames at the beginning and end

Re: [FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux

2017-06-05 Thread Hendrik Leppkes
On Mon, Jun 5, 2017 at 4:29 PM, James Almer wrote: > On 6/4/2017 8:49 PM, Michael Niedermayer wrote: >> On Sun, Jun 04, 2017 at 01:08:39PM -0300, James Almer wrote: >>> This test the demuxer discarding non ADTS frames at the beginning and >>> end of the input. >>> >>> As a side effect, this commit

Re: [FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux

2017-06-05 Thread James Almer
On 6/4/2017 8:49 PM, Michael Niedermayer wrote: > On Sun, Jun 04, 2017 at 01:08:39PM -0300, James Almer wrote: >> This test the demuxer discarding non ADTS frames at the beginning and >> end of the input. >> >> As a side effect, this commit also enables fate-adts-demux, which was >> accidentally di

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2017-06-05 Thread Moritz Barsnick
I can't comment on the rest (and still really like the concept), but just this: > +Allowed values are positive integers between @code{1} and @code{65535}. This maximum value is no longer correct. > +Allowed values are positive integers between @code{1} and @code{step}, > +where @code{1} correspo

[FFmpeg-devel] opensource investigation for a new solution

2017-06-05 Thread Cristian Lorenzetto
we are thinking to develop a MediaSource(MSE technology) object for the browsers not having it (IE , Safari). It permits pratically to add sequential chunks to a buffer for playing a video/audio. For doing it we need a javascript decoder permitting to add chunks of a file/stream and receive frames

Re: [FFmpeg-devel] [WIP] [PATCH 0/6] sse2/xmm version of 8-bit simple_idct

2017-06-05 Thread Ronald S. Bultje
Hi, On Mon, Jun 5, 2017 at 7:23 AM, James Darnley wrote: > I forgot to mention in my cover letter that although the dct test > passes, fate does not. As I mentioned on IRC, changing them causes > errors elsewhere in fate. I am currently looking into this problem and > I'm sure I will speak to

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: ipred_dl_32x32_16 avx2 implementation

2017-06-05 Thread Ronald S. Bultje
Hi, On Sun, Jun 4, 2017 at 1:52 PM, Ilia Valiakhmetov wrote: > vp9_diag_downleft_32x32_8bpp_c: 580.2 > vp9_diag_downleft_32x32_8bpp_sse2: 75.6 > vp9_diag_downleft_32x32_8bpp_ssse3: 73.7 > vp9_diag_downleft_32x32_8bpp_avx: 72.7 > vp9_diag_downleft_32x32_10bpp_c: 1101.2 > vp9_diag_downleft_32x32_1

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check local file extensions

2017-06-05 Thread Michael Niedermayer
On Mon, Jun 05, 2017 at 11:13:06AM +0200, Paul B Mahol wrote: > On 6/5/17, Michael Niedermayer wrote: > > On Sat, Jun 03, 2017 at 09:20:04PM +0200, Michael Niedermayer wrote: > >> This reduces the attack surface of local file-system > >> information leaking. > >> > >> It prevents the existing expl

Re: [FFmpeg-devel] [WIP] [PATCH 0/6] sse2/xmm version of 8-bit simple_idct

2017-06-05 Thread James Darnley
To answer the couple of questions that were asked over the weekend. Rostislav, about the performance. I can see how to force a particular IDCT implementation for real world decoding (the -idct option) but the MPEG2 HD sample I've been working with mostly uses the "idct add" function which doesn't

[FFmpeg-devel] [PATCH 2/2] libavfilter/scale2ref: Maintain main input's DAR

2017-06-05 Thread Kevin Mark
The scale2ref filter will now maintain the DAR of the main input and not the DAR of the reference input. This previous behavior was deemed counterintuitive for most (all?) use-cases. Before: scale2ref=iw/4:ow/mdar in w:320 h:240 fmt:rgb24 sar:1/1 ref w:640 h:360 fmt:rgb24 sar:1/1 out w:160 h:120

[FFmpeg-devel] [PATCH 1/2] libavfilter/scale: More descriptive in/ref/out logging

2017-06-05 Thread Kevin Mark
This change makes it more clear when using the scale and scale2ref filters what is actually happening. The old format did not differentiate between scale and scale2ref which would make it seem that, when using scale2ref, the ref was what was truly being scaled. Old format for both scale and scale2

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check local file extensions

2017-06-05 Thread Michael Niedermayer
On Mon, Jun 05, 2017 at 08:26:34AM +0200, Nicolas George wrote: > Le septidi 17 prairial, an CCXXV, Michael Niedermayer a écrit : > > Applied with the author name joke suggested by nicolas > > Despite Hendrik's objection? I have of course talked with hendrik before pushing. It was him who suggest

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check local file extensions

2017-06-05 Thread Paul B Mahol
On 6/5/17, Michael Niedermayer wrote: > On Sat, Jun 03, 2017 at 09:20:04PM +0200, Michael Niedermayer wrote: >> This reduces the attack surface of local file-system >> information leaking. >> >> It prevents the existing exploit leading to an information leak. As >> well as similar hypothetical att