Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: second_levels flags process function extract

2017-03-12 Thread Steven Liu
2017-03-11 12:31 GMT+08:00 Steven Liu : > the SECOND_LEVEL* flags process and name is too long > extract all of them output to funtions, make code clear > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 239 +- > - > 1 file changed, 136

[FFmpeg-devel] [PATCH] avcodec/videotoolbox: add rc_max_bitrate control into videotoolbox

2017-03-12 Thread Steven Liu
add kVTCompressionPropertyKey_DataRateLimits support by rc_max_bitrate Signed-off-by: Steven Liu --- libavcodec/videotoolboxenc.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 005f5d6..9738152 10

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vp6: clear dimensions on failed resolution change in vp6_parse_header()

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 03:04:06AM +0100, Michael Niedermayer wrote: > Fixes: 807/clusterfuzz-testcase-6470061042696192 > Fixes null pointer dereference > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv34: Fix runtime error: signed integer overflow: 36880 * 66288 cannot be represented in type 'int'

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 03:04:05AM +0100, Michael Niedermayer wrote: > Fixes: 768/clusterfuzz-testcase-4807444305805312 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/rv34.c | 2 +-

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mpeg12dec: Fix runtime error: left shift of negative value -1

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 03:04:04AM +0100, Michael Niedermayer wrote: > Fixes: 764/clusterfuzz-testcase-6273034652483584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg12dec.c |

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Marton Balint
On Sun, 12 Mar 2017, Paul B Mahol wrote: On 3/12/17, Nicolas George wrote: Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : I absolutely disagree with you on this one. I may have formulated the things a bit sarcastically, but the technical facts remain, and you need to address them.

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 08:54:07PM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Mar 12, 2017 at 7:32 PM, James Almer wrote: > > > On 3/12/2017 6:16 PM, Michael Niedermayer wrote: > > > Using the same type across platforms is more robust and avoids platform > > > specific issues from differen

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-12 Thread Sanchit Sinha
On Mon, Mar 13, 2017 at 2:36 AM, Paul B Mahol wrote: > On 3/12/17, Sanchit Sinha wrote: > > Any changes required in this one? > > Please do not top post. > > Expect vertical alignment, no changes are needed. > ___ > ffmpeg-devel mailing list > ffmpeg-d

[FFmpeg-devel] [PATCH 1/4] avcodec/wavpack: Fix runtime error: shift exponent 137 is too large for 32-bit type 'int'

2017-03-12 Thread Michael Niedermayer
Fixes: 808/clusterfuzz-testcase-4715513349406720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavpack.

[FFmpeg-devel] [PATCH 2/4] avcodec/targa: Skip hflip on blank images

2017-03-12 Thread Michael Niedermayer
Fixes: timeout with 810/clusterfuzz-testcase-5249282825256960 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/targa.c | 41 + 1 file changed, 21 insertion

[FFmpeg-devel] [PATCH 4/4] avcodec/wavpack: Fix runtime error: shift exponent 32 is too large for 32-bit type 'int'

2017-03-12 Thread Michael Niedermayer
Fixes: 822/clusterfuzz-testcase-4873433189974016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavpack.

[FFmpeg-devel] [PATCH 3/4] avcodec/simple_idct_template: Fix several integer overflows

2017-03-12 Thread Michael Niedermayer
Benchmarks with START_TIMER indicate that the code is faster with unsigned, (that is with the patch), there was quite some fluctuation in the numbers so this may be just random Fixes: 811/clusterfuzz-testcase-6465493076541440 Found-by: continuous fuzzing process https://github.com/google/oss-f

Re: [FFmpeg-devel] configure: clang -Oz for small size build to reduce size further

2017-03-12 Thread Wang Bin
How to benchmark codecs? Here is my configuration and result size. The total size of -Oz static or dynamic libraries is about 1M smaller. configure --disable-debug --enable-shared --enable-runtime-cpudetect --enable-hwaccels --enable-avresample --disable-postproc --install_name_dir=@rpath --enabl

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-12 Thread Ronald S. Bultje
Hi, On Sun, Mar 12, 2017 at 7:32 PM, James Almer wrote: > On 3/12/2017 6:16 PM, Michael Niedermayer wrote: > > Using the same type across platforms is more robust and avoids platform > > specific issues from differences in range. > > Also fixed point integers are on a semantical level not size_t

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-12 Thread James Almer
On 3/12/2017 6:16 PM, Michael Niedermayer wrote: > Using the same type across platforms is more robust and avoids platform > specific issues from differences in range. > Also fixed point integers are on a semantical level not size_t > > Previous version reviewed-by: James Almer > Signed-off-by: M

Re: [FFmpeg-devel] [PATCH] Documentation: -vf colormatrix options

2017-03-12 Thread Katherine Frances Nagels
Apologies - now with more useful commit message. I actually remade the commit since I realized I wasn't connected to my usual git login. I hope you can kill the other commit. Sorry for this. :( Contents as before: >From 99c2763fe7e455bf1d5acd68ae7080509da89ce1 Mon Sep 17 00:00:00 2001 From: kfrn

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> I absolutely disagree with you on this one. > > I may have formulated the things a bit sarcastically, but the technical > facts remain, and you need to address them. Yes, I addressed this specific one - I

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paul B Mahol a écrit : > I absolutely disagree with you on this one. I may have formulated the things a bit sarcastically, but the technical facts remain, and you need to address them. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> Because conflicting entries have not been added yet. Last time I >> compared it was different. > > Well, unlike some people on this mailing-list, I actually check my facts > before sending a mail. And I re

[FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

2017-03-12 Thread Michael Niedermayer
Using the same type across platforms is more robust and avoids platform specific issues from differences in range. Also fixed point integers are on a semantical level not size_t Previous version reviewed-by: James Almer Signed-off-by: Michael Niedermayer --- ffprobe.c | 2 +- libav

[FFmpeg-devel] [PATCH] avcodec/vp9: avx2 implementation of ipred_dl_16x16_16

2017-03-12 Thread Ilia
vp9_diag_downleft_16x16_10bpp_c: 263.0 vp9_diag_downleft_16x16_10bpp_sse2: 44.7 vp9_diag_downleft_16x16_10bpp_ssse3: 32.5 vp9_diag_downleft_16x16_10bpp_avx: 31.9 vp9_diag_downleft_16x16_10bpp_avx2: 25.7 vp9_diag_downleft_16x16_12bpp_c: 264.7 vp9_diag_downleft_16x16_12bpp_sse2: 44.4 vp9_diag_downlef

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-12 Thread Paul B Mahol
On 3/12/17, Sanchit Sinha wrote: > Any changes required in this one? Please do not top post. Expect vertical alignment, no changes are needed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Change type of spherical stuff to uint64_t

2017-03-12 Thread James Almer
On 3/12/2017 5:06 PM, Michael Niedermayer wrote: > Using the same type across platforms is more robust and avoids platform > specific issues from differences in range. > Also fixed point integers are on a semantical level not size_t LGTM. You could even use uint32_t as it's more than enough for th

Re: [FFmpeg-devel] [PATCH] Documentation: -vf colormatrix options

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 09:49:37AM +1300, Katherine Frances Nagels wrote: > Hi ffmpeg-devel, > > This is my first time submitting a patch, so I hope I'm on the right track. > > I noticed that not all of the -vf colormatrix options described in ffmpeg > -h filter=colormatrix are included in the do

Re: [FFmpeg-devel] [PATCH] Documentation: -vf colormatrix options

2017-03-12 Thread Kieran Kunhya
On Sat, 11 Mar 2017 at 20:56 Katherine Frances Nagels wrote: > Hi ffmpeg-devel, > > This is my first time submitting a patch, so I hope I'm on the right track. > > I noticed that not all of the -vf colormatrix options described in ffmpeg > -h filter=colormatrix are included in the docs at > https

Re: [FFmpeg-devel] [PATCH v2] swresample/swresample: do not reset tsf on swr_alloc_set_opts

2017-03-12 Thread Muhammad Faiz
On Mon, Mar 13, 2017 at 12:08 AM, Michael Niedermayer wrote: > On Sun, Mar 12, 2017 at 12:58:56AM +0700, Muhammad Faiz wrote: >> so tsf option in aresample will have effect >> previously tsf/internal_sample_format had no effect >> >> fate is updated >> s32p previously used fltp internally >> dblp

[FFmpeg-devel] [PATCH] Change type of spherical stuff to uint64_t

2017-03-12 Thread Michael Niedermayer
Using the same type across platforms is more robust and avoids platform specific issues from differences in range. Also fixed point integers are on a semantical level not size_t Signed-off-by: Michael Niedermayer --- ffprobe.c | 2 +- libavformat/dump.c| 6 +++--- libavutil/sph

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-12 Thread Sanchit Sinha
Any changes required in this one? On Mar 11, 2017 10:53 PM, "Sanchit Sinha" wrote: > > > > > > On Sat, Mar 11, 2017 at 10:38 PM, Paul B Mahol wrote: > >> On 3/11/17, Sanchit Sinha wrote: >> > On Sat, Mar 11, 2017 at 9:46 PM, Sanchit Sinha < >> sanchit15...@iiitd.ac.in> >> > wrote: >> > >> >> t

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paul B Mahol a écrit : > Because conflicting entries have not been added yet. Last time I > compared it was different. Well, unlike some people on this mailing-list, I actually check my facts before sending a mail. And I repeat, I did not see any conflict. > Also wh

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paras Chadha a ecrit : >> Xpm decoder was added >> Also added xpm_pipe demuxer with its probe function >> [...] >> +typedef struct XPMContext { > >> +uint32_t *pixels; >> +int pixels_size; > > The spacing is strange

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paras Chadha a écrit : > Xpm decoder was added > Also added xpm_pipe demuxer with its probe function > > Signed-off-by: Paras Chadha > --- > Changelog| 1 + > doc/general.texi | 2 + > libavcodec/Makefile | 1 + > libavcodec/allco

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: actually skip lines when encountering DOMAIN_ string

2017-03-12 Thread Clément Bœsch
On Sun, Mar 12, 2017 at 07:00:32PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_lut3d.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c > index b136cda..7a294b0 100644 > --- a/libavfilte

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add XPM decoder and demuxer

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> On 3/12/17, Nicolas George wrote: >> > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> >> You could reply with something like: please do not push, wait for my >> >> reply. >> > >> > Yes, I COULD

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add XPM decoder and demuxer

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paul B Mahol a écrit : > On 3/12/17, Nicolas George wrote: > > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : > >> You could reply with something like: please do not push, wait for my > >> reply. > > > > Yes, I COULD have done that. > > > > On the other hand,

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add XPM decoder and demuxer

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> You could reply with something like: please do not push, wait for my >> reply. > > Yes, I COULD have done that. > > On the other hand, you SHOULD have waited to push: first replying to > Marton's comments,

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add XPM decoder and demuxer

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paul B Mahol a écrit : > You could reply with something like: please do not push, wait for my reply. Yes, I COULD have done that. On the other hand, you SHOULD have waited to push: first replying to Marton's comments, and then giving him a fair amount of time to rep

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add XPM decoder and demuxer

2017-03-12 Thread Paul B Mahol
On 3/12/17, Nicolas George wrote: > Le duodi 22 ventose, an CCXXV, Paras Chadha a ecrit : >> ffmpeg | branch: master | Paras Chadha | Sun Mar >> 12 02:49:23 2017 +0530| [5dab7b91adf65eb35d4ae0e76fbd988d55b0d764] | >> committer: Paul B Mahol >> >> avcodec: add XPM decoder and demuxer >> >> Signed-

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paul B Mahol
On 3/12/17, Marton Balint wrote: > > On Sat, 11 Mar 2017, Paras Chadha wrote: > >> On Sat, Mar 11, 2017 at 5:40 AM, Moritz Barsnick wrote: >> >>> >>> > +static int color_table_compare(const void *lhs, const void *rhs) >>> > +{ >>> > +return av_strcasecmp(lhs, ((const ColorEntry *)rhs)->name);

Re: [FFmpeg-devel] [PATCH V3] vf_hwupload: Add missing return value check

2017-03-12 Thread Mark Thompson
On 10/03/17 01:23, Jun Zhao wrote: > V3: just remove noop ff_formats_unref() and add missing return value checks > to suppress build warning. Tested, LGTM, applied. Thanks, - Mark ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec: add XPM decoder and demuxer

2017-03-12 Thread Nicolas George
Le duodi 22 ventôse, an CCXXV, Paras Chadha a écrit : > ffmpeg | branch: master | Paras Chadha | Sun Mar 12 > 02:49:23 2017 +0530| [5dab7b91adf65eb35d4ae0e76fbd988d55b0d764] | committer: > Paul B Mahol > > avcodec: add XPM decoder and demuxer > > Signed-off-by: Paras Chadha It was a bit prem

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Marton Balint
On Sat, 11 Mar 2017, Paras Chadha wrote: On Sat, Mar 11, 2017 at 5:40 AM, Moritz Barsnick wrote: > +static int color_table_compare(const void *lhs, const void *rhs) > +{ > +return av_strcasecmp(lhs, ((const ColorEntry *)rhs)->name); > +} > + > +static const ColorEntry color_table[] = {

[FFmpeg-devel] [PATCH] avfilter/vf_lut3d: actually skip lines when encountering DOMAIN_ string

2017-03-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_lut3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index b136cda..7a294b0 100644 --- a/libavfilter/vf_lut3d.c +++ b/libavfilter/vf_lut3d.c @@ -320,6 +320,7 @@ static int parse

Re: [FFmpeg-devel] [PATCH 1/2] tests/api-seek: make the crc array uint32_t

2017-03-12 Thread James Almer
On 3/12/2017 9:42 AM, Michael Niedermayer wrote: > On Sat, Mar 11, 2017 at 08:33:52PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> tests/api/api-seek-test.c | 17 + >> 1 file changed, 9 insertions(+), 8 deletions(-) >> > > LGTM > > thx Pushed _

Re: [FFmpeg-devel] [PATCH 2/2] tests/api-seek: fix memory leak on realloc() failure

2017-03-12 Thread James Almer
On 3/12/2017 10:12 AM, Michael Niedermayer wrote: > On Sat, Mar 11, 2017 at 08:33:53PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> tests/api/api-seek-test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tests/api/api-seek-test.c b/tests/api/

Re: [FFmpeg-devel] [PATCH] test/api-seek: clean up properly on failure

2017-03-12 Thread James Almer
On 3/12/2017 2:10 PM, Michael Niedermayer wrote: > On Sun, Mar 12, 2017 at 10:51:27AM -0300, James Almer wrote: >> Also propagate better error values. >> >> Signed-off-by: James Almer >> --- >> To be applied before the realloc memleak fix. >> >> tests/api/api-seek-test.c | 31 +++-

Re: [FFmpeg-devel] [PATCH] test/api-seek: clean up properly on failure

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 10:51:27AM -0300, James Almer wrote: > Also propagate better error values. > > Signed-off-by: James Almer > --- > To be applied before the realloc memleak fix. > > tests/api/api-seek-test.c | 31 +++ > 1 file changed, 19 insertions(+), 12 dele

Re: [FFmpeg-devel] [PATCH v2] swresample/swresample: do not reset tsf on swr_alloc_set_opts

2017-03-12 Thread Michael Niedermayer
On Sun, Mar 12, 2017 at 12:58:56AM +0700, Muhammad Faiz wrote: > so tsf option in aresample will have effect > previously tsf/internal_sample_format had no effect > > fate is updated > s32p previously used fltp internally > dblp previously used fltp/dblp internally > > Signed-off-by: Muhammad Fai

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Be more explicit in logging white/black list matches

2017-03-12 Thread Michael Niedermayer
On Sat, Mar 11, 2017 at 06:55:17PM +0100, Alexander Strasser wrote: > The current form of the messages indicating matches in the white > or black lists seems to be a bit too much relying on context. > > Make the messages more explicit. > > This also matches the way codec white list errors are rep

Re: [FFmpeg-devel] [PATCH 1/2] lavf: Remove unnecessary escaping of ' in string literals

2017-03-12 Thread Michael Niedermayer
On Sat, Mar 11, 2017 at 06:54:58PM +0100, Alexander Strasser wrote: > Signed-off-by: Alexander Strasser > --- > libavformat/avio.c | 4 ++-- > libavformat/utils.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BA

Re: [FFmpeg-devel] [PATCH] Add XPM decoder

2017-03-12 Thread Paras Chadha
On Sat, Mar 11, 2017 at 5:47 PM, Michael Niedermayer wrote: > On Sat, Mar 11, 2017 at 05:33:30PM +0530, Paras Chadha wrote: > > Here is the patch with all the changes mentioned above > > > > Signed-off-by: Paras > > --- > > Changelog | 1 + > > doc/general.texi| 2 + >

[FFmpeg-devel] [PATCH] test/api-seek: clean up properly on failure

2017-03-12 Thread James Almer
Also propagate better error values. Signed-off-by: James Almer --- To be applied before the realloc memleak fix. tests/api/api-seek-test.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/tests/api/api-seek-test.c b/tests/api/api-seek-test.c

Re: [FFmpeg-devel] [PATCH 2/2] tests/api-seek: fix memory leak on realloc() failure

2017-03-12 Thread James Almer
On 3/12/2017 10:12 AM, Michael Niedermayer wrote: > On Sat, Mar 11, 2017 at 08:33:53PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> tests/api/api-seek-test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tests/api/api-seek-test.c b/tests/api/

Re: [FFmpeg-devel] [PATCH 2/2] tests/api-seek: fix memory leak on realloc() failure

2017-03-12 Thread Michael Niedermayer
On Sat, Mar 11, 2017 at 08:33:53PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/api/api-seek-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/api/api-seek-test.c b/tests/api/api-seek-test.c > index 6ef3b91933..503968fa13 100644 > -

Re: [FFmpeg-devel] [PATCH 1/2] tests/api-seek: make the crc array uint32_t

2017-03-12 Thread Michael Niedermayer
On Sat, Mar 11, 2017 at 08:33:52PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/api/api-seek-test.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB T

Re: [FFmpeg-devel] [PATCH] avfilter/vf_interlace: add complex vertcal lowpassfilter

2017-03-12 Thread Thomas Mundt
> James Almer schrieb am Sa, 11.3.2017: >>On 3/11/2017 12:39 PM, Thomas Mundt wrote: >>> James Almer schrieb am Fr, 10.3.2017: On 3/8/2017 1:58 PM, Thomas Mundt wrote: Hi, attached patch adds a complex (-1 2 6 2 -1) vertcal lowpassfilter to vf_interlace. This will better

[FFmpeg-devel] [PATCH 1/2] avcodec/scpr: avoid negative linesize

2017-03-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/scpr.c | 89 ++- 1 file changed, 48 insertions(+), 41 deletions(-) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index 465926a..a37e99a 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -2

[FFmpeg-devel] [PATCH 2/2] avcodec/scpr: rework frame handling

2017-03-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/scpr.c | 49 +++-- 1 file changed, 19 insertions(+), 30 deletions(-) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index a37e99a..2d190db 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -45,7 +4