On 3/12/17, Nicolas George <geo...@nsup.org> wrote: > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> On 3/12/17, Nicolas George <geo...@nsup.org> wrote: >> > Le duodi 22 ventose, an CCXXV, Paul B Mahol a ecrit : >> >> You could reply with something like: please do not push, wait for my >> >> reply. >> > >> > Yes, I COULD have done that. >> > >> > On the other hand, you SHOULD have waited to push: first replying to >> > Marton's comments, and then giving him a fair amount of time to reply. >> > >> > Pushing a simple patch when there are no comments is one thing. Pushing >> > a big patch when people have commented without replying, and even less >> > give them to follow up is not only breaking developer guidelines but >> > also basic courtesy. >> > >> >> I'm happy with code as it is. >> > >> > This is a necessary condition, but not a sufficient one. >> > >> > I will not demand you to revert, that would be silly, but please do not >> > do it again. And consider Marton's future comments (ans possibly mine) >> > exactly as binding as if the patch had not yet been applied. >> >> OK, I'm impatiently awaiting your review. > > Please acknowledge the rest of my message. Even if my own review never > arrives, the rest applies.
Yes sir. > > And if you were acting as mentor, I am sorry to say that you let a few > very dubious constructs pass. I'm all ears. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
