Re: [FFmpeg-devel] [PATCH] AAC Encoder: clipping avoidance

2015-07-29 Thread Claudio Freire
On Wed, Jul 29, 2015 at 4:15 PM, Michael Niedermayer wrote: > On Mon, Jul 27, 2015 at 07:28:35PM +0200, Michael Niedermayer wrote: >> On Mon, Jul 20, 2015 at 11:40:54PM -0300, Claudio Freire wrote: >> > On Mon, Jul 20, 2015 at 11:39 PM, Claudio Freire >> > wrote: >> > > On Fri, Jul 17, 2015 at 8

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: report pict_type/error via side-data

2015-07-29 Thread James Zern
On Wed, Jul 29, 2015 at 3:48 AM, Michael Niedermayer wrote: > On Tue, Jul 28, 2015 at 11:12:32PM -0700, James Zern wrote: >> --- >> libavcodec/libvpxenc.c | 10 -- >> 1 file changed, 8 insertions(+), 2 deletions(-) > > LGTM > applied > thanks > > [...] > -- > Michael GnuPG fingerpri

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-29 Thread James Zern
On Wed, Jul 29, 2015 at 3:50 AM, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 12:47:08PM +0200, Michael Niedermayer wrote: >> On Tue, Jul 28, 2015 at 11:12:31PM -0700, James Zern wrote: >> > --- >> > libavcodec/libvpxenc.c | 8 ++-- >> > 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH]lavd/v4l2: Use AVSTREAM_PARSE_FULL_ONCE for h264

2015-07-29 Thread Michael Niedermayer
On Thu, Jul 30, 2015 at 12:36:09AM +, Carl Eugen Hoyos wrote: > Carl Eugen Hoyos ag.or.at> writes: > > > Attached patch suggested and tested by noah fixes ticket #4644. > > > diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c > > index 64ac09c..5683731 100644 > > --- a/libavdevice/v4l2.c >

Re: [FFmpeg-devel] [PATCH]lavd/v4l2: Use AVSTREAM_PARSE_FULL_ONCE for h264

2015-07-29 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached patch suggested and tested by noah fixes ticket #4644. > diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c > index 64ac09c..5683731 100644 > --- a/libavdevice/v4l2.c > +++ b/libavdevice/v4l2.c > else if (codec_id == AV_CODEC_ID_H264) { > -

Re: [FFmpeg-devel] [PATCH] avutil/hmac: fix API/ABI compatibility with the fork

2015-07-29 Thread James Almer
On 29/07/15 9:27 PM, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 09:06:33PM -0300, James Almer wrote: >> The test code is updated with some cosmetics to avoid the loop >> using undefined AVHMACType values. >> The old enum values will be removed in the next major bump, effectively >> making

Re: [FFmpeg-devel] [PATCH] avutil/hmac: fix API/ABI compatibility with the fork

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 09:06:33PM -0300, James Almer wrote: > The test code is updated with some cosmetics to avoid the loop > using undefined AVHMACType values. > The old enum values will be removed in the next major bump, effectively > making both projects synced and without API or ABI issues. >

[FFmpeg-devel] [PATCH] avutil/hmac: fix API/ABI compatibility with the fork

2015-07-29 Thread James Almer
The test code is updated with some cosmetics to avoid the loop using undefined AVHMACType values. The old enum values will be removed in the next major bump, effectively making both projects synced and without API or ABI issues. Signed-off-by: James Almer --- libavutil/hmac.c| 59 +++

[FFmpeg-devel] [PATCH] avutil/hmac: fix API/ABI compatibility with the fork

2015-07-29 Thread James Almer
The test code is updated with some cosmetics to avoid the loop using undefined AVHMACType values. The old enum values will be removed in the next major bump, effectively making both projects synced. Signed-off-by: James Almer --- libavutil/hmac.c | 59 +---

Re: [FFmpeg-devel] [PATCH] rawdec: fix mjpeg probing buffer size check

2015-07-29 Thread Michael Niedermayer
On Thu, Jul 30, 2015 at 12:28:36AM +0200, wm4 wrote: > On Thu, 30 Jul 2015 00:17:49 +0200 > Michael Niedermayer wrote: > > > On Wed, Jul 29, 2015 at 10:33:44PM +0200, wm4 wrote: > > > --- > > > If I read this right, the subtraction and comparison would be done in > > > unsigned, because size_t is

Re: [FFmpeg-devel] [PATCH] rawdec: fix mjpeg probing buffer size check

2015-07-29 Thread wm4
On Thu, 30 Jul 2015 00:17:49 +0200 Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 10:33:44PM +0200, wm4 wrote: > > --- > > If I read this right, the subtraction and comparison would be done in > > unsigned, because size_t is unsigned. Which would make this check > > ineffective. (p->buf_siz

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread wm4
On Wed, 29 Jul 2015 05:12:05 +0200 Reimar Döffinger wrote: > On 29.07.2015, at 05:00, Reimar Döffinger wrote: > > On 29.07.2015, at 03:10, Sasi Inguva wrote: > >> A little context on why I need this. I use individual stream durations to > >> validate , if the outputs after transcoding have the

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread wm4
On Wed, 29 Jul 2015 15:10:47 -0700 Sasi Inguva wrote: > Ok. Didn't know of mkvmerge till now. I have no inclination towards > binary/string tags. I can write them as string tags with mkvmerge > formatting. I just thought parsing binary data directly is better than > parsing a string. But I guess

Re: [FFmpeg-devel] [PATCH] rawdec: fix mjpeg probing buffer size check

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 10:33:44PM +0200, wm4 wrote: > --- > If I read this right, the subtraction and comparison would be done in > unsigned, because size_t is unsigned. Which would make this check > ineffective. (p->buf_size is int.) > --- > libavformat/rawdec.c | 2 +- > 1 file changed, 1 inser

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Sasi Inguva
Ok. Didn't know of mkvmerge till now. I have no inclination towards binary/string tags. I can write them as string tags with mkvmerge formatting. I just thought parsing binary data directly is better than parsing a string. But I guess using string tag will be more useful when parsing mkv from other

Re: [FFmpeg-devel] [PATCH] rawdec: fix mjpeg probing

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 10:11:18PM +0200, wm4 wrote: > There can be other headers than "Content-Type:" (in this case, a > "Content-Length:" header was following), so checking for a trailing > newline is wrong. > --- > libavformat/rawdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ap

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread Ganesh Ajjanagadde
On Wed, Jul 29, 2015 at 3:27 PM, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: >> On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde >> wrote: >> > This fixes Ticket2964 >> > >> > Signed-off-by: Ganesh Ajjanagadde >> > --- >> > ffmpeg.c | 2 +-

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Hendrik Leppkes
On Wed, Jul 29, 2015 at 11:14 PM, Jerome Martinez wrote: > Le 29/07/2015 22:41, Hendrik Leppkes a écrit : >> >> On Wed, Jul 29, 2015 at 8:15 PM, Sasi Inguva wrote: >>> >>> @Reimar: >>> True about the stream duration being wrong if stream timestamp does not >>> start at 0 . I just duplicated the l

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Jerome Martinez
Le 29/07/2015 22:41, Hendrik Leppkes a écrit : On Wed, Jul 29, 2015 at 8:15 PM, Sasi Inguva wrote: @Reimar: True about the stream duration being wrong if stream timestamp does not start at 0 . I just duplicated the logic to compute the total duration. In which case, the total duration as it is

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread wm4
On Wed, 29 Jul 2015 22:41:49 +0200 Hendrik Leppkes wrote: > On Wed, Jul 29, 2015 at 8:15 PM, Sasi Inguva wrote: > > @Reimar: > > True about the stream duration being wrong if stream timestamp does not > > start at 0 . I just duplicated the logic to compute the total duration. In > > which case,

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Hendrik Leppkes
On Wed, Jul 29, 2015 at 8:15 PM, Sasi Inguva wrote: > @Reimar: > True about the stream duration being wrong if stream timestamp does not > start at 0 . I just duplicated the logic to compute the total duration. In > which case, the total duration as it is computed now, is also wrong. > Printing th

[FFmpeg-devel] [PATCH] rawdec: fix mjpeg probing buffer size check

2015-07-29 Thread wm4
--- If I read this right, the subtraction and comparison would be done in unsigned, because size_t is unsigned. Which would make this check ineffective. (p->buf_size is int.) --- libavformat/rawdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rawdec.c b/libavfo

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread wm4
On Wed, 29 Jul 2015 11:15:37 -0700 Sasi Inguva wrote: > @wm4: > Yes. It writes tags by default. But tags are written in the header at the > start of the file, as far as I can see > http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavformat/matroskaenc.c;h=2d0d5f6bb1b4ae4f737419cb11379ccb13ad18f0;

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread wm4
On Wed, 29 Jul 2015 21:27:09 +0200 Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: > > On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde > > wrote: > > > This fixes Ticket2964 > > > > > > Signed-off-by: Ganesh Ajjanagadde > > > --- > > > ffmpe

[FFmpeg-devel] [PATCH] rawdec: fix mjpeg probing

2015-07-29 Thread wm4
There can be other headers than "Content-Type:" (in this case, a "Content-Length:" header was following), so checking for a trailing newline is wrong. --- libavformat/rawdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c index b903

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: > On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde > wrote: > > This fixes Ticket2964 > > > > Signed-off-by: Ganesh Ajjanagadde > > --- > > ffmpeg.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] AAC Encoder: clipping avoidance

2015-07-29 Thread Michael Niedermayer
Hi On Mon, Jul 27, 2015 at 07:28:35PM +0200, Michael Niedermayer wrote: > On Mon, Jul 20, 2015 at 11:40:54PM -0300, Claudio Freire wrote: > > On Mon, Jul 20, 2015 at 11:39 PM, Claudio Freire > > wrote: > > > On Fri, Jul 17, 2015 at 8:42 PM, Michael Niedermayer > > > wrote: > > >>> If you mean a

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread Ganesh Ajjanagadde
On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde wrote: > This fixes Ticket2964 > > Signed-off-by: Ganesh Ajjanagadde > --- > ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 751c7d3..98f812e 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: use AVHMAC instead of a custom implementation

2015-07-29 Thread James Almer
On 29/07/15 6:57 AM, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 12:17:47AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> This can be tested with the rtmpe server listed in >> http://wiki.multimedia.cx/?title=RTMP > > should be ok if it works > > thanks Pushed. __

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Sasi Inguva
@Reimar: True about the stream duration being wrong if stream timestamp does not start at 0 . I just duplicated the logic to compute the total duration. In which case, the total duration as it is computed now, is also wrong. Printing the durations out in the logs, and then parsing the logs to get t

Re: [FFmpeg-devel] Hosting offer for ffmpeg by DreamHack

2015-07-29 Thread Michael Niedermayer
Hi On Sat, Jul 18, 2015 at 04:50:21PM +0200, Markus Viitamäki wrote: > Hello all! > > We at DreamHack would like to offer the ffmpeg project free hosting. > Location for this hosting would be in Sweden, and to be more exact > Stockholm. > > Hardware: > We have a few machines spare, and the most

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: Implement support for seeking relative to EOF

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 06:23:02PM +0200, Clément Bœsch wrote: > On Wed, Jul 29, 2015 at 05:32:14PM +0200, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Mon Jul 27 04:30:26 2015 +0200| [f4ada6dc3ff7a5c4193d2b30151a48de8e219c94] > > | committer: Michael Nieder

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: Implement support for seeking relative to EOF

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 06:22:04PM +0200, Clément Bœsch wrote: > On Wed, Jul 29, 2015 at 05:32:14PM +0200, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Mon Jul 27 04:30:26 2015 +0200| [f4ada6dc3ff7a5c4193d2b30151a48de8e219c94] > > | committer: Michael Nieder

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: Implement support for seeking relative to EOF

2015-07-29 Thread Clément Bœsch
On Wed, Jul 29, 2015 at 05:32:14PM +0200, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Mon > Jul 27 04:30:26 2015 +0200| [f4ada6dc3ff7a5c4193d2b30151a48de8e219c94] | > committer: Michael Niedermayer > > ffmpeg: Implement support for seeking relative to EOF > > F

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: Implement support for seeking relative to EOF

2015-07-29 Thread Clément Bœsch
On Wed, Jul 29, 2015 at 05:32:14PM +0200, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Mon > Jul 27 04:30:26 2015 +0200| [f4ada6dc3ff7a5c4193d2b30151a48de8e219c94] | > committer: Michael Niedermayer > > ffmpeg: Implement support for seeking relative to EOF > > F

Re: [FFmpeg-devel] [PATCH] avcodec: add new Videotoolbox hwaccel.

2015-07-29 Thread Clément Bœsch
On Tue, Jul 28, 2015 at 09:01:50PM +0800, Zhang Rui wrote: > 2015-07-28 16:04 GMT+08:00 Clément Bœsch : > > On Mon, Jul 27, 2015 at 10:10:12PM +0800, Zhang Rui wrote: > >> 2015-07-27 20:14 GMT+08:00 Clément Bœsch : > >> > On Mon, Jul 27, 2015 at 06:13:30PM +0800, Zhang Rui wrote: > >> >> 2015-07-15

Re: [FFmpeg-devel] [PATCH] ffmpeg: Implement support for seeking relative to EOF

2015-07-29 Thread Michael Niedermayer
On Mon, Jul 27, 2015 at 10:38:34AM +0800, Timothy Gu wrote: > On 7/27/15, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Fixes Ticket227 > > > > Signed-off-by: Michael Niedermayer > > --- > > ffmpeg.h |1 + > > ffmpeg_opt.c |6 ++ > > 2 files changed, 7 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix preparation for resampler

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 04:46:18PM +0200, Nedeljko Babic wrote: > 2nd channel makes sense only for CPE type. > > Skip 2nd channel in preparation for resampler (in spectral_to _sample()) > depending on block type. > > Fixes fate failure with clang ftrapv. > > Signed-off-by: Nedeljko Babic appli

[FFmpeg-devel] [PATCH] ffplay: add scale_subtitles option to allow disabling the scaling

2015-07-29 Thread Michael Niedermayer
From: Michael Niedermayer This theoretically is faster and might be useful on some low end embeded systems Inspired-by: Compns reply Signed-off-by: Michael Niedermayer --- ffplay.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/ffplay.c b/ffplay.c index c

[FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix preparation for resampler

2015-07-29 Thread Nedeljko Babic
2nd channel makes sense only for CPE type. Skip 2nd channel in preparation for resampler (in spectral_to _sample()) depending on block type. Fixes fate failure with clang ftrapv. Signed-off-by: Nedeljko Babic --- libavcodec/aacdec_template.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH] ffplay: Use sws_scale to scale subtitles

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 02:22:02AM +0200, Marton Balint wrote: > > On Tue, 28 Jul 2015, Michael Niedermayer wrote: > > >From: Michael Niedermayer > > > >Fixes some files from Ticket679 > > > >This also changes subtitles to 4:2:0 matching the output format and thus > >simplifying the blend code.

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow

2015-07-29 Thread Nedeljko Babic
>> for(j = 0; j> -che->ch[0].ret[j] = >> (int32_t)av_clipl_int32((int64_t)che->ch[0].ret[j]<<7)+0x8000; >> -che->ch[1].ret[j] = >> (int32_t)av_clipl_int32((int64_t)che->ch[1].ret[j]<<7)+0x8000; >> +che->c

Re: [FFmpeg-devel] GSoC Weekly report (libswscale)

2015-07-29 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 11:39:59PM -0300, Pedro Arthur wrote: > > do you think this patch would be ready to push to main ffmpeg once > > this (and any other remaining) issues are fixed > > or is there still some speed loss ? > > > I think I should work a bit more on it, in my tests some cases there

Re: [FFmpeg-devel] New Server

2015-07-29 Thread Nikolay Aleksandrov
On 07/29/2015 02:18 PM, compn wrote: > On Fri, 24 Jul 2015 19:06:02 +0200 > Michael Niedermayer wrote: > >> I intend to accept 2 of the offers below for redundancy, again if you >> think something else should be done, speak now! > > hi > > did anyone explain to the hosts that we get copyright c

Re: [FFmpeg-devel] New Server

2015-07-29 Thread compn
On Fri, 24 Jul 2015 19:06:02 +0200 Michael Niedermayer wrote: > I intend to accept 2 of the offers below for redundancy, again if you > think something else should be done, speak now! hi did anyone explain to the hosts that we get copyright claims and abuse mails because of files we host wrongl

Re: [FFmpeg-devel] [PATCH v5] Add support for Audible AA files

2015-07-29 Thread Vesselin Bontchev
28.07.2015, 20:09, "Vesselin Bontchev" : > I sneaked in some more fixes in this revision :) Hi Carl, Is the licensing blurb okay now? All, Hopefully, the code is now good enough to be merged. All feedback is welcome! Thanks, Vesselin ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] wavdec: make sample count check more precise

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 12:28:15AM -0400, Ganesh Ajjanagadde wrote: > May be used to fix Ticket4577 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/wavdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow

2015-07-29 Thread Michael Niedermayer
Hi On Wed, Jul 29, 2015 at 11:58:43AM +0200, Nedeljko Babic wrote: > Add type cast of result of av_clipl_int32() to 64 bit to avoid overflow in > addition later. > > Fixes fate failure with clang ftrapv. > > Signed-off-by: Nedeljko Babic > --- > libavcodec/aacdec_template.c | 4 ++-- > 1 file

Re: [FFmpeg-devel] New Server

2015-07-29 Thread compn
On Fri, 24 Jul 2015 19:06:02 +0200 Michael Niedermayer wrote: > I intend to accept 2 of the offers below for redundancy, again if you > think something else should be done, speak now! hi did anyone explain to the hosts that we get copyright claims and abuse mails because of files we host wrongl

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 12:47:08PM +0200, Michael Niedermayer wrote: > On Tue, Jul 28, 2015 at 11:12:31PM -0700, James Zern wrote: > > --- > > libavcodec/libvpxenc.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > applied i meant "LGTM" > > thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: report pict_type/error via side-data

2015-07-29 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 11:12:32PM -0700, James Zern wrote: > --- > libavcodec/libvpxenc.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to sugges

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-29 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 11:12:31PM -0700, James Zern wrote: > --- > libavcodec/libvpxenc.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highe

[FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow

2015-07-29 Thread Nedeljko Babic
Add type cast of result of av_clipl_int32() to 64 bit to avoid overflow in addition later. Fixes fate failure with clang ftrapv. Signed-off-by: Nedeljko Babic --- libavcodec/aacdec_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec_template.c b/

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: use AVHMAC instead of a custom implementation

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 12:17:47AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > This can be tested with the rtmpe server listed in > http://wiki.multimedia.cx/?title=RTMP should be ok if it works thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread wm4
On Tue, 28 Jul 2015 12:39:59 -0700 Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/matroska.h | 1 + > libavformat/matroskadec.c| 21 +- > libavformat/matroskaenc.c| 66 > ++-- > tests/fate/wavpack.mak

Re: [FFmpeg-devel] [PATCH 7/8] tests: Add aac_fixed decoder test

2015-07-29 Thread Clément Bœsch
On Tue, Jul 28, 2015 at 03:37:34PM +, Nedeljko Babic wrote: [...] > I am sending fix for a bug that pops out with the valgrind and > –disable-memory-poisoning. > Memory poisoning is writing data for every alloc (note: not realloc), so it prevents valgrind from detecting most of the uninitial