Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix UTCTiming Element

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 04:26:34PM -0700, Vignesh Venkatasubramanian wrote: > Remove the direct profile from UTCTiming element. Per DASH spec, > direct profile value should be the time at which the request was > made to the server and not the time at which the manifest was > written. So ffmpeg cann

Re: [FFmpeg-devel] [PATCH] apedec: set s->samples only when init_frame_decoder succeeded

2015-04-27 Thread Michael Niedermayer
On Tue, Apr 28, 2015 at 12:30:51AM +0200, Andreas Cadhalpun wrote: > Otherwise range_start_decoding is not necessarily run and thus > ctx->rc.range still 0 in range_dec_normalize leading to an infinite > loop. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/apedec.c | 2 +- > 1 file chan

Re: [FFmpeg-devel] [PATCH] apedec: ensure blockstodecode is large enough

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 11:56:15PM +0200, Andreas Cadhalpun wrote: > s->decoded_buffer is allocated with a min_size of: > 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer) > > Then it is assigned to s->decoded[0], which is passed as out buffer to > decode_array_. > > In this fun

Re: [FFmpeg-devel] [PATCH] libavformat/webm_chunk: Write first audio packet.

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 02:47:03PM -0700, Vignesh Venkatasubramanian wrote: > Fix a bug where the chunk muxer doesn't write the very first audio > packet (with pts == 0). > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/webm_chunk.c | 3 --- > 1 file changed, 3 deletions(-) app

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-27 Thread James Almer
On 27/04/15 9:02 PM, Michael Niedermayer wrote: > Ok, so the patch adds many #ifs to both the muxer and > encoder, and there are more changes in the encoder than the muxer > the commit message which is 1 single line only speaks about the encoder > and the patch is only about the muxer. > Did i unde

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 10:18:52PM +, Urvang Joshi wrote: > On Thu, Apr 23, 2015 at 2:51 PM Michael Niedermayer > wrote: > > > On Thu, Apr 16, 2015 at 10:40:14PM +, Urvang Joshi wrote: > > > On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote: > > > > > > > On 16/04/15 4:18 PM, Urvang Josh

[FFmpeg-devel] [PATCH] webmdashenc: Fix UTCTiming Element

2015-04-27 Thread Vignesh Venkatasubramanian
Remove the direct profile from UTCTiming element. Per DASH spec, direct profile value should be the time at which the request was made to the server and not the time at which the manifest was written. So ffmpeg cannot write this value. This patch removes the direct profile and write the UTCTiming e

[FFmpeg-devel] [PATCH] apedec: set s->samples only when init_frame_decoder succeeded

2015-04-27 Thread Andreas Cadhalpun
Otherwise range_start_decoding is not necessarily run and thus ctx->rc.range still 0 in range_dec_normalize leading to an infinite loop. Signed-off-by: Andreas Cadhalpun --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/a

[FFmpeg-devel] [PATCH] apedec: ensure blockstodecode is large enough

2015-04-27 Thread Andreas Cadhalpun
s->decoded_buffer is allocated with a min_size of: 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer) Then it is assigned to s->decoded[0], which is passed as out buffer to decode_array_. In this function 64 elements of the out buffer are written unconditionally and outside the a

Re: [FFmpeg-devel] Patch[1/2]: Fix bug for PPC LE in file libswscale/ppc/swscale_altivec.c

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 08:27:23PM +0200, Andreas Cadhalpun wrote: > On 27.04.2015 20:19, Michael Niedermayer wrote: > > On Mon, Apr 27, 2015 at 07:18:46PM +0200, Andreas Cadhalpun wrote: > >> On 27.04.2015 13:11, Michael Niedermayer wrote: > >>> On Mon, Apr 27, 2015 at 02:50:12PM +0800, rongyan wr

Re: [FFmpeg-devel] Patch[1/2]: Fix bug for PPC LE in file libswscale/ppc/swscale_altivec.c

2015-04-27 Thread Andreas Cadhalpun
On 27.04.2015 20:19, Michael Niedermayer wrote: > On Mon, Apr 27, 2015 at 07:18:46PM +0200, Andreas Cadhalpun wrote: >> On 27.04.2015 13:11, Michael Niedermayer wrote: >>> On Mon, Apr 27, 2015 at 02:50:12PM +0800, rongyan wrote: Hi, GCC tool has a bug of PPC intrinsic interpret, which has

Re: [FFmpeg-devel] Patch[1/2]: Fix bug for PPC LE in file libswscale/ppc/swscale_altivec.c

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 07:18:46PM +0200, Andreas Cadhalpun wrote: > On 27.04.2015 13:11, Michael Niedermayer wrote: > > On Mon, Apr 27, 2015 at 02:50:12PM +0800, rongyan wrote: > >> Hi, > >> GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC > >> 4.9.1. This bug lead to er

Re: [FFmpeg-devel] Patch[1/2]: Fix bug for PPC LE in file libswscale/ppc/swscale_altivec.c

2015-04-27 Thread Andreas Cadhalpun
On 27.04.2015 13:11, Michael Niedermayer wrote: > On Mon, Apr 27, 2015 at 02:50:12PM +0800, rongyan wrote: >> Hi, >> GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC >> 4.9.1. This bug lead to errors in two of our previous patches. We found this >> when we update our GCC

Re: [FFmpeg-devel] Test case for Closed caption decoder.

2015-04-27 Thread Clément Bœsch
On Mon, Apr 27, 2015 at 10:35:49PM +0530, Anshul wrote: > Hello, > > I am attaching patch for closed caption decoder. > > Thanks > Anshul > From 230cd5d9de356a8e84d2c36f91510631317986db Mon Sep 17 00:00:00 2001 > From: Anshul Maheshwari > Date: Mon, 27 Apr 2015 22:33:48 +0530 > Subject: [PATCH]

[FFmpeg-devel] Test case for Closed caption decoder.

2015-04-27 Thread Anshul
Hello, I am attaching patch for closed caption decoder. Thanks Anshul From 230cd5d9de356a8e84d2c36f91510631317986db Mon Sep 17 00:00:00 2001 From: Anshul Maheshwari Date: Mon, 27 Apr 2015 22:33:48 +0530 Subject: [PATCH] Adding Closed caption sub test case Signed-off-by: Anshul Maheshwari ---

Re: [FFmpeg-devel] [PATCH] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 03:58:44PM +0200, Nedeljko Babic wrote: > From: Djordje Pesut > > Functions for sqrt and sincos are added. these could be in a seperate patch > > Div function is improved. how? if its about adding av_recip_sf/av_div_sf_approx() then that commit message is outdated an

Re: [FFmpeg-devel] [PATCH 2/2] tests: make sure subtitles test are run with a rawdiff

2015-04-27 Thread Clément Bœsch
On Mon, Apr 27, 2015 at 12:19:08AM +0200, Michael Niedermayer wrote: > On Sun, Apr 26, 2015 at 10:34:49PM +0200, Clément Bœsch wrote: > > On Sun, Apr 26, 2015 at 10:30:14PM +0200, Clément Bœsch wrote: > > > On Sun, Apr 26, 2015 at 10:18:24PM +0200, Michael Niedermayer wrote: > > > > On Sun, Apr 26,

Re: [FFmpeg-devel] [PATCH] Adapt libavcodec/tableprint_vlc.h to the av_dlog -> ff_dlog change.

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 05:33:01PM +0200, Alexis Ballier wrote: > This fixes the build with --enable-hardcoded-tables that was broken since > [8f7b022c8c2f40bf8ddfd90778a4c91424d3a8e5]. > --- > libavcodec/tableprint_vlc.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied thanks

Re: [FFmpeg-devel] Adding Webvtt in hls muxer

2015-04-27 Thread Anshul
On 03/12/2015 08:03 PM, Deron wrote: On 2/26/15 4:26 AM, Anshul wrote: On 02/25/2015 10:04 PM, Deron wrote: On 2/21/15 8:05 AM, Deron wrote: On 2/15/15 5:44 AM, Anshul wrote: attached another cleaned patch. -Anshul Not sure if I should be posting here, privately, or do the user list s

[FFmpeg-devel] [PATCH] Adapt libavcodec/tableprint_vlc.h to the av_dlog -> ff_dlog change.

2015-04-27 Thread Alexis Ballier
This fixes the build with --enable-hardcoded-tables that was broken since [8f7b022c8c2f40bf8ddfd90778a4c91424d3a8e5]. --- libavcodec/tableprint_vlc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/tableprint_vlc.h b/libavcodec/tableprint_vlc.h index aa4c82b..7f46

[FFmpeg-devel] Softfloat changes

2015-04-27 Thread Nedeljko Babic
Change in accordance with last review. -Nedeljko ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] libavutil: Make changes in softfloat needed for fixed point aac decoder.

2015-04-27 Thread Nedeljko Babic
From: Djordje Pesut Functions for sqrt and sincos are added. Div function is improved. Some changes are made in order for code in softfloat to be usable in fixed aac decoder code. This doesn't create any impact on current ffmpeg code since softfloat is currently not in use and this way we don'

Re: [FFmpeg-devel] Loongson Optimization Patchs and Machine Express Issuse

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 10:58:11AM +0800, 周晓勇 wrote: > The imgtec's msa optimization had changed the Makefile earlier than me, it's > ok now. > > > > -原始邮件- > > 发件人: "Michael Niedermayer" > > 发送时间: 2015年4月25日 星期六 > > 收件人: "FFmpeg development discussions and patches" > > 抄送: gaoxiang ,

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXIII, Michael Niedermayer a écrit : > the code changes look ok The phrasing seems to invite this: The commit message does not shock me. Seriously, I do not know how my message about commit messages ended being so long, I do not intend to become a commit message tyrant,

Re: [FFmpeg-devel] [PATCH 2/2] Using size_t* instead of int** for dynarrays

2015-04-27 Thread Niklesh Lalwani
> > to clarify, patch 2 did not apply on top of a branch that contained > > patch 1 > > >> [...] > > >> -- > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Yes, I posted the updated patch which applies properly. I can post them as separate patches too. However, av_dy

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 10:13:59AM +0200, Carl Eugen Hoyos wrote: > On Thursday 23 April 2015 03:05:48 pm Michael Niedermayer wrote: > > without really thinking about it, the idea to remove the extension > > for apng or change it to .apng, seems like a good idea > > New patch attached. > > Please

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread Niklesh Lalwani
> > On Mon, Apr 27, 2015 at 12:47 PM, Carl Eugen Hoyos >>> wrote: >> >> >>> Please do not merge patches, instead send two >> >> patches: One that adds support for large boxes >> >> and a second one. The second one has to apply >> >> cleanly after the first was applied. >> >> >>> Carl Eugen >> >>

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread wm4
On Mon, 27 Apr 2015 17:18:31 +0530 Niklesh Lalwani wrote: > > > > On Mon, Apr 27, 2015 at 2:25 PM, wm4 wrote: > > > > This looks hacky. av_dynarray_add() is supposed to many an array of > > pointers, and here you twist it enough to reinterpret-cast an int to a > > pointer. > > > > Yes, this look

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread Niklesh Lalwani
> > On Mon, Apr 27, 2015 at 2:25 PM, wm4 wrote: > > This looks hacky. av_dynarray_add() is supposed to many an array of > pointers, and here you twist it enough to reinterpret-cast an int to a > pointer. > > Yes, this looks hacky. Earlier I was using int **number, passing address of element to add

Re: [FFmpeg-devel] [PATCH 2/2] Using size_t* instead of int** for dynarrays

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 05:10:47AM +0200, Michael Niedermayer wrote: > On Mon, Apr 27, 2015 at 07:33:59AM +0530, Niklesh Lalwani wrote: > > On Mon, Apr 27, 2015 at 7:10 AM, Michael Niedermayer > > >> wrote: > > >> > > >> > From: Niklesh > > >> > > > >> > Signed-off-by: Niklesh > > >> > --- > > >

Re: [FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompatibility issues

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 07:51:33AM +, Gupta, Maneesh wrote: > Hi, > > This patch attempts to fix the ABI incompatibility issues in the OpenCL code. > Please review it and let me know if there is anything that I missed > addressing in this patch. > > Regards, > Maneesh > opencl.c | 42 ++

Re: [FFmpeg-devel] [PATCH 2/2] OpenCL: Avoid potential buffer overflow in cmdutils_opencl.c by using strncpy instead of strcpy

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 07:51:36AM +, Gupta, Maneesh wrote: > Hi, > > There was a potential buffer overflow during a strcpy operation in > cmdutils_opencl.c. This patch attempts to fix the same. > > Regards, > Maneesh > cmdutils_opencl.c |2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [FFmpeg-devel] Patch[2/2]: Fix bug for PPC LE in file libavcodec/ppc/fdctdsp.c

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 02:52:02PM +0800, rongyan wrote: > Hi, > GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC > 4.9.1. This bug lead to errors in two of our previous patches. We found this > when we update our GCC tools to 4.9.1 and by reading the related info on GCC

Re: [FFmpeg-devel] Patch[1/2]: Fix bug for PPC LE in file libswscale/ppc/swscale_altivec.c

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 02:50:12PM +0800, rongyan wrote: > Hi, > GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC > 4.9.1. This bug lead to errors in two of our previous patches. We found this > when we update our GCC tools to 4.9.1 and by reading the related info on GCC

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread wm4
On Mon, 27 Apr 2015 09:58:58 +0530 Niklesh Lalwani wrote: > From: Niklesh > > Signed-off-by: Niklesh > --- > libavcodec/movtextdec.c | 54 > + > 1 file changed, 28 insertions(+), 26 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libav

Re: [FFmpeg-devel] [PATCH] libavcodec/parser.c: re-fetch PTS/DTS if fetch failed

2015-04-27 Thread Hendrik Leppkes
On Mon, Apr 27, 2015 at 10:39 AM, luckliuyuxin wrote: > Michael , > > This is my first time send path to ffmpeg. I'm not familiar with "make fate". > Could you please told me how the "make fate" report the break error? > The following is my steps to make fate on my computer, but I couldn't find >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add resizeable field to AVIOContext

2015-04-27 Thread wm4
On Mon, 27 Apr 2015 04:50:27 +0200 Michael Niedermayer wrote: > On Tue, Apr 21, 2015 at 02:23:19PM +0200, wm4 wrote: > > On Tue, 21 Apr 2015 13:22:00 +0200 > > Michael Niedermayer wrote: > > > > > This indicates that its safe to use av_free/av_malloc on the IO context > > > > > > Signed-off-by

Re: [FFmpeg-devel] [PATCH]Allow easy png streamcopying

2015-04-27 Thread Carl Eugen Hoyos
On Thursday 23 April 2015 03:05:48 pm Michael Niedermayer wrote: > without really thinking about it, the idea to remove the extension > for apng or change it to .apng, seems like a good idea New patch attached. Please comment, Carl Eugen From 56b8fa753399c53d83231bc56b7461ccaeb62de3 Mon Sep 17 00

Re: [FFmpeg-devel] [PATCH 2/2] OpenCL: Avoid potential buffer overflow in cmdutils_opencl.c by using strncpy instead of strcpy

2015-04-27 Thread highgod0401
From: Gupta, Maneesh Date: 2015-04-27 15:51 To: FFMPEG Developer Mailing List (ffmpeg-devel@ffmpeg.org) Subject: [FFmpeg-devel] [PATCH 2/2] OpenCL: Avoid potential buffer overflow in cmdutils_opencl.c by using strncpy instead of strcpy Hi, There was a potential buffer overflow during a strcpy op

Re: [FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompatibility issues

2015-04-27 Thread highgod0401
From: Gupta, Maneesh Date: 2015-04-27 15:51 To: FFMPEG Developer Mailing List (ffmpeg-devel@ffmpeg.org) Subject: [FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompatibility issues Hi, This patch attempts to fix the ABI incompatibility issues in the OpenCL code. Please review it and let me know if

[FFmpeg-devel] [PATCH 1/2] OpenCL: Fix ABI incompatibility issues

2015-04-27 Thread Gupta, Maneesh
Hi, This patch attempts to fix the ABI incompatibility issues in the OpenCL code. Please review it and let me know if there is anything that I missed addressing in this patch. Regards, Maneesh 0001-OpenCL-Fix-ABI-incompatibility-issues.patch Description: 0001-OpenCL-Fix-ABI-incompatibility-is

[FFmpeg-devel] [PATCH 2/2] OpenCL: Avoid potential buffer overflow in cmdutils_opencl.c by using strncpy instead of strcpy

2015-04-27 Thread Gupta, Maneesh
Hi, There was a potential buffer overflow during a strcpy operation in cmdutils_opencl.c. This patch attempts to fix the same. Regards, Maneesh 0002-OpenCL-Replace-strcpy-with-strncpy-to-avoid-buffer-o.patch Description: 0002-OpenCL-Replace-strcpy-with-strncpy-to-avoid-buffer-o.patch _

Re: [FFmpeg-devel] DXVA Question.

2015-04-27 Thread Hendrik Leppkes
On Mon, Apr 27, 2015 at 8:44 AM, Anton Fedchin wrote: > Hendrik Leppkes gmail.com> writes: > >> >> On Sun, Apr 26, 2015 at 8:45 AM, Anton Fedchin gmail.com> > wrote: >> > Hi, >> > >> > I'm working on porting our project Kodi to DirectX11. We also use ffmpeg >> > and I've implemented patch to ffm

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread Carl Eugen Hoyos
Niklesh Lalwani iitb.ac.in> writes: > -av_dynarray_add(&style_start, &index, style_pos); > +av_dynarray_add(&style_start, &index, (void*)(size_t)style_pos); Imo, this ugliness indicates that there is something wrong with your patch but that may only be me. Carl Eugen _

Re: [FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

2015-04-27 Thread Carl Eugen Hoyos
Niklesh Lalwani iitb.ac.in> writes: > This contains both the patches- support > for large boxes, and using size_t for dynarrays. Please do not merge patches, instead send two patches: One that adds support for large boxes and a second one. The second one has to apply cleanly after the first w