On Mon, Apr 27, 2015 at 03:58:44PM +0200, Nedeljko Babic wrote: > From: Djordje Pesut <djordje.pe...@imgtec.com> >
> Functions for sqrt and sincos are added. these could be in a seperate patch > > Div function is improved. how? if its about adding av_recip_sf/av_div_sf_approx() then that commit message is outdated and should be changed to match the code > > Some changes are made in order for code in softfloat to be usable in fixed aac > decoder code. which and why? > > This doesn't create any impact on current ffmpeg code since softfloat is > currently not in use and this way we don't need to make much changes in > implementation of aac fixed point decoder that uses this code. > > Softfloat tests are adjusted. no, this just changed the header files, the tests where in the c file also the commit message should mention how exactly the Softfloat exp/mantisa are changed, is this a bugfix, is there some offset added, is some sign changed, ... if you flip the sign or add a offset to some field that should be a seperate patch ideally so it can easily be understood. Otherwise if its mixed in with other changes the whole commit looks confusing [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
