Re: [FFmpeg-devel] Adding Rollup support in Closed caption

2015-02-06 Thread Anshul
On 02/07/2015 10:30 AM, Michael Niedermayer wrote: On Fri, Feb 06, 2015 at 08:22:40PM +0530, Anshul wrote: On 01/30/2015 08:49 AM, Anshul wrote: On January 30, 2015 4:23:08 AM IST, Michael Niedermayer wrote: @@ -426,10 +466,13 @@ static int process_cc608(CCaptionSubContext *ctx, int64_t pts

Re: [FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

2015-02-06 Thread James Almer
On 11/01/15 10:48 AM, Michael Niedermayer wrote: > On Tue, Jan 06, 2015 at 02:04:12AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> I don't have MSVC or ICL 10.x, so i only tested this with gcc after forcing >> HAVE_ALIGNED_STACK to 0 in config.asm > > can someone who has ICL

Re: [FFmpeg-devel] [PATCH] hevc/sao: do in-place band filtering when possible

2015-02-06 Thread James Almer
On 05/02/15 2:44 PM, Christophe Gisquet wrote: > On the other hand, the stride is known at compilation time, so the asm > could use that to reduce the number of gprs and therefore helps having > a x86_32 version. I already have the asm working on x86_32. I'll send a patch once this is committed.

Re: [FFmpeg-devel] Adding Rollup support in Closed caption

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 08:22:40PM +0530, Anshul wrote: > > On 01/30/2015 08:49 AM, Anshul wrote: > >On January 30, 2015 4:23:08 AM IST, Michael Niedermayer > >wrote: > >>@@ -426,10 +466,13 @@ static int process_cc608(CCaptionSubContext > >>*ctx, int64_t pts, uint8_t hi, uint8 > >>> han

[FFmpeg-devel] [PATCH] pixdesc: Include more functions in FF_DISABLE_DEPRECATION_WARNINGS

2015-02-06 Thread Timothy Gu
--- libavutil/pixdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 648d014..d52e9b6 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -2049,7 +2049,6 @@ enum AVPixelFormat av_pix_fmt_desc_get_id(const AVPixFmtDes

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
Actually GCC is too dumb. There is literally no way to "fix" this in a clean way. Patch dropped. On Fri Feb 06 2015 at 7:57:33 PM Timothy Gu wrote: > On Fri Feb 06 2015 at 7:55:31 PM Timothy Gu wrote: > >> On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer >> wrote: >> >>> On Fri, Feb 06, 20

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 7:55:31 PM Timothy Gu wrote: > On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer > wrote: > >> On Fri, Feb 06, 2015 at 07:32:56AM +, Timothy Gu wrote: >> > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu >> wrote: >> > >> > > (num_quant_units - 1) is later used as an i

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer wrote: > On Fri, Feb 06, 2015 at 07:32:56AM +, Timothy Gu wrote: > > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu > wrote: > > > > > (num_quant_units - 1) is later used as an index to > atrac3p_qu_to_subband, > > > which only has 32 elemen

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 07:32:56AM +, Timothy Gu wrote: > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu wrote: > > > (num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband, > > which only has 32 elements (i.e. maximum of num_quant_units is 32). > > --- > > libavcodec/atrac3p

[FFmpeg-devel] [PATCH] avutil/ppc: Add macro defination of vector types and vector

2015-02-06 Thread Zhenan Lin
Hi, The attached patch add macro defination of vector types and vector base types. Add function printv for dev purpose. Our team is working on AltiVec functions for HEVC decoder. Best regards, Zhenan avutil-ppc-Add-macro-defination-of-vector-types.patch Description: Binary data _

[FFmpeg-devel] [PATCH] avutil/ppc: Add macro defination of vector types and vector

2015-02-06 Thread Zhenan Lin
Hi, The attached patch add macro defination of vector types and vector base types. Add function printv for dev purpose. Our team is working on AltiVec functions for HEVC decoder. Best regards, Zhenan, ICST@PKU ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH 5/7] x86: lavc: share more constants

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 06:03:40PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Feb 5, 2015 at 2:20 PM, Christophe Gisquet < > christophe.gisq...@gmail.com> wrote: > > > diff --git a/libavcodec/x86/vp9intrapred.asm > > b/libavcodec/x86/vp9intrapred.asm > > index 169676f..08b3ae8 100644 > > --

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 02:44:06AM -0300, James Almer wrote: > On 06/02/15 12:57 AM, Ben Boeckel wrote: > > +if (s->error_recognition & AV_EF_COMPLIANT) > > +level = AV_LOG_ERROR; > > +av_log(s, level, "Spec-compliant FLAC do not support ID3 tags.\n"); > > As i said bac

[FFmpeg-devel] [PATCH] ffprobe: Force string_validation to int type, its accessed via AVOption as int

2015-02-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffprobe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ffprobe.c b/ffprobe.c index d352bb6b..8617c96 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -294,7 +294,8 @@ typedef enum { WRITER_STRING_VALIDATION_FAIL, WRITER_STRING_

Re: [FFmpeg-devel] [PATCH 3/3] avutil/pixfmt: Clarify the meaning of the alpha bits in rgb444 and similar formats

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 21:55:49 +0100 Reimar Döffinger wrote: > On Fri, Feb 06, 2015 at 09:49:17PM +0100, wm4 wrote: > > On Fri, 6 Feb 2015 20:57:50 +0100 > > Michael Niedermayer wrote: > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavutil/pixfmt.h |8 > > > 1 file

Re: [FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 11:20:03AM +0100, Stefano Sabatini wrote: > On date Thursday 2015-02-05 23:03:56 +0100, Michael Niedermayer encoded: > > On Thu, Feb 05, 2015 at 12:10:12PM +0100, Stefano Sabatini wrote: > > > On date Wednesday 2015-02-04 16:10:03 +0100, Michael Niedermayer encoded: > [...]

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 20:16:50 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > The pixfmt docs seems to imply that the extra > > component must be set to 0 if a RGB0 format is > > used. Camtasia puts random stuff. > > The documentation sounds wrong to me: The pix_fmt >

Re: [FFmpeg-devel] [PATCH 3/3] avutil/pixfmt: Clarify the meaning of the alpha bits in rgb444 and similar formats

2015-02-06 Thread Reimar Döffinger
On Fri, Feb 06, 2015 at 09:49:17PM +0100, wm4 wrote: > On Fri, 6 Feb 2015 20:57:50 +0100 > Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/pixfmt.h |8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/libavutil/pix

Re: [FFmpeg-devel] [PATCH 3/3] avutil/pixfmt: Clarify the meaning of the alpha bits in rgb444 and similar formats

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 20:57:50 +0100 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/pixfmt.h |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h > index cbcccb2..cee5f2c 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCH 4/7] x86/hevc_mc: use aligned loads

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 07:20:42PM +, Christophe Gisquet wrote: > From: Mickaël Raulet > > --- > libavcodec/hevc.h | 2 +- > libavcodec/x86/hevc_mc.asm | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B

Re: [FFmpeg-devel] [PATCH] x86/lossless_audiodsp: fix compilation with --disable-yasm

2015-02-06 Thread James Almer
On 06/02/15 4:11 PM, Michael Niedermayer wrote: > On Fri, Feb 06, 2015 at 03:49:52AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> See >> http://fate.ffmpeg.org/log.cgi?time=20150206062639&log=compile&slot=x86_64-darwin-gcc-4.6 >> >> libavcodec/x86/lossless_audiodsp_init.c |

Re: [FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > This is skipping avio_rl32() and not updating > the pb pointer when crc is not checked Sorry, please ignore. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > The pixfmt docs seems to imply that the extra > component must be set to 0 if a RGB0 format is > used. Camtasia puts random stuff. The documentation sounds wrong to me: The pix_fmt was needed because of hardware providing 32bit rgb, there is no guarantee what t

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 01:48:07PM +0100, wm4 wrote: > On Fri, 6 Feb 2015 12:10:59 + (UTC) > Carl Eugen Hoyos wrote: > > > wm4 googlemail.com> writes: > > > > > > I will fix this later if nobody beats me. > > > > > > How do you intend to beat this? > > > > Setting it to 0RGB32 instead of

[FFmpeg-devel] [PATCH 3/3] avutil/pixfmt: Clarify the meaning of the alpha bits in rgb444 and similar formats

2015-02-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/pixfmt.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index cbcccb2..cee5f2c 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -141,10 +141,10 @@ enum AVPixelFormat

[FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Clarify the meaning of the alpha byte in RGB0 and similar formats

2015-02-06 Thread Michael Niedermayer
Found-by: wm4 Signed-off-by: Michael Niedermayer --- libavutil/pixfmt.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index ef1837f..9f4928e 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -255,10 +255,10 @@ enum

[FFmpeg-devel] [PATCH 2/3] avutil/pixfmt: Clarify the meaning of the "alpha" bit in rgb555/bgr555

2015-02-06 Thread Michael Niedermayer
Found-by: wm4 Signed-off-by: Michael Niedermayer --- libavutil/pixfmt.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index 9f4928e..cbcccb2 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -118,13 +118,13 @@ enum

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-06 Thread wm4
On Thu, 5 Feb 2015 22:57:07 -0500 Ben Boeckel wrote: > FLAC doesn't really support ID3 tags, so warn if they are found at all. > If vorbis tags are found, toss out duplicate ID3 tags. > > Fixes #3799. > Discussing this topic further, it seems id3v2 tags really can happen with literally almost

Re: [FFmpeg-devel] [libav-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Vittorio Giovara
On Fri, Feb 6, 2015 at 11:32 AM, wm4 wrote: > This is a proposal for an API extension. > > Currently, some pixel formats support alpha, but whether the alpha > component contains something useful or just garbage is not part of the > pixel format definition. This applies at least to packed RGB form

Re: [FFmpeg-devel] [PATCH 2/2] new option for drawtext (boxborderw = set box border width)

2015-02-06 Thread Liviu Oniciuc
On 2/6/2015 5:11 AM, Nicolas George wrote: > The "box" that drawtext draws around the text is filled, it corresponds > to the "background" CSS property, and adding border in it corresponds > to what CSS calls "padding". Got confused by the borderw option, and based my name on what I expected bord

Re: [FFmpeg-devel] [PATCH 6/7] nutdec: Remove unused variables

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 11:06:44PM -0800, Timothy Gu wrote: > --- > libavformat/nutenc.c | 2 -- > 1 file changed, 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. s

Re: [FFmpeg-devel] [PATCH 2/7] img2dec: Remove dead code

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 07:21:30PM +0100, Reimar Döffinger wrote: > On Thu, Feb 05, 2015 at 11:06:40PM -0800, Timothy Gu wrote: > > --- > > libavformat/img2dec.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > > ind

Re: [FFmpeg-devel] [PATCH] x86/lossless_audiodsp: fix compilation with --disable-yasm

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 03:49:52AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > See > http://fate.ffmpeg.org/log.cgi?time=20150206062639&log=compile&slot=x86_64-darwin-gcc-4.6 > > libavcodec/x86/lossless_audiodsp_init.c | 8 > 1 file changed, 4 insertions(+), 4 deleti

Re: [FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

2015-02-06 Thread Reimar Döffinger
On Fri, Feb 06, 2015 at 04:07:36PM +, Timothy Gu wrote: > On Fri Feb 06 2015 at 1:28:09 AM Carl Eugen Hoyos wrote: > > > Timothy Gu gmail.com> writes: > > > > > if (!i || !*val) > > > return 0; > > > } > > > - > > > -return 0; > > > } > > > > > > > I fear tha

Re: [FFmpeg-devel] [PATCH 2/7] img2dec: Remove dead code

2015-02-06 Thread Reimar Döffinger
On Thu, Feb 05, 2015 at 11:06:40PM -0800, Timothy Gu wrote: > --- > libavformat/img2dec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index 1ab1309..8c5e9d5 100644 > --- a/libavformat/img2dec.c > +++ b/libavformat/img

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread James Almer
On 06/02/15 2:10 PM, Christophe Gisquet wrote: > The new common loading block could almost be abstracted in a single > macro (with the stride as parameter). > > Something like: > %macro LOAD_EO_ARGS 1 > %define tmp2q heightq > %if WIN64 > movsxd eoq, dword r4m > %else > movsxd

Re: [FFmpeg-devel] [PATCH 2/2] generate_wave_table: Add include for AVSampleFormat

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 11:27:35PM -0800, Timothy Gu wrote: > Fixes warning in `make checkheaders`. > --- > libavfilter/generate_wave_table.h | 2 ++ > 1 file changed, 2 insertions(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortun

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread James Almer
On 06/02/15 2:13 PM, Hendrik Leppkes wrote: > On Fri, Feb 6, 2015 at 6:10 PM, Christophe Gisquet > wrote: >> Hi, >> >> 2015-02-06 17:54 GMT+01:00 James Almer : >>> pb_eo must be handled as a rip relative address for MSVC64, so an >>> intermediate register is needed. Should fix link failures. >> >>

Re: [FFmpeg-devel] [PATCH 1/2] audioconvert: Add missing include for FF_API_AUDIO_CONVERT

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 11:27:34PM -0800, Timothy Gu wrote: > Fixes warning in `make checkheaders`. > --- > libavcodec/audioconvert.h | 2 ++ > 1 file changed, 2 insertions(+) applied thanks -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely thos

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread James Almer
On 06/02/15 1:05 PM, Christophe Gisquet wrote: > 2015-02-06 16:18 GMT+01:00 James Almer : >> "mov r5d, denomm" is loading it on Win64. It's also a superfluous >> instruction on >> UNIX64, where it translates to "mov r5d, r5d". >> At least if i'm reading this right. > > movifnidn then? Yes, that

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread Hendrik Leppkes
On Fri, Feb 6, 2015 at 6:10 PM, Christophe Gisquet wrote: > Hi, > > 2015-02-06 17:54 GMT+01:00 James Almer : >> pb_eo must be handled as a rip relative address for MSVC64, so an >> intermediate register is needed. Should fix link failures. > > Seems ok on principle, passes fate on mingw64. I'm alw

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread Christophe Gisquet
Hi, 2015-02-06 17:54 GMT+01:00 James Almer : > pb_eo must be handled as a rip relative address for MSVC64, so an > intermediate register is needed. Should fix link failures. Seems ok on principle, passes fate on mingw64. I'm always wary of those ABI, so if anyone could verify for msvc64 and unix6

Re: [FFmpeg-devel] [PATCH 3/7] x86/hevc: use CLIPW macro when possible

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 09:28:41PM -0300, James Almer wrote: > On 05/02/15 4:20 PM, Christophe Gisquet wrote: > > From: Mickaël Raulet > > > > Conflicts: > > libavcodec/x86/hevc_mc.asm > > --- > > libavcodec/x86/hevc_mc.asm | 12 > > 1 file changed, 4 insertions(+), 8 deletions(

Re: [FFmpeg-devel] [PATCH 2/7] x86: hevc_mc: use epel_hv 16-wide function

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 07:20:40PM +, Christophe Gisquet wrote: > The epel_hv functions were still relying on only epel_hv 8-wide > being the maximum width instanciated. > --- > libavcodec/x86/hevcdsp_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied thanks [...]

[FFmpeg-devel] [PATCH] x86/hevc_sao: fix loading of RIP address

2015-02-06 Thread James Almer
pb_eo must be handled as a rip relative address for MSVC64, so an intermediate register is needed. Should fix link failures. Suggested by Hendrik Leppkes and Christophe Gisquet. Signed-off-by: James Almer --- libavcodec/x86/hevc_sao.asm | 42 +- 1 file ch

Re: [FFmpeg-devel] [PATCH 1/7] x86: hevc_mc: add AVX2 optimizations

2015-02-06 Thread Michael Niedermayer
On Thu, Feb 05, 2015 at 09:15:28PM -0300, James Almer wrote: > On 05/02/15 4:20 PM, Christophe Gisquet wrote: > > From: plepere > > This should probably be changed to Pierre Edouard Lepere. changed [...] > > } > > > > c->transform_add[2] = ff_hevc_transform_add16_10_

Re: [FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 1:28:09 AM Carl Eugen Hoyos wrote: > Timothy Gu gmail.com> writes: > > > if (!i || !*val) > > return 0; > > } > > - > > -return 0; > > } > > > I fear that some (broken) compilers will emit > a warning when this gets applied that we > request

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread Christophe Gisquet
2015-02-06 16:18 GMT+01:00 James Almer : > "mov r5d, denomm" is loading it on Win64. It's also a superfluous instruction > on > UNIX64, where it translates to "mov r5d, r5d". > At least if i'm reading this right. movifnidn then? -- Christophe ___ ffmp

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-06 Thread James Almer
On 06/02/15 1:02 PM, Christophe Gisquet wrote: > Sure. Hopefully, the difference in number of gpr-passed args between > UNIX64 and WIN64 can be handled. I'll send a patch in a moment. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

Re: [FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread James Almer
On 06/02/15 6:15 AM, Carl Eugen Hoyos wrote: > -crc = ffio_get_checksum(s->pb) ^ UINT32_MAX; > -if (crc != avio_rl32(s->pb) && s->error_recognition & AV_EF_CRCCHECK) { > -av_log(s, AV_LOG_ERROR, "Header CRC error\n"); > -return AVERROR_INVALIDDATA; > +if (s->error_recogn

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-06 Thread Christophe Gisquet
Hi, 2015-02-06 16:41 GMT+01:00 James Almer : > Wouldn't it be better to just use the same code as UNIX64 instead? Now that > we're going to load > the address of the table to a reg, there's not point in having a whole > separate init path for > WIN64. > One for X86_64 and one for X86_32 (Where a

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread Timothy Gu
On Fri Feb 06 2015 at 2:58:19 AM wm4 wrote: > On Fri, 06 Feb 2015 07:32:56 + > Timothy Gu wrote: > > > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu > wrote: > > > > > (num_quant_units - 1) is later used as an index to > atrac3p_qu_to_subband, > > > which only has 32 elements (i.e. maximum o

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-06 Thread James Almer
On 06/02/15 9:49 AM, Christophe Gisquet wrote: > diff --git a/libavcodec/x86/hevc_sao.asm b/libavcodec/x86/hevc_sao.asm > index 5136121..8619716 100644 > --- a/libavcodec/x86/hevc_sao.asm > +++ b/libavcodec/x86/hevc_sao.asm > @@ -296,14 +296,16 @@ HEVC_SAO_BAND_FILTER_16 12, 64, 2 > %if WIN64 > c

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread James Almer
On 06/02/15 6:14 AM, Christophe Gisquet wrote: > 2015-02-05 20:20 GMT+01:00 Christophe Gisquet : >> > -cglobal hevc_put_hevc_bi_w%1_%2, 5, 7, 10, dst, dststride, src, >> > srcstride, src2, height, denom, wx0, wx1, ox0, ox1 >> > -mov r6d, denomm >> > +cglobal hevc_put_hevc_bi_w%1_%

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-06 Thread James Almer
On 06/02/15 7:07 AM, Hendrik Leppkes wrote: > For some reason, the non-WIN64 version does just this, but the WIN64 > version does not. > Any particular reason for this difference? We support PIC on WIN64 but not with others. Or at least x86inc.asm enables it that way. According to msvc documenta

Re: [FFmpeg-devel] Adding Rollup support in Closed caption

2015-02-06 Thread Anshul
On 01/30/2015 08:49 AM, Anshul wrote: On January 30, 2015 4:23:08 AM IST, Michael Niedermayer wrote: @@ -426,10 +466,13 @@ static int process_cc608(CCaptionSubContext *ctx, int64_t pts, uint8_t hi, uint8 handle_delete_end_of_row(ctx, hi, lo); } else if ( COR3(hi, 0x14, 0x15,

Re: [FFmpeg-devel] [PATCH] tests: add spp test

2015-02-06 Thread Clément Bœsch
On Fri, Feb 06, 2015 at 12:14:32PM +0100, Stefano Sabatini wrote: > On date Thursday 2015-02-05 22:57:31 +0100, Clément Bœsch encoded: > > On Thu, Feb 05, 2015 at 06:04:56PM +0100, Michael Niedermayer wrote: > > > On Thu, Feb 05, 2015 at 12:49:20PM +0100, Stefano Sabatini wrote: > > > > On date Wed

Re: [FFmpeg-devel] [PATCH 2/2] new option for drawtext (boxborderw = set box border width)

2015-02-06 Thread Nicolas George
Le septidi 17 pluviôse, an CCXXIII, Liviu Oniciuc a écrit : > it is not related with the inside padding, and yes it does try to follow the > css/ffmpeg vocabulary. 'boxborderw' refer to what css names: 'border-width', I think you are mistaken about either the effect of the drawtext options or the

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-06 Thread Christophe Gisquet
Hi, 2015-02-06 11:07 GMT+01:00 Hendrik Leppkes : > I looked into the MSVC 64bit failure from this patch, and from what I > can tell doing this doesn't work: > movsx a_strideq, byte [pb_eo+eoq*4+1] > > I'm not entirely sure on the specifics why it breaks however.. > But all I could find sugges

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 12:10:59 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > > I will fix this later if nobody beats me. > > > > How do you intend to beat this? > > Setting it to 0RGB32 instead of RGB32. > Unrelated to your API suggestion, this is a > bug in FFmpeg tha

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > I will fix this later if nobody beats me. > > How do you intend to beat this? Setting it to 0RGB32 instead of RGB32. Unrelated to your API suggestion, this is a bug in FFmpeg that we should fix. > Explicitly writing the alpha component? > (I was assuming this w

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > It's not consistently done, I worked (hard) on doing it consistently, please point me to the missing codecs. A possible reason for missing Camtasia is that I did not find a 32 bit sample (so I could not decide if alpha is hidden in the encoded image or not). >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rpl: check av_get_packet() for failure

2015-02-06 Thread Michael Niedermayer
On Fri, Feb 06, 2015 at 09:28:03AM +, Paul B Mahol wrote: > On 2/5/15, Michael Niedermayer wrote: > > On Thu, Feb 05, 2015 at 03:08:17PM +, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavformat/rpl.c | 4 > >> 1 file changed, 4 insertions(+) > >> > >> diff -

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 12:00:00 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > Camtasia can output AV_PIX_FMT_RGB32 > > (which is ARGB or BGRA depending on > > endian). Camtasia supports no alpha > > It appears I missed Camtasia when I > fixed this for many codecs years

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > Camtasia can output AV_PIX_FMT_RGB32 > (which is ARGB or BGRA depending on > endian). Camtasia supports no alpha It appears I missed Camtasia when I fixed this for many codecs years ago. I will fix this later if nobody beats me. Thank you, Carl Eugen _

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 12:45:43 +0100 Clément Bœsch wrote: > On Fri, Feb 06, 2015 at 12:32:14PM +0100, wm4 wrote: > > This is a proposal for an API extension. > > > > Currently, some pixel formats support alpha, but whether the alpha > > component contains something useful or just garbage is not par

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Clément Bœsch
On Fri, Feb 06, 2015 at 12:32:14PM +0100, wm4 wrote: > This is a proposal for an API extension. > > Currently, some pixel formats support alpha, but whether the alpha > component contains something useful or just garbage is not part of the > pixel format definition. This applies at least to packed

[FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread wm4
This is a proposal for an API extension. Currently, some pixel formats support alpha, but whether the alpha component contains something useful or just garbage is not part of the pixel format definition. This applies at least to packed RGB formats, where the 4th component is either alpha or garbag

Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to libavutil

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 11:06:28 + "Gupta, Maneesh" wrote: > > > > -Original Message- > > From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel- > > boun...@ffmpeg.org] On Behalf Of wm4 > > Sent: Friday, February 06, 2015 4:31 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFm

Re: [FFmpeg-devel] [PATCH 2/3] Use clew instead of cl.h for OpenCL

2015-02-06 Thread Dominik 'Rathann' Mierzejewski
Hello, Maneesh. On Friday, 06 February 2015 at 11:09, Gupta, Maneesh wrote: > Attached is the follow on patch that switches to using clew instead of cl.h What's the rationale to switch? cl.h is part of Khronos distribution while clew.h seems to be part of clcc with a couple of forks floating arou

Re: [FFmpeg-devel] [PATCH] tests: add spp test

2015-02-06 Thread Stefano Sabatini
On date Thursday 2015-02-05 22:57:31 +0100, Clément Bœsch encoded: > On Thu, Feb 05, 2015 at 06:04:56PM +0100, Michael Niedermayer wrote: > > On Thu, Feb 05, 2015 at 12:49:20PM +0100, Stefano Sabatini wrote: > > > On date Wednesday 2015-02-04 16:18:32 +0100, Michael Niedermayer encoded: > > > > On

Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to libavutil

2015-02-06 Thread Gupta, Maneesh
> -Original Message- > From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel- > boun...@ffmpeg.org] On Behalf Of wm4 > Sent: Friday, February 06, 2015 4:31 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to libavutil > > On Fri, 6 Feb 2

Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to libavutil

2015-02-06 Thread wm4
On Fri, 6 Feb 2015 11:14:21 +0100 Hendrik Leppkes wrote: > On Fri, Feb 6, 2015 at 11:09 AM, Gupta, Maneesh wrote: > > Hi All, > > > > There are several issues with the way ffmpeg compilation works when OpenCL > > is enabled using --enable-opencl. Chief among them are: > > 1. One needs to also u

Re: [FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

2015-02-06 Thread wm4
On Fri, 06 Feb 2015 07:32:56 + Timothy Gu wrote: > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu wrote: > > > (num_quant_units - 1) is later used as an index to atrac3p_qu_to_subband, > > which only has 32 elements (i.e. maximum of num_quant_units is 32). > > --- > > libavcodec/atrac3plus.c

Re: [FFmpeg-devel] [PATCHv4] flac: ignore duplicated ID3 tags if vorbis tags exist

2015-02-06 Thread wm4
On Thu, 5 Feb 2015 22:57:07 -0500 Ben Boeckel wrote: > FLAC doesn't really support ID3 tags, so warn if they are found at all. > If vorbis tags are found, toss out duplicate ID3 tags. > > Fixes #3799. > > Signed-off-by: Ben Boeckel > --- > libavformat/flacdec.c | 27 +

Re: [FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread Paul B Mahol
On 2/6/15, Carl Eugen Hoyos wrote: > Hi! > > I did not benchmark but attached should be both a little faster > and a little cleaner. > > Please comment, Carl Eugen > > From 8bf4e1c82e818483a5bbf55147bb818e5cfacc70 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Fri, 6 Feb 2015 10:13:31

Re: [FFmpeg-devel] [PATCH 1/2] avformat/thp: check av_get_packet() for failure

2015-02-06 Thread Paul B Mahol
On 2/5/15, Michael Niedermayer wrote: > On Thu, Feb 05, 2015 at 03:08:16PM +, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavformat/thp.c | 2 ++ >> 1 file changed, 2 insertions(+) > > LGTM > applied > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1336

Re: [FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-02-06 Thread Stefano Sabatini
On date Thursday 2015-02-05 23:03:56 +0100, Michael Niedermayer encoded: > On Thu, Feb 05, 2015 at 12:10:12PM +0100, Stefano Sabatini wrote: > > On date Wednesday 2015-02-04 16:10:03 +0100, Michael Niedermayer encoded: [...] > > > > the enum might be a different data type than int, it might have >

Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to libavutil

2015-02-06 Thread Hendrik Leppkes
On Fri, Feb 6, 2015 at 11:09 AM, Gupta, Maneesh wrote: > Hi All, > > There are several issues with the way ffmpeg compilation works when OpenCL is > enabled using --enable-opencl. Chief among them are: > 1. One needs to also use --extra-cflags, --extra-ldflags & -extra-libs to > specify the path

[FFmpeg-devel] [PATCH 3/3] Update configure since OpenCL compilation does not need cl.h

2015-02-06 Thread Gupta, Maneesh
Attached is the patch that updates the configure script since we no longer depend upon cl.h. One added advantage of using clew is that we can turn on OpenCL compilation by default. This patch additionally enables OpenCL compilation on Linux, Windows and Darwin target OS. Regards, Maneesh Gupta

[FFmpeg-devel] [PATCH 2/3] Use clew instead of cl.h for OpenCL

2015-02-06 Thread Gupta, Maneesh
Attached is the follow on patch that switches to using clew instead of cl.h Regards, Maneesh Gupta 0002-Use-clew-instead-of-cl.h-for-OpenCL.patch Description: 0002-Use-clew-instead-of-cl.h-for-OpenCL.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

2015-02-06 Thread Hendrik Leppkes
On Thu, Feb 5, 2015 at 7:07 PM, James Almer wrote: > > On 05/02/15 12:49 PM, Christophe Gisquet wrote: > > Hi, > > > > 2015-02-05 5:18 GMT+01:00 James Almer : > >> Original x86 intrinsics code and initial yasm port by Pierre-Edouard > >> Lepere. > >> Refactoring and optimizations by James Almer.

Re: [FFmpeg-devel] Adding Force Style option in Subtitles Filter

2015-02-06 Thread Stefano Sabatini
On date Thursday 2015-02-05 22:12:08 +0530, Eejya Singh encoded: [...] > From ed526a03c939055e2b9f931a0cb4e0e22b7b5b04 Mon Sep 17 00:00:00 2001 > From: Eejya Singh > Date: Wed, 28 Jan 2015 17:41:42 +0530 > Subject: [PATCH] lavfi/subtitles: add force_style option > > Signed-off-by: Eejya Singh >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rpl: check av_get_packet() for failure

2015-02-06 Thread Paul B Mahol
On 2/5/15, Michael Niedermayer wrote: > On Thu, Feb 05, 2015 at 03:08:17PM +, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavformat/rpl.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavformat/rpl.c b/libavformat/rpl.c >> index c1229e8..a05bff1 100644

Re: [FFmpeg-devel] [PATCH 1/7] opt: Remove dead code

2015-02-06 Thread Carl Eugen Hoyos
Timothy Gu gmail.com> writes: > if (!i || !*val) > return 0; > } > - > -return 0; > } I fear that some (broken) compilers will emit a warning when this gets applied that we request to be interpreted as an error. Same for 3, 4 and 5. I don't remember if an assert

[FFmpeg-devel] [PATCH]Only run the tta crc checks if requested

2015-02-06 Thread Carl Eugen Hoyos
Hi! I did not benchmark but attached should be both a little faster and a little cleaner. Please comment, Carl Eugen From 8bf4e1c82e818483a5bbf55147bb818e5cfacc70 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 6 Feb 2015 10:13:31 +0100 Subject: [PATCH] avformat/tta: only check for h

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread Christophe Gisquet
2015-02-05 20:20 GMT+01:00 Christophe Gisquet : > -cglobal hevc_put_hevc_bi_w%1_%2, 5, 7, 10, dst, dststride, src, srcstride, > src2, height, denom, wx0, wx1, ox0, ox1 > -mov r6d, denomm > +cglobal hevc_put_hevc_bi_w%1_%2, 4, 5, 10, dst, dststride, src, src2, > height, denom, wx0