On Fri, Feb 06, 2015 at 08:22:40PM +0530, Anshul wrote:
>
> On 01/30/2015 08:49 AM, Anshul wrote:
> >On January 30, 2015 4:23:08 AM IST, Michael Niedermayer <michae...@gmx.at>
> >wrote:
> >>@@ -426,10 +466,13 @@ static int process_cc608(CCaptionSubContext
> >>*ctx, int64_t pts, uint8_t hi, uint8
> >>> handle_delete_end_of_row(ctx, hi, lo);
> >>> } else if ( COR3(hi, 0x14, 0x15, 0x1C) && lo == 0x25 ) {
> >>> ctx->rollup = 2;
> >>>+ ctx->mode = CCMODE_ROLLUP_2;
> >>> } else if ( COR3(hi, 0x14, 0x15, 0x1C) && lo == 0x26 ) {
> >>> ctx->rollup = 3;
> >>>+ ctx->mode = CCMODE_ROLLUP_3;
> >>> } else if ( COR3(hi, 0x14, 0x15, 0x1C) && lo == 0x27 ) {
> >>> ctx->rollup = 4;
> >>>+ ctx->mode = CCMODE_ROLLUP_3;
> >>is this intended to be CCMODE_ROLLUP_3 instead of CCMODE_ROLLUP_4 ?
> >>
> >>also do you have a file to test this and the other patches ?
> >>
> >>thanks
> >>
> >>[...]
> >I tested this on bmd live video, all the rollup values were not tested, I
> >implemented this feature when roll up 2 was coming.
> >
> >I will check the database of ccextractor, if I get some video with different
> >rollup.
> >
> >
> >-Anshul
> >
> I have attached the patch which were not commited, In the rollup
> functionality there was one more
> bug other then typo, the first line was lost while converting the cc.
> I have corrected that.
> > Here > <http://gsocdev.ccextractor.org/%7Eanshul/test_video/Closedcaption_rollup.ts> > is video with rollup in closed caption. how can this be used for testing ? do you have a command line with that video that shows a difference with the patches ? the patches themselfs look good [...] > @@ -187,7 +187,7 @@ static av_cold int init_decoder(AVCodecContext *avctx) > ret = AVERROR(ENOMEM); > } > > - > +fail: > return ret; > } > i moved this hunk to the 2nd patch and applied first and second with also module "avcodec/..." prefixes in the commit messages Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
