Phil Estival writes:
>> What about changing sql.el to provide the necessary flexibility?
>> I'd prefer it better than rewriting parts of sql.el in Org mode.
>
> Gladly. Here is a proposal for patch for `sql-product-interactive' in
> sql.el. A specific case for sqlite is handled and this is not 10
* [2025-01-17 Fri 06:58 +0100] Ihor Radchenko
Phil Estival writes:
Is there any specific reason why you are seemingly re-implementing what
`sql-product-interactive' does? May we re-use it instead?
Yes. When opening a new connection `sql-product-interactive' will
systematically ask for input
Phil Estival writes:
> ... However, some SQL shells, like Mariadb, can only be
> configured through command line parameters. These are global in Emacs
> and set by `sql-set-product-feature'. So in order to support these,
> the function in charge of opening the connection needs different
> parame
* [2025-01-07 19:38] Ihor Radchenko:> Phil Estival writes:
[...] these `sql-set-product-feature' calls are overriding the defaults
from sql.el. They will not only affect Org babel blocks, but all the
interactive SQL sessions in Emacs. Such side effects are not acceptable.
May we somehow avoid m
Phil Estival writes:
> Hello. Here we go again.
Thanks!
See comments inline.
> Also, in the commit message of the patch for the tests,
> I mention that some macros should probably be moved upward
> in a file where generic functions which purposes are to help
> writing the tests of babel source
* [2024-12-13 18:46] Ihor Radchenko:
Phil Estival writes:
this patch modifies ob-sql to add support for session.
Before I start a more detailed preview, may you please:
1. Rebase your changes onto main (development) branch. This is where the
new features are added. See
https://orgmode
Phil Estival writes:
> From Org 9.7.16,
> this patch modifies ob-sql to add support for session.
> - reintroduces sqlite in ob-sql (even if there is ob-sqlite.el)
> - limitation: no line number in session (a block is provided
>on one prompt line)
> - tests: some generic macro for checking re
* [2024-11-26 15:34] Phil Estival:
From Org 9.7.16,
this patch modifies ob-sql to add support for session.
- reintroduces sqlite in ob-sql (even if there is ob-sqlite.el)
- limitation: no line number in session (a block is provided
on one prompt line)
- tests: some generic macros for chec
From Org 9.7.16,
this patch modifies ob-sql to add support for session.
- reintroduces sqlite in ob-sql (even if there is ob-sqlite.el)
- limitation: no line number in session (a block is provided
on one prompt line)
- tests: some generic macro for checking results could go up/out
of this tes
Phil Estival writes:
> I will keep running ob-sql with :session in the next days.
> This work configuration should help to detect if there is an anomaly.
>
> Shall I submit a patch?
Sure!
> Since many lines are changed due to proper indentation, docstrings,
> untabification and a few lateral im
* [2024-11-09 15:43] Ihor Radchenko:
Phil Estival writes:
Have you considered integrating it into ob-sql itself?
If not, what are the obstacles?
Hello Ihor,
yes I have. It grows ob-sql by approximately 300 lines.
There are rooms for improvements.
https://github.com/flintforge/ob-sql-sessio
11 matches
Mail list logo
